- Apr 25, 2012
-
-
Kai Koehne authored
Using waitForMessage() in the constructor after registerService() is _not_ safe: You might get the first message already after the registerService() and before the waitForMessage() call. Instead, use QMutex/QWaitCondition to block the initialization. Also make the use of the block mode explicit, since the service might already be enabled also for non-blocking modes ... Change-Id: I387bfe0627c80e2029acff71f86d12cd9ab58de1 Reviewed-by:
Kai Koehne <kai.koehne@nokia.com>
-
Kai Koehne authored
Make sure that the first message hasn't already arrived before we call d->messageArrivedCondition.wait(). Change-Id: I0d3df9adbd41f71df5c1c7d6df90c0037f494514 Reviewed-by:
Kai Koehne <kai.koehne@nokia.com>
-
- Apr 24, 2012
-
-
Kai Koehne authored
Variables without a name are free to be deleted even before the scope ends. Change-Id: I07fb6f98cd5b36876db5de2e1b4e8ce355f74415 Reviewed-by:
Aurindam Jana <aurindam.jana@nokia.com>
-
Kai Koehne authored
Change-Id: I7c377863eb42e693aa4022af33a83098547e0d58 Reviewed-by:
Aurindam Jana <aurindam.jana@nokia.com>
-
Kai Koehne authored
Make sure stateAboutToBeChanged(), stateChanged() is always called from the debugger thread. This matches how messageReceived() is called. On exit, run an event loop until all stateAboutToBeChanged calls have returned. Change-Id: I9cd6199cc80552ad97e4b7d504ea91aa116a6a34 Reviewed-by:
Aurindam Jana <aurindam.jana@nokia.com>
-
- Apr 10, 2012
-
-
Aurindam Jana authored
Change-Id: I118a7b9de886c712027c55c38be99f615aea6902 Reviewed-by:
Roberto Raggi <roberto.raggi@nokia.com>
-
- Mar 30, 2012
-
-
Kai Koehne authored
QT_DECLARATIVE_DEBUG will be removed as soon as qtbase is updated. Change-Id: I9dbfe95b8bcb3bf1502319a040a758389b6977a2 Reviewed-by:
Aurindam Jana <aurindam.jana@nokia.com>
-
Simjees Abraham authored
Irrelevant debug statement which gets printed at start of debug session is removed. The same is removed in Auto-tests as well. Change-Id: If8f44950952f08b55ff884c1fe42670108e2369d Reviewed-by:
Kai Koehne <kai.koehne@nokia.com>
-
- Mar 19, 2012
-
-
Simjees Abraham authored
Change-Id: I5bb2e48e2ad2019b8a92f6f8842b88027fcd2d28 Reviewed-by:
Kai Koehne <kai.koehne@nokia.com>
-
- Mar 14, 2012
-
-
Kai Koehne authored
This allows users to use QT_FATAL_WARNINGS. Change-Id: I114825764c841030418c956d23575159157dfd69 Reviewed-by:
Roberto Raggi <roberto.raggi@nokia.com>
-
- Mar 13, 2012
-
-
Kai Koehne authored
Change-Id: I5c33113783834ef0c7292f5f19f12d8c68f42141 Reviewed-by:
Aurindam Jana <aurindam.jana@nokia.com>
-
- Mar 07, 2012
-
-
Kai Koehne authored
Since we've been changing from QtDeclarativeDebugServer to QQmlDebugServer anyway, we might as well change it to the more readable "QML Debugger:" prefix. Change-Id: I852577233d7cdb1f57adc43ec1b85a14d212574d Reviewed-by:
Aurindam Jana <aurindam.jana@nokia.com>
-
Aurindam Jana authored
Revert the names of the services changed in b855240b to maintain BC. Change-Id: I79826d92fd09c41e0020541b0c7bb77b5b2ecb1f Reviewed-by:
Kai Koehne <kai.koehne@nokia.com>
-
- Feb 24, 2012
-
-
Matthew Vogt authored
Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by:
Martin Jones <martin.jones@nokia.com>
-
- Feb 10, 2012
-
-
Kai Koehne authored
Fix inconsistent naming e.g. in QtDeclarativeEngineDebug by always using 'state' instead of 'status'. This is in line with the other source code, which also seems to favor 'state'. Change-Id: I65a7a3bd0eb7dfffeb37b5f8dad15b0a4a78de70 Reviewed-by:
Aurindam Jana <aurindam.jana@nokia.com>
-
- Feb 09, 2012
-
-
Kai Koehne authored
Add a statusAboutToBeChanged virtual that allows services to send data e.g. on application exit. Change-Id: I28fa513ab2a12d6973c444aac3062d64a0957207 Reviewed-by:
Christiaan Janssen <christiaan.janssen@nokia.com>
-
- Jan 30, 2012
-
-
Jason McDonald authored
As in the past, to avoid rewriting various autotests that contain line-number information, an extra blank line has been inserted at the end of the license text to ensure that this commit does not change the total number of lines in the license header. Change-Id: If39bd256b0fa85eba17ea30f8ab87ea27d758908 Reviewed-by:
Rohan McGovern <rohan.mcgovern@nokia.com>
-
- Jan 23, 2012
-
-
Jason McDonald authored
Replace Nokia contact email address with Qt Project website. Change-Id: I6a730abc0c396fb545a48b2d6938abedac2e3f1c Reviewed-by:
Rohan McGovern <rohan.mcgovern@nokia.com> Reviewed-by:
Alan Alpert <alan.alpert@nokia.com>
-
- Jan 05, 2012
-
-
Jason McDonald authored
Change-Id: I0a8d99909cac867dce72da70b1bbcb649989a51b Reviewed-by:
Rohan McGovern <rohan.mcgovern@nokia.com>
-
- Dec 21, 2011
-
-
Kai Koehne authored
We did call a flush() after every single packet, which was slowing down things especially for the QDeclarativeDebugTrace service. Change-Id: Idab074941a22364e154502eb12afa43b4dd33c22 Reviewed-by:
Aurindam Jana <aurindam.jana@nokia.com> Reviewed-by:
Christiaan Janssen <christiaan.janssen@nokia.com>
-
- Dec 20, 2011
-
-
Kai Koehne authored
We used to close the debugger thread when the last service was killed: This happened in the unloading of static global variables. Apparently this is too late on Windows, since the OS thread associated was already terminated. Instead, we now kill the instance when the QCoreApplication event loop is exiting. Change-Id: I12a46ab9e7ac64561c94c0cd0d88b78fbaf8554c Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@nokia.com> Reviewed-by:
Aurindam Jana <aurindam.jana@nokia.com>
-
- Dec 16, 2011
-
-
Aurindam Jana authored
Send the version info of each plugin alongwith the plugin names to client. Change-Id: I223689b32cdc5b0c48a4f508330033352b427937 Reviewed-by:
Kai Koehne <kai.koehne@nokia.com>
-
- Nov 22, 2011
-
-
Kai Koehne authored
So far the debugger infrastructure was running in the GUI thread, which required e.g. nested event loops to implement blocking behavior. The server and networking code are now running in their own thread, while the services are still running in the main thread. Because v8 isn't thread safe, we're adding two new JSEngines + isolates to qv8debugservice: One to decode JSON messages in the debugger thread, and one in the GUI thread. Change-Id: I746f5e203968f7bcc510fb66118c88ef0fd0cd14 Reviewed-by:
Christiaan Janssen <christiaan.janssen@nokia.com>
-
- Nov 17, 2011
-
-
Aurindam Jana authored
Instantiate QPluginLoader on heap. Change-Id: I53a7cb669379d374e8b6f83fe998c0bb17fbce33 Reviewed-by:
Kai Koehne <kai.koehne@nokia.com>
-
- Nov 01, 2011
-
-
Kai Koehne authored
Print detailed information about plugin loading when QML_DEBUGGER_VERBOSE is set in the environment. Change-Id: I48b9df01948b2cd226969cfbc520801527ff5492 Reviewed-by:
Aurindam Jana <aurindam.jana@nokia.com>
-
- Oct 17, 2011
-
-
Kent Hansen authored
(This commit is in preparation of moving several files to a separate library (QtQuick2).) Don't add all subfolders to the includepath (from the .pri files). There's no good reason to do that. For headers (both public and private) that are in the same folder as the file that includes them, prefer to use #include "foo.h" #include "bar_p.h" For public headers that are outside the current folder but have "unambiguous" names (e.g. qdeclarative prefix), use #include <foo.h> For private headers that are outside the current folder, use #include <private/baz_p.h> Also change #include <QtDeclarative/private/foo_p.h> to #include <private/foo_p.h> The header filenames already have a qdeclarative or qsg prefix; there's no need to prefix by module name to disambiguate. Finally, #include "private/foo_p.h" should be avoided. private/ is used for auto-generated (forwarding) headers, which never reside in the current (source) directory. Use angle brackets instead. Change-Id: I04f8477fdba043546064ee276475c09dc373f8f2 Reviewed-by:
Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
-
- Oct 04, 2011
-
-
Kent Hansen authored
The debug arguments string was moved from QApplication to QCoreApplication as part of the Qt refactor/library split, so there's no need to depend on QGuiApplication. Change-Id: I0eb87be318b80290be656d707e3d38020f765a90 Reviewed-on: http://codereview.qt-project.org/5883 Reviewed-by:
Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by:
Kai Koehne <kai.koehne@nokia.com> Reviewed-by:
Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
-
- Sep 21, 2011
-
-
Tasuku Suzuki authored
Merge-request: 1206 Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@nokia.com> (cherry picked from commit eb61f612fea1b76fe01ee237e5bd160f66aeca3d) Conflicts: src/network/access/qhttpthreaddelegate.cpp src/network/access/qhttpthreaddelegate_p.h Change-Id: Id4f8154d1b5f69ab490d9818facfdf5a733ec794 Reviewed-on: http://codereview.qt-project.org/4593 Reviewed-by:
Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
-
- Sep 20, 2011
-
-
Kai Koehne authored
Allow a new client to attach once the old one was disconnected. Done by Aurindam Jana. Change-Id: Id85045204cc011ec6e02db2658173e652b75c07e Reviewed-on: http://codereview.qt-project.org/5132 Reviewed-by:
Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by:
Aurindam Jana <aurindam.jana@nokia.com>
-
- Sep 19, 2011
-
-
Kai Koehne authored
Change-Id: I57d2360566eb35c90db82075851f153727712980 Reviewed-on: http://codereview.qt-project.org/5137 Reviewed-by:
Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by:
Aurindam Jana <aurindam.jana@nokia.com>
-
- Sep 02, 2011
-
-
Kai Koehne authored
Change-Id: I4b85b205a359e4c3adc1fcb6682945724a0910c5 Reviewed-by:
Aurindam Jana <aurindam.jana@nokia.com> Reviewed-on: http://codereview.qt.nokia.com/3937 Reviewed-by:
Kai Koehne <kai.koehne@nokia.com>
-
- Sep 01, 2011
-
-
Lars Knoll authored
Change-Id: I49efc4d0af4c19c24515ecfaa5c549e36f442cc8 Reviewed-on: http://codereview.qt.nokia.com/3992 Reviewed-by:
Gunnar Sletta <gunnar.sletta@nokia.com>
-
- Aug 24, 2011
-
-
Aurindam Jana authored
The service name is cleared in waitForMessage instead of receiveMessage so that consequent packets can de delivered to the service. A flag is used to check if the operation succeeded. Change-Id: I45b94a6194026d22ffb75a394628c7497ce4704e Reviewed-on: http://codereview.qt.nokia.com/3486 Reviewed-by:
Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by:
Kai Koehne <kai.koehne@nokia.com>
-
- May 24, 2011
-
-
Jyri Tahtela authored
Updated version of LGPL and FDL licenseheaders. Apply release phase licenseheaders for all source files. Reviewed-by: Trust Me
-
- May 11, 2011
-
-
Thiago Macieira authored
(cherry picked from commit 4671c273edb87e55436dd3bf0b371267c5e34ff7)
-
- May 10, 2011
-
-
Thorbjørn Lindeijer authored
This is necessary since some services may like to send a message back immediately when its state changes to enabled. Reviewed-by: Kai Koehne (cherry picked from commit 9fa0a9319ee0f178d03f9bdc4afbabb8563b4c62)
-
- Apr 27, 2011
-
-
Qt by Nokia authored
Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
-
Qt by Nokia authored
This is the beginning of revision history for this module. If you want to look at revision history older than this, please refer to the Qt Git wiki for how to use Git history grafting. At the time of writing, this wiki is located here: http://qt.gitorious.org/qt/pages/GitIntroductionWithQt If you have already performed the grafting and you don't see any history beyond this commit, try running "git log" with the "--follow" argument. Branched from the monolithic repo, Qt master branch, at commit 896db169ea224deb96c59ce8af800d019de63f12
-