- 28 Nov, 2014 - 2 commits
-
-
Laszlo Agocs authored
Change-Id: Ic8c8e6d7a9d99216292b8b4faa2926d849333a05 Reviewed-by:
Paul Olav Tvete <paul.tvete@theqtcompany.com>
-
Albert Astals Cid authored
Change-Id: Ic0e594cb53016e6f68fbfb6e6064707344afefef Reviewed-by:
Laszlo Agocs <laszlo.agocs@theqtcompany.com> Reviewed-by:
Gunnar Sletta <gunnar@sletta.org>
-
- 21 Nov, 2014 - 1 commit
-
-
Joni Poikelin authored
Task-number: QTBUG-42777 Change-Id: I8027f100c593ae7c57df7c952e66cc2b3fae1dd9 Reviewed-by:
Laszlo Agocs <laszlo.agocs@digia.com>
-
- 18 Nov, 2014 - 2 commits
-
-
Laszlo Agocs authored
Leave it up to the clients of QQuickRenderControl to do this, if they want it. It is usually not necessary. In the single-threaded widget world forcing deferred deletes to execute on every invalidate(), so for example from the hide event handler of QQuickWidget, is dangerous because widget apps tend to deleteLater() all sorts of widgets which can then be destroyed at unexpected times. From windowDestroyed() we continue to send the deferred deletes, just like all the render loops do. Task-number: QTBUG-42618 Task-number: QTBUG-40435 Change-Id: I8189124e2e7675361ee97bd8ba3e88b10ef193fa Reviewed-by:
Gunnar Sletta <gunnar@sletta.org>
-
Nico Vertriest authored
sizeHint is not a property of QQuickView Task-number: QTBUG-39044 Change-Id: I6e19e975ab71f73ddaf703956afb90f2e607b6f8 Reviewed-by:
Martin Smith <martin.smith@digia.com> Reviewed-by:
Topi Reiniö <topi.reinio@digia.com>
-
- 17 Nov, 2014 - 1 commit
-
-
Laszlo Agocs authored
Fix a typo and add a note to the signals. Change-Id: Ia8810562c5b5f192d7e54bc965807b8e78a26985 Reviewed-by:
Karim Pinter <karim.pinter@digia.com> Reviewed-by:
Paul Olav Tvete <paul.tvete@theqtcompany.com>
-
- 13 Nov, 2014 - 1 commit
-
-
Eskil Abrahamsen Blomfeldt authored
The font caches can only be used from a single thread at a time. QFontEngineFT for instance, uses a global static thread storage which is accessed on releasing and creating engines, and this causes a crash if the font engine is created on one thread and released on another. We use the updatePolish() function to make sure the caches are empty before entering updatePaintNode(), and then we invalidate the cache again after updatePaintNode() is done. [ChangeLog][Text] Fixed uncommon crash in text nodes. Change-Id: I01dbc2ed58aeebd03d77a157c700330334bdb385 Task-number: QTBUG-38800 Reviewed-by:
Konstantin Ritt <ritt.ks@gmail.com>
-
- 11 Nov, 2014 - 2 commits
-
-
Topi Reinio authored
The new documentation style for publishing docs under qt.io requires dedicated div classes for pages that use a three- column layout. The new divs enable the columns to stack and react to changes in the window width. Task-number: QTBUG-42086 Change-Id: Id0ccb0ef7e0be237789b8c891db05413efc1f8aa Reviewed-by:
Martin Smith <martin.smith@digia.com>
-
Eskil Abrahamsen Blomfeldt authored
Linear filtering can cause pixels outside the glyph's bounding rect to be sampled. On drivers where uninitialized texture data is actually uninitialized, this could cause artifacts in rendering for glyphs at the right edge of the initiliazed area since they would sometimes sample random pixels. To avoid this, we add padding between the glyphs in the cache. [ChangeLog][Qt Quick] Fixed uncommon artifacts in rendering of distance field glyphs. Task-number: QTBUG-42148 Change-Id: I6982b4a150d9459185d50a4362e1ead588d3860f Reviewed-by:
Yoann Lopes <yoann.lopes@theqtcompany.com>
-
- 10 Nov, 2014 - 2 commits
-
-
Eskil Abrahamsen Blomfeldt authored
This reverts commit a9238292. It also reverts follow-up commits: 87755d04 c2c710e5 cc8a76ce The new implementation is much too slow because it will cause each section of the border image to be uploaded to the atlas, and it will not be shared between different border images nor between different sizes of the border. The performance regression is so significant that it's not worth it for the original bug fix. We leave the tests around, so some of those might regress due to this. Change-Id: I3f56f4564255ebb77e6487881a6a11b19ad0234e Task-number: QTBUG-42288 Task-number: QTBUG-35838 Reviewed-by:
Michael Brasser <michael.brasser@live.com>
-
Laszlo Agocs authored
The same old issue surfaces in the windows render loop too. The basic render loop is already fixed, apply a similar patch to the windows one too. Task-number: QTBUG-42213 Change-Id: I07068315f5164014e329b8ce061947c97ae9da61 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@theqtcompany.com> Reviewed-by:
Sean Harmer <sean.harmer@kdab.com>
-
- 07 Nov, 2014 - 2 commits
-
-
Richard Moe Gustavsen authored
The previous code was wrong, as it cleared focus from the active focus item directly. By doing so we would only clear focus inside the focus scope that surrounded the item, but leave the scope itself with active focus (which would then be the focus object). The intended result is rather to end up with the root as focus object. Change-Id: I455a8939f8bc6c48765119b995aa781aee6d1e70 Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@digia.com>
-
Eskil Abrahamsen Blomfeldt authored
This makes compilation possible of the saveTexture() function which is used to store the distance field glyph cache on disk when debugging. It also changes the warnings output from here to have no prefix, since this is anyway always available as the context in Qt 5. Change-Id: If3b64f0921a59c485b5321a5465369708e764afc Reviewed-by:
Yoann Lopes <yoann.lopes@theqtcompany.com>
-
- 05 Nov, 2014 - 4 commits
-
-
Friedemann Kleint authored
Fixes purify warning: [W] UMR: Uninitialized memory read in QSGAnimationDriver::advance(void) {1 occurrence} QSGAnimationDriver::advance(void) [qtdeclarative\src\quick\scenegraph\qsgcontext.cpp:221] Task-number: QTBUG-42213 Change-Id: Ide35830c60c5935644747da5cfbad1cdbd357232 Reviewed-by:
Gunnar Sletta <gunnar@sletta.org>
-
J-P Nurmi authored
This is essential to the Qt Quick Controls for implementing floating text selection handle popups. Change-Id: Ibae65110a5db6d65dacd197fef3ad567d11342dc Reviewed-by:
Alan Alpert <aalpert@blackberry.com> Reviewed-by:
Shawn Rutledge <shawn.rutledge@digia.com>
-
Eskil Abrahamsen Blomfeldt authored
Just copy the one from QSGSharedDistanceFieldCache with some compile fixes to the superclass so we store the default cache as well. Change-Id: I1fcc390601eea58f8b7729c9cead418e4c94714c Reviewed-by:
Yoann Lopes <yoann.lopes@theqtcompany.com>
-
Caroline Chao authored
There are new APIs in Qt 5.4, the import version needed is 2.4. Change-Id: I1c52c6a50362f539670d9ad00e03e57208234a17 Reviewed-by:
J-P Nurmi <jpnurmi@theqtcompany.com> Reviewed-by:
Topi Reiniö <topi.reinio@digia.com>
-
- 04 Nov, 2014 - 1 commit
-
-
Eskil Abrahamsen Blomfeldt authored
When having e.g. a clip node inside another clip node and adding children to the innermost, we would get into the situation where we did a partial rebuild for the outermost root, but its available render order count would not be updated to reflect the change deeper down in the tree. Since the z range would be based on the outermost batch root's knowledge of the maximum render order in the tree, what would happen is that the z of the rendered nodes would increase steadily until they went outside of the viewing volume and disappeared. When decreasing the available order count of a batch root, we need to also decrease the available order count of its parents. If any of them drop below zero, we need to rebuild the render lists. [ChangeLog][QtQuick] Fixed nodes sometimes disappearing when adding many new nodes to the tree. Change-Id: I39c34acf0e1e0e87601f0fcd983f8da38cee029f Task-number: QTBUG-42096 Reviewed-by:
Gunnar Sletta <gunnar@sletta.org>
-
- 31 Oct, 2014 - 2 commits
-
-
Lars Knoll authored
The C++ standard doesn't allow calling member functions on a mull object. Fix all such places, by moving the checks to the caller where required. Change-Id: I10fb22acaf0324d8ffd3a6d8e19152e5d32f56bb Reviewed-by:
Simon Hausmann <simon.hausmann@digia.com>
-
Eskil Abrahamsen Blomfeldt authored
When e.g. growing the size of the border image in an animation, we would not get updates of the paint nodes when the size was so small that the bounded target rect and source rect did not change (when the size was smaller than the sum of the borders). Since this can happen, we also need to detect when the size changes and update the node for this case. Task-number: QTBUG-42022 Change-Id: I0849d740f363e66a3a4fd6de23fc9d7399ab0779 Reviewed-by:
Gunnar Sletta <gunnar@sletta.org>
-
- 30 Oct, 2014 - 2 commits
-
-
Mitch Curtis authored
getContext documentation wasn't showing up due to a syntax error: "any ..." Also fixed some small issues here and there. Change-Id: I3c0444d25bd0fea72fb4fcbf07b3e00794ff1414 Reviewed-by:
Venugopal Shivashankar <venugopal.shivashankar@digia.com>
-
Richard Moe Gustavsen authored
Instead of using a cursor width of null when a cursor delegate is set, we should to use a value of 1. Otherwise the rect we e.g return from cursorRect() will be invalid. An alternative would be to use the width of the delegate, but that was found to be controversial. On iOS we saw a bug with this when telling iOS to position text spelling popups underneath the cursor. Since the cursor rect we got was invalid (zero-width), no popup would show. Change-Id: Ice51b9a1bd33f331183e3acec61b7d9c0f5163cd Reviewed-by:
Andrew den Exter <andrew.den.exter@qinetic.com.au>
-
- 29 Oct, 2014 - 2 commits
-
-
J-P Nurmi authored
QVariant comparison in setModel() started failing because JS arrays are now passed as a QJSValue. Re-assigning the same array content should not trigger a model change. This change restores the old behavior it had before, when JS arrays were passed as QVariantLists. Change-Id: I1882b3531f2893b116dbd817edeecab1ae812ce8 Reviewed-by:
Simon Hausmann <simon.hausmann@digia.com>
-
Daniel d'Andrada authored
If an item grabs a touch that is currently being used for mouse pointer emulation, the current mouse grabber should lose the mouse as mouse events will no longer be generated from that touch point. Example of what happens without this patch: -User touches a MouseArea. It gets pressed. -Some other item grabs that touch. -This touch eventually ends. -The MouseArea would still be pressed. And what will happens instead after this patch: -User touches a MouseArea. It gets pressed. -Some other item grabs that touch. -The MouseArea gets canceled and released -This touch eventually ends. Change-Id: I24114f18be564553a4a768243bb20379affe7a8f Reviewed-by:
Shawn Rutledge <shawn.rutledge@digia.com>
-
- 28 Oct, 2014 - 2 commits
-
-
Jan Arve Saether authored
This started crashing because of 8f6436f1 Task-number: QTBUG-42227 Change-Id: I9e4862f6008c6ad6ec54469f2b39dd6be583e422 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@digia.com> Reviewed-by:
Frederik Gladhorn <frederik.gladhorn@theqtcompany.com>
-
Mitch Curtis authored
It can't be instantiated like a QML type, so it's actually better to just document measureText() (which is the only way to construct objects of this type) as returning an object containing some metrics for the current font. This should have no effect on user code. This solves the issue of the new TextMetrics type's documentation not showing up. TextMetrics is a type that *can* be instantiated and is more feature complete. It provides a declarative API for the functions that take arguments in QFontMetrics. Change-Id: I46251e6f3aa7179ab569f5131307181f71043df4 Reviewed-by:
J-P Nurmi <jpnurmi@theqtcompany.com>
-
- 27 Oct, 2014 - 3 commits
-
-
Jan Arve Saether authored
With this change, instead of writing: function accessiblePressAction() { submit() } You should write: Accessible.onPressAction: { submit() } For the moment, only 4 actions are added: press, toggle, increase and decrease. The old style action handlers are deprecated, and removed from the documentation. New style action handlers will be preferred in case an item declares both styles. Change-Id: I11919e631d8476d55540f94252757b911c44ade4 Reviewed-by:
Frederik Gladhorn <frederik.gladhorn@theqtcompany.com>
-
Frederik Gladhorn authored
There are many places where this doesn't make sense (a button in a search field, a line in a list represented as button with a child button to remove the list item...). Change-Id: Iab1d411adda696a01b1dcfdebb0a250066d6a7c2 Reviewed-by:
Jan Arve Sæther <jan-arve.saether@theqtcompany.com>
-
Frederik Gladhorn authored
Change-Id: I9230deaa75d1e9a9614f364d4adf92349c8a1901 Reviewed-by:
Jan Arve Sæther <jan-arve.saether@theqtcompany.com>
-
- 24 Oct, 2014 - 2 commits
-
-
Alex Blasche authored
When QML declares sprites and goalSprite in wrong order the goalsprite attempts to set it on null spriteEngine. This patch ensures that the order doesn't matter anymore. Task-number: QTBUG-40595 Change-Id: I57f1c8754b2e2af91e0c7f72d1d67fec3ad4ede5 Reviewed-by:
Lars Knoll <lars.knoll@digia.com>
-
Samuel Nevala authored
QLineEdit closes input method on enter key press, TextInput should also do the same. Commit and hide input method on enter key. When Qt::ImhMultiLine input method hint set only commit. Task-number: QTBUG-37850 Change-Id: I5a06e3eb777d7f794dd1493b307f0b05a2caf281 Reviewed-by:
Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@theqtcompany.com>
-
- 23 Oct, 2014 - 4 commits
-
-
Samuel Gaist authored
The use of the qDebug() macro to construct a QDebug object fails when QT_NO_DEBUG_OUTPUT is defined when building Qt. This patch aims to fix this. [ChangeLog][General][Build] Can now build with QT_NO_DEBUG_OUTPUT defined Change-Id: If807ee3439db2a98b4d146f75860a98f40c247ec Reviewed-by:
Gunnar Sletta <gunnar@sletta.org>
-
Gunnar Sletta authored
Change 63e6c9ad introduced snapping to the pixel grid in the vertex shader for native text, but this code was broken on retina displays because it assumed integer only positions. Fix it by including the retina scale factor into the rounding. Task-number: QTBUG-38702 Change-Id: I84492b02d64f263c9fe030790e04cf79b0dc4e2f Reviewed-by:
Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@theqtcompany.com>
-
Eskil Abrahamsen Blomfeldt authored
In updateSize() we were trying to force relayouts for RichText when the width changes by always setting widthExceeded to true. But further down in the same function, we overwrote this with textWidth() < idealWidth(), which doesn't work, because both properties are the wrapped width of the document and should only differ if the text cannot be wrapped properly. The result was that when increasing the width of a Text element, we would hit the optimization and skip the relayout. [ChangeLog][Text] Fixed Text with the RichText format to correctly update wrapping when the width of the element grows. Change-Id: I5fd87052a5ba7e8ee2549be0cfac4adc8ddf8290 Task-number: QTBUG-33020 Reviewed-by:
Simon Hausmann <simon.hausmann@digia.com>
-
Shawn Rutledge authored
Change-Id: I08b22766b3e389b7d27ca4c56729f550b0647a08 Reviewed-by:
Jens Bache-Wiig <jensbw@gmail.com> Reviewed-by:
Richard Moe Gustavsen <richard.gustavsen@digia.com> Reviewed-by:
Morten Johan Sørvig <morten.sorvig@digia.com>
-
- 22 Oct, 2014 - 4 commits
-
-
Laszlo Agocs authored
Change-Id: I58aa163bd17fae7190161641d94f51887d8f88a6 Reviewed-by:
Morten Johan Sørvig <morten.sorvig@digia.com> Reviewed-by:
Gunnar Sletta <gunnar@sletta.org>
-
Mitch Curtis authored
It's not obvious that calling setPosition() directly, for example, won't trigger animations defined in behaviors that react to that item's x and y properties changing, because a quick glance at the code shows that they have almost identical code paths and both emit geometryChanged(). Change-Id: Ic7f7019b1bbba24732569c0de777ee02d79c1d3b Reviewed-by:
Gunnar Sletta <gunnar@sletta.org>
-
Laszlo Agocs authored
Having a retina and non-retina screen connected resulted in getting no output from QQuickRenderControl and QQuickWidget on the non-retina screen. This is caused by the fact that Quick is blindly calling QWindow::devicePixelRatio(). This approach is wrong when using QQuickRenderControl since the QQuickWindow does not have an actual native window and so devicePixelRatio() merely returns some default value which will definitely be wrong for one of the screens. The patch fixes the problem by introducing QQuickWindow::effectiveDevicePixelRatio(), which, via QQuickRenderControl::renderWindowFor, supports the redirected case too. Task-number: QTBUG-42114 Change-Id: I057e01f0a00758dde438fc9b10af3a435b06bb0b Reviewed-by:
Paul Olav Tvete <paul.tvete@digia.com>
-
Mitch Curtis authored
Change-Id: I5fa93d559cdfde5e6b84ab0f3f35fd600e6bec4f Reviewed-by:
Topi Reiniö <topi.reinio@digia.com>
-
- 21 Oct, 2014 - 1 commit
-
-
Jan Arve Saether authored
Ignoring items with children will make the children appear as children of the parent of the ignored item. Since setAccessibleFlagAndListener now only sets the flag we also rename the function to just setAccessible Change-Id: I79fc311509a3e454b4698274c63ad0e879fb93e3 Reviewed-by:
Frederik Gladhorn <frederik.gladhorn@theqtcompany.com>
-