WMF plugin: Prevent detaching of QMediaResourceList

Change-Id: I2bf0fa346a166bdb20ce76b1fd4d7227680810dd
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Yoann Lopes <yoann.lopes@qt.io>

src/plugins/wmf/sourceresolver.cpp

@@ -158,7 +158,7 @@ HRESULT STDMETHODCALLTYPE SourceResolver::GetParameters(DWORD*, DWORD*)
     return E_NOTIMPL;
 }
 
-void SourceResolver::load(QMediaResourceList& resources, QIODevice* stream)
+void SourceResolver::load(const QMediaResourceList &resources, QIODevice* stream)
 {
     QMutexLocker locker(&m_mutex);
     HRESULT hr = S_OK;
@@ -176,7 +176,7 @@ void SourceResolver::load(QMediaResourceList& resources, QIODevice* stream)
     } else if (stream) {
         QString url;
         if (!resources.isEmpty())
-            url = resources.takeFirst().url().toString();
+            url = resources.constFirst().url().toString();
         m_stream = new MFStream(stream, false);
         hr = m_sourceResolver->BeginCreateObjectFromByteStream(
                     m_stream, url.isEmpty() ? 0 : reinterpret_cast<LPCWSTR>(url.utf16()),
@@ -187,7 +187,7 @@ void SourceResolver::load(QMediaResourceList& resources, QIODevice* stream)
             emit error(hr);
         }
     } else {
-        QMediaResource resource = resources.takeFirst();
+        QMediaResource resource = resources.constFirst();
         QUrl url = resource.url();
 #ifdef DEBUG_MEDIAFOUNDATION
         qDebug() << "loading :" << url;

src/plugins/wmf/sourceresolver.h

@@ -59,7 +59,7 @@ public:
 
     HRESULT STDMETHODCALLTYPE GetParameters(DWORD*, DWORD*);
 
-    void load(QMediaResourceList& resources, QIODevice* stream);
+    void load(const QMediaResourceList &resources, QIODevice* stream);
 
     void cancel();