Commit a25d3a24 authored by James McDonnell's avatar James McDonnell
Browse files

Limit the size of the QnxAudioOutput stack buffer


QnxAudioOutput allocates a buffer on the stack based on the free value
from snd_pcm_plugin_status, but the way that QnxAudioOutput configures
the stream, how QnxAudioOutput currently pauses playback, and a bug in
io-audio combine to cause io-audio to produce very large free values
when resuming playback after a long pause.  As a result, QnxAudioOutput
allocates a stack buffer that causes a stack overflow.  Allocating
a buffer on the stack with a size that isn't restrained in any way
isn't a good idea.  Put some constraints on the size.

Change-Id: I2b72e72504041f0caeb591912662fb9bed931b21
Reviewed-by: default avatarDan Cape <dcape@qnx.com>
Reviewed-by: default avatarYoann Lopes <yoann.lopes@qt.io>
parent ed8f90d0
Showing with 4 additions and 1 deletion
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment