- 28 Nov, 2016 - 1 commit
-
-
Oswald Buddenhagen authored
Change-Id: If20b4d8a3280afd169991d479d7cfe330ba41288
-
- 23 Nov, 2016 - 1 commit
-
-
Filippo Cucchetto authored
When diving two real values we can obtain an Infinite value. The qml engine perform an implicit conversion (and silent) if this value is directly assigned to an "int" property. On Arm the conversion of Infinite to int gives the value +2147483648. Thus the Repeater model instantiate 2147483648 items and crashes. By morphing both the rowHeight and paddedRowCount properties to "real" we keep the Infinite value semantic. This allows the Repeater to handle properly the Infinite case. Task-number: QTBUG-57283 Change-Id: I376f9ca497bea1f1aab413d1c1ba87d918b73fbb Reviewed-by:
Mitch Curtis <mitch.curtis@qt.io>
-
- 17 Nov, 2016 - 1 commit
-
-
Shawn Rutledge authored
TableView has currentRow not currentIndex. Task-number: QTBUG-56663 Change-Id: I9376354364bc843d118a672fcd1d9dfbba8e775c Reviewed-by:
J-P Nurmi <jpnurmi@qt.io>
-
- 11 Nov, 2016 - 2 commits
-
-
Oswald Buddenhagen authored
the CI obtains them from the qt5 super repo nowadays. Change-Id: Iaf03da27ec5ab4e901672439801be1929676533a Reviewed-by:
Jędrzej Nowacki <jedrzej.nowacki@qt.io>
-
Liang Qi authored
Task-number: QTBUG-53520 Change-Id: I0a38467a873bac8104b2e1fba7f7018f236673e6 Reviewed-by:
Mitch Curtis <mitch.curtis@qt.io>
-
- 01 Nov, 2016 - 1 commit
-
-
Oleg Yadrov authored
Date() constructor uses local time. E.g. in Brazil Oct-21-2012 is the start of daylight saving time, thus local dates at Oct-21-2012 between 00:00 and 01:00 do not exist there, so new Date(2012,10,21) returns Oct-20-2012 23:00, but new Date(2012,10,21,1) returns Oct-21-2012 00:00. 1 hour is enough to "jump over" the lost hour, but just in case we use 12. Task-number: QTBUG-54559 Change-Id: I35e1b69868d27dd98f78c4d57b3128a51b3e4b5e Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io> Reviewed-by:
Mitch Curtis <mitch.curtis@qt.io>
-
- 07 Oct, 2016 - 1 commit
-
-
J-P Nurmi authored
Task-number: QTBUG-54310 Change-Id: I9beef4d983c5fcea4e969cae5090686dfc1d37c6 Reviewed-by:
Shawn Rutledge <shawn.rutledge@qt.io>
-
- 06 Oct, 2016 - 1 commit
-
-
Frederik Schwarzer authored
This way it fits better to the other entries. Change-Id: I099ceaec4ecf80d267cb431815d63597e004fef1 Reviewed-by:
Shawn Rutledge <shawn.rutledge@qt.io>
-
- 16 Sep, 2016 - 1 commit
-
-
Liang Qi authored
Change-Id: I216e0df7ffff798827f4bea2c5cb8769eb37a053
-
- 14 Sep, 2016 - 1 commit
-
-
Mitch Curtis authored
__handlePos (badly named; it should be, e.g. __handleValueForPos) represents the value of the handle based on "fakeHandle"'s position. It is the result of range.valueForPosition() being called. However, the arguments to this function (fakeHandle.x and fakeHandle.y) don't always change when the values of the slider change, which leads to the x calculation for the handle delegate in SliderStyle having outdated information, causing the related bug. The fix for another bug already works around this issue by passing the relevant properties as arguments (which are ignored) to the function call. This is presumably done this way because it should be cheaper than forcing the JavaScript engine to evaluate a more clearly written expression where each related property is on its own line, for example. property real __handlePos: { range.positionAtMinimum, range.positionAtMaximum; return range.valueForPosition(__horizontal ? fakeHandle.x : fakeHandle.y); } In the case of the related bug, minimumValue has been updated, but __handlePos is still using the old value, causing the handle to be positioned incorrectly. So, we continue this tradition and add another property to the list of arguments. Task-number: QTBUG-51765 Change-Id: I40882872e668a867a8f5e5768244e199618bd769 Reviewed-by:
J-P Nurmi <jpnurmi@qt.io>
-
- 13 Sep, 2016 - 1 commit
-
-
Mitch Curtis authored
The layout was being destroyed before the text, which meant that the removeItemChangeListener() call never got hit. To ensure that the listener is always removed, loop through each child in QQuickLayout's destructor. Task-number: QTBUG-51927 Change-Id: I4235579501bd1790e9483a8741915e55f1b1b803 Reviewed-by:
Frederik Gladhorn <frederik.gladhorn@qt.io> Reviewed-by:
J-P Nurmi <jpnurmi@qt.io>
-
- 12 Sep, 2016 - 2 commits
-
-
Mitch Curtis authored
Change-Id: I625e7d3e4b5003105587769edb8fc68747ceac35 Reviewed-by:
Topi Reiniö <topi.reinio@theqtcompany.com>
-
Mitch Curtis authored
Specifying width and height is typically a bad idea, as they can be overridden by the layouting engine. implicitWidth and implicitHeight are better. Change-Id: Ib597f1fa98f82f00236c79bb5f9f07405593c35e Task-number: QTBUG-51842 Reviewed-by:
Andy Shaw <andy.shaw@qt.io> Reviewed-by:
J-P Nurmi <jpnurmi@qt.io>
-
- 08 Sep, 2016 - 1 commit
-
-
Iikka Eklund authored
Change-Id: I7676b06dfe58898b655e575208277f6a9a9ab7cf Reviewed-by:
Mitch Curtis <mitch.curtis@qt.io>
-
- 05 Sep, 2016 - 2 commits
-
-
Mitch Curtis authored
It's not exactly clear from the documentation. Change-Id: If173c63e080709c13b4a7b0bf18ef9b02eeec474 Reviewed-by:
Richard Moe Gustavsen <richard.gustavsen@qt.io>
-
J-P Nurmi authored
Task-number: QTBUG-55727 Change-Id: I6cbc1f020ead184fd8475f965f69db635ee2cc7b Reviewed-by:
Mitch Curtis <mitch.curtis@qt.io>
-
- 30 Aug, 2016 - 1 commit
-
-
Joni Poikelin authored
Prevent extra value changed signal to be fired in case when Slider with minimum > 0 and value > minimum are set. Change-Id: I86824c403a7c0296f782d2eec7ed30acfc13b304 Reviewed-by:
Mitch Curtis <mitch.curtis@qt.io>
-
- 26 Aug, 2016 - 1 commit
-
-
Joni Poikelin authored
Property binding for row property in styleData causes an update which tries to read new value for the index property, but index is changed afterwards which causes old value to be read. This may lead to crashes and other unwanted behavior. Depth changes are now delivered to update item depths in visible items and model index changes though role instead of looking for a row change. Task-number: QTBUG-47523 Change-Id: I540cd06a25281f18e4628f4b030cf969dc8e0a7f Reviewed-by:
Alex Blasche <alexander.blasche@qt.io>
-
- 22 Aug, 2016 - 1 commit
-
-
Filipe Azevedo authored
If the parent window gets destroyed while a QtQuick Controls menu is open the macOS native platform menu is not dismissed and you see a blank gray rectangle without any text. Also, at this point the QQmlEngine was already destroyed but it's still present on the call stack, so you get a crash when the stack unwinds to the original right mouse click that created the context menu. Change-Id: I638b0de13734815995d2994e6dd6603bcb0ebefc Reviewed-by:
Gabriel de Dietrich <gabriel.dedietrich@qt.io>
-
- 18 Aug, 2016 - 3 commits
-
-
Frederik Schwarzer authored
Change-Id: I6242fa1ab805d13753678feb5929da67ae0f4385 Reviewed-by:
J-P Nurmi <jpnurmi@qt.io>
-
Frederik Schwarzer authored
Change-Id: Ibd33614206e8d770bd7ee0888a8806662e3a1a73 Reviewed-by:
J-P Nurmi <jpnurmi@qt.io>
-
Nikita Krupenko authored
If scroll indicator is at the beginning and data prepended to contentItem, scroll indicator should change position to previous content beginning. This is especially important with so-called "infinite scrolling", when scrolling goes upwards and new content added at the top of the view. Task-number: QTBUG-50795 Change-Id: I250d6535b1146a54c6a70062b659cc49ed43709f Reviewed-by:
Mitch Curtis <mitch.curtis@qt.io>
-
- 15 Aug, 2016 - 1 commit
-
-
Topi Reinio authored
As of version 10.12 (Sierra), the name of Apple's desktop operating system will be macOS. Change all occurrences where the platform is discussed to use the macro \macos (defined in the documentation configuration in qtbase). Change-Id: I5ca47e4d830c12df297ee298ed22fd2d41dee739 Reviewed-by:
Leena Miettinen <riitta-leena.miettinen@qt.io>
-
- 12 Aug, 2016 - 1 commit
-
-
Sergio Martins authored
Closing a window while a popup is open should not trigger an activation event when the popup is closed. Prevents QGuiApplicationPrivate::focus_window from being changed to a stale window, which happens inside QGuiApplicationPrivate::processActivatedEvent(). Change-Id: I3145b3d191abb20d56fa9acbec8a0776a6bf8526 Reviewed-by:
Laszlo Agocs <laszlo.agocs@qt.io> Reviewed-by:
Gabriel de Dietrich <gabriel.dedietrich@qt.io>
-
- 02 Aug, 2016 - 1 commit
-
-
Mitch Curtis authored
This hasn't been an issue so far probably because those properties were accessed after m_doc had been set. However, adding some debug text can trigger a crash: Text { text: "document.cursorPosition=" + document.cursorPosition } Change-Id: Ib468815cdc0b103a2384457ab937cc3b764b96c8 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io>
-
- 07 Jul, 2016 - 1 commit
-
-
Mitch Curtis authored
Change-Id: I1c4c467eb549ea0be40cb1706647f933a963ada5 Task-number: QTBUG-54558 Reviewed-by:
Frederik Gladhorn <frederik.gladhorn@qt.io>
-
- 20 Jun, 2016 - 1 commit
-
-
Tim Jenssen authored
Change-Id: I305659b22f680eea903bf2e02a2998b9f71f5f5f Reviewed-by:
Tim Jenssen <tim.jenssen@theqtcompany.com>
-
- 19 Jun, 2016 - 1 commit
-
-
Sze Howe Koh authored
See http://comments.gmane.org/gmane.comp.lib.qt.devel/25771 Change-Id: If103e86d52428c4c6ea7ed9c4c6dd50ece6e8461 Reviewed-by:
Lars Knoll <lars.knoll@qt.io>
-
- 17 Jun, 2016 - 1 commit
-
-
Topi Reinio authored
src/controls/doc/src/qtquickcontrols-examples.qdoc:90: warning: Unable to parse QML snippet: "Expected token `{'" at line 1, column 10 src/controls/doc/src/qtquickcontrols-examples.qdoc:116: warning: Unable to parse QML snippet: "Expected a qualified name id" at line 1, column 1 src/controls/doc/src/qtquickcontrols-tableview.qdoc:299: warning: Unrecognizable QML module/component qualifier for TableView::section src/controls/doc/src/qtquickcontrols-treeview.qdoc:138: warning: Unrecognizable QML module/component qualifier for TreeView::section (multiple) warning: Can't link to 'DropShadow' Change-Id: Ic5e2dcbe9810486290e164f561ecba969f57df78 Reviewed-by:
Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
-
- 09 Jun, 2016 - 3 commits
-
-
Liang Qi authored
-
Olivier Goffart authored
Changing the contentHeight might change the maximum value of the scrollbar which might change the value of the scrollbar which, if blockUpdates is not set, will change the contentY of the flickable. This can cause flickering when contentHeight varries with contentY which might typically happen for a ListView where not all elements have the same height. Or worse, this can make the scrolling jump and result in the wrong position. Change-Id: I1968055492d679387ebbf6813a160efbf82e4fbb Reviewed-by:
Gabriel de Dietrich <gabriel.dedietrich@qt.io>
-
Liang Qi authored
Change-Id: I9d0eb301403bb785ab40120463c0ad184d1af7be
-
- 24 May, 2016 - 1 commit
-
-
Venugopal Shivashankar authored
Change-Id: I45816d2984bc91d2eb72d8d1c7506f9012486976 Reviewed-by:
Shawn Rutledge <shawn.rutledge@theqtcompany.com> Reviewed-by:
J-P Nurmi <jpnurmi@qt.io>
-
- 19 May, 2016 - 1 commit
-
-
Oswald Buddenhagen authored
Change-Id: I8c4251a7b49cbb572b64490f41edf87830603ecc
-
- 12 May, 2016 - 1 commit
-
-
Topi Reinio authored
Examples in binary packages now directly match the install path. Change-Id: Icd9ae9ef887b99b96177ec7b590fc3f35da18c82 Task-number: QTBUG-52953 Reviewed-by:
Antti Kokko <antti.kokko@qt.io>
-
- 11 May, 2016 - 2 commits
-
-
Albert Astals Cid authored
Unfortunately the destructor of QStyleOption is not virtual so you need to cast them all individually otherwise the wrong destructor is called Change-Id: I3b07450438d98910fbbff9f81234876551ed4e5d Reviewed-by:
J-P Nurmi <jpnurmi@qt.io>
-
Aleix Pol authored
Instead of instantiating a SystemPalette object for every Label, re-use the singleton, which is already designed for this. Change-Id: I7356fc983ea6dcd4dad0207c41ae1e0ba07dace4 Reviewed-by:
Albert Astals Cid <albert.astals@canonical.com> Reviewed-by:
J-P Nurmi <jpnurmi@qt.io>
-
- 10 May, 2016 - 1 commit
-
-
Shawn Rutledge authored
On OS X, if visible: true is declared, the dialog can be shown before the changes in 10f0ae7c are able to set the minimumWidth/Height properties. QWindow::setMinimumWidth() also does not force the window to be wider if it is already shown. Task-number: QTBUG-49058 Change-Id: Id87d92072904555639e1695851d908550d22fe86 Reviewed-by:
Alberto Mardegan <mardy@users.sourceforge.net> Reviewed-by:
Nikita Krupenko <krnekit@gmail.com> Reviewed-by:
Liang Qi <liang.qi@qt.io>
-
- 06 May, 2016 - 1 commit
-
-
J-P Nurmi authored
Use the pre-defined macro. Change-Id: I52e362672ff719202d3e40e4245baac2af29f624 Task-number: QTBUG-53208 Reviewed-by:
Simon Hausmann <simon.hausmann@theqtcompany.com>
-
- 03 May, 2016 - 1 commit
-
-
J-P Nurmi authored
Task-number: QTBUG-53123 Change-Id: If7b33d46828808d869a7e325a908a8a353c35f57 Reviewed-by:
Liang Qi <liang.qi@qt.io> Reviewed-by:
Mitch Curtis <mitch.curtis@qt.io>
-