Commit ddd24c00 authored by Oswald Buddenhagen's avatar Oswald Buddenhagen
Browse files

factor out add_reviewers


Change-Id: I4d210bd3c896bb5d1cb13b4d38a08bfb317f4150
Reviewed-by: default avatarSergio Ahumada <sahumada@blackberry.com>
parent 5989af3d
No related merge requests found
Showing with 12 additions and 8 deletions
...@@ -199,6 +199,17 @@ sub lookup_alias($) ...@@ -199,6 +199,17 @@ sub lookup_alias($)
return $user; return $user;
} }
sub add_reviewers()
{
if (@reviewers || @CCs) {
my @dudes = ();
push @dudes, "--receive-pack=git receive-pack";
push @dudes, map { " --reviewer=$_" } @reviewers;
push @dudes, map { " --cc=$_" } @CCs;
push @arguments, join('', @dudes); # Single argument to git push
}
}
sub push_patches() sub push_patches()
{ {
# Detect tracking branch if ref-to is not set # Detect tracking branch if ref-to is not set
...@@ -224,16 +235,8 @@ sub push_patches() ...@@ -224,16 +235,8 @@ sub push_patches()
$ref_to = "refs/for/".$ref_to; $ref_to = "refs/for/".$ref_to;
} }
my @dudes = ();
if (@reviewers || @CCs) {
push @dudes, "--receive-pack=git receive-pack";
push @dudes, map { " --reviewer=$_" } @reviewers;
push @dudes, map { " --cc=$_" } @CCs;
}
my @gitcmd = ("git", "push"); my @gitcmd = ("git", "push");
push @gitcmd, @arguments; push @gitcmd, @arguments;
push @gitcmd, join('', @dudes) if (scalar @dudes); # Single argument to git push
push @gitcmd, $remote, "$ref_from:$ref_to"; push @gitcmd, $remote, "$ref_from:$ref_to";
print '+'.join(',', @gitcmd)."\n" if ($verbose); print '+'.join(',', @gitcmd)."\n" if ($verbose);
...@@ -242,4 +245,5 @@ sub push_patches() ...@@ -242,4 +245,5 @@ sub push_patches()
load_aliases(); load_aliases();
parse_arguments(@ARGV); parse_arguments(@ARGV);
add_reviewers();
push_patches(); push_patches();
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment