Commit ea234a97 authored by Oswald Buddenhagen's avatar Oswald Buddenhagen
Browse files

hint about Signed-off-by footers


we don't need them, as contributors do a pre-emptive sign-off on all their
contributions by agreeing with the CLA.

Change-Id: Ibab565370e00800dde7fddaa10a7aa21c332037f
Reviewed-by: default avatarThiago Macieira <thiago.macieira@intel.com>
parent 0836a8e5
Branches
Tags
No related merge requests found
Showing with 8 additions and 0 deletions
......@@ -92,6 +92,7 @@ sub complain()
my $lineno = 0;
my $iswip = defined($cfg{wip});
my $badrev = 0;
my $badsign = 0;
my $badlog = defined($cfg{log});
my $spell_check = !defined($cfg{spell});
my $parents = 0;
......@@ -194,9 +195,13 @@ while (<MSG>) {
if (!$badrev && /^Reviewed-by:/i) {
$badrev = 1;
}
if (/^Signed-off-by:/i) {
$badsign = 1;
}
if (/^\(cherry[- ]picked /) {
# Some bad footers are ok above cherry-pick lines.
$badrev = 0;
$badsign = 0;
}
}
}
......@@ -221,6 +226,9 @@ if ($badcommitter) {
if ($badrev && !defined($cfg{revby})) {
&complain("Bogus Reviewed-by footer", "revby", 1);
}
if ($badsign) {
&complain("Unnecessary Signed-off-by footer", "", -1);
}
{
local $file = 'log message';
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment