Change-Id: I3d34f98c0f6b8abb6fcfb6846edab4c3dd9a4b45
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

Change-Id: Icc4dfd681017ff07ab34444004d0259579fe9949
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

messages like "Adding big file (49KiB > 50kB)" are a tad confusing.

Task-number: QTQAINFRA-485
Change-Id: If3ce78b47be8ba2e64075553abab7236044fb57a
Reviewed-by: Sergio Ahumada <sergio.ahumada@digia.com>

Change-Id: Ic15a8917b8b09d45f608123eab83b08079b837d6
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

It's more or less pointless to complain about these.

Change-Id: I85099cc3a267ab41915552a73c6b6c8c7fcb9ae8
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

the priority argument is not the gerrit score, not even inverted ...

Change-Id: Iec9081449bc9113715b68d2f7268939f6b568fef
Reviewed-by: Sergio Ahumada <sergio.ahumada@digia.com>

Detect and complain about various English spelling errors/typos.
The spelling error dataset comes from the Lingua::EN::CommonMistakes
CPAN module; the feature is silently disabled if that module is not
installed.

Change-Id: Ie67984e43803683477549926cb39c61b96549966
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

allows specifying a group to get config data from.

Change-Id: I80e8816e73d4690634fc558390cb3601a255f255
Reviewed-by: Sergio Ahumada <sergio.ahumada@digia.com>

The change is needed by qdoc to work after
https://codereview.qt-project.org/#change,51141



Change-Id: I4e97ef5957d2afc15aa314b73a49f4a22b01029e
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>

Change-Id: I8e2d3f2fa3a914d53cd84b93c32ae5c4424b63d0
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>

Change-Id: Ibae5d3655a9a5c76d21fee94b0c63efaba7a4996
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>

Change-Id: I9af54a1c6a75159a5f18f318f5e99332d8437dcc
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>

Change-Id: Id413cc1ce60e4421cecec612942243ede5280a91
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>

At some point "make docs" command started to need qhelpgenerator which
doesn't exist in qtbase, so it can not be used. That was causing
the qdoc bot to fail with a cryptic message:

    make[3]: *** Waiting for unfinished jobs....

Change-Id: I2bf2dd421fc55720a68a4659ddffbd3b789facf1
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>

Change-Id: I670423c6001e2a504df8be80b42ee88566ad3baa
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

this is in line with the other tools, and it allows us to use a sane
copyright header.

Revert "Add a proper license header qdoc-bot"

This reverts commit 30a8d896

.

Change-Id: I2ef4c1cde7fb2ca6ccbe2a8f84b3cb99c47a653c
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

Change-Id: I285d66824f135017f4880607af9f10b33b5ceb2d
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>

Use a single variable for the current line number of the commit message
and of the current file, in preparation for new checks which use this information.

Note that $lineno always counts from 1. Previously, $ln counted from 0 while
$lineno counted from 1.

Change-Id: I3a87d29df1378e304a27a7672630f0319dc863a2
Reviewed-by: Sergio Ahumada <sergio.ahumada@digia.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

Change-Id: I1cec04e8763c6102b485638058df37d9093ed859
Reviewed-by: Lars Knoll <lars.knoll@digia.com>

Change-Id: I1a88ac25571ad0e23672098dc03c2bb85062f390
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>

qdoc-bot should only provide a -1 if something can be staged.
When it is work in progress (WIP or ***) there is no risk of
it getting into Qt, so it should only provide a score of 0
and just tell what the (possible) problems are.

Otherwise it can be misread as a human -1 review to an idea.

Change-Id: Ica2b664eecf375cd0262007a423aafe379c607fd
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>

Change-Id: Ibaec7723a155c760ccafa89fe09c67d6410f06b5
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>

Otherwise viewing a table of review requests looks like a human has
already given a +1.

Change-Id: I670fb681ed52cce6ca252b581b94c48bbfc5d811
Reviewed-by: Thorbjørn Lund Martsum <tmartsum@gmail.com>
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>

In the future you can easily add more modules to the list.

Change-Id: I1a0fafd95d36ce8614711179bd5a60d5cbb5ac87
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>

Change copyrights and license headers from Nokia to Digia

Change-Id: I5b63c06bf0e6e45f5b00669f749e5e136ddc2f9d
Reviewed-by: Janne Anttila <janne.anttila@digia.com>
Reviewed-by: Lars Knoll <lars.knoll@digia.com>

Change-Id: I2de83a6046eeb75dfea27e07119c6eaf918642a0
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>

Change-Id: Ib6ad40d7555405bbb82e621d6f5d73062023eb62
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>

Change-Id: If340a1c7d7c7ece5484bac1a020e99676413d0f4
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>

Change-Id: Id76e2e974bb718ef0caa37dbc3f1df41ef007c55
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>

Change-Id: Ibf6374c5ebd0dd4fa8445f7bcd6092dbda442143
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>

Change-Id: I55f6e1571e1b43d01dff2777e051308d9d5286b0
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>

Change-Id: Icbaa49c966c23c23e7660d1e23b6ccd7ef9a5d8c
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>

Change-Id: Id221708d9b2ef61bd0bb21f9e75ef2d70b9b057a
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>

Change-Id: Ib529e42aa71569ef4c6296b23b13e24877ee7511
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>

Change-Id: I47ac9e23e9b12727fed26cf9e3b2598b0052b624
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>

Change-Id: I0b3434a10a3eac90d0cc7cd87d9626d0c9ebff15
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>

don't mess with the remote ref string

Change-Id: I30890801a40fc66049e96534ec69c7fe60032085
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>

- don't re-fetch them unless gerrit tells us there was an update
- fetch them together with the change ref

Change-Id: Icf00564ad676cd1b30cd5ab6596df83520d3fa53
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>

if the sanity bot is configured with gitdofetch=1, the repos need a
periodic cleanup - otherwise they become amazingly slow (a simple fetch
can take minutes before anything happens).

i was too lazy make this an option of the sanity-bot script itself.
maybe later.

Change-Id: I85306264cd67d321c10cb069e5bfb5b60b2ca6db
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>

options are stored in as git options in the group sanity.<dirname>, with
<dirname> being the basename of the repository.
it is recommended that these keys are added to the global git config,
outside the clones of the inspected repos.

the only currently recognized option is "flags", which corresponds to
the GIT_PUSH environment variable.

Change-Id: I011d4f335ca94b5aa08fc9bcb6283e6c2f7b3b79
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>