Change-Id: I5a4c481d5c4d417aece2b1db2bb940253c2f06b2

the CI obtains them from the qt5 super repo nowadays.

Change-Id: I528e92563d2a30c44d185811d40a133af7690e2d
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@qt.io>

The various byte count fields are all unsigned byte however the incoming
data are loaded in a QByteArray which returns signed char. This patch
fixes this by converting the field value to quint8.

[ChangeLog][Modbus] Fixed handling of packets with payloads longer than
127 bytes.

Task-number: QTBUG-54834
Change-Id: I699c4cf0cea9933bef6c040c573d2d6e6a113920
Reviewed-by: André Hartmann <aha_1980@gmx.de>

Task-number: QTBUG-51845
Change-Id: I2b6c4b9c55b43005a8bb153a3bb24d1e63ce5815
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>

QSerialPort::aboutToClose calls q->close() which leads to an infinite
recursion. Calling QModbusRtuSerialMaster::close() explicitly is not
necessary because when the serial port is closed,
QModbusRtuSerialMaster::close() has been invoked already in all cases.
Moreover, QSerialPort::aboutToClose asserts that serial master is
always in closing state.

Task-number: QTBUG-56009
Change-Id: If0dce93bbaa22116328b467f26c289cb58efc93f
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>

Change-Id: Ibb5049d46210a83704ec7ff3b9a300ab786f75ca

While the formula itself is correct, there is a chance of
getting wrong values due to limited data types.

Found after a hint from H.Mueller in the Peak Forum:
http://www.peak-system.com/forum/viewtopic.php?f=41&t=1238



Change-Id: I0f3036c5d694bee7cc8d3fd54e206545b71344b7
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>

It now still takes 76 chars only.

Change-Id: I561ca00274b4527ddc1a82e055692162b502c16b
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>

After talking to Simon we decided to include the 5.6.1 changes
file into this patchset, so we have it in for further reference.

Change-Id: I298070bd420a415446fc8721fcba0836b457051b
Reviewed-by: André Hartmann <aha_1980@gmx.de>

The TimeStamp object gets seconds and microseconds,
so the milliseconds that are smaller than one second
have to be transformed to microseconds.

Further, add the millis_overflow to extend the range
of the timestamps.

Change-Id: I0b0b531a7d1f2816d24a0683a2156cb19a3f655e
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>

The function PeakCanBackendPrivate::startRead() reads
all incoming frames until the receive buffer becomes empty.

When the receive buffer is empty, the function should
exit silently. Otherwise, an error should be set up.

The previous code simply used the wrong constant to
allow this valid case.

Change-Id: I325e25682d7749950d936bf715a160a2beff7d06
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>

* Copies at most sizeof(ifr_name) bytes
* Guarantees that ifr_name is zero-terminated

Change-Id: I68966767002dbe5f349ce9f03f34f4657d1827e9
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>

qcanbusdevice.h is already included in socketcanbackend.h

Change-Id: Ibcc50712c807b1e880b11d36e8dab08fcbcf9f2e
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>

To be consistent with other tech. preview module docs,
which use a different navigation.homepage for the breadcrumb.

Change-Id: Ib3ae3e5d027f01a4bd30958d87a3a699ae977add
Reviewed-by: Topi Reiniö <topi.reinio@theqtcompany.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>

From the qPrintable() help:

"Note: qDebug(), qInfo(), qWarning(), qCritical(), qFatal() expect %s
arguments to be UTF-8 encoded, while qPrintable() converts to local
8-bit encoding. Therefore qUtf8Printable() should be used for logging
strings instead of qPrintable()."

Change-Id: I724cc61659dd4f998617eade140b273dca841b35
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>

Make use of the detailed (and localized) error messages that
QLibrary already provides.

Example:

Cannot load library pcanbasic: \
  (pcanbasic: cannot open shared object file: No such file or directory)

Change-Id: I3f4fd42d1872a00f2c4ecc6172ccc17995c7888e
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>

We do not need do excess checks on is "open/close", as this
should becomes once in QCanBusDevice.

* QCBD::connectDevice() should return an error when the device
still is in progress of connecting/disconnecting, or already
connected.

* QCBD::disconnectDevice() has to make disconnection when the
device is in connected or connecting state; otherwise if the
device is in disconnecting state, then it should do nothing
(and as well when the device is in disconnected state).

Note: This behavior is similar to QAbstractSocket.

Change-Id: I4b62e728d37b190fbaee768bdd0a2878c3ba98ab
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>

Change-Id: If4e3bfcd736729b4505512070c48a3b86850e457
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>

Change-Id: I6293d1cef0a625faab8361f5899194b720a8af4b
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>

QCanBusDevice::setError() is no SIGNAL, but a protected
member function.

Change-Id: I10e83d189d3df93504b759729d0c4fc5caa682b0
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>

... for PEAK and TINY backends.

Change-Id: I0285107616bbfbaa91df266e2116f5d7460d60ca
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>

Change-Id: I726e3e739494cc2a6224260149d29b7977da767c
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>

Trying to close an interface that is not open leads
to errors which fill the internal error message buffer
with unrelated errors like "full write buffer".

Instead, the error should indicate that open failed.

As QCanBusDevice::connectDevice() already sets
UnconnectedState, this does not need to be done here.

Change-Id: I61c73c9d51e05eb5ea80a13e1c706e4a3eca98c0
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>

Change-Id: Iaa89eeae6c98d20719528acd6198ad10923205a2
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>

Change-Id: Iaadc554311f9c2dfd3f5c9d2970251a7ace3378b
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>

Change-Id: I35988b74c11517f5f0e5f7ea11038ea69f5c569c
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>

Change-Id: I6cdf904794f84d6a88261726b54f01200af1aec7
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>

The assignment '=' operator has a lower priority,
than the comparison '==, !=' operators. Thus, the
result of logical statements is wrong.

Change-Id: Iab281f1f3dd95b59da94379fd68a45f75e2dd5ac
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>

While a standard identifier has a range from 0 to 2^11,
extended identifiers have a range from 0 to 2^29.

As they are distinct by the IDE (identifier extension) bit,
the same numeric value is still different in the overlapping
range from 0...0x7FF.

E.g. 0x123 (IDE = 0) is different from 0x00000123 (IDE = 1).

With this change, the received messages are displayed
correctly according to the IDE bit.

The proper solution is already done in dev branch as
55ad040d



Task-number: QTBUG-53171
Change-Id: I7383b0f9c5e05746f442998cddfafe32f0932120
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>

While remote request frames can have a data length code,
they always have an empty data field. Fixed this by only
displaying the data length code and not the data field.

The proper solution is already done in dev branch as
55ad040d



Task-number: QTBUG-53171
Change-Id: I7a538f80a72b4efa5c66fee53e93eefd3a15e6f6
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>

Before, the connect dialog stayed open
when the main window was already closed.

Change-Id: I36734ab4ed4cea9e6e4c7a7ead11bb382b828f21
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>

Change-Id: I2b49dab5d934c9ff8524c45129f00becef87fd85
Reviewed-by: Ralf Nolden <nolden@kde.org>
Reviewed-by: Karsten Heimrich <karsten.heimrich@qt.io>

The line is much shorter than the 100 chars limit.

Change-Id: I030e7b7d61f607059de0723036e4114435c21bea
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>

Change-Id: I008cbae8c60c2bde7722f6f8955f9a53045b083d
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>

See http://comments.gmane.org/gmane.comp.lib.qt.devel/25771



Change-Id: Ib650bbd160e934a704fc8e7c49cbc18f0500c81f
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>

Use a properly set or calculated value, do not sporadically
calculate it inside a sending function. The only place the
caluculation shall happen is in setupEnvironment().

Task-number: QTBUG-53767
Change-Id: Id40fd3406bee404b9d44c8ad43a5160622eda2de
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>

Task-number: QTBUG-53277
Change-Id: I24d019696e73171154c8c29a5f76d9fc1737645c
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Karsten Heimrich <karsten.heimrich@theqtcompany.com>

Appearently, CanBusUtil was inspired by SocketCANs cansend,
and this does interpret all input as hexadecimal.

Further, the data byte following the hash mark '#' were
already used in hex, so let's be consequent.

Change-Id: I21324eb540ae2792f747dbae49865973d182d2d9
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>

That's totally valid, compatible to cansend,
and also stated in the help:

'{payload} has 0..8 (0..64 CAN FD) ASCII hex-value pairs'.

Syntax: canbusutil <plugin> <device> 123#

Change-Id: I4bd3aade2041cd7b4b1eae9779747b0a0f9dc379
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>

Change-Id: I12f20c93b50159c18216690edf58dcdc78ebe50a
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>