- 25 Oct, 2017 - 2 commits
-
-
Denis Shienkov authored
Qt includes should be added before platform-specific includes. Change-Id: Ie8bcf306c9e0f3d5d719ee57bcddc8bd2967f5cb Reviewed-by:
Alex Blasche <alexander.blasche@qt.io> Reviewed-by:
André Hartmann <aha_1980@gmx.de>
-
Denis Shienkov authored
It makes sense to use the QStandardPaths::writableLocation(QStandardPaths::TempLocation) directory for any of Unix-like platforms, as a 'last resort' to store the lock-files, if no other preferable directory was found. Change-Id: Ifd1a5789c014388509b29837171d3fdc440d63e6 Reviewed-by:
André Hartmann <aha_1980@gmx.de> Reviewed-by:
Alex Blasche <alexander.blasche@qt.io>
-
- 24 Oct, 2017 - 2 commits
-
-
Denis Shienkov authored
Change-Id: I844f5102077e7b4d5240947a614bfb163c8b7890 Reviewed-by:
Alex Blasche <alexander.blasche@qt.io> Reviewed-by:
André Hartmann <aha_1980@gmx.de>
-
Denis Shienkov authored
Change-Id: I12da9eb3a57fc312fb4b029714166af10755ca76 Reviewed-by:
Alex Blasche <alexander.blasche@qt.io> Reviewed-by:
André Hartmann <aha_1980@gmx.de>
-
- 12 Oct, 2017 - 2 commits
-
-
Denis Shienkov authored
* Update includes to common style. * Split very long lines. * Remove QT_USE_NAMESPACE macro. * Remove QObject::tr() calls. Task-number: QTBUG-60652 Change-Id: I76105da84b8b89e76b723208600604bca6edd8a5 Reviewed-by:
André Hartmann <aha_1980@gmx.de> Reviewed-by:
Alex Blasche <alexander.blasche@qt.io>
-
Denis Shienkov authored
Change-Id: I427b993a3a71f199029a8956cdf0dc2c98f0e444 Reviewed-by:
Alex Blasche <alexander.blasche@qt.io> Reviewed-by:
André Hartmann <aha_1980@gmx.de>
-
- 06 Oct, 2017 - 2 commits
-
-
Denis Shienkov authored
* Use the 'const' keywords more. * Split very long lines. * Use the 'm_' prefixes for all class members. * Use the QOverload in signal/slot casting. * Use more member class initializations. * Remove QT_USE_NAMESPACE macro. * Use from(to)Utf8 instead of from(to)Local8Bit. Task-number: QTBUG-60652 Change-Id: I5ef9916cc1e6371dde97154f5f5683f85bc02e96 Reviewed-by:
André Hartmann <aha_1980@gmx.de>
-
Denis Shienkov authored
* Use the 'const' keywords more. * Split very long lines. * Use the 'm_' prefixes for all class members. * Use the QOverload in signal/slot casting. * Use more member class initializations. * Remove QT_USE_NAMESPACE macro. * Use from(to)Utf8 instead of from(to)Local8Bit. Task-number: QTBUG-60652 Change-Id: I64bfaf93672dc69f4d10bcaaa0c1c6dd87267d3e Reviewed-by:
André Hartmann <aha_1980@gmx.de> Reviewed-by:
Alex Blasche <alexander.blasche@qt.io>
-
- 05 Oct, 2017 - 8 commits
-
-
Denis Shienkov authored
* Use the 'const' keywords more. * Split very long lines. * Remove QT_USE_NAMESPACE macro. * Update includes to common style. * Use more member class initializations. * Remove empy dtor. Task-number: QTBUG-60652 Change-Id: I9cd0e010f2489993141ed4e24557e492201c98b6 Reviewed-by:
André Hartmann <aha_1980@gmx.de> Reviewed-by:
Alex Blasche <alexander.blasche@qt.io>
-
Denis Shienkov authored
* Use the 'const' keywords more. * Split very long lines. * Remove QT_USE_NAMESPACE macro. * Update includes to common style. * Use more member class initializations. * Remove empy dtor. Task-number: QTBUG-60652 Change-Id: Ia9b108ad9fd65d55dd88e2d6c1e3ee36830abb6e Reviewed-by:
André Hartmann <aha_1980@gmx.de> Reviewed-by:
Alex Blasche <alexander.blasche@qt.io>
-
Denis Shienkov authored
* Use the 'const' keywords more. * Split very long lines. * Remove QT_USE_NAMESPACE macro. * Update includes to common style. Task-number: QTBUG-60652 Change-Id: I427f778f8005ea5766c0e6035c3996f6a01246ba Reviewed-by:
André Hartmann <aha_1980@gmx.de> Reviewed-by:
Alex Blasche <alexander.blasche@qt.io>
-
Denis Shienkov authored
* Use the 'const' keywords more. * Split very long lines. * Remove QT_USE_NAMESPACE macro. * Update includes to common style. Task-number: QTBUG-60652 Change-Id: I920ff6f7de9cede2e761cb629ab89945e70254d9 Reviewed-by:
André Hartmann <aha_1980@gmx.de> Reviewed-by:
Alex Blasche <alexander.blasche@qt.io>
-
Denis Shienkov authored
* Use the 'm_' prefixes for all class members. * Use more member class initializations. * Remove QT_USE_NAMESPACE macro. * Use from(to)Utf8 instead of from(to)Local8Bit. Task-number: QTBUG-60652 Change-Id: Ibdc607653d8727b88d4e041d0a9eb0a96e3289d7 Reviewed-by:
André Hartmann <aha_1980@gmx.de> Reviewed-by:
Alex Blasche <alexander.blasche@qt.io>
-
Denis Shienkov authored
* Use the 'm_' prefixes for all class members. * Use the QOverload in signal/slot casting. * Use more member class initializations. * Remove QT_USE_NAMESPACE macro. * Use from(to)Utf8 instead of from(to)Local8Bit. Task-number: QTBUG-60652 Change-Id: I3f7f078aad6d86f56feb6a3dfa78bf158ee0ee63 Reviewed-by:
André Hartmann <aha_1980@gmx.de> Reviewed-by:
Alex Blasche <alexander.blasche@qt.io>
-
Denis Shienkov authored
* Update includes to common style. * Remove QT_USE_NAMESPACE macro. Task-number: QTBUG-60652 Change-Id: Ic8860e7e6d0fa320e251e02f3d294845c662a8d0 Reviewed-by:
André Hartmann <aha_1980@gmx.de> Reviewed-by:
Alex Blasche <alexander.blasche@qt.io>
-
Denis Shienkov authored
* Use the 'm_' prefixes for all class members. * Use the QOverload in signal/slot casting. * Use more member class initializations. * Remove QT_USE_NAMESPACE macro. Task-number: QTBUG-60652 Change-Id: I1a2000de2f9a5152de31ec896659b6721aeb3a9a Reviewed-by:
André Hartmann <aha_1980@gmx.de> Reviewed-by:
Alex Blasche <alexander.blasche@qt.io>
-
- 18 Sep, 2017 - 1 commit
-
-
Andre Hartmann authored
* Replace Q_DECL_OVERRIDE with override * Init all POD members * Update includes to common style and remove unneded ones Task-number: QTBUG-60652 Change-Id: Ibb5c0347bd14cfc0386f39059498edd384a7200c Reviewed-by:
Denis Shienkov <denis.shienkov@gmail.com>
-
- 15 Aug, 2017 - 2 commits
-
-
Liang Qi authored
Conflicts: .qmake.conf Change-Id: Ie7fa76a9fb0013106e5a21b587585c8ccd7339d5
-
Thiago Macieira authored
Change-Id: Ib57b52598e2f452985e9fffd1459eb18587c99e3 Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io>
-
- 30 Jun, 2017 - 3 commits
-
-
Liang Qi authored
Change-Id: I36eef79e45e4dbc030b738d4453d7727d3418b48
-
Oswald Buddenhagen authored
Change-Id: I86804f418157aaa5fba0614bd68abb1d504aaa9c
-
Milla Pohjanheimo authored
Binary compatibility files updated for Qt5.9.0 Change-Id: Ib1009be62ab89954ea7221de88d8c0a748c8c017 Reviewed-by:
Sergio Ahumada <sahumada@texla.cl>
-
- 20 Jun, 2017 - 1 commit
-
-
Jani Heikkinen authored
Change-Id: I4b203538574e67c33c45a295b79bb13f6dcd244c Reviewed-by:
Alex Trotsenko <alex1973tr@gmail.com> Reviewed-by:
Denis Shienkov <denis.shienkov@gmail.com>
-
- 07 Jun, 2017 - 1 commit
-
-
Liang Qi authored
Conflicts: .qmake.conf src/serialport/qserialport_win.cpp Change-Id: Icc832e218a1135cb82e780ccaa63abd990289eaf
-
- 31 May, 2017 - 1 commit
-
-
Liang Qi authored
Change-Id: Ie6c5829bb5816b31a337976228dd218767c7c87d
-
- 17 May, 2017 - 1 commit
-
-
Denis Shienkov authored
... as there are plans to remove it from the QtCore. Change-Id: I79a2250b7b392896fa1c7307488a74dd44d62736 Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io> Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
- 11 May, 2017 - 1 commit
-
-
Jani Heikkinen authored
Listing important changes and bug-fixes. Change-Id: If72171427d5cf3de39f9404e15dc3b394d78a265 Reviewed-by:
Alex Blasche <alexander.blasche@qt.io>
-
- 10 May, 2017 - 1 commit
-
-
Oswald Buddenhagen authored
Change-Id: Ifc7f1e60966489b0352ef326a7fa5d141eee8d8f
-
- 04 May, 2017 - 1 commit
-
-
Alex Trotsenko authored
'bytesToRead' takes the result of signed 64-bit computation which could be negative. So, its type should be qint64. Change-Id: Ib51129143fcb70475ad383df417ae4282c858e41 Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
- 26 Apr, 2017 - 2 commits
-
-
Alex Trotsenko authored
Read notifications should be enabled all the time while the device is opened unless the buffer size limit is reached. To enable the read notifier again, the user needs to read the data or enlarge the buffer with a setReadBufferSize() call. According to that scenario, it's very likely that the device will toggle the state of notifier twice (on->off->on) in one notification cycle. This patch prevents this unnecessary toggling by: - unconditionally setting the notifier's state in setReadBufferSize()/ readData(); - deferring the notification disabling in readNotification() on Unix and in completeAsyncRead() on Windows to the next notification cycle. Change-Id: I97fc041bb705c034a7e73d1437e64b9b34dc2c18 Reviewed-by:
Denis Shienkov <denis.shienkov@gmail.com>
-
Denis Shienkov authored
This reduces the number of syscalls and thus the CPU load when dealing with fast ports. And 32KiB seems still small enough to be no concern on modern hardware even if it's excessive for a given port. Change-Id: I4749e4255627d3abf2393323216e01ac6436413b Reviewed-by:
Alex Trotsenko <alex1973tr@gmail.com> Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io> Reviewed-by:
Denis Shienkov <denis.shienkov@gmail.com>
-
- 25 Apr, 2017 - 1 commit
-
-
Alex Trotsenko authored
This patch replicates commit 225ef1ba for Windows. Change-Id: Ic4e3444183289e7ce1a487500633fb5ad95590b9 Reviewed-by:
Denis Shienkov <denis.shienkov@gmail.com>
-
- 22 Apr, 2017 - 2 commits
-
-
Alex Trotsenko authored
If the user calls setReadBufferSize() with a value lesser than the current size of the read buffer, then we get UB in readNotification(): readFromPort(nullptr, some_negative_value); Change-Id: Iddf5838c84c8615670285e9883c48f29faacc07e Reviewed-by:
Denis Shienkov <denis.shienkov@gmail.com>
-
Alex Trotsenko authored
We should not add the size of the internal write buffer here because QIODevice::bytesToWrite() already checks it. Also, take into account the size of 'writeChunkBuffer' on Windows. Change-Id: I87dfcb4dd1cd9d2bbb6f82a084d79fb4db9323d8 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
- 09 Apr, 2017 - 5 commits
-
-
Denis Shienkov authored
We do not need to use the ifdef guards for the CBR_ constants, because constants are standard and always exists in native API. Change-Id: I75ae9ffc17b132786fe5e72791b3f7c82c72c76e Reviewed-by:
Anton Kudryavtsev <antkudr@mail.ru> Reviewed-by:
Denis Shienkov <denis.shienkov@gmail.com>
-
Denis Shienkov authored
... otherwise, this notifier's instance will be active even if the serial port is not open. Change-Id: Ieebb894a048f3ed89ac5d1c259e21bc790f5d387 Reviewed-by:
Anton Kudryavtsev <antkudr@mail.ru> Reviewed-by:
Denis Shienkov <denis.shienkov@gmail.com>
-
Denis Shienkov authored
The event mask variable is used only once in process of initialization, so we do not need to keep this variable as the class member. Change-Id: I1f97a312cc92345d435dee821fefb8c2de33665e Reviewed-by:
Anton Kudryavtsev <antkudr@mail.ru> Reviewed-by:
Denis Shienkov <denis.shienkov@gmail.com>
-
Denis Shienkov authored
Change-Id: Ia9b0851ea7259bc4bc1aa709992b5eb215144a77 Reviewed-by:
Anton Kudryavtsev <antkudr@mail.ru> Reviewed-by:
Denis Shienkov <denis.shienkov@gmail.com>
-
Denis Shienkov authored
Change-Id: I0dc20fa836888d3caa678fd8f5b620625e00ec92 Reviewed-by:
Anton Kudryavtsev <antkudr@mail.ru> Reviewed-by:
Denis Shienkov <denis.shienkov@gmail.com>
-
- 27 Mar, 2017 - 1 commit
-
-
Kimmo Ollila authored
This module is not yet supported on INTEGRITY and therefore we'll exclude it from the CI build. Change-Id: Ia08354f0680865f0a2e08a3a3e3f59a88e98bd4e Reviewed-by:
Simon Hausmann <simon.hausmann@qt.io>
-