Skip to content
  • Marc Mutz's avatar
    Eradicate the last Java-style iterators and mark the module free of them · 6ed8a22d
    Marc Mutz authored
    
    
    ... and of QLinkedList.
    
    The change in QDesignerAbstractPropertySheetFactory is
    straight-forward.
    
    The rest are little buggers:
    
    - In macdeployqt, the code iterates inside an if. Weird, but portable.
    
    - In CppCodeParser, it's still somewhat harmless: just a call to
      std::remove_if to avoid running into quadratic complexity, even
      though the original loop had a good idea of iterating backwards,
      saving at least some copies in the process. Need to take care there
      that we continue to find the _first_ main.cpp, not the last, so add
      a check for mainCpp.isEmpty().
    
    - In QtGradientStopsModel, however, needed to work around the absence
      of QMap::rbegin()/rend(), and it shows why they're missing: QMap's
      funky op* makes it impossible to just use std::reverse_iterator to
      do the heavy lifting. Use the recently-added QKeyValueIterator to
      get an approximation. I say 'approximation', because that one lacks
      operator->, so we need to use (*it).first, which brings back
      memories of Qt 2's iterators...
    
    Change-Id: I051e64b8d36b04ed2e7cf7695d9b797f08efaccb
    Reviewed-by: default avatarJarek Kobus <jaroslaw.kobus@qt.io>
    Reviewed-by: default avatarFriedemann Kleint <Friedemann.Kleint@qt.io>
    6ed8a22d