Task-number: QTBUG-60664
Change-Id: If27459f44dbd4c4c7f5f6d0d8d8826f3c7f5a030
Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
Reviewed-by: Nico Vertriest <nico.vertriest@qt.io>

In addition, fix repetetive invocation of end().

Change-Id: I69c659e566dab8957cae3f50ae3e2671d0cc1ba3
Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

Task-number: QTBUG-60664
Change-Id: Ic3a55919c9f2fa2c07bc4cdc98dec3ed9aba72d0
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

The ternary expressions were the wrong way around.

This patch also makes the disabled EnterKey text more visible, as it
was very hard to see before.

Change-Id: I73b61ac7076e4c132c78e2c40be294e45bef3cc9
Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

Calling InputEngine::setInputMethod(null) did not clear the pointer
value stored in SelectionListModelPrivate.

Also, in case the input method is destroyed without setting it null,
prevent use of dangling pointer in selection list model by using
QPointer.

Task-number: QTBUG-61308
Change-Id: If340d99a63489c54414497c61cd482e06a21c5ee
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

To reduce the recognition response time, the engine allows to use
multi-threading. If the macro DECUMA_USE_MULTI_THREAD is defined
in the OEM build configuration file, and nMaxThreads is set to be
greater than 1, we will use a maximum of threads in recognition
process.

Change-Id: Ie285d5a8c64584e88f85723967fd42228d36208c
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

The file name of the database binaries has changed and is now
"hwrDB_le.bin" for T9 Write v8.0.0 and later.

Change-Id: Iad964ae3298c1674cd36f72b00bcb95c6934b955
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

Specific rules need to be executed in certain order. Wrap the
UNPACK_RULES to a list, so the order of the rules can be specified.

Change-Id: Ib160a814b49ed25fd0ed85337cfddf80afa0ccd7
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

[ChangeLog] Added Hebrew keyboard layout.

Change-Id: I7779db4e5ac3c5a99937a0d7b7e572db65f0d811
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

The timer in the ShiftHandler is used for detecting double
click events for shift key. A double click event will trigger
caps lock if the initial shift state is lower case.

However, the implementation did not handle a case where
the keyboard layout changes between the first and second
press. This can be done with multitouch.

The second problem was with the automatic test cases, where
the test code toggles the shift to see if there is a secondary
layout triggered by the shift key, e.g. in Arabic and Farsi.
However, if the keyboard layout does not contain secondary
layout, rapid shift state change will trigger caps lock
instead. This issue was identified with certain test case for
Hebrew layout.

This change fixes the issue by clearing the shift toggle timer
when the layout changes and in the automatic tests while
checking for the secondary layout with the shift key.

Also, update test code so that the shift press is simulated
with mouse. This will ensure the key exists in the layout
and that the key is enabled.

Change-Id: I2a528f1b82c30e8b8d9746d380b32ee370b38004
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

[ChangeLog] Added Farsi handwriting.

Change-Id: I1bf25cbc7f36cf8ca3f0a44b7e217a55ed3aa13a
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

[ChangeLog] Added Arabic handwriting.

Change-Id: Ica0601da2df262369159415d28fdb183e6f63736
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

The commit bc84550e

 added an option
to unpack a directory. However, the feature was not compatible with
python 3 due to incorrect chmod parameter. This change fixes the
parameter so it works with python 2 and 3.

Change-Id: Iaf74f2be660d6ee5de6cd58cc9c983707b2a9364
Reviewed-by: Liang Qi <liang.qi@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

If the Key.alternativeKeys are assigned like:

Key {
    alternativeKeys: condition ? "abc" : "def"
}

it will cause the following QML warning from BaseKey:

[...]/BaseKey.qml:82:32: Unable to assign [undefined] to QString

It seems to be caused by the order in which the dependent
properties effectiveAlternativeKeysHighlightIndex and
effectiveAlternativeKeys are updated.

This change fixes the issue by adding the effectiveAlternativeKeys
as condition for the property assignment.

Change-Id: I0225a95a60920201161c7d8c084667c57c1c29d4
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

This change allows the rules with same input file name (but
with different directory prefix) to co-exist. It works by
removing the already matched input file from the "zip list".
However, this only works if the rules are ordered correctly,
i.e. the most exact ones being first in the list.

Consider the following example:

'data/arabic': [
    '*/Arabic/_databas_le.bin',
],
'data': [
    '*/_databas_le.bin',
]

Without this change the later rule will override the
file entry already copied for 'data/arabic'. But with
'Arabic/_databas_le.bin' removed from the input list, it
will not be matched.

Change-Id: Ifd06125d1519c45dba077e50f69769fdb0070351
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

Accept directory as an input argument in addition to zip file.

Change-Id: I2faf446f7636d190941fae0f76e569cb1e7c332e
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

This fixes the original commit - 9db37be7



Change-Id: I6679ce07a4890f7d8d332f0400a5bbd2cc6bb577
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

Change-Id: I7a18614b4c9b44573490c3611bb0703ec60baa84
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

QWARN  : tst_layoutresources::layouts() qrc:///QtQuick/VirtualKeyboard/content/components/SelectionControl.qml:80: TypeError: Cannot read property 'cursorRectIntersectsClipRect' of null
QWARN  : tst_layoutresources::layouts() qrc:///QtQuick/VirtualKeyboard/content/components/SelectionControl.qml:48

: TypeError: Cannot read property 'anchorRectIntersectsClipRect' of null

Change-Id: I8478487c51462a37d3fa5396eac5b6ab4bec3a17
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

The guide lines were invisible due to incorrect color.

Change-Id: Ifdaf4b96aa15279ac2d79a71bad21ed7a713a26b
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

Since adding the new component InputModeKey in commit
ea998f43

 certain tests
(tst_plugin::test_hwrNumericInputSequence) started to fail.

The reason for the failure is the LipiInputMethod which always
returns all the supported input modes (Latin, Numeric and Digits)
regardless of input method hints.

This change modifies this behavior and limits the input modes
to ones actually requested by input method hints.

Change-Id: Iddc315a60541a879d2e655d0cbf4d65189026e8f
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

[ChangeLog] Added Serbian keyboard layout.

Change-Id: I7baa330791c62f7bbf4ff6a253ce1eea9f9c0e32
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

[ChangeLog] Added Hungarian keyboard layout.

Change-Id: Ie0491c625aa767c2e775f1961192f3e4fa0c652b
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

[ChangeLog] Added Czech keyboard layout.

Change-Id: I12d989436e0299dc3dc1e993d756aba31a30a763
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

[ChangeLog] Added Croatian keyboard layout.

Change-Id: I6e06b81439b046919561a5f7349d2603e53a7f55
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

[ChangeLog] Added Bulgarian keyboard layout.

Change-Id: I636ba97d3fe80c94f91b269426465023a433d7bf
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

[ChangeLog] Added Greek keyboard layout.

Change-Id: I56a15ebcf58c768d8f544654cb8a17a77c743e3f
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

The MODIFIER LETTER ACUTE ACCENT and MODIFIER LETTER GRAVE ACCENT were
not rendered correctly on the keyboard layout. Fix it by defining
regular accent characters in the displayText property.

After adding the displayText, it was noticed that the character preview
is not using the BaseKey::displayText for rendering. So fix it too.

Change-Id: If4889729a33a31d6adaf149ca4d263a2004abe7e
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

If a Key does not provide Key::key value, the default value is
derived from the first letter of Key::text. However, the key
should always be in uppercase. This change forces the default
key in uppercase.

[ChangeLog] Ensure the default value of Key.key property is
uppercase.

Change-Id: Ie1879e0f0e5020bdfc0f916d537dbf9cb2f6cb51
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

New property InputModeKey::inputModes:

    This property allows to define a custom list of input modes to
    toggle. If the list contains an invalid input modes (the ones
    not included in the available input modes) they are automatically
    disabled. The default list contains all the available input modes.

New property InputModeKey::inputModeCount:

    This read-only property reflects the actual number of input modes
    the user can cycle through this key.

Change-Id: I6be118565dc3d799074aa4159f1b0eec802ce591
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

If a keyboard layout provides multiple choices for input modes
(e.g. latin and cyrillic), prefer the current choice when switching
to handwriting layout and back.

Also, use the same mechanism to avoid binding loop when switching
input mode with InputModeKey contained in a KeyboardLayoutLoader
where the layout depends on the input mode.

Change-Id: If7adae92db39f3b1e49ec362679e6b6ae7f32fa4
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

Key caption is aligned differently when smallText is enabled.
This is not an issue if smallText is enabled for all keys,
but if enabled for individual keys the rendering will look bad.

Change-Id: I6d75dd1c012d79cdb2883b1f99988c6ba6aabe40
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

The T9 Write CJK integration added a new internal function
T9WriteInputMethodPrivate::setContext() used for updating T9 Write
session settings for different layout scenarios (e.g. full screen
mode vs regular layout).

However, this function calls finishRecognition() so it breaks the
input when switching between full screen mode and regular layout.

Fix this regression by preserving input between context changes.

Change-Id: I3ac269247466d34729c9b49c43425af069af69ea
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

The crash occurs in Hiragana input mode only when pressing the space
after entering a smiley. Fix it by handling the smiley as individual
characters instead of text when submitting to OpenWNN engine.

[ChangeLog][OpenWNN] Fixed crash when pressing the space after entering a smiley.

Task-number: QTBUG-62143
Change-Id: Ic5f271bdfe05491ffd6147f1fc8eb9f54ef4e032
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

[ChangeLog] Added Estonian keyboard layout.

Change-Id: Iadb39df14980e36a15f61f4e4f346f8aeee63b91
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

[ChangeLog] Added Dutch keyboard layout.

Change-Id: I91d853fe2e74c68492caf9afac85df2c4b64548d
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

This has been handled automatically for a while now.

We'll leave the section about the deployment location though, as
that could be useful.

Task-number: QTBUG-62099
Change-Id: Idc13302dbeb4ede632338747c492e5503ce2395c
Reviewed-by: Kati Kankaanpaa <kati.kankaanpaa@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

If a plugin is used, the qmldir file must be located next to
the plugin in the file system. By it being included in the .qrc
file it was deployed twice, once in the file system and once
in the virtual resource file system. A recent change in declarative
ended up doing an implicit import on that virtual directory and
thus uncovered this bug of the qmldir file being present in a (virtual)
directory where it doesn't belong.

qml_module.prf takes care of deploying the qmldir.

Task-number: QTBUG-62138
Change-Id: I7693b5656cb593454e2d777fe179e6f889d6dbdf
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>

QStringLiteral is broken in MSVC2015 onwards when used with \uXXXX
encoded character literals. This was the reason Japanese tests were
failing - the OpenWNN engine was actually broken and producing
garbage.

Not only this change eliminates QStringLiteral from openwnn, but also
reduces runtime memory usage by replacing QMap<QString, QString>.

The new solution is based on simple binary lookup table WnnLookupTable.
WnnLookupTable data was converted from existing QMap structures using
WnnLookupTable::create() method, which was left there for future
reference.

This change also removes the unnecessary QObjectPrivate definitions
from Romkan* classes.

[ChangeLog][OpenWNN] Fixed and optimized OpenWNN engine (as a workaround
for QStringLiteral breakage)

Task-number: QTBUG-62133
Change-Id: I50c9e2f5c363e1314f47d7023685da543ec9a7eb
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
(cherry picked from commit 0bf1c6ad)

Reduces allocations.

This is the result of running the (experimental) clang-tidy check
   qt-modernize-qsharedpointer-create

Discarded changes: none.

Change-Id: I9ef1ccd46315f1bb8f3cc30a652f17c18b46232c
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>