Commits on Source (7)
-
Allan Sandfeld Jensen authored
Destroy KeyboardLockServiceImpl instance when RenderFrameHost goes away This CL updates KeyboardLockServiceImpl to release its mojo binding if the RenderFrameHost instance it is linked to is destroyed. Bug: 888678 Change-Id: Icea5fe1a5c76df4d71fa4e78c423e49828664637 Reviewed-on: https://chromium-review.googlesource.com/1246290 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#594534}(cherry picked from commit 9d46e6e6ca8b9021b2d9f60bc3f3261b8718c616) Reviewed-on: https://chromium-review.googlesource.com/1254503 Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#769} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
d17576d3 -
Allan Sandfeld Jensen authored
fix dashimpl underflow Previous impl would assert (and read past legal memory) for the new test. Bug: skia: 8274 Bug: 875494 Change-Id: I2a2e20085d54d611151a9e20ae9cebf33c511329 Reviewed-on: https://skia-review.googlesource.com/148940 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Mike Klein <mtklein@google.com> Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
c6e96291 -
Allan Sandfeld Jensen authored
check for overflow in maxedgecount Bug: 848521 Change-Id: I5d5f28bc2ceef6e7a90b87f5e8c064473c6f67a3 Reviewed-on: https://skia-review.googlesource.com/146880 Auto-Submit: Mike Reed <reed@google.com> Commit-Queue: Herb Derby <herb@google.com> Reviewed-by:
Herb Derby <herb@google.com> Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
3eeb84af -
Allan Sandfeld Jensen authored
Roll skia/third_party/skcms f1e2b45d18fa..b2fffd2ecf2e (1 commits) https://skia.googlesource.com/skcms.git/+log/f1e2b45d18fa..b2fffd2ecf2e 2018-08-16 brianosman@google.com Actually support profiles with 1D and 2D CLUTs The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=kjlubick@google.com Change-Id: I1f1d967b7a856a79dd82ffc2fb51ff23c3e3bab8 Reviewed-on: https://skia-review.googlesource.com/147400 Reviewed-by:
skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
6d63f10a -
Allan Sandfeld Jensen authored
Worker: Move UpgradeInsecureRequest() to PopulateResourceRequest() Currently, UpgradeInsecureRequest() is called in WorkerFetchContext::PrepareRequest(), which is called after mixed content check. Therefore, insecure requests are blocked as mixed content before upgraded. This CL moves the UpgradeInsecureRequest() call to WorkerFetchContext::PopulateResourceRequest(), which is called before mixed content check. This is also consistent with FrameFetchContext, where insecure request is upgraded in FrameFetchContext::PopulateResourceRequest(). Bug: 880986, 880023, 880015, 880027 Change-Id: I983a40eebda8d04698b70d8c29e3707d4dcdf838 Reviewed-on: https://chromium-review.googlesource.com/1205750 Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#589478}(cherry picked from commit 85ef12e4845a8fdfcc00517ba61c5ebc3fd6416c) Reviewed-on: https://chromium-review.googlesource.com/1228779 Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#452} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
1c382237 -
Allan Sandfeld Jensen authored
Implement HTTPS state To make mixed content check more spec-conformant, this CL makes mixed content check in Workers/Worklets take into account whether the parent contexts are HTTPS or not, in addition to their SecurityOrigin, by - Implementing HTTPS state spec concept in ExecutionContext, i.e. Document https://html.spec.whatwg.org/#concept-document-https-state WorkerGlobalScope https://html.spec.whatwg.org/#concept-workerglobalscope-https-state WorkletGlobalScope https://drafts.css-houdini.org/worklets/#set-up-a-worklet-environment-settings-object - Plumbing outside Settings's HTTP state to Worker/WorkletGlobalScope via GlobalScopeCreationParams, and - Plumbing HTTP state from Worker/WorkletGlobalScope to WorkerFetchContext via FetchClientSettingsObjectImpl, and https://html.spec.whatwg.org/#https-state - Using it for mixed content check instead of SecurityOrigin. https://w3c.github.io/webappsec-mixed-content/#categorize-settings-object While this is still not completely spec-conformant, mixed content check becomes stricter: for top-level worklet scripts and subresource requests from data: URL workers created from HTTPS Documents, HTTP requests will be blocked after this CL. TBR=mkwst@chromium.org, nhiroki@chromium.org (cherry picked from commit a4a8feb2ce11b24b5330aace67081d8446b9ffa3) Bug: 880986, 880023, 880015 Change-Id: I4a43e2ee424177e93b0d7da40c2c1b8891cdced3 Reviewed-on: https://chromium-review.googlesource.com/1208390 Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#590225} Reviewed-on: https://chromium-review.googlesource.com/1228491 Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#455} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
e6c8000f -
Peter Varga authored
Add missing https_state.cc and https_state.h. This amends commit: e6c8000f [Backport] Fix for security issue 880023 (2/2) Change-Id: I810334ed6ec8e8ba2c43992f26a7c9de1c1706a1 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
4eda1a08
Showing