An error occurred while loading the file. Please try again.
-
Allan Sandfeld Jensen authored
The code was not correctly giving a function as argument to the addEventHandler, and the whole logic was more complicated than it needed to be. Change-Id: I21e4e6bb6adf1071ae7eb2798d129224af8ef0fb Reviewed-by:Peter Varga <pvarga@inf.u-szeged.hu>
dcd882be
/* Copyright (C) 2015 The Qt Company Ltd. This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with this library; see the file COPYING.LIB. If not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.*/#include <QtTest/QtTest>#include <qwebenginepage.h>#include <qwebenginescript.h>#include <qwebenginescriptcollection.h>#include <qwebengineview.h>#include "../util.h"#include <QWebChannel>class tst_QWebEngineScript: public QObject { Q_OBJECTprivate Q_SLOTS: void domEditing(); void injectionPoint(); void injectionPoint_data(); void scriptWorld(); void scriptModifications(); void webChannel_data(); void webChannel(); void noTransportWithoutWebChannel(); void scriptsInNestedIframes();};void tst_QWebEngineScript::domEditing(){ QWebEnginePage page; QWebEngineView view; view.setPage(&page); QWebEngineScript s; s.setInjectionPoint(QWebEngineScript::DocumentReady); s.setWorldId(QWebEngineScript::ApplicationWorld + 1); s.setSourceCode("el = document.createElement(\"div\");\ el.id = \"banner\";\ el.style.position = \"absolute\";\ el.style.width = \"100%\";\ el.style.padding = \"1em\";\ el.style.textAlign = \"center\";\ el.style.top = \"0\";\ el.style.left = \"0\";\ el.style.backgroundColor = \"#80C342\";\ el.innerText = \"Injected banner\";\ document.body.appendChild(el);"); page.scripts().insert(s); page.load(QUrl("about:blank")); view.show(); QSignalSpy spyFinished(&page, &QWebEnginePage::loadFinished); QVERIFY(spyFinished.wait()); QCOMPARE(evaluateJavaScriptSync(&page, "document.getElementById(\"banner\").innerText"), QVariant(QStringLiteral("Injected banner"))); // elementFromPoint only works for exposed elements QVERIFY(QTest::qWaitForWindowExposed(&view));7172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140
QCOMPARE(evaluateJavaScriptSync(&page, "document.elementFromPoint(2, 2).id"), QVariant::fromValue(QStringLiteral("banner")));
}
void tst_QWebEngineScript::injectionPoint()
{
QFETCH(int, injectionPoint);
QFETCH(QString, testScript);
QWebEngineScript s;
s.setSourceCode("var foo = \"foobar\";");
s.setInjectionPoint(static_cast<QWebEngineScript::InjectionPoint>(injectionPoint));
s.setWorldId(QWebEngineScript::MainWorld);
QWebEnginePage page;
QSignalSpy spyFinished(&page, &QWebEnginePage::loadFinished);
page.scripts().insert(s);
page.setHtml(QStringLiteral("<html><head><script>") + testScript + QStringLiteral("</script></head><body></body></html>"));
QVERIFY(spyFinished.wait());
const QVariant expected(QVariant::fromValue(QStringLiteral("SUCCESS")));
QTRY_COMPARE(evaluateJavaScriptSync(&page, "document.myContents"), expected);
}
void tst_QWebEngineScript::injectionPoint_data()
{
QTest::addColumn<int>("injectionPoint");
QTest::addColumn<QString>("testScript");
QTest::newRow("DocumentCreation") << static_cast<int>(QWebEngineScript::DocumentCreation)
<< QStringLiteral("document.myContents = (typeof(foo) == \"undefined\")? \"FAILURE\" : \"SUCCESS\";");
QTest::newRow("DocumentReady") << static_cast<int>(QWebEngineScript::DocumentReady)
// use a zero timeout to make sure the user script got a chance to run as the order is undefined.
<< QStringLiteral("document.addEventListener(\"DOMContentLoaded\", function() {\
setTimeout(function() {\
document.myContents = (typeof(foo) == \"undefined\")? \"FAILURE\" : \"SUCCESS\";\
}, 0)});");
QTest::newRow("Deferred") << static_cast<int>(QWebEngineScript::DocumentReady)
<< QStringLiteral("document.onreadystatechange = function() { \
if (document.readyState == \"complete\") { \
setTimeout(function() {\
document.myContents = (typeof(foo) == \"undefined\")? \"FAILURE\" : \"SUCCESS\";\
}, 0);\
} \
};");
}
void tst_QWebEngineScript::scriptWorld()
{
QWebEnginePage page;
QWebEngineScript script;
script.setInjectionPoint(QWebEngineScript::DocumentCreation);
script.setWorldId(QWebEngineScript::MainWorld);
script.setSourceCode(QStringLiteral("var userScriptTest = 1;"));
page.scripts().insert(script);
page.load(QUrl("about:blank"));
QSignalSpy spyFinished(&page, &QWebEnginePage::loadFinished);
QVERIFY(spyFinished.wait());
QCOMPARE(evaluateJavaScriptSync(&page, "typeof(userScriptTest) != \"undefined\" && userScriptTest == 1;"), QVariant::fromValue(true));
QCOMPARE(evaluateJavaScriptSyncInWorld(&page, "typeof(userScriptTest) == \"undefined\"", QWebEngineScript::ApplicationWorld), QVariant::fromValue(true));
script.setWorldId(QWebEngineScript::ApplicationWorld);
page.scripts().clear();
page.scripts().insert(script);
page.load(QUrl("about:blank"));
QVERIFY(spyFinished.wait());
QCOMPARE(evaluateJavaScriptSync(&page, "typeof(userScriptTest) == \"undefined\""), QVariant::fromValue(true));
QCOMPARE(evaluateJavaScriptSyncInWorld(&page, "typeof(userScriptTest) != \"undefined\" && userScriptTest == 1;", QWebEngineScript::ApplicationWorld), QVariant::fromValue(true));
}
void tst_QWebEngineScript::scriptModifications()
{
QWebEnginePage page;
QWebEngineScript script;
script.setName(QStringLiteral("String1"));
141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210
script.setInjectionPoint(QWebEngineScript::DocumentCreation);
script.setWorldId(QWebEngineScript::MainWorld);
script.setSourceCode("var foo = \"SUCCESS\";");
page.scripts().insert(script);
page.setHtml(QStringLiteral("<html><head><script>document.addEventListener(\"DOMContentLoaded\", function() {\
document.body.innerText = foo;});\
</script></head><body></body></html>"));
QVERIFY(page.scripts().count() == 1);
QSignalSpy spyFinished(&page, &QWebEnginePage::loadFinished);
QVERIFY(spyFinished.wait());
QCOMPARE(evaluateJavaScriptSync(&page, "document.body.innerText"), QVariant::fromValue(QStringLiteral("SUCCESS")));
script.setSourceCode("var foo = \"FAILURE\"");
page.triggerAction(QWebEnginePage::ReloadAndBypassCache);
QVERIFY(spyFinished.wait());
QCOMPARE(evaluateJavaScriptSync(&page, "document.body.innerText"), QVariant::fromValue(QStringLiteral("SUCCESS")));
QVERIFY(page.scripts().count() == 1);
QWebEngineScript s = page.scripts().findScript(QStringLiteral("String1"));
QVERIFY(page.scripts().remove(s));
QVERIFY(page.scripts().count() == 0);
}
class TestObject : public QObject
{
Q_OBJECT
Q_PROPERTY(QString text READ text WRITE setText NOTIFY textChanged)
public:
TestObject(QObject *parent = 0) : QObject(parent) { }
void setText(const QString &text)
{
if (text == m_text)
return;
m_text = text;
emit textChanged(text);
}
QString text() const { return m_text; }
signals:
void textChanged(const QString &text);
private:
QString m_text;
};
void tst_QWebEngineScript::webChannel_data()
{
QTest::addColumn<int>("worldId");
QTest::addColumn<bool>("reloadFirst");
QTest::newRow("MainWorld") << static_cast<int>(QWebEngineScript::MainWorld) << false;
QTest::newRow("ApplicationWorld") << static_cast<int>(QWebEngineScript::ApplicationWorld) << false;
QTest::newRow("MainWorldWithReload") << static_cast<int>(QWebEngineScript::MainWorld) << true;
QTest::newRow("ApplicationWorldWithReload") << static_cast<int>(QWebEngineScript::ApplicationWorld) << true;
}
void tst_QWebEngineScript::webChannel()
{
QFETCH(int, worldId);
QFETCH(bool, reloadFirst);
QWebEnginePage page;
TestObject testObject;
QScopedPointer<QWebChannel> channel(new QWebChannel(this));
channel->registerObject(QStringLiteral("object"), &testObject);
page.setWebChannel(channel.data(), worldId);
QFile qwebchanneljs(":/qwebchannel.js");
QVERIFY(qwebchanneljs.exists());
qwebchanneljs.open(QFile::ReadOnly);
QByteArray scriptSrc = qwebchanneljs.readAll();
211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280
qwebchanneljs.close();
QWebEngineScript script;
script.setInjectionPoint(QWebEngineScript::DocumentCreation);
script.setWorldId(worldId);
script.setSourceCode(QString::fromLatin1(scriptSrc));
page.scripts().insert(script);
page.setHtml(QStringLiteral("<html><body></body></html>"));
QSignalSpy spyFinished(&page, &QWebEnginePage::loadFinished);
QVERIFY(spyFinished.wait());
if (reloadFirst) {
// Check that the transport is also reinstalled on navigation
page.triggerAction(QWebEnginePage::Reload);
QVERIFY(spyFinished.wait());
}
page.runJavaScript(QLatin1String(
"new QWebChannel(qt.webChannelTransport,"
" function(channel) {"
" channel.objects.object.text = 'test';"
" }"
");"), worldId);
QSignalSpy spyTextChanged(&testObject, &TestObject::textChanged);
QVERIFY(spyTextChanged.wait());
QCOMPARE(testObject.text(), QStringLiteral("test"));
if (worldId != QWebEngineScript::MainWorld)
QCOMPARE(evaluateJavaScriptSync(&page, "qt.webChannelTransport"), QVariant(QVariant::Invalid));
}
void tst_QWebEngineScript::noTransportWithoutWebChannel()
{
QWebEnginePage page;
page.setHtml(QStringLiteral("<html><body></body></html>"));
QCOMPARE(evaluateJavaScriptSync(&page, "qt.webChannelTransport"), QVariant(QVariant::Invalid));
page.triggerAction(QWebEnginePage::Reload);
QSignalSpy spyFinished(&page, &QWebEnginePage::loadFinished);
QVERIFY(spyFinished.wait());
QCOMPARE(evaluateJavaScriptSync(&page, "qt.webChannelTransport"), QVariant(QVariant::Invalid));
}
void tst_QWebEngineScript::scriptsInNestedIframes()
{
QWebEnginePage page;
QWebEngineView view;
view.setPage(&page);
QWebEngineScript s;
s.setInjectionPoint(QWebEngineScript::DocumentReady);
s.setWorldId(QWebEngineScript::ApplicationWorld);
// Prepend a "Modified prefix" to every frame's div content.
s.setSourceCode("var elements = document.getElementsByTagName(\"div\");\
var i;\
for (i = 0; i < elements.length; i++) {\
var content = elements[i].innerHTML;\
elements[i].innerHTML = \"Modified \" + content;\
}\
");
// Make sure the script runs on all frames.
s.setRunsOnSubFrames(true);
page.scripts().insert(s);
QSignalSpy spyFinished(&page, &QWebEnginePage::loadFinished);
page.load(QUrl("qrc:/resources/test_iframe_main.html"));
view.show();
QVERIFY(spyFinished.wait());
// Check that main frame has modified content.
QCOMPARE(
evaluateJavaScriptSyncInWorld(&page, "document.getElementsByTagName(\"div\")[0].innerHTML",
281282283284285286287288289290291292293294295296297298299300301302303304305306
QWebEngineScript::ApplicationWorld),
QVariant::fromValue(QStringLiteral("Modified Main text")));
// Check that outer frame has modified content.
QCOMPARE(
evaluateJavaScriptSyncInWorld(&page,
"var i = document.getElementById(\"outer\").contentDocument;\
i.getElementsByTagName(\"div\")[0].innerHTML",
QWebEngineScript::ApplicationWorld),
QVariant::fromValue(QStringLiteral("Modified Outer text")));
// Check that inner frame has modified content.
QCOMPARE(
evaluateJavaScriptSyncInWorld(&page,
"var i = document.getElementById(\"outer\").contentDocument;\
var i2 = i.getElementById(\"inner\").contentDocument;\
i2.getElementsByTagName(\"div\")[0].innerHTML",
QWebEngineScript::ApplicationWorld),
QVariant::fromValue(QStringLiteral("Modified Inner text")));
}
QTEST_MAIN(tst_QWebEngineScript)
#include "tst_qwebenginescript.moc"