Commit 9522dc8f authored by Kirill Burtsev's avatar Kirill Burtsev
Browse files

Revert "Blacklist several Qt WebEngine quick dialog tests on macOS 10.13"

This reverts commit d4022e03
and partially fb430b4e

.

Reason for revert: initial blacklisting was done because of wrong assumption for test being flaky. But this is not the case. There is a non-zero chance that invalid build for macOS will be generated due to some undiscovered issue in build configuration or CI. Produced binaries are invalid and can't be used. If this first testcase fails then the whole suite will fail for every test. Blacklisting only moves failure further: first time from contextMenuRequested to javaScriptDialogRequested and etc, and second time to next test in whole suite tst_InspectorServer::testPageList. This creates a lot of really invalid failure entries in grafana testresults aggregator. It also creates confusion for the reason behind these kind of test failures and invalid bug report for other test failures.

Task-number: QTBUG-76549
Change-Id: I1dfe850f6a9cabec352c6e2bd5471e7c4f2e99ca
Reviewed-by: default avatarAllan Sandfeld Jensen <allan.jensen@qt.io>
parent b3458b3c
Branches
No related merge requests found
Showing with 0 additions and 8 deletions
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment