- Oct 07, 2014
-
-
Kai Koehne authored
It's faster to use QLatin1String in places where we don't actually need a QString object (like for comparison, or when creating a string with QStringBuilder). Change-Id: I9b8e28040dc2b79a767e15015b85822d06141bbe Reviewed-by:
Zeno Albisser <zeno.albisser@digia.com>
-
- Oct 03, 2014
-
-
Topi Reinio authored
- Remove url variable (it's included from global doc config) - Fix qhp selector for QML types - Sort the examples in qhp Change-Id: I7f72aebe4f5482ac922a294ad156f8a73e4ccc6e Reviewed-by:
Martin Smith <martin.smith@digia.com>
-
- Sep 29, 2014
-
-
Jerome Pasion authored
-added \since and added commands such as \readonly -converted enum values to use \value -edited language and other minor issues. -only the main Qt WebEngine, the widget docs will be edited later. Change-Id: Ifbb76a6472b5efede15daebc78d605b8b449d957 Task-number: QTBUG-40757 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com> Reviewed-by:
Topi Reiniö <topi.reinio@digia.com>
-
Jocelyn Turcotte authored
- Fix the example pages titles to match the qdocconf files - Remove information not as relevant for QtWebEngine as it was for QtWebKit - Fix the QtWebEngineWidgets snippet not to refer to webengine - Remove the dead link and the reference to Arora from QtWebEngine Change-Id: Ib3c57c8dd534330b3323c94fb2217374b3e52cf9 Reviewed-by:
Andras Becsi <andras.becsi@digia.com> Reviewed-by:
Jerome Pasion <jerome.pasion@digia.com>
-
- Sep 12, 2014
-
-
Jocelyn Turcotte authored
This method will be called if JavaScript calls window.close() and it currently crashes because of Q_UNREACHABLE. Change-Id: I50e261ff459879e9befb2a754f0108d7d2f18ca2 Reviewed-by:
Michael Bruning <michael.bruning@digia.com>
-
- Sep 11, 2014
-
-
Jocelyn Turcotte authored
After trying to get rid of all private header includes, the last standing one is qplatformnativeinterface.h even though its name previously suggested that it isn't private. This would be a complicated piece to expose publically in a way both flexible and binary compatible, and is a task heavy enough to justify committing to follow Qt's release cycle. The QML import version remains to 1.0 and will be incremented the same manner as QtQuick itself does. Change-Id: I6fab5f229d9f79dbc7a3e82d65ad324020929863 Reviewed-by:
Michael Bruning <michael.bruning@digia.com>
-
Jocelyn Turcotte authored
Most importantly, get rid of QOpenGLContextPrivate::globalShareContext which will be removed before the final. Change-Id: I5796fa822d2962c21fd8b6d8d3c196686d536e3d Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- Sep 10, 2014
-
-
Adam Kallai authored
The filesSelected QML signal is connected to FilePickerController::accepted slot but the type of the parameters were different. Change-Id: I36a33857b557797fc18699144c4d558d0e454cf8 Reviewed-by:
Michael Bruning <michael.bruning@digia.com> Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- Sep 05, 2014
-
-
Peter Varga authored
The test_urlProperty() qml test has failed because the active url was stored in LoadRequest in case of LoadFailedStatus. With this fix the loadRequest stores the url of that page which implies the request. Change-Id: I6aab814a4a7d3b47043b03fccde3d9995b40d8fa Reviewed-by:
Pierre Rossi <pierre.rossi@gmail.com>
-
- Sep 02, 2014
-
-
Pierre Rossi authored
The fact that the error pages are HTML and get loaded through the same mechanism should be kept an implementation detail and not be considered as a new load in the API sense. Also implement HasErrorPage for good measure and remove an anoying warning from the demo browser. The issue of the url not being changed remains in the QML test (but it doesn't affect a typical browser-like UI since the user input is still there untouched in the address bar), just make sure that failure does not affect the later checks. It also seems like we have a focus problem somehow, but the test should probably use a click for that matter. Change-Id: Ib5e363981a11287fdf4bfe84b93c999d96ed8087 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
Pierre Rossi authored
Expose settings in experimental for now. Simply use the global/per-view mechanism as a group level in between seems like overkill. Change-Id: I7610e9c7765ccb41674702acdd24a52b87716da8 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- Aug 29, 2014
-
-
Allan Sandfeld Jensen authored
This adds API for overriding some certificate errors. Once overridden any identical error for the same hostname and certificate will use the same override. Similar API for QtWebEngine QML should be added in a later patch. Change-Id: I144147b86d9b592e3f87346a1e48890acee0c670 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- Aug 28, 2014
-
-
Pierre Rossi authored
Not only this causes warnings because it is deprecated, it lead to a crash in our QML tests when the callback fails to return a valid engine instance. Change-Id: I9412f138f87c39fbee8dbb6121a5bf0a69dcfbb4 Reviewed-by:
Andras Becsi <andras.becsi@digia.com> Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
Pierre Rossi authored
Because the files were recent additions or for other unclear reasons, not all the files were updated to reflect the license change. Change-Id: I6898f6f4f993f1efa9489382f0b94af285f8c4f5 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- Aug 26, 2014
-
-
Jerome Pasion authored
-increases visibility to those pages. Change-Id: I6b776157eee991907c8e2bc16c63df90a85663a3 Task-number: QTBUG-40757 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- Aug 21, 2014
-
-
Zeno Albisser authored
For the WebEngineVersionBumper we have to remove the major version bits after right shifting to determine the minor number. Change-Id: I09f47dd261dc8de1e5cc94085ac3fdf3503588fb Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
Zeno Albisser authored
Change-Id: Idbe0eafb51d77cc00e3a93179b81770724d5bfaa Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com> Reviewed-by:
Tuukka Turunen <tuukka.turunen@digia.com> Reviewed-by:
Pierre Rossi <pierre.rossi@gmail.com>
-
- Aug 20, 2014
-
-
Jocelyn Turcotte authored
This fixes a regression after the 37 upgrade where the select popups would have the wrong position. Adjust to the new behavior and also avoid doing a mapToGlobal of the position received in InitAsPopup. RWHV::SetBounds has been giving us screen coordinates since the Chromium 33 update, but popup locations somehow managed to work properly through some side-effect sorcery. This also fixes the value of window.screen[XY] in JavaScript which wasn't updated when the window was moved. Change-Id: I544499bafedccfb7d389b4abc48f1386c398473f Reviewed-by:
Pierre Rossi <pierre.rossi@gmail.com>
-
- Aug 19, 2014
-
-
Michael Brüning authored
This is done on initialization of the Web Engine as this should happen before any contexts and Direct 3D devices are created. It makes D3D9 create a device with the D3DCREATE_MULTITHREADED flag and makes D3D11 enable multithread protection using the ID3D10Multithread interface. Depends on the appropriate counterpart in QtANGLE. Change-Id: I8204de2f8ebe993273ff9f11af55caacb1290e4e Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@digia.com>
-
- Aug 12, 2014
-
-
Jocelyn Turcotte authored
Also update all the examples to use 1.0 as 0.9 shouldn't be publically recommended. Change-Id: Ic58e35bdfd3a0f3d5201fc069b7103027ba84574 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- Aug 09, 2014
-
-
Pierre Rossi authored
Core interface to expose toggling some of the WebPreferences for now and most probably some of the WebRuntimeFeatures soon. The whole dummy settings business is meant to keep things from breaking too much when bisecting, because it is assumed that there are always valid settings for a given adapterClient. Change-Id: Ic0a62bcb5af8c0254436dc770b43cde5016c3bbd Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@digia.com>
-
- Aug 07, 2014
-
-
Peter Varga authored
Change-Id: Ic0de45c1fe2a5537d61ad446c96fe8fda7c30966 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- Aug 06, 2014
-
-
Jocelyn Turcotte authored
Manually import qt_(set_)gl_global_share_context from QtGui instead. The binary compatibility of those symbols should be maintained in QtGui, allowing us to avoid depending on private API. Change-Id: I1f954ec10a793c3195d3aec01409dde1bc767d64 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
Jocelyn Turcotte authored
QSGEngine was added in Qt 5.4 to allow using the scene graph without QQuickWindow. Use it for our FBO as well as for the QOpenGLWidget rendering. Change-Id: If4665d4f33c9dad69d2d4269309163bb5ffbd8e3 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
Andras Becsi authored
This is essential API that should be public. Change-Id: Ifbd86171933936112e2495ebed074faa2e52464d Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
Andras Becsi authored
Hide QObject's d_ptr member and use the macros when accessing the private class. This patch also adds missing qt namespace macros to the implementation. Change-Id: I004e3ea52bf21618835724d218f2a405f77ca4d1 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
Andras Becsi authored
Add missing navigationRequested API to be able to intercept navigation requests. This is useful for ignoring requests for example in kiosk-like applications that want to restrinct navigation to a specific url or domain, or want to disable specific types of navigation requests (e.g. reloading, clicking links, form submissions). Change-Id: Ie375e635a3c3566527972d05f5d99b39489c5ca8 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- Aug 04, 2014
-
-
Pierre Rossi authored
Use the chromium localized error strings for that purpose, otherwise the error description is always empty. While we're at it, let's tap into the chromium error pages, which should hopefully make sense for most errors, and add some static asserts to check that the qt quick enum and the core one are in sync. Change-Id: Icf8fa7c3bf4a674c60a10950422135fb6930447a Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
Pierre Rossi authored
and make it a namespace Change-Id: I15c1af8c7d0d8ab213cdf7945109263fe461d2ac Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
Jocelyn Turcotte authored
Do the d_ptr magic ourselves to avoid having to include private headers from qtcore, qtgui and qtdeclarative. It is hackish to hide QObject's d_ptr member to have the macros working in a public class, but if anything goes wrong we just need to replace the private macro convenience while maintaining the binary compatibility of the stored extra opaque pointer. Change-Id: Idb92f4f902826bef9068a5c2ef6ea31fc3fa15b2 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- Aug 01, 2014
-
-
Jocelyn Turcotte authored
Duplicate the small implementation of that function, which uses QMetaObject public API together with the semi-public fact that the meta class info named DefaultProperty needs to be fetched. Change-Id: I37413bd28a0b0ead55853e4e3db5864dfc39966b Reviewed-by:
Michael Bruning <michael.bruning@digia.com>
-
Jocelyn Turcotte authored
Fixes: - Make sure that we call SetInitialFocus when giving focus through Tab This does the same as would WebContents::FocusThroughTabTraversal - Implement QWebEnginePagePrivate::passOnFocus - Set each new RWHVQtDelegate as the focus proxy of the QWebEngineView - Make sure that the widgets delegate accepts the tab focus policy Cleaups: - RenderWidgetHostViewQtDelegateQuick doesn't need to be a focus scope, it doesn't have any children - We don't need to reimplement QQuickWebEngineView::forceActiveFocus since the view is now a focus scope - Do not explicitly setFocus(true) on the QQuickWebEngineView, the application should decide this through the API Change-Id: I817dc2c895d4fff4aa3536c71ecc5d306bb3bee0 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
Jocelyn Turcotte authored
Do what focusNextPrev does internally. Also fix the tab-focus by getting the next item relatively to the delegate (the scopedFocusItem()) instead of the view itself. Change-Id: I0d35a12bd5ef54d69df35b29ccdd55ac2301eec8 Reviewed-by:
Michael Bruning <michael.bruning@digia.com> Reviewed-by:
Zeno Albisser <zeno.albisser@digia.com>
-
Jocelyn Turcotte authored
Querying the platform names directly will be just as reliable as we are still only supporting a limited number of platforms. Change-Id: I9feba66b6ac23281db4d0ba675cc9a1e5560daea Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
Jocelyn Turcotte authored
We actually already depend on dev (5.4) in other areas. Change-Id: Iab297a51ab06209a96f11f97c74463d38203eda8 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
Szabolcs David authored
This fixes the flaky QQuickWebEngineViewGraphics test and extends it with a new test case. Change-Id: I2d8a0762716cb9232fdea6473760e67ac2e7146d Reviewed-by:
Andras Becsi <andras.becsi@digia.com> Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- Jul 26, 2014
-
-
Frederik Gladhorn authored
With this patch the accessibility hierarchy inside webengine becomes accessible when navigating from Qt Quick based web views. Change-Id: Ic1c8caaa908bd32e4175ee9dcdb7a6bef89818b6 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- Jul 24, 2014
-
-
Adam Kallai authored
Change-Id: Iffb04ff0c61e7a5e0c42ca224b1b04d0a62c66f8 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- Jul 21, 2014
-
-
Zeno Albisser authored
Change-Id: I50e3a2ba95b3c0b49af2139f763f11154defe503 Reviewed-by:
Frederik Gladhorn <frederik.gladhorn@digia.com> Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com> Reviewed-by:
Michael Bruning <michael.bruning@digia.com>
-
Zeno Albisser authored
QRectF takes either two points (top left / bottom right), or separate coordinates (x/y) together with dimensions for width and height. Change-Id: Iac20e2abaa4a273ddf7605ffa306220717ae283a Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-