- Jul 30, 2014
-
-
Allan Sandfeld Jensen authored
Adds one of the missing pieces of the QWebFrame and QWebView APIs. Unlike the QtWebKit version this only fetches the favicon URL, and not the icon. This is because we do not want to implement an icon database, and that the icon would be loaded asynchronous anyway, bringing no guarantee to be a valid icon/image yet. Change-Id: I227311ae3676044da850e687b82bee752b5079c8 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- Jul 11, 2014
-
-
Frederik Gladhorn authored
Change-Id: I37a32bd5dd8760bc91173968a620a1932ae67b4e Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
Frederik Gladhorn authored
The blink root element already has document as role. By setting it in the webview we'd get two documents in the hierarchy. Change-Id: Ie14e57b4e2050dbd9495c4fa94de4e2faebc02c1 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- Jul 10, 2014
-
-
Frederik Gladhorn authored
With this patch the accessibility hierarchy inside webengine becomes available when navigating from QWidget based web views. Change-Id: Ib3625a6ec93b4d3f298fb845ab85209b348349ba Reviewed-by:
Zeno Albisser <zeno.albisser@digia.com> Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- Jul 09, 2014
-
-
Frederik Gladhorn authored
This commit adds the basics to bridge the blink accessibility classes to QAccessibleInterfaces. Note that it needs two follow up commits to implement the bridging from the QWidget/Qt Quick worlds. [ChangeLog][Accessibility] QtWebEngine now has accessibility support, enabling assistive technology such as screen readers to work with it. Change-Id: Ied1d97e61a024115ac7a9245331211f6d9fac1b4 Reviewed-by:
Zeno Albisser <zeno.albisser@digia.com> Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- Jul 07, 2014
-
-
Frederik Gladhorn authored
Change-Id: I87d6532babc9475e46e28f6be7d1593622958764 Reviewed-by:
Michael Bruning <michael.bruning@digia.com>
-
- May 15, 2014
-
-
Szabolcs David authored
Drop hovered title and link text parameters, as we did in the Quick API. Change-Id: Ia1a38e0d728afbcbb6858a890486772da74aa813 Reviewed-by:
Pierre Rossi <pierre.rossi@gmail.com>
-
- May 12, 2014
-
-
Jocelyn Turcotte authored
This value is only used internally by Chromium and risks being removed at anytime, for which we would then have to maintain a downstream implementation. Chromium also only supports frame values, while a complete support of the interface would require also supporting this xPath to point to individual document element by affecting the value of "this", the same way that QWebElement::evaluateJavaScript allowed in QtWebKit. Change-Id: Id0cb1b8e3bdf9a6db0ca786fb5eb46ffd726d165 Reviewed-by:
Michael Bruning <michael.bruning@digia.com>
-
Michael Brüning authored
This keeps consistency with the other enum names. Change-Id: Idaedb8566fd770b05effeeba377b09a84bf0af12 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- May 08, 2014
-
-
Szabolcs David authored
Remove unreachableUrl support from WebContentsAdapter::setContent, because this argument behaves exactly the same as baseUrl. Change-Id: I36f92b99b7045c6d3b831481bb04d51a0e05772f Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- May 07, 2014
-
-
Jocelyn Turcotte authored
This patch fixes two issues: - The RWHV delegate of the old page would not be detached from the view when attaching a new page to that view. Call reattachRWHV as we do on the new page to make sure that the delegate gets unparented from the view. - QtWebKit documents that a page having the view as its QObject parent should be deleted when setPage is called with a new page. This would cause QupZilla to leak the page when opening a new window through a link. This also adds a workaround to avoid a crash when unparenting the delegate where QOpenGLWidget would try to call paintGL without a valid QSurface. Change-Id: Icd2659f441d2220c26dc175d66424e6c26125861 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- May 05, 2014
-
-
Szabolcs David authored
I dropped hovered title support from the QtWebKit API, it seems we don't need that logic. Change-Id: I5617c295344512a35aa526a6f1307f0b21f866d6 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- Apr 29, 2014
-
-
Pierre Rossi authored
Simply reuse the existing feature request approach that was used for geolocation and notifications in QtWebKit. Change-Id: I8fec4f4e9e81b491163912fadb4ce17d343864dd Reviewed-by:
Zeno Albisser <zeno.albisser@digia.com>
-
Pierre Rossi authored
Reuse the MediaCaptureDevicesDispatcher from the chrome layer, pretty much as is, and wire it in with WebContentsDelegateQt and WebContentsAdapter/WebContentsAdapterClient for API delegation. We also need to ensure that our user agent string mentions Chrome and the Chrome version we're based on, in order to please websites that detect feature support that way. Change-Id: I0ddf8cd34e4add96bc36f59adfe8e0384e728d93 Reviewed-by:
Zeno Albisser <zeno.albisser@digia.com>
-
Pierre Rossi authored
We could use this to prompt the user for various feature permissions that we are not ready to expose in our API. Change-Id: If6e6a16aca4142b0564121dfc7677b7c4996f742 Reviewed-by:
Zeno Albisser <zeno.albisser@digia.com>
-
- Apr 15, 2014
-
-
Jocelyn Turcotte authored
Headers were left intact to leave a trace of the evolution compared to the QtWebKit API and to make it easier to work until we had a basic subset of the API implemented. With the upcoming release, this patch removes this convenience in the aim of starting polishing the headers and the documentation for the upcoming release. Change-Id: Iae436b4ec041d771a7002575e122835802bc9f3e Reviewed-by:
Michael Bruning <michael.bruning@digia.com>
-
Jocelyn Turcotte authored
This changes implemented methods. The rest of the references will go away with the public headers cleanup. Change-Id: I82340cd7a4488c4b463489ae98cd9c16de4e7487 Reviewed-by:
Michael Bruning <michael.bruning@digia.com>
-
Jocelyn Turcotte authored
Expose the same values as currently available in QQuickWebEngineView::NewViewDestination. Rename the WebModalDialog to WebDialog, which actually replaces the tool/status/menuBarVisibilityChangeRequested signals. Change-Id: Icc103f434fb3eca49f1a53e476e101c3d6fffd36 Reviewed-by:
Pierre Rossi <pierre.rossi@gmail.com>
-
Jocelyn Turcotte authored
I initially misintepreted the meaning of the enum, assuming that it meant that the window should possibly be blocked. The user_gesture parameter in WebContentsDelegate::AddNewContents is actually doing this, while the popup disposition means that JavaScript requested the window to be opened without one of the standard decoration (i.e. status bar, menu bar, tool bar, etc.). Update the QtQuick API to reflect this, renaming the "isPopup" parameter to a more familiar "isUserInitiated". The popup disposition is named "dialog" to match the previous QWebPage::WebModalDialog enum. Change-Id: Ib0c4bc53671fcf0dd9499aa1be2bbc8c494ba49e Reviewed-by:
Michael Bruning <michael.bruning@digia.com>
-
- Apr 14, 2014
-
-
Michael Brüning authored
Translates the internally used LogSeverity values to enums defined by the QtWebEngine integration layer. Change-Id: I7da0983d4fb5c199e1a2436b5899a43cf6698784 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- Apr 10, 2014
-
-
Pierre Rossi authored
Due to the asynchronous nature of context menu events in chromium, we need to filter out the Qt generated events, and rely of what comes back from the chromium side. We keep a flag to ensure we're always in a consistent state, but the part re-setting it in QWEView went missing. This simply re-adds it together with initializing it to false upon view construction. Change-Id: I5d187faf93742898c96a1951b7dc477ce1b3f5bd Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu>
-
- Apr 08, 2014
-
-
Jocelyn Turcotte authored
Now that the widgets view is also using the delegated renderer, there are no supported configuration that use the BackingStore rendering path, itself on the way of deprecation in Chromium. Change-Id: I4ab889f6a7c65e8447c259faf2c7a98b88c1acf5 Reviewed-by:
Simon Hausmann <simon.hausmann@digia.com>
-
Jocelyn Turcotte authored
This means that widgets application now need to setup the GL context sharing as well. QWebEngineWidgets::initialize() must be called, which has the same effect as QWebEngine::initialize(). The QtWebEngineWidgets now depends on the QtWebEngine module to make this happen. Since QOpenGLWidget is only available in Qt 5.3, this patch also disables the webenginewidgets module completely when building using Qt 5.2. Change-Id: I0e99a779d1eb080f2ccf5a338ff0763ad64e6eba Reviewed-by:
Simon Hausmann <simon.hausmann@digia.com>
-
Jocelyn Turcotte authored
This reverts parts of commit 9c198939 . This does keeps the popup fixes and removes support for QWebEnginePage::setViewportSize and QWebEnginePage::render until we can evaluate the needs vs the cost of such feature. Change-Id: I1b55b751d463717b1462393ea8cd353422f8fdbb Reviewed-by:
Simon Hausmann <simon.hausmann@digia.com>
-
- Mar 31, 2014
-
-
Pierre Rossi authored
if people do something as nasty as "return this;" in createWindow. Change-Id: Id9c3e22607e4676b7ea286a6f85816b347262615 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
Jocelyn Turcotte authored
Change-Id: I105cb2a0a2479b146e2ab68db6d194ac2ac2d3f9 Reviewed-by:
Andras Becsi <andras.becsi@digia.com> Reviewed-by:
Zeno Albisser <zeno.albisser@digia.com>
-
Jocelyn Turcotte authored
Make sure that the navigation actions are updated when clearing the history. Change-Id: I663d2b68164dd695005165595ea08d051aae9fab Reviewed-by:
Pierre Rossi <pierre.rossi@gmail.com>
-
Jocelyn Turcotte authored
This does uses logic taken from Chromium's state save and restore code. The history version is incremented from the same method in QtWebKit in cases where the application would try loading a stream from a previous version using QtWebKit. In all cases where Chromium does a restore of a serialized history, it does so on a fresh WebContents instance, thus we must do the same and some of the initialization code has to be updated. Change-Id: I45abb052073bd44c9cb47bc2abcf4b558fe3dbbd Reviewed-by:
Pierre Rossi <pierre.rossi@gmail.com>
-
Jocelyn Turcotte authored
The adapter might change, while the page association should always remain. Change-Id: Ib2b49c599d497864484dd6758f47473d70fe4cb3 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- Mar 21, 2014
-
-
Jocelyn Turcotte authored
This mainly remove the use of the LoadingStateChanged callback, which is tied to DidStartLoading and DidStopLoading. Those signals are handled from the browser process side, also wrapping the time where the render process is initialized. We can't rely on those signals for loadStarted, but afterward rely on the Blink loader for loadFinished. We must use the same source for both. Instead only rely on Blink callbacks ultimately related to network events. This gives us a behavior closer to QtWebKit. The major compromise that this forces us to to accept is that loadStarted is now triggered asynchronously. This will basically break anything expecting loadStarted to be emitted synchronously from the load method. This also adjust autotests to get a few more passing. Initial-patch-by:
Pierre Rossi <pierre.rossi@digia.com> Change-Id: Ib6c0170df891d1b7f8ed4dc1d483985523e267dc Reviewed-by:
Pierre Rossi <pierre.rossi@gmail.com> Reviewed-by:
Simon Hausmann <simon.hausmann@digia.com>
-
- Mar 14, 2014
-
-
Pierre Rossi authored
Basic tooltip support for widgets relying on the existing QToolTip mechanism. Left unimplemented on the Qt Quick side for now since ToolTip support is still very much a work in progress there. Change-Id: Ia4bfd715a224e0cbc147c8860e131d1545cebe1e Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- Feb 28, 2014
-
-
Jocelyn Turcotte authored
This allows handling calls that would be signaled by QNetworkAccessManager in QtWebKit. This pulls QtNetwork as a dependency of the QtWebEngineWidgets module to be able to use QAuthenticator, but isn't required otherwise. Only the request URL is available in the case of HTTP authentication (no access to HTTP request headers that the QNetworkReply would allow) and only the proxy host name in the case case of proxy authentication. This keeps the API synchronous the same way, as QtWebKit did, in favor of source compatibility at the cost of requiring a modal dialog, even though the implementation doesn't require it. Change-Id: I9e021def38e6107c9e66d2de8f86bd0328d543df Reviewed-by:
Michael Bruning <michael.bruning@digia.com>
-
- Feb 21, 2014
-
-
Jocelyn Turcotte authored
Keep the size in the page itself, and ask the optionally attached QWebEngineView only for the rect position. When the view size change, call setViewportSize on the page like QtWebKit does. Change-Id: I735f1509cab9ef9b5d32bf31249a59c919939804 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- Feb 20, 2014
-
-
Jocelyn Turcotte authored
We also need to update the WebContentsAdapter pointer in QWebEngineHistoryPrivate. Change-Id: I8251e9834b179747b6b65630cf4ced5c2b1af27f Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
Jocelyn Turcotte authored
Change-Id: I1b58d2b2e86f60e296ae48095ed8d5e8172e0d1e Reviewed-by:
Pierre Rossi <pierre.rossi@gmail.com>
-
- Feb 13, 2014
-
-
Jocelyn Turcotte authored
A few changes to the API: - Return the success result asynchronously. - FindWrapsAroundDocument and HighlightAllOccurrences are enabled by defaults and cannot be disabled. - Found text isn't updating the selection on the page like QtWebKit did, but triggers a separate state not available. A find count and current index could be exposed, but isn't in this case to keep the API delta lower. This also adds the possibility to pass bool results through the CallbackDirectory and add a new tst_QWebEnginePage::findTextResult test since the old test relied on the selection to be updated when the searched text is found. Change-Id: I8189b5aea8d832df183c6c1ae03e3f08198a9c45 Reviewed-by:
Simon Hausmann <simon.hausmann@digia.com>
-
Jocelyn Turcotte authored
Change-Id: Idebde8da0befbea7ccc5942de1e09fcc61ce16d4 Reviewed-by:
Simon Hausmann <simon.hausmann@digia.com>
-
Jocelyn Turcotte authored
With the upcoming addition of a new type of callback result, this patch allows storing multiple callback types in the same QHash instead or requiring a different hash table just to please the type system. This does so by managing the ref-counted callback pointers directly instead of relying on a templated QExplicitlySharedDataPointer that requires a different type for each different callback pointer type. The ref-counting, construction and destruction is managed through a run-time type enum. Change-Id: I90ab2e1efc0c9703fc5b6ef57b38204ac8eea828 Reviewed-by:
Simon Hausmann <simon.hausmann@digia.com>
-
Jocelyn Turcotte authored
This tries to get the order of declaration to be consistent. It also follows the order used by Chromium in some places where the routing_id usually comes first, then the request_id and then the result of the asynchronous request. Change-Id: I88e164dee67e1631161a222f7dd7a4679c3d3acd Reviewed-by:
Simon Hausmann <simon.hausmann@digia.com>
-
Jocelyn Turcotte authored
Change-Id: I87c18edb89658433d6dc3487ab92d2ff7bd6c986 Reviewed-by:
Simon Hausmann <simon.hausmann@digia.com>
-