- Feb 07, 2018
-
-
Peter Varga authored
WebContentsAdapter is not created together with the QQuickWebEngineView. Thus querying a view property can lead to a crash if it uses the adapter. This fix adds the missing guards for contentSize and scrollPosition as it is done for similar WebEngineView properties. Task-number: QTBUG-65942 Change-Id: I9c2668a059b08325629f5730608280ba7f3669cf Reviewed-by:
Alexandru Croitor <alexandru.croitor@qt.io>
-
- Feb 05, 2018
-
-
Michal Klocek authored
Shutdown storage should take place in destructor, otherwise it might get recreated on web content destruction. Task-number: QTBUG-66081 Change-Id: Ibba3fce50e05e09131cf45061320a9f99267babd Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Feb 02, 2018
-
-
Michal Klocek authored
Do not use "Default" as custom profile, global profile uses "Default" as storge name, this ends up on creating two browser context adapters using the same files. Change-Id: I298fa87ee14c5c83a15683710ba3fbb29c201714 Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by:
Alexandru Croitor <alexandru.croitor@qt.io>
-
- Jan 31, 2018
-
-
Allan Sandfeld Jensen authored
The feature has been redesigned for security reasons in 64. [ChangeLog][General] SharedWorkers have been disabled as they have been changed in the newest spec for security reasons. Change-Id: I3d0e03f170ef646a0352a38b65030bb4c06f3397 Reviewed-by:
Michael Brüning <michael.bruning@qt.io>
-
- Jan 19, 2018
-
-
Jüri Valdmann authored
Task-number: QTBUG-62640 Change-Id: I2b16f24533b38c20a7071319723382ba240e35f3 Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu>
-
- Jan 18, 2018
-
-
Frank Richter authored
The glXCreatePbuffer() documentation states that the attributes list must be terminated with "None or NULL". However, GLX_NONE does not have a null value. Mesa is sensitive to this. Change-Id: I9606d95a6a0dadec446496abb8e0213950e3d700 Reviewed-by:
Michael Brüning <michael.bruning@qt.io>
-
- Jan 16, 2018
-
-
Michal Klocek authored
Change order of parsing buildtools.pro to avoid missing toolchain generated files. Change-Id: I40456cbf38573903c119313d036e4c2aea039b16 Reviewed-by:
Viktor Engelmann <viktor.engelmann@qt.io> Reviewed-by:
Kai Koehne <kai.koehne@qt.io>
-
Allan Sandfeld Jensen authored
-
- Jan 15, 2018
-
-
Allan Sandfeld Jensen authored
Moves QWebEngineBrowserContext to core and makes use of it from both widget and qml. Change-Id: I34748f302b0515b11b5831690d28478dfa6a852b Reviewed-by:
Michal Klocek <michal.klocek@qt.io> Reviewed-by:
Alexandru Croitor <alexandru.croitor@qt.io>
-
Allan Sandfeld Jensen authored
Change-Id: I63420b008c4511022868175ebac60949cf8aa434
-
Jüri Valdmann authored
Unlike QNetworkProxy, Chromium's net::ProxyServer expects the hostname and port to be at default values for special schemes (DIRECT and INVALID). Otherwise, a DCHECK is triggered at proxy_server.cc:73. Change-Id: I1ac6c425ea03fcbfe084d25c2fd05bf174c753d6 Reviewed-by:
Viktor Engelmann <viktor.engelmann@qt.io>
-
Allan Sandfeld Jensen authored
It was vulnerable to race conditions if two requests were send before the first was caught. Change-Id: Ia0b68594337028675678ad190f261202372c2ad6 Reviewed-by:
Viktor Engelmann <viktor.engelmann@qt.io>
-
Allan Sandfeld Jensen authored
Pull in SPECTRE mitigation Change-Id: I3849adce737c5518d02a5b27431bac50224c2065 Reviewed-by:
Michael Brüning <michael.bruning@qt.io>
-
- Jan 11, 2018
-
-
Michael Brüning authored
Pulling in the second set of security patches from Chrome 63. Changes: eebf32c32027 [Backport] Fix UAF in SetVisible(). a6ca6057e7e9 [Backport] [BlobStorage] Fixing potential overflow 0f0ad4d73977 [Backport] Fix a range bug in Persian calendar 81ed5d7a47a2 [Backport] Cherry-pick the entire fix for Persian calendar 9b1e7a460573 [Backport] Add size_t variants of constant-time functions. 941bccbf33f5 [Backport] Clear bottom three bits of password scalar in SPAKE2. 1f43353c961a [Backport] Change the script mixing policy to highly restrictive Task-number: QTBUG-65042 Change-Id: I668700e17f89297bbf2593a248f301f56904c72c Reviewed-by:
Alexandru Croitor <alexandru.croitor@qt.io>
-
- Jan 09, 2018
-
-
Allan Sandfeld Jensen authored
Pulling in the first set of security patches from Chrome 63 Changes: 4318c22e5167 Add missing .gitattributes -file in 3rdparty submodule eb4e4c294b56 [Backport] Fix OOB Write in QuicStreamSequencerBuffer::OnStreamData 13d8b0ed6a3a [Backport] Remove unsafe align4 call 93362702cc7e [Backport] Don't clear DnsAttempts that have received a response eeffcf490fd6 [Backport] Serialize struct tm in a safe way. 864b219901f8 [Backport] Simplify / fix SkBitmap::ReadRawPixels() 13827fc77195 [Backport] Resource Timing: Do not report subsequent navigations within subframes 07527dc5cae2 [Backport] Make CPWL_Wnd classes be observable. 0ce0976538dc [Backport] Setting focus on a widget may destroy the widget Task-number: QTBUG-65042 Change-Id: I6bb1b93d37111ada696ae77c2b2c04ecc17d2ca3 Reviewed-by:
Michael Brüning <michael.bruning@qt.io>
-
Antti Kokko authored
Change-Id: I0ff5721c1317ca97b574538c8c52127a87f73c29 Reviewed-by:
Frederik Gladhorn <frederik.gladhorn@qt.io>
-
- Jan 08, 2018
-
-
Alexandru Croitor authored
Both qtbase/src/corelib/configure.json and qtwebengine/configure.json declare the "icu" library, but the definitions of the library are different. Make sure to prefix the webengine "icu" declaration, so that it does not override the qtbase one. This is a partial backport of commit 2ed1e0ba which was introduced in Qt 5.10.0. The rest of the library definitions are not conflicting at the moment. Task-number: QTBUG-62944 Change-Id: If5cbf07a5bab149c7663ce05c7eb8183c5f63300 Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io> Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Peter Varga authored
- Guard QTemporaryDir::filePath (5.9) usage in the drag and drop implementation. - Guard QQuickItem::mapToGlobal (5.7) usage in the Quick context menu implementation. Change-Id: If383fa55fbbd1b2a3fe4abd57373598a1703786c Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Jan 05, 2018
-
-
Allan Sandfeld Jensen authored
After we keep around the browser-context after the profile is deleted it was keeping pointers to deleted objects and would sometimes use them on shutdown. Change-Id: Ib67d0ee0b27cb1a1b64d9b8b4c348ed418b9bbc3 Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-
- Jan 04, 2018
-
-
Kai Koehne authored
Static function ScreenWin::GetSystemMetricsInDIP returned an incorrect (already scaled) size for the scrollbars. To take system scaling into account an instance of the ScreenWin singleton has to be created once. So let's use ScreenWin directly, instead of DesktopScreenQt, which is just a mock object anyway. [ChangeLog][Windows] Fixed issues with too large scrollbars on Hi-DPI monitors. Task-number: QTBUG-60705 Change-Id: I7cbc10e98b2a5217b0a0e78afb32818c1cb199d7 Reviewed-by:
Alexandru Croitor <alexandru.croitor@qt.io> Reviewed-by:
Viktor Engelmann <viktor.engelmann@qt.io>
-
- Jan 02, 2018
-
-
Michal Klocek authored
Since e812237b we do not longer use QT_LIBDIR_EGL and QT_LIBDIR_GLES2 to dynamically load gl libraries. Remove leftovers from gn generator. Task-number: QTBUG-65442 Change-Id: I045242b49be411373d36eb9c333916d27b0f169d Reviewed-by:
Viktor Engelmann <viktor.engelmann@qt.io>
-
- Dec 20, 2017
-
-
David Faure authored
It's used from another thread, so it shouldn't be deleted immediately, and it's not deleted by the QtWebEngine code, so tell people to do it themselves at the right time. Change-Id: I54786be320f5fe82f144e7b1c2e6137260d9ceab Reviewed-by:
Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Dec 18, 2017
-
-
Alexandru Croitor authored
2ee59e45bd Fix hanging of process when application is closed too fast cdecf3ca05 Silence most spurious warnings with gcc Change-Id: I220ec63538e13cd5e71552a5f6d99de564a3f0ea Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Kai Koehne authored
The docs were wrong in that the default is actually text/plain with US-ASCII encoding (see e.g. data_url_unittest.cc). Anyhow, saying it might change in the future does not help anyone, and is actually a potential security risk - see e.g. the discussion about 'magic' in QTextEdit::setText(). Because of this, it's unlikely that Chromium ever changes the default. Anyhow, we can as well hardcode the default, and document it then. Change-Id: I949111598a30fa69d152d3e98d76e9d96df92d54 Reviewed-by:
Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by:
Viktor Engelmann <viktor.engelmann@qt.io> Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Dec 14, 2017
-
-
Michael Brüning authored
When printing very large documents using the QPrinter-based API, it was possible to run out of memory because the images that pdfium has generated was cached for reuse when printing multiple copies of the document. Caching the images is now removed as printing multiple copies is not the default use case and is nowadays often also handled by the printer itself. Task-number: QTBUG-58400 Change-Id: I27bd17b33a839a845ca1b387b0c3bd0466b6592f Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Alexandru Croitor authored
The method currentTimeForEvent() tried to access the timestamp() method for a QEvent::Leave event. Leave events are regular QEvents and not QInputEvents, and thus have no such method. Change-Id: Iecc20d239b0e2a5b39b995dabdd7ca8fb44491aa Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Dec 13, 2017
-
-
Jüri Valdmann authored
Software layers (added in qtdeclarative 5.8) also need updating. Task-number: QTBUG-62867 Change-Id: If7a941d7e360871822e1776cde3845abcb1f7efa Reviewed-by:
Michael Brüning <michael.bruning@qt.io>
-
Peter Varga authored
Task-number: QTBUG-64967 Change-Id: Ida79d6cdb682d510e9a2e91e3e3ca263acf34a99 Reviewed-by:
Viktor Engelmann <viktor.engelmann@qt.io>
-
- Dec 12, 2017
-
-
Oswald Buddenhagen authored
Change-Id: I88eb85ea51a5d0b0b98b21e7213ed963995b255a
-
- Dec 11, 2017
-
-
Allan Sandfeld Jensen authored
It can according to documentation potentially be null, even if it might not happen in our cases. Task-number: QTBUG-63854 Change-Id: I76029c83fe32c163c2707568fe81b7590a79b4fe Reviewed-by:
Alexandru Croitor <alexandru.croitor@qt.io> Reviewed-by:
Michael Brüning <michael.bruning@qt.io> Reviewed-by:
Viktor Engelmann <viktor.engelmann@qt.io>
-
- Dec 08, 2017
-
-
Peter Varga authored
Hide tooltip on empty text and make tooltips more fluent by ignoring duplicate requests. Task-number: QTBUG-64933 Change-Id: Ib82cb06ceda938548429cd694b849a2faadd2633 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Dec 05, 2017
-
-
Peter Varga authored
Task-number: QTBUG-64812 Change-Id: I9df71253cf6c541622e431b1ff444fc49269d0c3 Reviewed-by:
Jüri Valdmann <juri.valdmann@qt.io> Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Dec 04, 2017
-
-
Alexandru Croitor authored
Continiously failed 5 times on Windows when integrating unrelated patches. Task-number: QTBUG-61887 Change-Id: Ibc3e1563355364302f7ee430c97209798e86e3e7 Reviewed-by:
Michael Brüning <michael.bruning@qt.io> (cherry picked from commit f1003c50 ) Reviewed-by:
Liang Qi <liang.qi@qt.io>
-
- Dec 02, 2017
-
-
Allan Sandfeld Jensen authored
Set the viewport related preferences together. Task-number: QTWB-2 Task-number: QTBUG-57206 Change-Id: Ib06bf0159d0e0d77d963f8fa3752b668e4795f8b Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-
- Nov 29, 2017
-
-
Jüri Valdmann authored
In RenderWidgetHostViewQt::RenderWidgetHostViewQt we first call m_host->SetView(this) and then initialize the m_beginFrameSource member. However, since Chromium 55, m_host->SetView(this) ends up calling RenderWidgetHostViewQt::SetNeedsBeginFrames which already needs the m_beginFrameSource member. Fix by initializing m_beginFrameSource before calling m_host->SetView(this). Task-number: QTBUG-64560 Change-Id: Idda188977d0eec0656297fb4e3f3b3d2302f5eba Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Allan Sandfeld Jensen authored
The context menu does not like when we delete current widget while handling the context menu actions. Change-Id: I18dc9d19ae2a669c97c9d4bc833950fcdc0204b0 Reviewed-by:
Michael Brüning <michael.bruning@qt.io>
-
- Nov 24, 2017
-
-
Szabolcs David authored
Fix pointerType of the currently supported (mouse and touch) events. Support of pen and eraser types is coming with QTBUG-62975. Backport of 5.10 fix: 64ad0e8b Task-number: QTBUG-63266 Task-number: QTBUG-64436 Change-Id: Ief32b9680ab5acfb15537aba74c2bcdd6f51c978 Reviewed-by:
Viktor Engelmann <viktor.engelmann@qt.io> Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Nov 15, 2017
-
-
Michal Klocek authored
This recommits d4c621f6 and fixes the issue that on some platforms "eglGetProcAddress" call was not resolved. On some platforms libGLESv2 does not link to libEGL and eglGetProcAddress is resolved in qpa plugin, therefore use it as fallback. Task-number: QTBUG-63341 Task-number: QTBUG-57761 Change-Id: I14f0853a1b92f8f2a9ae7e40f16ce80ab55db331 Reviewed-by:
Viktor Engelmann <viktor.engelmann@qt.io>
-
- Nov 14, 2017
-
-
Allan Sandfeld Jensen authored
Change-Id: Iceb6449776de31c9a2716ed83377ad432f2992b0
-
- Nov 12, 2017
-
-
Alexandru Croitor authored
Change-Id: I5ab44cf691c4a0fa4e7e96a8fe957dc849dc6f19 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-