Change-Id: I978f70545484060218f5243c74978c85bc603c16
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

tst_QWebEnginePage::comboBoxPopupPositionAfterMove():
Fix moving view by changing coordinates according to the old view
position instead of the screen position.

tst_QWebEnginePage::comboBoxPopupPositionAfterChildMove():
Fix resizing spacer widget to change position of view properly.

Task-number: QTBUG-55158
Change-Id: I62ebb06ee3f9dadd80888eae05d037e7129bcd69
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

Task-number: QTBUG-63346
Change-Id: Ie33cea29ca4e274070f3fa52aef499f02a080108
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

Change-Id: Ib210bbf873493cb8f19d99a4e4fb0cbdb3769312
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>

Change-Id: I1dd136df7004b11e2f38a2ec4e82a6fa81627479

Move the client certificate store from being global to being tied
to individual profiles.

Change-Id: Ib21ae14c501b7d0612b84ae7535120291aeeada2
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>

Uses the value in QMAKE_MAC_SDK_PATH that Qt also uses as an isysroot
parameter.

Updates Chromium:
3fe203d43c Soften check for single thread only if layer1 or layer2 sandbox
0aae24c287 Add isysroot parameter for macOS to build gn with the right toolchain

Change-Id: I0315a054e066ec5743235347d7e96ac8b2c05c3b
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>

Currently users might forget to delete webcontent client before
profile adapter. This might be nasty if users are not aware of default
profile. Instead of asserting badly in chromium, clean up and release
chromium resources.

This avoids the crash, but might leak memory if users never deletes
page.

Task-number: QTBUG-74021
Change-Id: I66f466f169d12f7ee08866d505260dca47800bb0
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

Issue takes place when QQmlApplicationEngine is a child of qApp.
In case WebEngineContext gets destructed do not try to get default
profile, which is anyway already gone.

Task-number: QTBUG-74116
Change-Id: I24ea87baf677360a420d444b4c964feb722ab317
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

Adapt DownloadManagerDelegateQt::m_currentId to
https://chromium-review.googlesource.com/1144311



Update Chromium:
09516a434b [Backport] Allow DownloadManagerImpl to get InProgressDownloadManager from DownloadManagerService
b3edbf2a84 [Backport] Make DownloadManagerImpl to generate download IDs for in-progress DB

Task-number: QTBUG-70702
Change-Id: I1224643398a2084fcd5d70d2c04b105ed69c1f3d
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

Clean up tryGL check and add missing check for platform
capability so webengine tests can run on arm in ci.

Note this change only fixes webengine with offscreen plugin
wihtout xlib support, which is the case for coin ci.

Task-number: QTBUG-63346
Change-Id: I66fe6457f98815dad0dcd02df4500dc0ff752958
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>

Change-Id: I423ab09061b0fb1963953438e6e6b09b2602254f

Get rid of copy constructors for QObjects by making the elements objects
on the heap.

Change-Id: Ic9a214f01b39feb824b99d17d17fd342d431cd97
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>

Based on review feedback

Change-Id: Ide40d4fd563ea682eaa2cc457d857445adea85cd
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>

Fixes: QTBUG-74070
Change-Id: Iad514671a588c0a3e0405dd0141ef54320ae8c86
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>

This is more descriptive / easier to search for. It also makes sure the feature
list is again alphabetically sorted.

Change-Id: Ib5276e06b64f01a8d6b92067d4a74274a9555636
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>

Don't access nullpointer.

Also don't print developer warnings to end-users.

Change-Id: I273101dd581a335464ff2dbae5095bc99e455649
Reviewed-by: Michal Klocek <michal.klocek@qt.io>

Status bubble is always visible in the lower left corner.

Change-Id: I334246d65261b8c762aafb7d276122f63fe3a8ba
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

If the users manipulate the API from the UI, we need to read from the
UI thread as well.

Change-Id: I8af787a357954cff4fbdd94bcf27b880fb6aecb4
Reviewed-by: Michal Klocek <michal.klocek@qt.io>

Installing an event filter on QApplication which uses dynamic_cast will crash
the application since QtWebEngine is sending QTimerEvents to classes without
RTTI information.

Fix by

  1. Moving the QObject part of MessagePumpForUIQt into api/ as a private class.
  2. Using QTimer directly in WebEngineSettings, without subclassing.

Fixes: QTBUG-73833
Change-Id: Ida73006a4fef76637c964f8f05468adcc4a190ce
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

Store the icon type in a bitfield because the same icon URL might be
used for various types on same page. This way webengine won't ignore to
download a default icon what is also set as a touch icon when touch
icons are disabled.

Moreover, do not store the icon types from the previous page because
a subsequent page might use the same icon URL but with different type.
With this change the type of the cached icons are updated after each
page load.

Fixes: QTBUG-70081
Change-Id: I8031a740b07b0c6a8e5759a994f386b13ce87be2
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

This is clearer than 'null string', and actually also what the code checks for.

Change-Id: I856de48016b609cb7a8be1286f8be51ad765abd6
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>

Task-number: QTBUG-73484
Change-Id: I9e8fb525e7dc77b46cff654b9c4b7a52b76cd45d
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

[ChangeLog] Introduces a setting to control if the internal PDF viewer
is enabled. By default, PDF documents will now be opened in the viewer
instead of being downloaded.

Change-Id: I78b3b3702ae3be3da58c9635720ba861db3de661
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>

Change-Id: I41bb4f924b9091b550354065211672e31088d1cb
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>

Make sure all \brief descriptions start with an upper-case letter and end with a .

Also start descriptions of \class with the name of the class or struct.

Change-Id: Ifd2656201f9c1dff092085508a5423ce516e2d3f
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>

Explain what happens when the HTML has no proper <title> defined and clarify the
meaning of 'by default': it refers to the state before load()/setUrl()/etc.

Fixes: QTBUG-71799
Change-Id: Ib2669007573b3ea53e205d9228237bae392f6f78
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>

    Makefile:530: warning: overriding recipe for target '.rcc/qrc_tst_qwebengineclientcertificatestore.cpp'
    Makefile:522: warning: ignoring old recipe for target '.rcc/qrc_tst_qwebengineclientcertificatestore.cpp'

The resource file tst_qwebengineclientcertificatestore.qrc is already
automatically added to RESOURCES by tests.pri, no need to add it again.

Change-Id: Idfbde5da06337c5e436734c6a88651c153223bfc
Reviewed-by: Kai Koehne <kai.koehne@qt.io>

Change-Id: I3728a4d0bb41412cd5059a63633ad383b2a378ea
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>

Change-Id: I6a5ff72c91cb1b173ca140efe3d4c95036f945eb
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

qmake does not have cross specs archiver definition,
so do not pass it.

Updates Chromium:

29a45e8b7f Fix not working ar on windows
c2a58ec0a9 Fix builds with no xrandr
76b0b85ab0 Disable download and print buttons in PDF viewer
fa79a21c87 Fix extensions build for Windows on 71-based
6c56c89f1a Bypass CHECK for uninitialized resources when destroying plugin host

Change-Id: I45eb7ab7fb3d9e8d9346559fdd7607bbac83675b
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

Add sth like 'NINJAJOBS=-j20 make'. Helps to quickly investigate
icecc issue without need to do qmake_all.

Change-Id: I7438e9cd1a2b15bcbc1a4790bbc4d6596c5c7abd
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

After change cfe53bce

, the 'minimal' example isn't that minimal anymore.
Rather copy the few lines, like we already do for the widget example.

Change-Id: I9dd818738edb8d229f54ff24822d4c1723376ccc
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>

Currently selectionChanged is emitted from a Chromium task, meaning our
MessagePump is blocked and, even with a nested QEventLoop, it's not possible to
for Chromium code to make any progress during the handling of this signal.

Fixes: QTBUG-73876
Change-Id: I45135238cffa81fb0db74ddfd53037c7f1b94348
Reviewed-by: Michal Klocek <michal.klocek@qt.io>

Change-Id: Ib8fdfdd21c064f31acfcf8ce2cf840463d10c07e
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

The last of the security fixes from Chrome 72

Changes:
493fab1afff5 [Backport] Fix for security issue 895970

Fixes: QTBUG-73417
Change-Id: If6a4f6f5773c99db3498e3b178cce39e36c85e79
Reviewed-by: Michael Brüning <michael.bruning@qt.io>

Change-Id: I660e890b4630fba2c6828571cac99a529f24be50

In the Widgets API, download items are children of the profile and are
destroyed when the parent profile destroys its children. The download
item's destructor can therefore not access the profile, as it would
cause a heap-use-after-free crashes. On quick side turn ongoing downloads
cleanup to match widgets one.

Fixes: QTBUG-73839
Change-Id: Iabb379e91187e3e68ebcd4693fec35883b72b1f2
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>