- Nov 06, 2019
-
-
Allan Sandfeld Jensen authored
Expand many more timeouts as loading basic test cases can now take many seconds. Task-number: QTBUG-79290 Change-Id: I749fe50525919b24a4a3fcba905745b6d6648121 Reviewed-by:
Kirill Burtsev <kirill.burtsev@qt.io>
-
- Nov 05, 2019
-
-
Tamas Zakor authored
Implements suggestion from 5.14 API review: - Replace QT_DEPRECATED with QT_DEPRECATED_SINCE and QT_DEPRECATED_VERSION_X Change-Id: I4d0bf8a2b535c44b5749cbd3bbab7e305bd137c6 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Nov 04, 2019
-
-
Allan Sandfeld Jensen authored
Cleanup page between tests, increase load timeout and switch to QVERIFY_TRY to be told of timeout overruns. Fixes: QTBUG-79719 Change-Id: Ic246a5b0926c3e8b6c0f90f5ff21a33fa262c046 Reviewed-by:
Jüri Valdmann <juri.valdmann@qt.io>
-
Allan Sandfeld Jensen authored
Picking suggested changes for a clang-format run. Change-Id: I1a803b0c0bbf305b3e0861fa42b47ee404b4b255 Reviewed-by:
Michael Brüning <michael.bruning@qt.io>
-
- Oct 30, 2019
-
-
Allan Sandfeld Jensen authored
Change-Id: I6ab2e949cb2fa3b2db55a1654d42667db6257eab
-
Allan Sandfeld Jensen authored
Fixes: QTBUG-79434 Change-Id: I7ae77a6ff50afe76ad3b8e199b5a8fb793ad65d8 Reviewed-by:
Michael Brüning <michael.bruning@qt.io>
-
Jüri Valdmann authored
Fix all warnings save for -Wdeprecated-declarations in tests. Warnings from GCC 9.2.0: src/core/renderer/extensions/resource_request_policy_qt.cpp:157:23: warning: variable 'resource_root_relative_path' set but not used [-Wunused-but-set-variable] src/core/chromium_overrides.cpp:121:21: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move] src/core/render_widget_host_view_qt.cpp:540:12: warning: enumeration value 'kNull' not handled in switch [-Wswitch] warning: enumeration value 'kMiddlePanningVertical' not handled in switch [-Wswitch] warning: enumeration value 'kMiddlePanningHorizontal' not handled in switch [-Wswitch] warning: enumeration value 'kDndNone' not handled in switch [-Wswitch] warning: enumeration value 'kDndMove' not handled in switch [-Wswitch] warning: enumeration value 'kDndCopy' not handled in switch [-Wswitch] warning: enumeration value 'kDndLink' not handled in switch [-Wswitch] warning: enumeration value 'kMaxValue' not handled in switch [-Wswitch] src/core/type_conversion.cpp:57:12: warning: enumeration value ‘kRGBA_F16Norm_SkColorType’ not handled in switch [-Wswitch] src/core/api/qtbug-60565.cpp:83:6: warning: 'void __ShimCppDeleteArrayNoThrow(void*, const std::nothrow_t&)' alias between functions of incompatible types 'void(void*, const std::nothrow_t&) noexcept' and 'void(void*)' [-Wattribute-alias=] src/core/api/qtbug-60565.cpp:79:6: warning: 'void __ShimCppDeleteNoThrow(void*, const std::nothrow_t&)' alias between functions of incompatible types 'void(void*, const std::nothrow_t&) noexcept' and 'void(void*)' [-Wattribute-alias=] src/core/api/qtbug-60565.cpp:75:6: warning: 'void __ShimCppNewArrayNoThrow(size_t, const std::nothrow_t&)' alias between functions of incompatible types 'void(size_t, const std::nothrow_t&) noexcept' {aka 'void(long unsigned int, const std::nothrow_t&) noexcept'} and 'void*(size_t)' {aka 'void*(long unsigned int)'} [-Wattribute-alias=] src/core/api/qtbug-60565.cpp:71:6: warning: 'void __ShimCppNewNoThrow(size_t, const std::nothrow_t&)' alias between functions of incompatible types 'void(size_t, const std::nothrow_t&) noexcept' {aka 'void(long unsigned int, const std::nothrow_t&) noexcept'} and 'void*(size_t)' {aka 'void*(long unsigned int)'} [-Wattribute-alias=] Warnings from Clang 9.0.1: src/core/renderer/extensions/renderer_permissions_policy_delegate_qt.h:61:29: warning: private field 'm_dispatcher' is not used [-Wunused-private-field] src/core/web_event_factory.cpp:1296:5: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] src/core/compositor/compositor_resource_fence.h:55:81: warning: extra ';' after member function definition [-Wextra-semi] src/core/renderer/render_frame_observer_qt.h:81:10: warning: 'ReadyToCommitNavigation' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] src/core/extensions/mime_handler_view_guest_delegate_qt.h:69:27: warning: private field 'guest_' is not used [-Wunused-private-field] src/core/chromium_overrides.cpp:121:12: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move] src/core/chromium_overrides.cpp:145:64: warning: missing field 'set_up_command_line' initializer [-Wmissing-field-initializers] src/core/chromium_overrides.cpp:146:55: warning: missing field 'set_up_command_line' initializer [-Wmissing-field-initializers] src/core/render_widget_host_view_qt.cpp:540:13: warning: 7 enumeration values not handled in switch: 'kNull', 'kMiddlePanningVertical', 'kMiddlePanningHorizontal'... [-Wswitch] src/core/compositor/stream_video_node.cpp:50:18: warning: 'updateState' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] src/core/compositor/stream_video_node.cpp:103:18: warning: 'initialize' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] src/core/type_conversion.cpp:57:13: warning: enumeration value 'kRGBA_F16Norm_SkColorType' not handled in switch [-Wswitch] src/core/renderer_host/web_channel_ipc_transport_host.cpp:59:60: warning: extra ';' outside of a function is incompatible with C++98 [-Wc++98-compat-extra-semi] tests/auto/widgets/loadsignals/tst_loadsignals.cpp:237:10: warning: lambda capture 'this' is not used [-Wunused-lambda-capture] tests/auto/widgets/qwebenginedownloaditem/tst_qwebenginedownloaditem.cpp:1112:62: warning: lambda capture 'item' is not used [-Wunused-lambda-capture] tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp:1534:55: warning: lambda capture 'this' is not used [-Wunused-lambda-capture] Change-Id: I374be0d4e58accc0a00a2596a560dd6103a98994 Reviewed-by:
Michal Klocek <michal.klocek@qt.io> Reviewed-by:
Michael Brüning <michael.bruning@qt.io>
-
Jüri Valdmann authored
A regression in 5.10 has resulted in the web events generated for autorepeating keys not conforming to the spec. Restore the correct behavior from 5.9. Fixes: QTBUG-77208 Change-Id: Ia2f07fd4a8ee78c4599b36aceb235c245a49d566 Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-
- Oct 28, 2019
-
-
Allan Sandfeld Jensen authored
Change-Id: I5c95819f139bb0995475324bd33dab478802db59
-
- Oct 25, 2019
-
-
Allan Sandfeld Jensen authored
Chromium now separates normal EGL and ANGLE OpenGL targets. Change-Id: I59555c856a6d9862dabe531dcdb53f50311b37c2 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Oct 24, 2019
-
-
Jüri Valdmann authored
Change-Id: Iab2f1735ea3ef73e77e0c37d263c0771a4ffb336 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Kai Koehne authored
Change-Id: I44dd06e94f116a7b580c4530aaa3d142a79b196d Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Allan Sandfeld Jensen authored
This makes the code cleaner and also valid with network-service. Change-Id: I9a26f33c4a26784dc62269e386c0ae271a5c1a05 Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-
- Oct 23, 2019
-
-
Michael Brüning authored
Pulls in the following changes: cd435b32a24 Fix crash on exit on Windows 3a617f46cd9 FIXUP: Bring enable_webrtc back 34662922afe Convert asserts to logs and returns in the PpapiHost 27947d92157 Fix compilation with system ICU e49a67d250a Disable long presentation time DCHECK e9b4b34de81 Remove broken symlinks 134f953c5b4 Apply workarounds to build extensions with gcc 5.3.1 on 77-based c212ffca5c7 Adapt DrawQuad::ShouldDrawWithBlending() to work with both compositors 6e50fb5037b Fixup rtc_use_x11 88a931558e2 FIXUP: Apply workarounds to build extensions with gcc 5.3.1 on 77-based Change-Id: I2bab0f1d3fc2c8a85fe9f4d3ebf47d63024b1a6c Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Allan Sandfeld Jensen authored
Now we need to pass 'true' as argument to get our special behavior. Change-Id: Ifdf5eb71083441350d5ca4c3971d8930cb724d7c Fixes: QTBUG-78762 Reviewed-by:
Jüri Valdmann <juri.valdmann@qt.io>
-
Kirill Burtsev authored
Set it according to V8_MINIMUM_ICU_VERSION define. Change-Id: If41bb7067570bfc825a214f92883bd0e0caca681 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Jüri Valdmann authored
Previously cross-origin XMLHttpRequests could only be made to the builtin CORS-enabled schemes, http, https, data, and chrome. Now we also support extending this set with new custom schemes using the CorsEnabled flag. Fixes: QTBUG-79322 Change-Id: I8628aad2be62013e32708308797712de82ff185b Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Antti Kokko authored
Change-Id: I623b33e2b3c4bb6efd6cf9fd105266637dcb0e3b Reviewed-by:
Leena Miettinen <riitta-leena.miettinen@qt.io>
-
Kirill Burtsev authored
On destroy profile level interceptor is cleaned through QPointer in ProfileAdapter but not in ProfileIOData where it is stored as a raw pointer and used by NetworkDelegateQt. Track 'destroyed' signal and clean it from ProfileIOData, which resolves these issues after interceptor is deleted without explicitly being reset in profile: - for deprecated 'setRequestInterceptor': one of possible access violation in NetworkDelegateQt::OnBeforeURLRequest - for setUrlRequestInterceptor: sending URLRequestNotification for every url request after interceptor is deleted Fixes: QTBUG-79156 Change-Id: Ie2dd3f0909bc45748278c5f97c5c2701742591b5 Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-
Allan Sandfeld Jensen authored
Changes: b5d06a458283 [Backport] Security issue 946978 [1/2] 4f553e3a0c62 [Backport] Security issue 946978 [2/2] 32d77d99be3f [Backport] CVE-2019-13674 2a45953d844a [Backport] CVE-2019-13675 2708f4fe1f1a [Backport] Plumb initiating origin info to download stack. 1d21cbce407f [Backport] CVE-2019-13678/CVE-2019-13681 0da18c7f04e3 [Backport] Security issue 960354 4e50fd02436d [Backport] Security issue 973628 9e3becc64121 [Backport] Security issue 979373 729e9b30bbf2 [Backport] Security issue 981459 28150e5eb962 [Backport] Security issue 981597 843d70ac87de [Backport] Security issue 971904 Fixes: QTBUG-79193 Change-Id: Ic90455446f79500d5971a975e2a04344f65238ac Reviewed-by:
Michael Brüning <michael.bruning@qt.io>
-
Allan Sandfeld Jensen authored
Bumb up timeouts to even more higher levels to accommodate even slower CI instances. Task-number: QTBUG-79290 Change-Id: I33a4660165f72837273c3089092687a8962c83ba Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-
Allan Sandfeld Jensen authored
Some code only checks the http content type and not the job mimetype. Change-Id: I7a2b2f5d30c2f349f2570f0422ce415eebd0f644 Fixes: QTBUG-79319 Reviewed-by:
Jüri Valdmann <juri.valdmann@qt.io>
-
- Oct 22, 2019
-
-
Allan Sandfeld Jensen authored
Conflicts: examples/webengine/minimal/main.cpp src/3rdparty src/core/net/url_request_custom_job.cpp tests/auto/widgets/qwebengineprofile/tst_qwebengineprofile.cpp Change-Id: I33994024a4be5ed787800c5718a0a443b970c36d Reviewed-by:
Jüri Valdmann <juri.valdmann@qt.io>
-
- Oct 21, 2019
-
-
Jüri Valdmann authored
Change-Id: I92d84285f7b5dcfe4178b2ed393f192c161c57c7 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Kai Koehne authored
Task-number: QTBUG-78690 Change-Id: Ieeb9ffc0873b57a2642293d042ae60dd1382fdda Reviewed-by:
Kai Koehne <kai.koehne@qt.io> Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Kai Koehne authored
This makes reviewing API etc easier. Change-Id: Ib6cfa74cb130cf1085d6af24eaaa0b9cf403889b Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Allan Sandfeld Jensen authored
Set Blink-settings based on Chromium theme settings to match Chrome defaults. Change-Id: I02975c319644583166ed3c5a0eae02975d7b14f1 Fixes: QTBUG-79347 Reviewed-by:
Jüri Valdmann <juri.valdmann@qt.io>
-
- Oct 19, 2019
-
-
Peter Varga authored
Implements suggestions from 5.14 API review: - Rename activeMatchOrdinal to activeMatch - Extend documentation - Change QML import version number to 1.10 Task-number: QTBUG-77839 Change-Id: I5eae659cfb5355af8d0c878d3b5f00654c9d6d13 Reviewed-by:
Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Oct 18, 2019
-
-
Michael Bruning authored
This removes the special handling for the lower GCC versions that we support on linux. This will make the extensions and the PDF viewer available on the pre-built linux packages. Change-Id: I7b79c82f8e2596e2401e05f81041d736486d1c7d Fixes: QTBUG-76329 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Oct 17, 2019
-
-
Kirill Burtsev authored
Address API review and make the name to be consistent with other methods like localCertificateChain and peerCertificateChain of QSslCertificate Change-Id: I4f115846965d31ea9a20df3b7a27c6c041c52768 Reviewed-by:
Michael Brüning <michael.bruning@qt.io>
-
Tamas Zakor authored
Assertion fail occurs when the destruction order of the windows is not correct. This happens only in this test and can not be reproduced manually. Destroy popup window before destroying the main window. Change-Id: Iea00df25c200e1b8aff9ce08ef73a411e549fcab Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Kai Koehne authored
New QML API in Qt 5.14 should be made available under import QtWebEngine 1.10 Change-Id: Ia421755eaa77f283d7a23b4b2b3b3ea1a491714d Reviewed-by:
Michael Brüning <michael.bruning@qt.io> Reviewed-by:
Jüri Valdmann <juri.valdmann@qt.io>
-
Allan Sandfeld Jensen authored
Changes: 01b3f792f17b [Backport] CVE-2019-13659 d0e61ebba346 [Backport] CVE-2019-13694 9312eb97bf60 [Backport] Security issue 986727 [1/2] 66c739040bba [Backport] Security issue 986727 [2/2] b1ce3367b489 [Backport] CVE-2019-13660 ade14af90b01 [Backport] CVE-2019-13633 [1/2] 5f5f67b3a1f5 [Backport] CVE-2019-13664 6ddab05a4c71 [Backport] Security issue 990234 e8ba421d30c9 [Backport] CVE-2019-13663 [2/2] 1f64c1f27840 [Backport] CVE-2019-13665 8635cf233cdf [Backport] CVE-2019-13668 691467ccbb87 [Backport] CVE-2019-13673 fe065266295e [Backport] Security issue 946351 e989f4cb8907 [Backport] Security issue 964938 6114514c9e76 [Backport] Security issue 974354 [1/2] 858447a76544 [Backport] Security issue 974354 [2/2] 3d7a96629b79 Convert asserts to logs and returns in the PpapiHost a42666a17663 Apply workarounds to build extensions with gcc 5.3.1 18d4c6e82503 Revert "[Backport] CVE-2019-13668" Task-number: QTBUG-79193 Change-Id: I2b70a4343fd37321e0c10e574e515e42930ada10 Reviewed-by:
Michael Brüning <michael.bruning@qt.io>
-
Jüri Valdmann authored
The MEDIA_DISPLAY_VIDEO_CAPTURE stream type is handled incorrectly by MediaCaptureDevicesDispatcher causing a crash when an unexpected type of media device is returned to Chromium. This patch only fixes the crash, screen sharing is nonetheless not properly supported by WebEngine due to limitations of the public API which does not allow selecting between screens, not to mention windows or tabs. On Linux WebRTC's ScreenCapturer is not even built since it depends on use_x11 being set in GN. Fixes: QTBUG-78016 Change-Id: I7fa49febaba1be94bdb6c31265dfc24ee809d635 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by:
Qt CI Bot <qt_ci_bot@qt-project.org>
-
- Oct 16, 2019
-
-
Szabolcs David authored
toTime() conversion function was incorrect and this resulted inaccurate timestamps when using the geolocation feature. Change-Id: I4d536a3a99bb630c9304e91f06b77b9035b0ffc6 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Allan Sandfeld Jensen authored
Our surface id might have been invalidated, so we need to generate a new one. And DelegatedFrameHost::WasShown needs to be called after RenderWidgetHostImpl::WasShown which cancels the eviction. Change-Id: I5761d47b11754a77e40ebde7fc5ed2e64f372613 Fixes: QTBUG-79021 Reviewed-by:
Jüri Valdmann <juri.valdmann@qt.io>
-
Michal Klocek authored
There some issue with running glib event message pump, due to coming release just make sure glib is disabled. Change-Id: Ibe7b89ddfbcd57dbb41cfbc5d6a8ad1c69be39cb Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Oct 15, 2019
-
-
Allan Sandfeld Jensen authored
Changes: 6a5dc3af3537 [Backport] Reintroduce glib message event loop 1/3 580ffe2cb750 [Backport] Reintroduce glib event loop 2/3 9ae8ddaeea11 Reintroduce glib event loop 3/3 1f07ca687b1a [Backport] CVE-2019-5870 00d9e1e3be09 [Backport] CVE-2019-5872 d627df149baa [Backport] CVE-2019-5875 2d9ed8b1aaa6 [Backport] CVE-2019-5876 bebd1df6d51d [Backport] CVE-2019-13691 1c7141ad185b [Backport] CVE-2019-13692 f0e6f7f8a392 [Backport] CVE-2019-13688 495b2ebcd9d3 [Backport] CVE-2019-13687 cc18c848e174 [Backport] CVE-2019-13693 b41d57627c00 [Backport] CVE-2019-13695 c88d2026cc60 [Backport] CVE-2019-13697 Task-number: QTBUG-79193 Change-Id: I1a318d573d5f95c8bad02e96ed5084a1a1ef7bf8 Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-
- Oct 14, 2019
-
-
Michal Klocek authored
On some boards we get wrong tile textures on the screen. It looks like this is some sort of a race condition or a problem with gl fencing. Add quick workaround by setting QTWEBENGINE_DISABLE_GPU_THREAD env. variable to force no in-process-gpu-thread. Change-Id: Ib397b04e039a279413c79277e25b77064b9b6854 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Frederik Gladhorn authored
Change-Id: Ic761ec9a79057f18ebea20ff2556eaac63d39d75
-