1. Nov 06, 2019
  2. Nov 05, 2019
  3. Nov 04, 2019
  4. Oct 30, 2019
    • Allan Sandfeld Jensen's avatar
      Merge branch '5.13' into 5.14 · 4cf520d6
      Allan Sandfeld Jensen authored
      Change-Id: I6ab2e949cb2fa3b2db55a1654d42667db6257eab
      4cf520d6
    • Allan Sandfeld Jensen's avatar
      Update documented Chromium version · 21f10e77
      Allan Sandfeld Jensen authored
      
      Fixes: QTBUG-79434
      Change-Id: I7ae77a6ff50afe76ad3b8e199b5a8fb793ad65d8
      Reviewed-by: default avatarMichael Brüning <michael.bruning@qt.io>
      21f10e77
    • Jüri Valdmann's avatar
      Fix all GCC and Clang warnings · 418f929e
      Jüri Valdmann authored
      
      Fix all warnings save for -Wdeprecated-declarations in tests.
      
      Warnings from GCC 9.2.0:
      
        src/core/renderer/extensions/resource_request_policy_qt.cpp:157:23:
          warning: variable 'resource_root_relative_path' set but not used
          [-Wunused-but-set-variable]
      
        src/core/chromium_overrides.cpp:121:21:
          warning: moving a local object in a return statement prevents copy elision
          [-Wpessimizing-move]
      
        src/core/render_widget_host_view_qt.cpp:540:12:
          warning: enumeration value 'kNull' not handled in switch [-Wswitch]
          warning: enumeration value 'kMiddlePanningVertical' not handled in switch
          [-Wswitch]
          warning: enumeration value 'kMiddlePanningHorizontal' not handled in switch
          [-Wswitch]
          warning: enumeration value 'kDndNone' not handled in switch [-Wswitch]
          warning: enumeration value 'kDndMove' not handled in switch [-Wswitch]
          warning: enumeration value 'kDndCopy' not handled in switch [-Wswitch]
          warning: enumeration value 'kDndLink' not handled in switch [-Wswitch]
          warning: enumeration value 'kMaxValue' not handled in switch [-Wswitch]
      
        src/core/type_conversion.cpp:57:12:
          warning: enumeration value ‘kRGBA_F16Norm_SkColorType’ not handled in switch
          [-Wswitch]
      
        src/core/api/qtbug-60565.cpp:83:6:
          warning: 'void __ShimCppDeleteArrayNoThrow(void*, const std::nothrow_t&)'
          alias between functions of incompatible types 'void(void*, const
          std::nothrow_t&) noexcept' and 'void(void*)' [-Wattribute-alias=]
        src/core/api/qtbug-60565.cpp:79:6:
          warning: 'void __ShimCppDeleteNoThrow(void*, const std::nothrow_t&)' alias
          between functions of incompatible types 'void(void*, const std::nothrow_t&)
          noexcept' and 'void(void*)' [-Wattribute-alias=]
        src/core/api/qtbug-60565.cpp:75:6:
          warning: 'void __ShimCppNewArrayNoThrow(size_t, const std::nothrow_t&)'
          alias between functions of incompatible types 'void(size_t, const
          std::nothrow_t&) noexcept' {aka 'void(long unsigned int, const
          std::nothrow_t&) noexcept'} and 'void*(size_t)' {aka 'void*(long unsigned
          int)'} [-Wattribute-alias=]
        src/core/api/qtbug-60565.cpp:71:6:
          warning: 'void __ShimCppNewNoThrow(size_t, const std::nothrow_t&)' alias
          between functions of incompatible types 'void(size_t, const std::nothrow_t&)
          noexcept' {aka 'void(long unsigned int, const std::nothrow_t&) noexcept'}
          and 'void*(size_t)' {aka 'void*(long unsigned int)'} [-Wattribute-alias=]
      
      Warnings from Clang 9.0.1:
      
        src/core/renderer/extensions/renderer_permissions_policy_delegate_qt.h:61:29:
          warning: private field 'm_dispatcher' is not used [-Wunused-private-field]
      
        src/core/web_event_factory.cpp:1296:5:
          warning: unannotated fall-through between switch labels
          [-Wimplicit-fallthrough]
      
        src/core/compositor/compositor_resource_fence.h:55:81:
          warning: extra ';' after member function definition [-Wextra-semi]
      
        src/core/renderer/render_frame_observer_qt.h:81:10:
          warning: 'ReadyToCommitNavigation' overrides a member function but is not
          marked 'override' [-Winconsistent-missing-override]
      
        src/core/extensions/mime_handler_view_guest_delegate_qt.h:69:27:
          warning: private field 'guest_' is not used [-Wunused-private-field]
      
        src/core/chromium_overrides.cpp:121:12:
          warning: moving a local object in a return statement prevents copy elision
          [-Wpessimizing-move]
        src/core/chromium_overrides.cpp:145:64:
           warning: missing field 'set_up_command_line' initializer
           [-Wmissing-field-initializers]
        src/core/chromium_overrides.cpp:146:55:
           warning: missing field 'set_up_command_line' initializer
           [-Wmissing-field-initializers]
      
        src/core/render_widget_host_view_qt.cpp:540:13:
           warning: 7 enumeration values not handled in switch: 'kNull',
           'kMiddlePanningVertical', 'kMiddlePanningHorizontal'... [-Wswitch]
      
        src/core/compositor/stream_video_node.cpp:50:18:
           warning: 'updateState' overrides a member function but is not marked
           'override' [-Winconsistent-missing-override]
        src/core/compositor/stream_video_node.cpp:103:18:
           warning: 'initialize' overrides a member function but is not marked
           'override' [-Winconsistent-missing-override]
      
        src/core/type_conversion.cpp:57:13:
           warning: enumeration value 'kRGBA_F16Norm_SkColorType' not handled in
           switch [-Wswitch]
      
        src/core/renderer_host/web_channel_ipc_transport_host.cpp:59:60:
           warning: extra ';' outside of a function is incompatible with C++98
           [-Wc++98-compat-extra-semi]
      
        tests/auto/widgets/loadsignals/tst_loadsignals.cpp:237:10:
           warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
      
        tests/auto/widgets/qwebenginedownloaditem/tst_qwebenginedownloaditem.cpp:1112:62:
           warning: lambda capture 'item' is not used [-Wunused-lambda-capture]
      
        tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp:1534:55:
           warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
      
      Change-Id: I374be0d4e58accc0a00a2596a560dd6103a98994
      Reviewed-by: default avatarMichal Klocek <michal.klocek@qt.io>
      Reviewed-by: default avatarMichael Brüning <michael.bruning@qt.io>
      418f929e
    • Jüri Valdmann's avatar
      Fix handling of autorepeating KeyRelease events · 24bb272a
      Jüri Valdmann authored
      
      A regression in 5.10 has resulted in the web events generated for autorepeating
      keys not conforming to the spec. Restore the correct behavior from 5.9.
      
      Fixes: QTBUG-77208
      Change-Id: Ia2f07fd4a8ee78c4599b36aceb235c245a49d566
      Reviewed-by: default avatarMichal Klocek <michal.klocek@qt.io>
      24bb272a
  5. Oct 28, 2019
  6. Oct 25, 2019
  7. Oct 24, 2019
  8. Oct 23, 2019
    • Michael Brüning's avatar
      Update Chromium · 696c2d3c
      Michael Brüning authored
      
      Pulls in the following changes:
      
      cd435b32a24 Fix crash on exit on Windows
      3a617f46cd9 FIXUP: Bring enable_webrtc back
      34662922afe Convert asserts to logs and returns in the PpapiHost
      27947d92157 Fix compilation with system ICU
      e49a67d250a Disable long presentation time DCHECK
      e9b4b34de81 Remove broken symlinks
      134f953c5b4 Apply workarounds to build extensions with gcc 5.3.1 on 77-based
      c212ffca5c7 Adapt DrawQuad::ShouldDrawWithBlending() to work with both compositors
      6e50fb5037b Fixup rtc_use_x11
      88a931558e2 FIXUP: Apply workarounds to build extensions with gcc 5.3.1 on 77-based
      
      Change-Id: I2bab0f1d3fc2c8a85fe9f4d3ebf47d63024b1a6c
      Reviewed-by: default avatarAllan Sandfeld Jensen <allan.jensen@qt.io>
      696c2d3c
    • Allan Sandfeld Jensen's avatar
      Adapt to change in DrawQuad::ShouldDrawWithBlending · 25ccc01a
      Allan Sandfeld Jensen authored
      
      Now we need to pass 'true' as argument to get our special behavior.
      
      Change-Id: Ifdf5eb71083441350d5ca4c3971d8930cb724d7c
      Fixes: QTBUG-78762
      Reviewed-by: default avatarJüri Valdmann <juri.valdmann@qt.io>
      25ccc01a
    • Kirill Burtsev's avatar
      Update minimum requirement for ICU version to 64 · 299494ac
      Kirill Burtsev authored
      
      Set it according to V8_MINIMUM_ICU_VERSION define.
      
      Change-Id: If41bb7067570bfc825a214f92883bd0e0caca681
      Reviewed-by: default avatarAllan Sandfeld Jensen <allan.jensen@qt.io>
      299494ac
    • Jüri Valdmann's avatar
      Test XMLHttpRequests to CorsEnabled custom schemes · 73a8a53f
      Jüri Valdmann authored
      
      Previously cross-origin XMLHttpRequests could only be made to the builtin
      CORS-enabled schemes, http, https, data, and chrome. Now we also support
      extending this set with new custom schemes using the CorsEnabled flag.
      
      Fixes: QTBUG-79322
      Change-Id: I8628aad2be62013e32708308797712de82ff185b
      Reviewed-by: default avatarAllan Sandfeld Jensen <allan.jensen@qt.io>
      73a8a53f
    • Antti Kokko's avatar
      Add changes file for Qt 5.13.2 · 556576b5
      Antti Kokko authored
      
      Change-Id: I623b33e2b3c4bb6efd6cf9fd105266637dcb0e3b
      Reviewed-by: default avatarLeena Miettinen <riitta-leena.miettinen@qt.io>
      v5.13.2
      556576b5
    • Kirill Burtsev's avatar
      Track request interceptor destroy and update profile io data accordingly · 49e660a9
      Kirill Burtsev authored
      
      On destroy profile level interceptor is cleaned through QPointer
      in ProfileAdapter but not in ProfileIOData where it is stored as
      a raw pointer and used by NetworkDelegateQt.
      
      Track 'destroyed' signal and clean it from ProfileIOData,
      which resolves these issues after interceptor is deleted
      without explicitly being reset in profile:
      
      - for deprecated 'setRequestInterceptor': one of possible
      access violation in NetworkDelegateQt::OnBeforeURLRequest
      - for setUrlRequestInterceptor: sending URLRequestNotification
      for every url request after interceptor is deleted
      
      Fixes: QTBUG-79156
      Change-Id: Ie2dd3f0909bc45748278c5f97c5c2701742591b5
      Reviewed-by: default avatarMichal Klocek <michal.klocek@qt.io>
      49e660a9
    • Allan Sandfeld Jensen's avatar
      Update Chromium · 9bba6cf6
      Allan Sandfeld Jensen authored
      
      Changes:
      b5d06a458283 [Backport] Security issue 946978 [1/2]
      4f553e3a0c62 [Backport] Security issue 946978 [2/2]
      32d77d99be3f [Backport] CVE-2019-13674
      2a45953d844a [Backport] CVE-2019-13675
      2708f4fe1f1a [Backport] Plumb initiating origin info to download stack.
      1d21cbce407f [Backport] CVE-2019-13678/CVE-2019-13681
      0da18c7f04e3 [Backport] Security issue 960354
      4e50fd02436d [Backport] Security issue 973628
      9e3becc64121 [Backport] Security issue 979373
      729e9b30bbf2 [Backport] Security issue 981459
      28150e5eb962 [Backport] Security issue 981597
      843d70ac87de [Backport] Security issue 971904
      
      Fixes: QTBUG-79193
      Change-Id: Ic90455446f79500d5971a975e2a04344f65238ac
      Reviewed-by: default avatarMichael Brüning <michael.bruning@qt.io>
      9bba6cf6
    • Allan Sandfeld Jensen's avatar
      Speculatively prepare for even slower CI · fc0dbde7
      Allan Sandfeld Jensen authored
      
      Bumb up timeouts to even more higher levels to accommodate even
      slower CI instances.
      
      Task-number: QTBUG-79290
      Change-Id: I33a4660165f72837273c3089092687a8962c83ba
      Reviewed-by: default avatarMichal Klocek <michal.klocek@qt.io>
      fc0dbde7
    • Allan Sandfeld Jensen's avatar
      Add HTTP content-type · dbbf4c11
      Allan Sandfeld Jensen authored
      
      Some code only checks the http content type and not the job mimetype.
      
      Change-Id: I7a2b2f5d30c2f349f2570f0422ce415eebd0f644
      Fixes: QTBUG-79319
      Reviewed-by: default avatarJüri Valdmann <juri.valdmann@qt.io>
      dbbf4c11
  9. Oct 22, 2019
  10. Oct 21, 2019
  11. Oct 19, 2019
  12. Oct 18, 2019
  13. Oct 17, 2019
    • Kirill Burtsev's avatar
      Rename certificate error's chain API method · 0ce522cb
      Kirill Burtsev authored
      
      Address API review and make the name to be consistent with other methods
      like localCertificateChain and peerCertificateChain of QSslCertificate
      
      Change-Id: I4f115846965d31ea9a20df3b7a27c6c041c52768
      Reviewed-by: default avatarMichael Brüning <michael.bruning@qt.io>
      0ce522cb
    • Tamas Zakor's avatar
      Fix tst_qwebenginepage::comboBoxPopupPositionAfterMove() auto test · 615ea60a
      Tamas Zakor authored
      
      Assertion fail occurs when the destruction order of the windows
      is not correct. This happens only in this test and can not be
      reproduced manually.
      
      Destroy popup window before destroying the main window.
      
      Change-Id: Iea00df25c200e1b8aff9ce08ef73a411e549fcab
      Reviewed-by: default avatarAllan Sandfeld Jensen <allan.jensen@qt.io>
      615ea60a
    • Kai Koehne's avatar
      QML: Fix import to 1.10 · f4fa4d3d
      Kai Koehne authored
      
      New QML API in Qt 5.14 should be made available under
      
        import QtWebEngine 1.10
      
      Change-Id: Ia421755eaa77f283d7a23b4b2b3b3ea1a491714d
      Reviewed-by: default avatarMichael Brüning <michael.bruning@qt.io>
      Reviewed-by: default avatarJüri Valdmann <juri.valdmann@qt.io>
      f4fa4d3d
    • Allan Sandfeld Jensen's avatar
      Update Chromium · 808645a7
      Allan Sandfeld Jensen authored
      
      Changes:
      01b3f792f17b [Backport] CVE-2019-13659
      d0e61ebba346 [Backport] CVE-2019-13694
      9312eb97bf60 [Backport] Security issue 986727 [1/2]
      66c739040bba [Backport] Security issue 986727 [2/2]
      b1ce3367b489 [Backport] CVE-2019-13660
      ade14af90b01 [Backport] CVE-2019-13633 [1/2]
      5f5f67b3a1f5 [Backport] CVE-2019-13664
      6ddab05a4c71 [Backport] Security issue 990234
      e8ba421d30c9 [Backport] CVE-2019-13663 [2/2]
      1f64c1f27840 [Backport] CVE-2019-13665
      8635cf233cdf [Backport] CVE-2019-13668
      691467ccbb87 [Backport] CVE-2019-13673
      fe065266295e [Backport] Security issue 946351
      e989f4cb8907 [Backport] Security issue 964938
      6114514c9e76 [Backport] Security issue 974354 [1/2]
      858447a76544 [Backport] Security issue 974354 [2/2]
      3d7a96629b79 Convert asserts to logs and returns in the PpapiHost
      a42666a17663 Apply workarounds to build extensions with gcc 5.3.1
      18d4c6e82503 Revert "[Backport] CVE-2019-13668"
      
      Task-number: QTBUG-79193
      Change-Id: I2b70a4343fd37321e0c10e574e515e42930ada10
      Reviewed-by: default avatarMichael Brüning <michael.bruning@qt.io>
      808645a7
    • Jüri Valdmann's avatar
      Fix getDisplayMedia crash · 0d8e9d61
      Jüri Valdmann authored
      
      The MEDIA_DISPLAY_VIDEO_CAPTURE stream type is handled incorrectly by
      MediaCaptureDevicesDispatcher causing a crash when an unexpected type of media
      device is returned to Chromium.
      
      This patch only fixes the crash, screen sharing is nonetheless not properly
      supported by WebEngine due to limitations of the public API which does not allow
      selecting between screens, not to mention windows or tabs.
      
      On Linux WebRTC's ScreenCapturer is not even built since it depends on use_x11
      being set in GN.
      
      Fixes: QTBUG-78016
      Change-Id: I7fa49febaba1be94bdb6c31265dfc24ee809d635
      Reviewed-by: default avatarAllan Sandfeld Jensen <allan.jensen@qt.io>
      Reviewed-by: default avatarQt CI Bot <qt_ci_bot@qt-project.org>
      0d8e9d61
  14. Oct 16, 2019
  15. Oct 15, 2019
    • Allan Sandfeld Jensen's avatar
      Update Chromium · 4a141b14
      Allan Sandfeld Jensen authored
      
      Changes:
      6a5dc3af3537 [Backport] Reintroduce glib message event loop 1/3
      580ffe2cb750 [Backport] Reintroduce glib event loop 2/3
      9ae8ddaeea11 Reintroduce glib event loop 3/3
      1f07ca687b1a [Backport] CVE-2019-5870
      00d9e1e3be09 [Backport] CVE-2019-5872
      d627df149baa [Backport] CVE-2019-5875
      2d9ed8b1aaa6 [Backport] CVE-2019-5876
      bebd1df6d51d [Backport] CVE-2019-13691
      1c7141ad185b [Backport] CVE-2019-13692
      f0e6f7f8a392 [Backport] CVE-2019-13688
      495b2ebcd9d3 [Backport] CVE-2019-13687
      cc18c848e174 [Backport] CVE-2019-13693
      b41d57627c00 [Backport] CVE-2019-13695
      c88d2026cc60 [Backport] CVE-2019-13697
      
      Task-number: QTBUG-79193
      Change-Id: I1a318d573d5f95c8bad02e96ed5084a1a1ef7bf8
      Reviewed-by: default avatarMichal Klocek <michal.klocek@qt.io>
      4a141b14
  16. Oct 14, 2019