1. 28 Nov, 2016 - 1 commit
  2. 06 Nov, 2016 - 1 commit
  3. 02 Nov, 2016 - 1 commit
    • Albert Astals Cid's avatar
      Fix memory leak · 6b6f7db3
      Albert Astals Cid authored
      
      We can't have the ExpressionVariableReference/TemplateParameterReference
      holding a Ptr of VariableDeclaration because the VariableDeclaration
      holds a Ptr of them (in the references member) so they were referencing
      eachother and the reference count never reaches 0.
      
      Task-number: QTBUG-32745
      Change-Id: I4cda6d9eccad123984f4ad35db3e56da01d4d5b1
      Reviewed-by: default avatarErik Verbruggen <erik.verbruggen@qt.io>
      6b6f7db3
  4. 05 Sep, 2016 - 1 commit
  5. 31 Jul, 2016 - 1 commit
  6. 19 Jul, 2016 - 5 commits
    • Marc Mutz's avatar
      QXmlQuery: fix smart pointer type · c0b6fbca
      Marc Mutz authored
      
      m_resourceLoader is a QExplicitlySharedPointer<DeviceResourceLoader>, and
      ResourceDelegator inherits DeviceResourceLoader, but the newly-allocated
      object was constructed into a QExplicitlySharedPointer<ResourceLoader>.
      
      Benign, but wrong. Found while trying to compile the module without
      QT_ENABLE_QEXPLICITLYSHAREDDATAPOINTER_STATICCAST.
      
      Change-Id: I6f0e7bd50488ae6db6ab6c7022503332cd8523f1
      Reviewed-by: default avatarFrederik Gladhorn <frederik.gladhorn@qt.io>
      c0b6fbca
    • Marc Mutz's avatar
      Fix type of QCommonValues::YearMonthDurationZero · 72ba369a
      Marc Mutz authored
      
      As reported by UBSan:
      
        src/corelib/tools/qshareddata.h:167:13: runtime error: downcast of address 0x0000023ce510 which does not point to an object of type 'DayTimeDuration'
        0x0000023ce510: note: object is of type 'QPatternist::YearMonthDuration'
         00 00 00 00  90 6c 52 5b 1f 2b 00 00  01 00 00 00 01 00 00 00  00 00 00 00 00 00 00 00  31 00 00 00
                      ^~~~~~~~~~~~~~~~~~~~~~~
                      vptr for 'QPatternist::YearMonthDuration'
      
      Another victim of QT_ENABLE_QEXPLICITLYSHAREDDATAPOINTER_STATICCAST...
      
      Change-Id: I121433e0d2ad8b203ccf9d9f08bd166b39502cbb
      Reviewed-by: default avatarTobias Koenig <tobias.koenig@kdab.com>
      Reviewed-by: default avatarFrederik Gladhorn <frederik.gladhorn@qt.io>
      72ba369a
    • Marc Mutz's avatar
      Correct return type of QXmlQueryPrivate::staticContext() · d75868d0
      Marc Mutz authored
      
      As reported by UBSan:
      
        qtbase/src/corelib/tools/qshareddata.h:167:13: runtime error: downcast of address 0x2ac9a801a410 which does not point to an object of type 'GenericStaticContext'
        0x2ac9a801a410: note: object is of type 'QPatternist::StaticFocusContext'
         00 00 00 00  28 95 b7 9d c9 2a 00 00  01 00 00 00 c9 2a 00 00  f0 a1 01 a8 c9 2a 00 00  70 fa 0b 02
                      ^~~~~~~~~~~~~~~~~~~~~~~
                      vptr for 'QPatternist::StaticFocusContext'
      
      I had no idea how the QExplicitlySharedDataPointer conversion
      could ever compile, until I saw that this module defines
      
         QT_ENABLE_QEXPLICITLYSHAREDDATAPOINTER_STATICCAST
      
      which is, of course, utterly broken.
      
      Change-Id: Ie392ba74438b6c75fde9fabe09f9b0e655489cd9
      Reviewed-by: default avatarTobias Koenig <tobias.koenig@kdab.com>
      Reviewed-by: default avatarFrederik Gladhorn <frederik.gladhorn@qt.io>
      d75868d0
    • Marc Mutz's avatar
      Item: replace a Q_ASSERT with a Q_STATIC_ASSERT · b4b17b20
      Marc Mutz authored
      
      Change-Id: I32927731c73b5335f2589c0754ffef2cf0d5ed3f
      Reviewed-by: default avatarTobias Koenig <tobias.koenig@kdab.com>
      Reviewed-by: default avatarFrederik Gladhorn <frederik.gladhorn@qt.io>
      b4b17b20
    • Marc Mutz's avatar
      Add some missing initialization · 03f392f8
      Marc Mutz authored
      
      As reported by UBSan:
      
        xmlpatterns/expr/qorderby_p.h:78:15: runtime error: load of value 11181584, which is not a valid value for type 'Direction'
        xmlpatterns/expr/qorderby_p.h:78:15: runtime error: load of value 32766, which is not a valid value for type 'OrderingEmptySequence'
        xmlpatterns/schema/qxsdstatemachine_p.h:66:11: runtime error: load of value 2979516404, which is not a valid value for type 'NodeName'
        xmlpatterns/schema/qxsdschemaparser.cpp:340:67: runtime error: load of value 40, which is not a valid value for type 'bool'
      
      The init values are chosen to match what zero-initialization
      would have chosen.
      
      Change-Id: Iaf69720476cfe6c117dc2c91f39801a0be8bde54
      Reviewed-by: default avatarTobias Koenig <tobias.koenig@kdab.com>
      Reviewed-by: default avatarFrederik Gladhorn <frederik.gladhorn@qt.io>
      03f392f8
  7. 12 Jul, 2016 - 1 commit
    • Marc Mutz's avatar
      Unbreak ubsan developer-build · d91d3536
      Marc Mutz authored
      
      GCC's undefined-behavior sanitizer checks that the
      declared type of the object is a base class of the
      dynamic type of the object on each access to a
      member of a class type.
      
      It therefore requires the typeinfo for these types,
      which for polymorphic types is emitted in the TU
      where the vtable is emitted, too.
      
      QtPatternist::AtomicValue is a polymorphic non-
      exported class, so this failed at link-time. Ditto
      for the other cases.
      
      Fix by autotest-exporting the classes.
      
      Also, where applicable, de-inline the dtors, so the
      vtable (and typeinfo) are pinned to one TU.
      
      Change-Id: I5c47be779a3833433a7108a79a57d61a93ab5494
      Reviewed-by: default avatarThiago Macieira <thiago.macieira@intel.com>
      d91d3536
  8. 01 Jul, 2016 - 1 commit
    • Frederik Gladhorn's avatar
      Fix -Werror=duplicated-cond · 71ca09a0
      Frederik Gladhorn authored
      
      This bit of error handling is actually not checking what was originally
      intended - doing manual pluralization of the error message.
      
      Fix it to at least compile with -Werror (gcc 6.1.1).
      
      parser/qmaintainingreader_tpl_p.h:204:26:  error: duplicated ‘if’ condition [-Werror=duplicated-cond]
      
      Change-Id: Ia81ad3c8c1393d08da0a229c4625504faf56c184
      Reviewed-by: default avatarThiago Macieira <thiago.macieira@intel.com>
      71ca09a0
  9. 17 Jun, 2016 - 1 commit
  10. 31 May, 2016 - 2 commits
  11. 24 May, 2016 - 1 commit
  12. 19 May, 2016 - 1 commit
  13. 12 May, 2016 - 1 commit
  14. 10 May, 2016 - 1 commit
  15. 06 Apr, 2016 - 1 commit
  16. 02 Mar, 2016 - 1 commit
  17. 25 Feb, 2016 - 1 commit
  18. 08 Feb, 2016 - 1 commit
  19. 28 Jan, 2016 - 1 commit
  20. 15 Jan, 2016 - 1 commit
    • Sergio Martins's avatar
      Fix QAbstractMessageHandler's docs regarding thread safety · 640b381a
      Sergio Martins authored
      
      The QMutexLocker's usage was bogus, it didn't do any locking
      because it was being created as an anonymous temporary.
      
      It's too late in the game to fix the locking. The user's virtual
      function might have it's own locking to workaround this bug and might
      re-enter Qtxmlpatterns API causing a dead-lock.
      
      So instead, make the docs consistent with the current behavior.
      
      Change-Id: I4d2bdb1431b44262583abf48f795067ed37281d5
      Reviewed-by: default avatarOlivier Goffart (Woboq GmbH) <ogoffart@woboq.com>
      640b381a
  21. 10 Dec, 2015 - 1 commit
  22. 05 Nov, 2015 - 1 commit
    • Friedemann Kleint's avatar
      Test suite: Streamline code in QPatternistSDK::DebugExpressionFactory. · ee56885f
      Friedemann Kleint authored
      
      Fix release mode compiler warnings:
      
      In member function 'virtual void QPatternistSDK::DebugExpressionFactory::processTemplateRule(const Ptr&, const Ptr&, const QXmlName&, QPatternist::ExpressionFactory::TemplateCompilationStage)':
      warning: 'title' may be used uninitialized in this function [-Wmaybe-uninitialized]
      In member function 'virtual void QPatternistSDK::DebugExpressionFactory::processNamedTemplate(const QXmlName&, const Ptr&, QPatternist::ExpressionFactory::TemplateCompilationStage)':
      warning: 'title' may be used uninitialized in this function [-Wmaybe-uninitialized]
      
      by rewriting the code to directly add to a QString.
      
      Change-Id: I23781b624e6b3fbc385d8b041a1923d49c291f51
      Reviewed-by: default avatarMitch Curtis <mitch.curtis@theqtcompany.com>
      ee56885f
  23. 28 Oct, 2015 - 1 commit
  24. 26 Oct, 2015 - 1 commit
  25. 23 Oct, 2015 - 1 commit
  26. 21 Oct, 2015 - 1 commit
  27. 08 Oct, 2015 - 2 commits
  28. 07 Oct, 2015 - 1 commit
  29. 05 Oct, 2015 - 1 commit
    • Topi Reinio's avatar
      Doc: Fix linking issues · 32d682e8
      Topi Reinio authored
      
      QXmlName has overloads for its functions, marked \internal, and
      QDoc fails to link to the public ones because it sees the
      internal ones first.
      
      As a workaround, exclude parentheses from the link - QDoc then
      uses a different code path which resolves the functions
      correctly.
      
      Change-Id: I0470cfd67c5d089ca586fd2debcb7b71c606a716
      Reviewed-by: default avatarNico Vertriest <nico.vertriest@digia.com>
      32d682e8
  30. 01 Oct, 2015 - 1 commit
    • Nico Vertriest's avatar
      Doc: Replaced \target with \keyword right after \startpage · 840c8621
      Nico Vertriest authored
      
      A \target whose purpose is to link to the top of a
      page (and not to a section within a page) works better
      as a \keyword, because \target generates a
      new html anchor which, in this case, is not tied to
      any title element on the page.
      A \keyword links to the page itself, as expected.
      
      Task-number: QTBUG-48482
      Change-Id: I0d55924f66c26f3fb23a07be1f1d57f2105c879d
      Reviewed-by: default avatarTopi Reiniö <topi.reinio@digia.com>
      840c8621
  31. 11 Sep, 2015 - 1 commit
  32. 07 Sep, 2015 - 1 commit
    • Friedemann Kleint's avatar
      OrderBy: Replace deprecated qLess by std::less. · c4fd65e4
      Friedemann Kleint authored
      
      Fix warning:
      expr\qorderby.cpp:79:7: warning: 'template<class T> class qLess' is deprecated [-Wdeprecated-declarations]
       class qLess<Item::List>
             ^
      In file included from qtbase\include\QtCore/qalgorithms.h:1:0,
                       from qtbase\include\QtCore/QtAlgorithms:1,
                       from expr\qorderby.cpp:34:
      qtbase/src/corelib/tools/qalgorithms.h:150:40: note: declared here
       class QT_DEPRECATED_X("Use std::less") qLess
                                              ^
      expr\qorderby.cpp: In member function 'virtual QAbstractXmlForwardIterator<QPatternist::Item>::Ptr QPatternist::OrderBy::evaluateSequence(const Ptr&) const':
      expr\qorderby.cpp:172:11: warning: 'template<class T> class qLess' is deprecated [-Wdeprecated-declarations]
           const qLess<Item::List> sorter(m_orderSpecs, context);
                 ^
      In file included from qtbase\include\QtCore/qalgorithms.h:1:0,
                       from qtbase\include\QtCore/QtAlgorithms:1,
                       from expr\qorderby.cpp:34:
      
      Change-Id: Ieb626eb0de96aea670433bb46a52ed780240e8d7
      Reviewed-by: default avatarBjörn Breitmeyer <bjoern.breitmeyer@kdab.com>
      c4fd65e4
  33. 03 Sep, 2015 - 1 commit
  34. 19 Aug, 2015 - 1 commit