Correct the Echo Canceller Calibrator to get a better estimate of the delay on mac and some linux.
In the ECC, a detected tone is validated only if the given tone has been played, based on its start time. This prevent from validating a frequency that is played later, leading to a a negative local delay that biaises the global delay computation. Note: this problem of false positive seems to be fixed since the correction of the frame size of the tone detector.
Remove 20% to the delay estimated by ECC, to get margin for echo detection during AEC. The margin cannot exceed 40 ms, that is the half of the window used for echo detection in AEC.
The deprecated function linphone_core_start_echo_calibration
in test_ecc.c has been replaced by linphone_core_start_echo_canceller_calibration
.
Ticket Jira https://linphone.atlassian.net/browse/SDK-116
Activity
assigned to @flore.harle
mentioned in merge request linphone-sdk!4522 (merged)
added 1 commit
- 7b5256e5 - ECC: test if a tone has really been played before the validation of the detection.
added 11 commits
-
7b5256e5...baecf09e - 9 commits from branch
master
- b7d22704 - ECC: replace deprecated function in test_ecc.c by linphone_core_start_echo_canceller_calibration
- 921cf729 - ECC: test if a tone has really been played before the validation of the detection.
-
7b5256e5...baecf09e - 9 commits from branch
requested review from @smorlat
added 6 commits
-
921cf729...13eac45d - 3 commits from branch
master
- 9cfa0c31 - ECC: replace deprecated function in test_ecc.c by linphone_core_start_echo_canceller_calibration
- a4eb126a - ECC: test if a tone has really been played before the validation of the detection.
- 2b3ce9c3 - ECC: reduce the estimated delay for Mac of 20s in order to add a margin for AEC.
Toggle commit list-
921cf729...13eac45d - 3 commits from branch
added 1 commit
- 7ac4944a - ECC: reduce the estimated delay for Mac of 20 ms in order to add a margin for AEC.
- Resolved by Flore Harlé
added 4 commits
-
9eb282ee - 1 commit from branch
master
- e64eb103 - ECC: replace deprecated function in test_ecc.c by linphone_core_start_echo_canceller_calibration
- e975118d - ECC: test if a tone has really been played before the validation of the detection.
- 62e2f497 - ECC: Reduce the estimated delay in order to add a margin for AEC, for all...
Toggle commit list-
9eb282ee - 1 commit from branch
added 4 commits
-
a0a9c1f2 - 1 commit from branch
master
- fe21055f - ECC: replace deprecated function in test_ecc.c by linphone_core_start_echo_canceller_calibration
- 32a28a20 - ECC: test if a tone has really been played before the validation of the detection.
- fca8b51a - ECC: Reduce the estimated delay in order to add a margin for AEC, for all...
Toggle commit list-
a0a9c1f2 - 1 commit from branch
added 4 commits
-
1650cc55 - 1 commit from branch
master
- 4a095f17 - ECC: replace deprecated function in test_ecc.c by linphone_core_start_echo_canceller_calibration
- ab1cae88 - ECC: test if a tone has really been played before the validation of the detection.
- ba9dc9af - ECC: Reduce the estimated delay in order to add a margin for AEC, for all...
Toggle commit list-
1650cc55 - 1 commit from branch