CMAKE_BUILD_TYPE was not propagated, then some submodules were build in their...
Review guidelines
Produced code must conform to:
- Coding style for liblinphone project
- Liblinphone API design guide for liblinphone public API addons or changes
- Software development good practice BC's guide
In addition, from a pure C++ usage, it is recommended to follow the C++ Core Guidelines.
Review comments should, whenever possible, be supported by references to relevant documents mentionned above. All comments and discussions between reviewers and developers must remain respectful and constructive. By grounding discussions in shared references, code reviews should help foster constructive debate and contribute to the collective adoption and dissemination of good practices across the team.