- 31 Oct, 2014 - 19 commits
-
-
Thiago Macieira authored
I don't know why it was an #if 0. The __has_feature has been there for a while. But, just to be sure, we check the presence of the header too. Change-Id: I36e34c9e8fd4ce55c98966d2fad246b77eb16597 Reviewed-by:
Olivier Goffart <ogoffart@woboq.com>
-
Thiago Macieira authored
The libc++ header does this: #if !__has_feature(cxx_atomic) #error <atomic> is not implemented So we can't enable the feature until the compiler reports true for that test. Change-Id: I96f1c7eea8b93d93bd721fe5a85fa987339d091f Reviewed-by:
Olivier Goffart <ogoffart@woboq.com>
-
Roland Winklmeier authored
QTestEventLoop::exitLoop() is used by QSignalSpy to stop event processing when the connected signal has been received. The design of QSignalSpy requires QTestEventLoop::exitLoop() to be thread-safe, which it wasn't. When QSignalSpy is connected to a signal in a different thread, exitLoop() was called from the thread which emitted the signal and not the one in which QTestEventLoop is running. This caused troubles when killing the internal timer. This patch adds a check in the beginning of exitLoop(). If it is called from a different thread, it will post an event into the message queue in which QTestEventLoop is running and execute it there. Change-Id: Icb8c8ff2f5344800ee6c6125b98c677c7a196c32 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Lars Knoll authored
Also fixes a compiler warning with clang Change-Id: I99beb7e099477b2b8b53af0e9fd32a7605a6c08a Reviewed-by:
Jørgen Lind <jorgen.lind@digia.com>
-
Lars Knoll authored
Loading a dock window state saved by a Qt 4.2 app is not something we need to support anymore. Change-Id: I9ee6e2c742b31114081852e7236cfc8696b9b270 Reviewed-by:
Paul Olav Tvete <paul.tvete@digia.com>
-
Thiago Macieira authored
Tested with GCC 4.9, Clang from XCode 5.1 and ICC 15 beta. Clang 3.5 (pre-release) cannot compile qtdeclarative yet with -Werror due to invalid C++ code there that calls member functions on null pointers. Change-Id: Ic2845371a1899716985bc0813dfb820fa418e207 Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Tor Arne Vestbø authored
Change-Id: If4d9c9c769b598a3194a7cd5bbe5c74e7650694b Reviewed-by:
Richard Moe Gustavsen <richard.gustavsen@digia.com> Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@digia.com>
-
Olivier Goffart authored
qtdelcarative's qquickaccessibleattached.cpp contains now some static instance of QMetaMethod. Marking the constructor as constexpr, let GCC to remove call to the constructor at load time. Change-Id: Ic5ab7db0d06caa08f15d65d3bb5f22a34a111fee Reviewed-by:
Jędrzej Nowacki <jedrzej.nowacki@digia.com>
-
Jędrzej Nowacki authored
We know that type id can't be changed, let pass this information to the compiler. Change-Id: I105b460417288b84250a954571c247608976f8f7 Reviewed-by:
Stephen Kelly <steveire@gmail.com>
-
Friedemann Kleint authored
Previously, the device was delay-created, which is a problem if its type is to be used for determinining the pan gesture type. Task-number: QTBUG-40461 Change-Id: I2dee3d7a3786a0fdf0a9b2b9e174dd121697ab44 Reviewed-by:
Shawn Rutledge <shawn.rutledge@digia.com> Reviewed-by:
Laszlo Agocs <laszlo.agocs@digia.com>
-
Allan Sandfeld Jensen authored
We shouldn't excluded all volumes under /run since some distos will mount filesystems there. Instead we should exclude all filesystems with the type "tmpfs" that /run has, and rpc_pipefs that is mounted below /run. Tmpfs" is excluded for all UNIX systems since the BSDs have a similarly named filesystem. Change-Id: I03fdac515c0bfb1b824b2e3eae1022dd699c0998 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Timur Pocheptsov authored
The patch 916dfcb8 while fixing one problem, introduced another - leaking CGImage. Change-Id: I08db6ea9fa97ae3489a0bfa1f93e0d18f3671885 Reviewed-by:
Morten Johan Sørvig <morten.sorvig@digia.com>
-
Giuseppe D'Angelo authored
Change-Id: Id7cc8cbbcd62c546055d525473f90d2bad0c144a Reviewed-by:
Laszlo Agocs <laszlo.agocs@digia.com> Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@digia.com>
-
Thiago Macieira authored
Because difference_type is 64-bit on 64-bit systems, there's a downconversion warning from MSVC and possibly other compilers when it gets passed to functions taking simply int. Task-number: QTBUG-41092 Change-Id: I46a710810f4a57b8b84c4933f419a1f1fdf6bb5a Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@digia.com> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Thiago Macieira authored
Several of the unit tests request that the peer emit more than one signal, but only handle one. The rest of the signals stay queued in the socket and will be delivered at the next test, causing it to fail often. This doesn't happen in the tests with the bus. There, we don't receive the extraneous signals due to AddMatch/ReceiveMatch on each signal individually and the synchronous nature of the emission (the signals have already been emitted by the next AddMatch and cannot match it). Task-number: QTBUG-42145 Change-Id: I743a0553074972042fca46b76db5d9e7b3209620 Reviewed-by:
Jędrzej Nowacki <jedrzej.nowacki@digia.com>
-
Thiago Macieira authored
This is a very rare occurrence: if the user is the owner of the directory, the user can chmod(2), and we already checked that the user is the owner. However, chmod(2) can still fail on read-only fs and on hardened systems. Task-number: QTBUG-41735 Change-Id: I8f8bac763bf5a6e575ed59dac55bd265e5b66271 Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com> Reviewed-by:
David Faure <david.faure@kdab.com>
-
Thiago Macieira authored
Since the current user is the owner of the dir, we'll get 0x7700 as permissions, not just 0x700. With the wrong check, we were always doing an unnecessary chmod. Task-number: QTBUG-41735 Change-Id: Ib1fc258fef4bf526baa9c71201f9b78d36f5454f Reviewed-by:
David Faure <david.faure@kdab.com>
-
Thiago Macieira authored
Use qint64 wherever possible. The linear buffer is never requested to allocate that much memory (always limited), but at least we ensure we're not dropping bits where we shouldn't. Windows's POSIX compatibility layer is never largefile enabled, so it is always necessary to chunk large reads and writes. On Unix, this will be rare, unless someone passed -no-largefile to configure, for some weird reason. Unfortunately, this is not testable, unless we can allocate a buffer with 4 GB or more in size. The test for this would be to open a file we know to be small, then try to read 4 GB + 1 byte. If everything works correctly, we'll read the full file; if there was a truncation, we'd read one byte. Change-Id: If3ee511bf1de17e0123c85bbcaa463b9972746ce Reviewed-by:
Kai Koehne <kai.koehne@theqtcompany.com> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Jørgen Lind authored
Change-Id: Ibb522af33e8490719010af441cce712bdc7a71bf Reviewed-by:
Paul Olav Tvete <paul.tvete@digia.com>
-
- 30 Oct, 2014 - 16 commits
-
-
Thiago Macieira authored
Obtained from: http://freebsd.googlecode.com/git-history/4658f9721d395818ba760a79b1cb0b54957d4576/lib/libc/stdlib/strtoull.c http://freebsd.googlecode.com/git-history/4658f9721d395818ba760a79b1cb0b54957d4576/lib/libc/stdlib/strtoll.c Changes: - remove the #includes and the SCCSID - rename from strtoxx_l to qt_strtoxx (merging the two functions) - remove __restrict - remove the locale_t parameter and use ascii_isspace instead of isspace_l Change-Id: I1e522e12da90eb35eefcf4025102dc11b22c60a5 Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com> Reviewed-by:
Lars Knoll <lars.knoll@digia.com>
-
Friedemann Kleint authored
Unlike qtouchevents, this provides a touch area which logs its events and devices. Task-number: QTBUG-40461 Change-Id: Iaaa3589dd692caf8c7078f5ed2ff1e8b2322a369 Reviewed-by:
Shawn Rutledge <shawn.rutledge@digia.com>
-
J-P Nurmi authored
CE_ComboBoxLabel was relying on a font color / painter pen set by CC_ComboBox. This change ensures that CE_ComboBoxLabel has correct color when CC_ComboBox and CE_ComboBoxLabel are drawn independently. Change-Id: Id548d831fdde5885bc7c157d55de6235ef3f0a56 Task-number: QTBUG-41702 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@digia.com>
-
Dyami Caliri authored
Some CFStringRefs created with CFStringCreate* methods were not being released. Using the QCFString helper class to perform auto release. Change-Id: I36d15c0d35118524089e99ea3cd53c41342d6308 Reviewed-by:
Jake Petroules <jake.petroules@petroules.com>
-
Dyami Caliri authored
CFRelease should be called IFF PMPrinterCopyDescriptionURL succeeds Change-Id: Id289aea3a4e3da397dae4062319256a043538597 Reviewed-by:
Jake Petroules <jake.petroules@petroules.com>
-
Fawzi Mohamed authored
Since commmit 0127962e the PBXResourcesBuildPhase is used only for ICONS, because the old behavior of using it when target path is not given differed from the documentation and behavior of the makefile generator by using Contents/Resources as target directory when targeting osx. The PBXResouceBuildPhase optimizes png, compiles xib or asset catalogs and copies the rest. The advantage is that it makes it easy to add resources to the bundle, the only problem is that the target directory is always the resource directory. The copy operation currently used does not compile resources, which makes adding .xib (for the Launch File required to support iphone 6) and asset catalogs difficult. So we restore the old 5.3 behavior for ios, and use the build resources phase when possible on osx (target Contents/Resources). On osx this still implies a difference between the makefile generator and the xcode generator: only the latter compiles resources. Change-Id: Id1853693e88fc46562b044efdea2bf5f9da2c98c Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com> Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@digia.com>
-
Lars Knoll authored
Found by coverity. The cachedIcon can be deleted when being inserted into the icon cache (in QCache::insert). So copy it to icon before trying to insert it into the cache. Change-Id: I5ed13c0c7ecb8f8f13285ca5d06237493dbea479 Reviewed-by:
Laszlo Agocs <laszlo.agocs@digia.com>
-
Laszlo Agocs authored
Not wayland. Use the default of eglfs coming from linux_device_pre.conf. Qt 5.4 includes QtWayland and the platform plugin from there may get built unexpectedly. The result is that the Pi setup that worked with 5.3 and eglfs stops functioning. Task-number: QTBUG-40538 Change-Id: If894c7ddd7b40a22272797d94ce1a545b7ab43f2 Reviewed-by:
Louai Al-Khanji <louai.al-khanji@theqtcompany.com> Reviewed-by:
Andy Nichols <andy.nichols@digia.com>
-
Kai Koehne authored
The warning was introduced in a133cea2 . Change-Id: Ia8180b6c7d83f57cba79519bf4c0e3bf97966c16 Reviewed-by:
Richard J. Moore <rich@kde.org>
-
Kai Koehne authored
Change-Id: I321622b393ea1f452805299d74a28d12270b2238 Reviewed-by:
Richard J. Moore <rich@kde.org>
-
Kai Koehne authored
Fixes errors like qsslsocket_openssl_symbols.cpp:111:6: error: unused function 'qsslSocketUnresolvedSymbolWarning' [-Werror,-Wunused-function] void qsslSocketUnresolvedSymbolWarning(const char *functionName) ^ 1 error generated. Change-Id: I164518de583f080724ab9a7165c885602a1c6231 Reviewed-by:
Richard J. Moore <rich@kde.org>
-
Kai Koehne authored
Task-number: QTBUG-40378 Change-Id: I33f1e92127972e1346993aa4e07731bf4b697667 Reviewed-by:
Lars Knoll <lars.knoll@digia.com>
-
Gabriel de Dietrich authored
Some offsets differ between QWidgets and Controls. Therefore, we need drawNSViewInRect() to know about the origin of the call. Change-Id: I3bd165f94731f2b37423d86ed5d3c302a17d5ef5 Task-number: QTBUG-42067 Reviewed-by:
Morten Johan Sørvig <morten.sorvig@digia.com>
-
Gabriel de Dietrich authored
Task-number: QTBUG-40833 Change-Id: Id3c3f4fd4f5c72cba844bf23f2e79ce0ea2b4a95 Reviewed-by:
Morten Johan Sørvig <morten.sorvig@digia.com>
-
Albert Astals Cid authored
This is needed since the names of the header are the ones you have to use in the QML signal handlers to access the variables Change-Id: I507e2ccc05a1fd2c5efd0bf4bef92ed33a186d95 Reviewed-by:
Simon Hausmann <simon.hausmann@digia.com>
-
Samuel Gaist authored
Currently DataLocation returns the same value as DocumentsLocation which doesn't fit the purpose for what should go in this directory. This patch aims to correct that. On a side note, it will also be more inline with OS X current behavior [ChangeLog][QtCore][iOS] Fixed path to QStandardPaths::DataLocation. Until now DataLocation was pointing to the Document directory. With this patch, it will return the more accurate Library/Application Support. Application making use of DataLocation should move these data to the new location. This can be done using the path provided by DocumentLocation as source path. Task-number: QTBUG-42276 Change-Id: I35415643cf8cc7a60528f9b0fb5028ada5deace0 Reviewed-by:
Jake Petroules <jake.petroules@petroules.com> Reviewed-by:
David Faure <david.faure@kdab.com>
-
- 29 Oct, 2014 - 5 commits
-
-
John Brooks authored
When QWindow::alert() is called with a duration of 0, it calls QPlatformWindow::setAlertState(true), and expects the alert state to be reset when the window is next activated. Other calls to alert are ignored while alertState is still true. If alert was called for an active window, it would remain in the alert state until deactivated and activated again, and on some platforms calls to alert would be broken while deactivated. Alerting doesn't make sense for active windows, so we can simply ignore it, which was the behavior with Qt 4 on some platforms. Change-Id: Ia3324da4c89db711b63eb31cddf0bf742bb4e3b8 Found-By:
Jan Noertemann <jan.noertemann@uni-dortmund.de> Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@digia.com> Reviewed-by:
Martin Gräßlin <mgraesslin@kde.org> Reviewed-by:
Shawn Rutledge <shawn.rutledge@digia.com>
-
Shawn Rutledge authored
Change-Id: I3b31cc499067540e6ad7b6d05df75d9ba0e1e615 Reviewed-by:
BogDan Vatra <bogdan@kde.org>
-
Laszlo Agocs authored
Change-Id: I45cdf79c14b823b3e93ed0e0923cb687a0ea17c7 Reviewed-by:
Louai Al-Khanji <louai.al-khanji@theqtcompany.com>
-
Kai Koehne authored
Change-Id: Ia9a79e659e028eb6173a7adef12d4973f78c32e9 Reviewed-by:
Liang Qi <liang.qi@theqtcompany.com>
-
Shawn Rutledge authored
Task-number: QTBUG-42249 Change-Id: Ie5d41ed26a69103991a5189c4f42aa37ac73de26 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@theqtcompany.com> Reviewed-by:
Liang Qi <liang.qi@theqtcompany.com>
-