- 01 Feb, 2018 - 4 commits
-
-
Thiago Macieira authored
This reverts commit ab1e5075 . That was supposed to be a minor behavior change, but ends up having visible effects such as QtXmlPatterns xs:dateTime type now reporting sub-second fractions. So we're reverting in 5.10 and re-applying in 5.11. Change-Id: I741e49459c9a688c1c329d6cbd521cd4a0b2aa84 Reviewed-by:
Lars Knoll <lars.knoll@qt.io>
-
Christian Strømme authored
If the QLoggingRegistry gets called as part of the static initialization phase, it would call into Android's QStandarPaths implementation, which assumed that the HOME env. variable was already set. Since the variable isn't set before main is called, QDir::homePath() returns the root path, which would be cached and always returned. With this fix we now call Android's getFilesDir() directly, which will always return the right path. Since the font locations are also relying on an environment variable being set, we no longer cache that either. Task-number: QTBUG-65820 Change-Id: If45f3d5f0e87b808a62118ae95c31b492885646a Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@qt.io> Reviewed-by:
Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
-
Tor Arne Vestbø authored
On Android, we load the application library, and its dependencies (Qt), on Android's main thread (thread 0), and then spin up a secondary thread (thread 1), that we call main() on. If any QObject is constructed during loading of the application library or any of Qt's libraries, via static initializers or constructor functions, we will set QCoreApplicationPrivate::theMainThread to thread 0, which will confuse Qt later on when it's being run on thread 1, and will result in a warning during QCoreApplication construction: QApplication was not created in the main() thread This situation can easily lead to a crash as well. Unfortunately logging via qDebug/qCDebug and friends will trigger this too, as they internally use QObject. Fixing the root cause of this is under investigation, but for now we will partially revert fa2a653b for Android. The effect is that any qCDebug with a "qt.*" category before qApp construction will turn into a no-op, like it was before fa2a653b. This patch does not cover the case of a regular qDebug, or a qCDebug with a non-Qt category. Those will still produce the same symptom, as before fa2a653b . Task-number: QTBUG-65863 Change-Id: I95675731d233244530d0a2a1c82a9578d5599775 Reviewed-by:
Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io> Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@qt.io>
-
Tor Arne Vestbø authored
Instead of trying to detect situations where we need to send a real expose event instead of an update request in response to a drawRect call, we keep track of when we've asked the view to display due to a requestUpdate call, and only deliver the corresponding drawRect as an update request if no other code has asked the view to display. This should cover all cases of asking the view to display, issued from our code or from AppKit, such as the view changing its backing scale factor, or otherwise needing a real expose event. Task-number: QTBUG-65663 Change-Id: I1783787823aee889dad8e48f34a1cb0f1b7b06bd Reviewed-by:
Shawn Rutledge <shawn.rutledge@qt.io>
-
- 26 Jan, 2018 - 2 commits
-
-
Liang Qi authored
Change-Id: I7bfb75083f60190aa1def82d153f89925a92fd56
-
Joerg Bornemann authored
The backwards iteration was done under the assumption that the only valid modification of the winEventNotifierList in a slot connected to activated() would be the removal of the notifier itself. This is wrong. Instead, iterate forwards, like before 85403d0a , and check the index against the current list size in every iteration. This ensures that we do not run out of bounds while the list is modified. Also, retry the activation loop if the list was modified by a slot connected to activated(). This ensures that all notifiers with signaled handles are activated. Task-number: QTBUG-65940 Change-Id: I25f305463b9234f391abc51fe0628d02f49b6931 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io> Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
- 25 Jan, 2018 - 9 commits
-
-
Alexey Safronov authored
Change-Id: Ib9a1b107dd8d2cd4bf541c3edf19a602fde6356f Reviewed-by:
Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io> Reviewed-by:
Martin Smith <martin.smith@qt.io> Reviewed-by:
Paul Wicking <paul.wicking@qt.io>
-
Thiago Macieira authored
This way, it's lossless. Change-Id: I5e421e32396d44e4b39efffd150b744e40fff3a1 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by:
Lars Knoll <lars.knoll@qt.io>
-
André Klitzing authored
[ChangeLog][Third-Party Code] libjpeg-turbo was updated to version 1.5.3 Change-Id: I8c0caec3c92ba199b1a3baac9a523cc399c8001f Reviewed-by:
Kai Koehne <kai.koehne@qt.io> Reviewed-by:
Eirik Aavitsland <eirik.aavitsland@qt.io>
-
Ville Voutilainen authored
Without this, building Qt and Qt applications fails with GCC 8. The errors look like this: writing to an object of type ‘class QPointer<QQuickPointerHandler>’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Werror=class-memaccess] Task-number: QTBUG-65691 Change-Id: Ie5a30814125deca7a160b9a61f5aa3f944ee1ac9 Reviewed-by:
Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Jake Petroules authored
The PRODUCT_BUNDLE_IDENTIFIER property was not defined in the Xcode project file and therefore the build would fail. This fixes a regression introduced by 0749ba2c . Task-number: QTBUG-65673 Change-Id: I8089b36d86588223ec34859af7388c99a3574d8b Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
Morten Johan Sørvig authored
Fix regression from commit 8b3a120a where also dialogs got NSResizableWindowMask, making them have a Zoom button. Task-number: QTBUG-65668 Change-Id: I21054b3aa6fc11eab3d93f78ede44ae771522e2c Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@qt.io>
-
Joni Poikelin authored
Change-Id: I4d213a266034d388af723337deeeb4cdd1f5cbdb Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io>
-
Joerg Bornemann authored
The idx member of EventWithNotifier is unused. Change-Id: I0f5aacaaad4b4e82c57ff7bb020586944014f139 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io>
-
Andy Shaw authored
When the application is hidden then Qt will hide the popup windows associated with it when it has lost the activation for the application. However, when it gets to this point it believes the popup windows to be hidden already due to the fact that the application itself is hidden. As a result, when the application is restored it causes a problem with the still visible popup window as it is taking the input events without responding to them. Therefore we need to explicitly hide the windows right before the application is hidden to ensure that they are actually hidden correctly. Task-number: QTBUG-58727 Change-Id: I4be1e1c0b1388d0c9ec872e7732185670998b7af Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@qt.io>
-
- 24 Jan, 2018 - 12 commits
-
-
Thiago Macieira authored
The linker complains: LINK : warning LNK4281: undesirable base address 0x67000000 for x64 image; set base address above 4GB for best ASLR optimization And it's not really required anymore, as the recommended /DYNAMICBASE is the default. Change-Id: I56b444f9d6274221a3b7fffd150caab1beecfd43 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io>
-
Liang Qi authored
-
Konstantin Tokarev authored
When original QNetworkRequest is missing "Host" header (which is the most common case), it is provided automatically from request URL. However, resulting header is appended to the list, i.e. after all headers specified by user, which may include a big bunch of cookies. To the contrary, RFC 7230 suggests: "However, it is good practice to send header fields that contain control data first, such as Host on requests and Date on responses, so that implementations can decide when not to handle a message as early as possible". Many other user agents are following this suggestion. Task-number: QTBUG-51557 Change-Id: I1448ed3ae124f5ce86a8ca8ff35f5d05476a005d Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com> Reviewed-by:
Mårten Nordheim <marten.nordheim@qt.io> Reviewed-by:
Timur Pocheptsov <timur.pocheptsov@qt.io>
-
Alexis Jeandet authored
Build systems such as Meson heavily rely on pkg-config to get build flags. -DQT_{module}_LIB isn't exported in .pc files which makes Meson unable to build some codes out of the box. Change-Id: I806998f19f815e05a47b60129977e52587b38d47 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com> Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
Friedemann Kleint authored
Account for the (not yet created) native menu height when handling the initial resize message. Complements 7849aa6e . Task-number: QTBUG-65917 Task-number: QTBUG-55967 Change-Id: I65c75d796634ecf1a90a72fef8ff3e6e89de11c4 Reviewed-by:
Oliver Wolff <oliver.wolff@qt.io> Reviewed-by:
J-P Nurmi <jpnurmi@qt.io>
-
Andy Shaw authored
Since braille characters are not included in Apple Unicode MS, we extend the fallback to include Apple Symbols to cover those too. Task-number: QTBUG-63510 Change-Id: I3977f1f9b7370a9fe9cfde643c86518e006c050a Reviewed-by:
Konstantin Ritt <ritt.ks@gmail.com> Reviewed-by:
Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
-
Kai Koehne authored
Follow the example of the other modules and explicitly mention the valid licenses on each module landing page, optionally combining it with trademark information. Change-Id: I9f1fea0f002e0ab607da89a0cbfe7c53060582d7 Reviewed-by:
Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by:
Topi Reiniö <topi.reinio@qt.io>
-
Liang Qi authored
Conflicts: src/corelib/global/qglobal.cpp src/corelib/global/qrandom.cpp tests/auto/corelib/io/qfileinfo/tst_qfileinfo.cpp Change-Id: Icc10543a1f2db5d640d01796bfec70a63517a6b2
-
Mitch Curtis authored
Make it clearer what the variable actually does by mentioning that it makes its headers available for inclusion and causes it to be linked to the binary. Change-Id: I72821d4bceea7a92e91175ba6c5acc4c3377d7b7 Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
Val Doroshchuk authored
Setting speed to 0 means the current frame will continue to be shown, the finished signal is not emitted, and state remains QMovie::Running. Task-number: QTBUG-65758 Change-Id: I681d902e3211c5899b21043e5177b7c73d5d3fb5 Reviewed-by:
Shawn Rutledge <shawn.rutledge@qt.io>
-
Martin Storsjö authored
There's no external arm assembler to fall back on here. The actual assembly is already disabled since 8072c36e , but passing the empty assembly file to any random external assembler could end up producing an empty object file for the host environment instead of the target, in a cross build. This wasn't an issue as long as the clang compiler only was identified as g++ within mkspecs, making no_clang_integrated_as a no-op. If the mkspec actually identifies it as clang, this config can't be added here. Change-Id: I0f20b9b2a8d13b5e7e1b654e391d88b639c031bf Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Andy Shaw authored
Passing -1 to waitForReadyRead() may cause it to wait for some time but the data retrieved may be enough for processing. So if 0 is passed from read, indicating that there is potentially more to come, then it will do a waitForReadyRead() then for more data to come. Change-Id: I75f270d1f124ecc12b18512cc20fb11f7a88f02e Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
- 23 Jan, 2018 - 3 commits
-
-
Laszlo Agocs authored
Task-number: QTBUG-59636 Change-Id: I38394009993e92ab9db853a1450687fc48e471f5 Reviewed-by:
Andy Nichols <andy.nichols@qt.io>
-
Martin Storsjö authored
sljit, the JIT in pcre2, doesn't quite fully work on windows on arm yet (although the subset of functionality used by pcre2 might mostly work). On arm64, it fails to compile (although working around that failure is pretty easy), when using clang in MinGW mode (where __GNUC__ is defined, making the JIT auto-enabled). Disable it in these configurations until it has been fully tested and fixed upstream first. Change-Id: Ie9681cb7cdd1960586ba194c71e057eb918cb419 Reviewed-by:
Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
-
Friedemann Kleint authored
Correctly scale the requested geometry in the constructor of QWindowSystemInterfacePrivate::GeometryChangeEvent(). Amends 3a31c708 . Task-number: QTBUG-57608 Task-number: QTBUG-65580 Change-Id: I0ef60deda69bb61ab57972e02c342b7773e1da6b Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@qt.io>
-
- 22 Jan, 2018 - 6 commits
-
-
Gabriel de Dietrich authored
Change-Id: I5a7588c07106227e2a8b5e1f180230ef5b0342d1 Task-number: QTBUG-65228 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io> Reviewed-by:
Alexandru Croitor <alexandru.croitor@qt.io> Reviewed-by:
Morten Johan Sørvig <morten.sorvig@qt.io>
-
Gabriel de Dietrich authored
This affected PE_IndicatorCheckBox in some cases. Change-Id: I6f10dabd2ca4093f4c1bdaa2bd0ebf73c02e8d12 Task-number: QTBUG-65737 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io> Reviewed-by:
Yulong Bai <yulong.bai@qt.io> Reviewed-by:
Morten Johan Sørvig <morten.sorvig@qt.io>
-
Alexander Shevchenko authored
mingw-w64 toolchain: - remove 'QMAKE_CFLAGS_AESNI' and 'QMAKE_CFLAGS_SHANI' definitions, which are already set in 'gcc-base.conf' toolchain; this is a continuation of 77347a36 relating variables, introduced in 5.10, - remove 'gcc-base.conf' duplicate inclusion, left after eef2d1af was merged into 5.10. Change-Id: I328def916ccfb93c3f6b8336eb8801defbac37ae Reviewed-by:
Kai Koehne <kai.koehne@qt.io> Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
Jeremy LUGAGNE authored
Change-Id: Ie7a2ff0e42131afef1bdec853d09c3b447f9748c Reviewed-by:
Sérgio Martins <sergio.martins@kdab.com>
-
Oliver Wolff authored
Task-number: QTBUG-65735 Change-Id: I7e0d19de4ac92603f2fd033007343f20a408618a Reviewed-by:
Nico Vertriest <nico.vertriest@qt.io>
-
Thiago Macieira authored
Both ICC and MSVC have bugs concatenating strings and that's despite the standard giving an example ([lex.string] table 9) that says that u"a" "b" is the same as u"ab" We can't change to preprocessor concatenation (u ## STR) because that fails when QStringLiteral is used with a macro instead of an actual string literal. Task-number: QTBUG-65479 Change-Id: I39332e0a867442d58082fffd1504a0a868c291ef Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
- 20 Jan, 2018 - 3 commits
-
-
Liang Qi authored
-
Otto Ryynänen authored
The Embedded Android build (Boot to Qt Android injection) is defined by having both Q_OS_ANDROID and Q_OS_ANDROID_EMBEDDED flags defined, as well as having Qt config android-embedded. This commit enables the possibility to build embedded Android builds. (i.e. Qt build for Android baselayer only, without JNI) Change-Id: I8406e959fdf1c8d9efebbbe53f1a391fa25f336a Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io> Reviewed-by:
Paul Olav Tvete <paul.tvete@qt.io>
-
Alex Trotsenko authored
Change-Id: Ic53a8a53b882f1e6b6434b943fff0a6fcd95f341 Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io>
-
- 19 Jan, 2018 - 1 commit
-
-
Andre de la Rocha authored
A large plugin dll (e.g., one with many MB of debug info) could cause a 32-bit application to crash when the entire dll file could not fit within the address space of the process. The code for validating a plugin library and retrieving metadata from it first tried to map the entire file in memory, which failed for large files, returning NULL. In this case, the code tried then to read the entire file via QFile::readAll(), which deep below caused a bad_alloc exception in malloc, resulting in the termination of the application. This change handles the case where the library could not be mapped into memory, in spite of memory mapping being supported, by reporting the error and returning false, making the plugin unavailable. [ChangeLog][QtCore][QPluginLoader] Fixed a bug that would cause the Qt plugin scanning system to allocate too much memory and possibly crash the process. Task-number: QTBUG-65197 Change-Id: I8c7235d86175c9fcd2b87fcb1151570da9b9ebe3 Reviewed-by:
Jan Arve Sæther <jan-arve.saether@qt.io>
-