- 15 Apr, 2019 - 1 commit
-
-
Kavindra Palaraja authored
Task-number: QTBUG-50011 Change-Id: I18261e62e387eeb74fc7584bf034a11ac75db1be Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io>
-
- 10 Apr, 2019 - 2 commits
-
-
Liang Qi authored
-
Johan Klokkhammer Helsing authored
Task-number: QTBUG-74879 Change-Id: Idb39a39a10bccb1822bdb80343fbe1b5c92560e9 Reviewed-by:
Laszlo Agocs <laszlo.agocs@qt.io>
-
- 09 Apr, 2019 - 16 commits
-
-
Qt Forward Merge Bot authored
Change-Id: I44eda44bf424fdcffab048a2534905d6162e5559
-
Allan Sandfeld Jensen authored
Clang-cl couldn't find the header given to it by -FI when it isn't in any of the included directories. Additionally clang-cl 8 has a bug with exported templated classes with inline methods that causes it to have missing symbols at link time. We work around this. Fixes: QTBUG-74563 Change-Id: I7becf05fa8edb07bd4cefe12bee3737e5e1dfa14 Reviewed-by:
Yuhang Zhao <2546789017@qq.com> Reviewed-by:
Mårten Nordheim <marten.nordheim@qt.io> Reviewed-by:
Kai Koehne <kai.koehne@qt.io>
-
Allan Sandfeld Jensen authored
Include many headers that are commonly used now, and avoid listing them twice. Change-Id: I679dc24cff2cb3a3c9c18585ec78007ab3550743 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Liang Qi authored
-
Christian Ehrlicher authored
QTableView drew additional grid lines on the top and left side when the corresponding header was not visible and the ScrollMode was ScrollPerItem. After 8f2bacea they were also drawn for ScrolPerPixel for consistency. But they are not needed at all and only create visual artifacts. Therefore remove the drawing of the additional lines completely. Fixes: QTBUG-74706 Change-Id: I5c77d53a2eeefab9b9bfe0efea6439f5afede4ac Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io> Reviewed-by:
Andy Shaw <andy.shaw@qt.io>
-
Christian Ehrlicher authored
Ctrl+End moves the visual index to the bottom left index. This does not work correctly when the item in the bottom left is disabled. It should be fixed with 7863be31 but does not due to a typo. Fix the typo by using the newly calculated visualColumn instead the initial column. There are cases where the algorithm still does not work as expected when there are more disabled items but fixing them would add a lot of complexity with no (much) gain. Fixes: QTBUG-72400 Change-Id: Ie90f6b3e41e00f54e826c2b4e7303e85ac1e4115 Reviewed-by:
Richard Moe Gustavsen <richard.gustavsen@qt.io>
-
Milian Wolff authored
QMetaObject::newInstance returns a QObject, thus it's not possible to create a new instance of a Q_GADGET using this function. Previously, we returned a non-null QObject pointer for such scenarios, which then leads to crashes when one tries to use it. Now, we check whether the meta object inherits QObject's meta object, and error out early otherwise. Change-Id: I7b1fb6c8d48b3e98161894be2f281a491963345e Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Edward Welbourne authored
The central loop starts by reading five bytes; but the loop condition only checked that four were available. Change-Id: I244cecacabeffbac10ad94081f32847f912d95d9 Reviewed-by:
Kai Koehne <kai.koehne@qt.io> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com> Reviewed-by:
hjk <hjk@qt.io>
-
Joerg Bornemann authored
When installing directories, QINSTALL must not ignore contained hidden files to be consistent with the old INSTALL_DIR. Fixes: QTBUG-66835 Change-Id: I3a7c952dcac9732d5b17c5a258f87ca277b388d2 Reviewed-by:
Kai Koehne <kai.koehne@qt.io>
-
Kai Koehne authored
/GM at one point apparently was set by default for debug builds. However, nowaways it's officially deprecated and even generates a warning in Visual Studio 2019; so we don't have to 'unset' it specifically anymore. Change-Id: I5b9b93c058c2ee8a5e025da43251d3859acbe061 Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io>
-
Kai Koehne authored
The comment hints that it's fixing an issue in Visual Studio 2013, which we don't support anymore. In all supported Visual Studio Versions -Gm is actually deprecated anyhow, and not set anymore by default. So I guess it's safe to remove the special handling here. Change-Id: I2e8ff85350ba651d9a763aabba7b6494ba88d82e Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io>
-
Kai Koehne authored
Fixes clang-cl warning qelapsedtimer_win.cpp(80,22): warning: unused function 'nanosecondsToTicks' [-Wunused-function] Change-Id: I1ff334049fcf4b265fe97235b7daf06969331313 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Kai Koehne authored
qprintengine_win.cpp(1117,14): warning: comparison of two values with different enumeration types in switch statement ('QPrint::DuplexMode' and 'QPrinter::DuplexMode') [-Wenum-compare-switch] case QPrinter::DuplexShortSide: Change-Id: Ib5028d80ecf7f6bb9eb0562e5c137acfeb709a14 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io>
-
Samuel Gaist authored
This patch updates the code from the deprecated QRegExp class to QRegularExpression. Task-number: QTBUG-25485 Change-Id: I946790f50c6b14787bca31771de5e3a0d5fefe4c Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Paul Lemire authored
Leads to a huge loss of context for people trying to understand and maintain that code. Replacing with proper types to ensure better readability and maintenance. Change-Id: I9900b743e8b7fe11bcc7db9ce3191c89f8718afc Reviewed-by:
Mike Krus <mike.krus@kdab.com>
-
Timur Pocheptsov authored
to test different h2 modes: "h2c" (clear text with protocol upgrade), "h2" (encrypted, negotiating via ALPN extension), "h2-direct" (encrypted, no ALPN), "h2c-direct" (plain text, no protocol upgrade). This patch-set is an amendment to the recent fix in the protocol handler where we were crashing in "h2c-direct" mode. Change-Id: I3ff5ed1396a59b72b59a95f927d404ccd202d0b8 Reviewed-by:
Timur Pocheptsov <timur.pocheptsov@qt.io> Reviewed-by:
Mårten Nordheim <marten.nordheim@qt.io>
-
- 08 Apr, 2019 - 10 commits
-
-
Qt Forward Merge Bot authored
Change-Id: I05d14a40e17554691bad369d0363e88413afd9b3
-
Allan Sandfeld Jensen authored
We were using low precision dx/dy for calculating the starting point which meant we could be off when clipping at high scale factors. Fixes: QTBUG-60782 Change-Id: I883f9aed1346fdffae070b6316ea808b83519701 Reviewed-by:
Eirik Aavitsland <eirik.aavitsland@qt.io>
-
Thiago Macieira authored
Updated to https://github.com/thiagomacieira/tinycbor commit ac9369d8ec8511bc7516266ae6b07f7da860c954. Fabrice Fontaine (1): fix undefined encode_half in json2cbor Pedro Oliveira (1): Fixed minor error in the example code. Svyatoslav Phirsov (2): Typo fixed in stdlib fread(...) usage typo in dumprecursive return type Thiago Macieira (9): Install the tinycbor-version.h header. Update version number for a possible but unlikely 0.5.3 release Fix #137: off-by-one error in UTF-8 decoding Update Travis CI to Ubuntu Xenial Pretty: fix use of uninitialised variable Validation: fix out-of-bounds access when content ends in a string Parser: apply the same memory-check update Tests: remove useless comment Tests: Catch an earlier QCOMPARE failure in compare() phirsov (6): Fix off-by-one causing buffer overflow in open_memstream Protect macro argument expansion using parentheses eliminating misleading messages in case .config file not yet created Run check silently in Travis Make AppVeyor test suit run silent as in Travis enhancement #149 implemented: access half-precision floating point data as single float Change-Id: I9e3d261ad9bf41cfb2b6fffd159088f1cc9b3b02 Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io>
-
Friedemann Kleint authored
The test changes the current directory to the test directory in fromUserInputWithCwd(), but did not restore it, causing: Totals 898 passed, 0 failed, 1 skipped, 0 blacklisted, 368ms ********* Finished testing of tst_QUrl ********* QTemporaryDir Unable to remove "C:\\TEMP\\tst_qurl-ryVxqu" most likely due to the presence of read-only files. Restore the old directory at the end to fix this. Change-Id: I62669868f3c6d97dd38ebac76515428c14b7e1e7 Reviewed-by:
David Faure <david.faure@kdab.com>
-
Friedemann Kleint authored
Move the code returning whether a popup should use the full screen to QStylePrivate and use for QMenu and QComboBox. Task-number: QTBUG-73231 Change-Id: I1901ecedfa90edf16329ce3b13ef4abea5ab44e8 Reviewed-by:
Morten Johan Sørvig <morten.sorvig@qt.io> Reviewed-by:
Richard Moe Gustavsen <richard.gustavsen@qt.io>
-
Friedemann Kleint authored
The native Windows allows for typing in http[s] URLs directly (without checking existence). Pass these up. Fixes: QTBUG-71785 Change-Id: I60237bab596ca3f52e6f513f17544ff94e9080da Reviewed-by:
Andre de la Rocha <andre.rocha@qt.io> Reviewed-by:
Oliver Wolff <oliver.wolff@qt.io>
-
Joerg Bornemann authored
...like the install commands before Qt 5.9 did. This ensures consistent permissions. Also, we can throw away the code that took care of removing and re-adding the read-only flag on Windows. This reverts commit a0b5d6e6 with the addition of preserving permissions when copying directories to properly install app bundles (QTBUG-74912). Fixes: QTBUG-74733 Task-number: QTBUG-74912 Change-Id: Iee6d7c5e86787dd3ada5e5e9441209d418100b1f Reviewed-by:
Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io> Reviewed-by:
Simon Hausmann <simon.hausmann@qt.io>
-
Andre Hartmann authored
Change-Id: Ice210b979a1dd948cd8d95003bd50a4b71d91852 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Andre Hartmann authored
QNetworkDatagram was introduced together with these methods in Qt 5.8 (commit 4da2dda2 ) Change-Id: I454c26ebf6f94988cada8ac9315db1d43a31a595 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Qt Forward Merge Bot authored
Change-Id: Id60d508c0f25fd5e67be07daafd2d4c56ae73934
-
- 06 Apr, 2019 - 2 commits
-
-
Davide Beatrici authored
The current code only tries to load the required functions from LIBRESOLV_SO (if defined) and resolv, but on FreeBSD they are in libc: https://www.freebsd.org/cgi/man.cgi?query=res_query&sektion=3&apropos=0&manpath=freebsd This commit changes the code so that, after failing to load the non-existent libraries, it attempts to load the functions with dlsym() using the special handle RTLD_DEFAULT, which searches for the specified symbol in the loaded libraries. This is a follow-up to 8eeb5150 . Change-Id: I19d90b0ca8703398bf4f5f4edd5ae31e346ef251 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Davide Beatrici authored
The current code only tries to load the required functions from LIBRESOLV_SO (if defined) and resolv, but on FreeBSD they are in libc: https://www.freebsd.org/cgi/man.cgi?query=res_query&sektion=3&apropos=0&manpath=freebsd This commit changes the code so that, after failing to load the non-existent libraries, it attempts to load the functions with dlsym() using the special handle RTLD_DEFAULT, which searches for the specified symbol in the loaded libraries. Task-number: QTBUG-74844 Change-Id: If97aaae233cabbfa01c30d26d9a7fb01ec3ff5c2 Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
- 05 Apr, 2019 - 9 commits
-
-
Qt Forward Merge Bot authored
Change-Id: Iec860bb703f983b7438e67c695b9c454e72b3e0f
-
Edward Welbourne authored
Includes a fixup for 03fadc26 , which removed the check on empty transition list, needed when no data are available. Ensured that such a data-free zone would in fact be noticed as invalid during init(). Fixed handling of times before the epoch (we still want to consult a POSIX rule, if that's all that's available) while ensuring we (as documented) ignore DST for such times. Fixed handling of large times (milliseconds since epoch outside int range) when looking up POSIX rules. Gave QTimeZonePrivate a YearRange enum (to be moved to QTimeZone once this merges up to dev) so as to eliminate a magic number (and avoid adding another). Moved year-munging in POSIX rules after the one early return, which doesn't need the year range. Added test-cases for the distant past/future (just checking UTC's offsets; SLES has a minimal version of the UTC data-file that triggers the bugs fixed here for them). Fixes: QTBUG-74666 Fixes: QTBUG-74550 Change-Id: Ief7b7e55c62cf11064700934f404b2fc283614e1 Reviewed-by:
Tony Sarajärvi <tony.sarajarvi@qt.io> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Milian Wolff authored
This allows tools that look for matching `foo_entry/exit` pairs in the trace data to work properly. An unmatched `_entry` would otherwise confuse them, making them think that the call stack is continuously increasing. Change-Id: Idff7f587ea25c46ec86ad623cc82d503db34a194 Reviewed-by:
Christoph Sterz <christoph.sterz@kdab.com> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Milian Wolff authored
Additionally, we also add a Q_TRACE_EXIT which runs a trace point when the scope is exited, leveraging qScopeGuard behind the scenes. Q_TRACE_SCOPE uses Q_TRACE_EXIT internally - the difference is that the _SCOPE version enforces the naming scheme of _entry / _exit for the tracepoints, whereas Q_TRACE_EXIT can be used generically. Change-Id: I4a2f5ea09f451fcf664d07fd493b679f7527ac06 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Milian Wolff authored
This allows us to deduce a lot about what a Qt application is doing, since the debug output usually contains a lot of information. Change-Id: I28a18afd151a1640a44ba8c7c9cd87d5d66c99b0 Reviewed-by:
Christoph Sterz <christoph.sterz@kdab.com> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Milian Wolff authored
This patch fixes compilation with `-trace lttng` or `-trace etw`. We need to forward declare QEvent, QImageReader etc., otherwise the types will be unknown while compiling the trace points. In order to handle this generically, the tracegen utility is extended to support a 'prefix text' in the `*.tracepoints` input files. Any text within curly braces will be embedded as-is in the generated file. This can then be used to add forward declarations for the types we need, including potential namespaces and such. Change-Id: I5cb16763ce0fcb48ce3ea4577578d468ff3a4f4b Reviewed-by:
Konstantin Tokarev <annulen@yandex.ru>
-
Friedemann Kleint authored
Remove the canCopy() check which is not required and pass up the error message. Remove special characters and use the base name of the display name which can be an URL. Task-number: QTBUG-71785 Change-Id: I22966cb8d1f5bca0bbca71cf3ebe66e4ede1a747 Reviewed-by:
Oliver Wolff <oliver.wolff@qt.io> Reviewed-by:
Andre de la Rocha <andre.rocha@qt.io>
-
Qt Forward Merge Bot authored
Change-Id: I010a6322d12e038fdce247a58dfb05e204c2ff3b
-
Albert Astals Cid authored
oss-fuzz found at least width is sometimes not initialized, and we're initializing almost all of them in most cases so be complete. the oss-fuzz instance was ==1==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x667c43 in operator!= /src/qtbase/src/corelib/tools/qsize.h:173:25 #1 0x667c43 in setup_qt /src/qtbase/src/gui/image/qpnghandler.cpp:403 Change-Id: Idb9aaf5ab85509d9c893beaf8d9118339ba46be7 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-