1. 04 Nov, 2014 - 3 commits
    • Liang Jian's avatar
      Fix memory leak in QQmlLocaleData · 6cbb84d2
      Liang Jian authored
      
      Call the correct destructor in QQmlLocaleData::destroy() to prevent memory
      leak.
      
      Change-Id: Id5b7657443521fbb46486bfbc5575d914c7c7b71
      Reviewed-by: default avatarSimon Hausmann <simon.hausmann@digia.com>
      6cbb84d2
    • Eskil Abrahamsen Blomfeldt's avatar
      Fix disappearing nodes when adding in two levels of batch root · 326c4d80
      Eskil Abrahamsen Blomfeldt authored
      
      When having e.g. a clip node inside another clip node and adding
      children to the innermost, we would get into the situation where
      we did a partial rebuild for the outermost root, but its available
      render order count would not be updated to reflect the change
      deeper down in the tree. Since the z range would be based on the
      outermost batch root's knowledge of the maximum render order in
      the tree, what would happen is that the z of the rendered nodes
      would increase steadily until they went outside of the viewing
      volume and disappeared.
      
      When decreasing the available order count of a batch root, we need
      to also decrease the available order count of its parents. If any
      of them drop below zero, we need to rebuild the render lists.
      
      [ChangeLog][QtQuick] Fixed nodes sometimes disappearing when
      adding many new nodes to the tree.
      
      Change-Id: I39c34acf0e1e0e87601f0fcd983f8da38cee029f
      Task-number: QTBUG-42096
      Reviewed-by: default avatarGunnar Sletta <gunnar@sletta.org>
      326c4d80
    • Liang Jian's avatar
      Fix memory leak in QV4::QQmlSequence · c748f51f
      Liang Jian authored
      
      Use the correct destructor in QV4::QQmlSequence::destroy() to prevent
      memory leak
      
      Change-Id: If9531f731abe5cd9aecfb9642ebf4f5108978f99
      Reviewed-by: default avatarSimon Hausmann <simon.hausmann@digia.com>
      c748f51f
  2. 03 Nov, 2014 - 1 commit
  3. 02 Nov, 2014 - 1 commit
  4. 31 Oct, 2014 - 4 commits
    • Thiago Macieira's avatar
      Don't use qDebug and qWarning for formatted output · be9c969b
      Thiago Macieira authored
      
      They are not meant to be used like that. If you want formatted output to
      the console, use stdio.h functions or std::cout. Otherwise, you get
      something like:
      
       $ qmlscene -h
       [233103.196] (126848)(usage|?qmlscene?|__libc_start_main|?qmlscene?): Usage: qmlscene [options] <filename>
       [233103.197] (126848)(usage|?qmlscene?|__libc_start_main|?qmlscene?):
       [233103.197] (126848)(usage|?qmlscene?|__libc_start_main|?qmlscene?):  Options:
       [233103.198] (126848)(usage|?qmlscene?|__libc_start_main|?qmlscene?):   --maximized ............................... Run maximized
       [...]
      
      I've replaced all qDebug with puts/printf and most qWarning with fprintf
      to stderr. In my opinion, some of the qWarnings aren't errors, so I
      replaced those with puts/printf too.
      
      Change-Id: I3e493950bc4a588059fec6c7441b010c2780dffd
      Reviewed-by: default avatarSimon Hausmann <simon.hausmann@digia.com>
      be9c969b
    • Lars Knoll's avatar
      Get rid of !this and similar constructs · 0704d2be
      Lars Knoll authored
      
      The C++ standard doesn't allow calling member functions
      on a mull object. Fix all such places, by moving the checks
      to the caller where required.
      
      Change-Id: I10fb22acaf0324d8ffd3a6d8e19152e5d32f56bb
      Reviewed-by: default avatarSimon Hausmann <simon.hausmann@digia.com>
      0704d2be
    • Lars Knoll's avatar
      Don't allocate less memory than required · e6794882
      Lars Knoll authored
      
      When switching from a simple to a sparse array,
      keep the previously allocated size, to not corrupt
      memory.
      
      Change-Id: I33f0fb049a2ad6f24ee3703f2c333855830fe9d2
      Reviewed-by: default avatarSimon Hausmann <simon.hausmann@digia.com>
      e6794882
    • Eskil Abrahamsen Blomfeldt's avatar
      BorderImage: Fix white area when size changes after first paint · 87755d04
      Eskil Abrahamsen Blomfeldt authored
      
      When e.g. growing the size of the border image in an animation,
      we would not get updates of the paint nodes when the size was
      so small that the bounded target rect and source rect did not
      change (when the size was smaller than the sum of the borders).
      Since this can happen, we also need to detect when the size
      changes and update the node for this case.
      
      Task-number: QTBUG-42022
      Change-Id: I0849d740f363e66a3a4fd6de23fc9d7399ab0779
      Reviewed-by: default avatarGunnar Sletta <gunnar@sletta.org>
      87755d04
  5. 30 Oct, 2014 - 3 commits
  6. 29 Oct, 2014 - 2 commits
    • J-P Nurmi's avatar
      Repeater & itemviews: fix setModel() JS array handling · cf959b4b
      J-P Nurmi authored
      
      QVariant comparison in setModel() started failing because
      JS arrays are now passed as a QJSValue. Re-assigning the
      same array content should not trigger a model change.
      
      This change restores the old behavior it had before, when
      JS arrays were passed as QVariantLists.
      
      Change-Id: I1882b3531f2893b116dbd817edeecab1ae812ce8
      Reviewed-by: default avatarSimon Hausmann <simon.hausmann@digia.com>
      cf959b4b
    • Daniel d'Andrada's avatar
      Remove mouse grabber if touch used for mouse emulation has been grabbed · 4b7dc1cf
      Daniel d'Andrada authored
      
      If an item grabs a touch that is currently being used for mouse pointer
      emulation, the current mouse grabber should lose the mouse as mouse
      events will no longer be generated from that touch point.
      
      Example of what happens without this patch:
      -User touches a MouseArea. It gets pressed.
      -Some other item grabs that touch.
      -This touch eventually ends.
      -The MouseArea would still be pressed.
      And what will happens instead after this patch:
      -User touches a MouseArea. It gets pressed.
      -Some other item grabs that touch.
      -The MouseArea gets canceled and released
      -This touch eventually ends.
      
      Change-Id: I24114f18be564553a4a768243bb20379affe7a8f
      Reviewed-by: default avatarShawn Rutledge <shawn.rutledge@digia.com>
      4b7dc1cf
  7. 28 Oct, 2014 - 3 commits
  8. 27 Oct, 2014 - 10 commits
  9. 24 Oct, 2014 - 7 commits
  10. 23 Oct, 2014 - 6 commits
    • Samuel Gaist's avatar
      Fix build with QT_NO_DEBUG_OUTPUT defined · 0f65f30c
      Samuel Gaist authored
      
      The use of the qDebug() macro to construct a QDebug object fails when
      QT_NO_DEBUG_OUTPUT is defined when building Qt.
      This patch aims to fix this.
      
      [ChangeLog][General][Build] Can now build with QT_NO_DEBUG_OUTPUT
      defined
      
      Change-Id: If807ee3439db2a98b4d146f75860a98f40c247ec
      Reviewed-by: default avatarGunnar Sletta <gunnar@sletta.org>
      0f65f30c
    • Kai Koehne's avatar
      QmlEngine: Use separate mutex for network access manager · 174e998e
      Kai Koehne authored
      
      Creating the network access manager can involve blocking calls to DBus,
      which apparently can take quite long in pathological cases. Using the
      same mutex in this case like for instance registering objects can
      therefore result in a freezing UI.
      
      Mitigate this by introducing a separate mutex.
      
      Task-number: QTBUG-41183
      Change-Id: I55bd8453d8e4bbc0bda1591eb3fd48b50ca921c1
      Reviewed-by: default avatarSimon Hausmann <simon.hausmann@digia.com>
      174e998e
    • Gunnar Sletta's avatar
      Fix pixelgrid snapping of native text on retina displays. · 6e883c53
      Gunnar Sletta authored
      Change 63e6c9ad
      
       introduced snapping to
      the pixel grid in the vertex shader for native text, but this code was
      broken on retina displays because it assumed integer only positions.
      Fix it by including the retina scale factor into the rounding.
      
      Task-number: QTBUG-38702
      Change-Id: I84492b02d64f263c9fe030790e04cf79b0dc4e2f
      Reviewed-by: default avatarEskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@theqtcompany.com>
      6e883c53
    • Eskil Abrahamsen Blomfeldt's avatar
      Relayout rich text when width increases · e3c6f397
      Eskil Abrahamsen Blomfeldt authored
      
      In updateSize() we were trying to force relayouts for RichText
      when the width changes by always setting widthExceeded to true.
      But further down in the same function, we overwrote this
      with textWidth() < idealWidth(), which doesn't work, because
      both properties are the wrapped width of the document and
      should only differ if the text cannot be wrapped properly.
      
      The result was that when increasing the width of a Text element,
      we would hit the optimization and skip the relayout.
      
      [ChangeLog][Text] Fixed Text with the RichText format to
      correctly update wrapping when the width of the element grows.
      
      Change-Id: I5fd87052a5ba7e8ee2549be0cfac4adc8ddf8290
      Task-number: QTBUG-33020
      Reviewed-by: default avatarSimon Hausmann <simon.hausmann@digia.com>
      e3c6f397
    • Laszlo Agocs's avatar
      Remove unnecessary doneCurrent in QQuickWidget · 0fc6e4b2
      Laszlo Agocs authored
      
      Excessive makeCurrent - doneCurrent pairs should be avoided. We already
      do this in QOpenGLWidget and the QPlatformBackingStore composition code.
      Remove the doneCurrent from QQuickWidget too.
      
      Change-Id: I6f998d381c33880c470f34d7c8462b6ed8cd8ae9
      Reviewed-by: default avatarGunnar Sletta <gunnar@sletta.org>
      0fc6e4b2
    • Venu's avatar
      Doc: Fixed an error in the QML snippet · 0c8bb607
      Venu authored
      
      Also updated the C++ snippet to look like a
      gui app that shows the QML example, instead of
      a console app that just provides the context data
      to the QML example.
      
      Change-Id: I17aca9f03521cfcadba1a965a4924e87cbf14c62
      Task-number: QTBUG-41699
      Reviewed-by: default avatarTopi Reiniö <topi.reinio@digia.com>
      0c8bb607