- 16 Sep, 2014 - 5 commits
-
-
Eskil Abrahamsen Blomfeldt authored
While we protected against the the borders exceeding the size of the source image when deciding whether to create a given patch, we did not protect against the case where the target rectangle is smaller than the borders. To fix this, we simply move the calculation of the target rectangle up to before we create the nodes, and check for isEmpty() before creating the nodes. In addition, we did not properly handle changing the borders dynamically. The subtree has to be rebuilt if the borders change so that the source or target rectangles change. Change-Id: Ia6a0df616ebbd0a32924de0b63fd48043027930a Task-number: QTBUG-41338 Reviewed-by:
Gunnar Sletta <gunnar@sletta.org>
-
Richard Moe Gustavsen authored
If the text cursor changes position by indirect manipulation of the document that backs a QQuickTextControl, we need to inform that the cursor rect changed as well. This will fix a bug with QQuickTextEdit that caused the platform input method to be out of sync since the cursor rect signal was never emitted from the the text control. Task-number: QTBUG-41042 Change-Id: Idcf35a2d51c8dffcb80ba21f8e59a61e04e5a879 Reviewed-by:
Andrew den Exter <andrew.den.exter@qinetic.com.au>
-
Ulf Hermann authored
0/0 is not always a red pixel after rendering "Hello" in red. The chosen font has an influence on that. Looking for some red pixel in row 0 is pretty safe. Change-Id: I669548c3c9d8cd25d720998fd9ba31c1f480e4e3 Reviewed-by:
Simon Hausmann <simon.hausmann@digia.com>
-
Ulf Hermann authored
In the case of derived classes (like the only user of QQmlThread) we cannot guarantee that the class is completely constructed when the thread starts. This includes the vtable which is necessary to decide which virtual functions to call. Change-Id: Ieaea67a72cc3b4f845b8621b34ca2928185917fb Reviewed-by:
Simon Hausmann <simon.hausmann@digia.com>
-
Ulf Hermann authored
200ms can be too short if the system is busy Change-Id: I4f9c6bcbec93d511b5b5e9d531450f3ffd22cb0c Reviewed-by:
Simon Hausmann <simon.hausmann@digia.com>
-
- 12 Sep, 2014 - 3 commits
-
-
Gunnar Sletta authored
Change-Id: Iae934e4d9e91f4ea21dd5bf27c4fafc5d481fb0a Task-number: QTBUG-41278 Reviewed-by:
Laszlo Agocs <laszlo.agocs@digia.com>
-
Simon Hausmann authored
We require at least 256 kbytes slack stack space, and if a system is configured with less (or equal), then the stack size checks fail early on and strange error message occur during engine startup and execution. This patch calls the stack check code early on and bails out with an error message that's more descriptive. Change-Id: I3263f2f93f62332d08003411e1bb5b3b1140d02b Task-number: QTBUG-41213 Reviewed-by:
Lars Knoll <lars.knoll@digia.com>
-
Mitch Curtis authored
For those clicking directly on specific property links who might not know that the info they need about event order already exists. Change-Id: I18a9124697f542f5b3a2955ee10dfee538a93385 Reviewed-by:
J-P Nurmi <jpnurmi@digia.com> Reviewed-by:
Topi Reiniö <topi.reinio@digia.com>
-
- 11 Sep, 2014 - 17 commits
-
-
Tasuku Suzuki authored
Regression introduced in 81ba77d7 Task-number: QTBUG-41241 Change-Id: I9a65af6915325e1cbf9205c7da94273d5b91b310 Reviewed-by:
Gunnar Sletta <gunnar@sletta.org>
-
Tasuku Suzuki authored
Change-Id: I60d0494ff8d619cb9be8d7a5db712c1316450b97 Reviewed-by:
Gunnar Sletta <gunnar@sletta.org>
-
Andy Nichols authored
A QQuickWindow with a valid QSGRenderContext is what should be checked for in QQuickCanvasItem::itemChange. Change-Id: Ibb85c2bb79d85b2d91b5d68cfa8a4760106047ae Reviewed-by:
Gunnar Sletta <gunnar@sletta.org>
-
Ole André Vadla Ravnås authored
Task-number: QTBUG-41167 Change-Id: I696fbb7400215c7f1fb8cb2a1dbbc0780440a8c3 Reviewed-by:
Simon Hausmann <simon.hausmann@digia.com>
-
Andy Nichols authored
We can not assume that there will be a current OpenGL context to use in QQuickImageParticle so now there is a check before we make a call to the current context. Change-Id: I0c77895d0b0f1afdf4853c0486fba0ef9a7b883d Reviewed-by:
Lars Knoll <lars.knoll@digia.com>
-
Venu authored
Task-number: QTBUG-37203 Change-Id: I62664b5dd0041cf8ba210dc3f0375793f7c72a00 Reviewed-by:
Nico Vertriest <nico.vertriest@digia.com> Reviewed-by:
Martin Smith <martin.smith@digia.com>
-
Ulf Hermann authored
Some features, like the memory profiler, create huge amounts of data. Often enough, we're not actually interested in all the data available from the profiler and collecting it all can lead to excessive memory consumption. This change enables us to optionally turn various aspects of QML profiling off. Task-number: QTBUG-41118 Change-Id: I7bb223414e24eb903124ffa6e0896af6ce974e49 Reviewed-by:
Gunnar Sletta <gunnar@sletta.org>
-
Gunnar Sletta authored
It was wrong when we ran without depth buffer or when we used the separate ibo code path. Change-Id: Ie6e4bfc99ee2a4a593e45be7d9af9af17896bcba Reviewed-by:
Laszlo Agocs <laszlo.agocs@digia.com>
-
Gunnar Sletta authored
The implementation relied on the full matrix, but did not set the RequiresFullMatrix flag. Setting the flag would have serious negative performance impact as it prevents batching, so we solve it in the vertex shader instead. Task-number: QTBUG-38702 Change-Id: I0c245ea9e18b0b29dd9e3073a2648a7f4e061685 Reviewed-by:
Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@digia.com>
-
Lars Knoll authored
The methods where converting doing a localtime->UTC conversion even though the input was already in UTC. Task-number: QTBUG-38448 Change-Id: I4409275fade0dd2a677af2293edc87445f853879 Reviewed-by:
Simon Hausmann <simon.hausmann@digia.com>
-
Lars Knoll authored
Always convert null to a QVariant(VoidStar) as documented in QJSValue. Make sure the reverse conversion will lead back to a null JS value. Adjusted two test cases that expected an invalid QVariant when setting the property to null, and added test cases for the correct conversion. Task-number: QTBUG-40880 Change-Id: I6eb01f0067f2c89779c53fd2cd0a1193047ed2cc Reviewed-by:
Simon Hausmann <simon.hausmann@digia.com>
-
Simon Hausmann authored
When a QML singleton file accesses itself, we would hit incomplete type data. Task-number: QTBUG-41220 Change-Id: Id0bd5fd71cf9be21f7e4ad8527fa8724a718d702 Reviewed-by:
Michael Brasser <michael.brasser@live.com>
-
Simon Hausmann authored
-
Mitch Curtis authored
Change-Id: I07e66deb4b21eca191c17532749eeccd33d83fb0 Reviewed-by:
Mitch Curtis <mitch.curtis@digia.com>
-
Mitch Curtis authored
Change-Id: Ifba60b729c8ad02009cd5c8caa5d58e20a76c73b Reviewed-by:
J-P Nurmi <jpnurmi@digia.com>
-
Mitch Curtis authored
toBoolean() isn't even a function in that class, and declaring the button on the stack causes crashes upon closing the application. Change-Id: I063cac2bb144cfb9786f20bbc122d5af92a4c2c0 Reviewed-by:
Jędrzej Nowacki <jedrzej.nowacki@digia.com>
-
Richard Moe Gustavsen authored
Change-Id: Idf854ad4f868e873582731dfa6b0253ac5b17c5c Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@digia.com>
-
- 10 Sep, 2014 - 8 commits
-
-
Laszlo Agocs authored
Provide a section similar to the one in the QOpenGLWidget docs. Change-Id: Ibe161f5b6e1b6654e78b522f44ba21b89fc85abe Reviewed-by:
Mitch Curtis <mitch.curtis@digia.com>
-
Laszlo Agocs authored
Change-Id: I904782e6a54c8df63a2e187cdfed5a3193ff2a54 Reviewed-by:
Paul Olav Tvete <paul.tvete@digia.com>
-
Laszlo Agocs authored
Remove the red rectangle. Change the background color to a gradient. (taken from rendercontrol) Disable the transparency checkbox everywhere but Linux since it usually will not work. (too much hassle with platform specifics like frameless windows, etc.) Change-Id: I21488386cddc5841a2bdc8104e7abb197b075b0d Reviewed-by:
Paul Olav Tvete <paul.tvete@digia.com>
-
Erik Verbruggen authored
Tell the compiler to schedule the int32 case first, tune the double conversion a bit (int64->double is quite expensive), and write the function in such a way that it matches typical overflow idiom which compilers recognize. Change-Id: Ieae9a60275716002fbdbc54e1d7291c8aad8c927 Reviewed-by:
Lars Knoll <lars.knoll@digia.com>
-
Richard Moe Gustavsen authored
Calculating the height of the line using ascent + descent seems inaccurate, since the result will not match what ends up being drawn. QQuickTextEdit uses instead QTextLine::height() for the same function, and this works correct. Since there seems to be no reason to reinvent how to calculate the height when the line already has a function for that, and since the result also seems to be wrong, we change the implementation to use QTextLine::height(). Change-Id: I9c9cd4360b6d4cfd3582756c4efdff9c02065789 Reviewed-by:
Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@digia.com>
-
Ulf Hermann authored
QCoreApplication complains about that. The context will only be valid once it has been requested in one way or another. Change-Id: Idb44f2541d71355443a5b491078a3040907b1614 Reviewed-by:
Gunnar Sletta <gunnar@sletta.org>
-
Eskil Abrahamsen Blomfeldt authored
This test gives false negatives blocking CI consistently. Change-Id: Id904f147b720a183167f335ee4db856d7e3ca94d Task-number: QTBUG-41228 Reviewed-by:
Gunnar Sletta <gunnar@sletta.org>
-
Eskil Abrahamsen Blomfeldt authored
Keeping all patches of the border image in the same texture with different sample points can cause parts of the border to bleed over to the center patch. To rectify this, we create a separate texture for each of the nine patches we need, and separate image nodes. To avoid applying antialiasing on the interior edges of the border image, we introduce new antialiasing flags which can be used to specify precisely which edges of the image should be antialiased. [ChangeLog][BorderImage] Fixed possible pixel bleed between border patches and center patch in BorderImage. Change-Id: Icc292b3969217320eecca99e79675316c42eab08 Task-number: QTBUG-35838 Reviewed-by:
Gunnar Sletta <gunnar@sletta.org>
-
- 08 Sep, 2014 - 1 commit
-
-
Simon Hausmann authored
Conflicts: .qmake.conf src/qml/jsruntime/qv4arraydata.cpp src/quick/scenegraph/util/qsgatlastexture.cpp Change-Id: Ic4c96066d5c37dcf0d5446baed590ea005d445ce
-
- 05 Sep, 2014 - 2 commits
-
-
Erik Verbruggen authored
When importing a JS library into a QML file with the "import" keyword, that JS file was parsed in QML mode, disallowing QML keywords like "as". Task-number: QTBUG-40143 Change-Id: Ie98adceb27544732c2e96657d41170db36bff288 Reviewed-by:
Simon Hausmann <simon.hausmann@digia.com>
-
Topi Reinio authored
Linking to 'Qt Namespace' will link to the Detailed Description section on the Qt namespace doc. Use the new linking format to link to the start of the page instead. Change-Id: Ib7e1b2b91fd9987262fc1a083ae94ef086260766 Reviewed-by:
Martin Smith <martin.smith@digia.com>
-
- 04 Sep, 2014 - 2 commits
-
-
Shawn Rutledge authored
It was giving up too early because qmlscene_??.qm doesn't exist. The file qt_??.qm links to all existing Qt-provided translation files, so it is enough by itself unless there are application-specific translations besides. Change-Id: Iebedf54ddb4eef4f4d7da8a7fade1850a366aee8 Reviewed-by:
Jan Arve Sæther <jan-arve.saether@digia.com>
-
Richard Moe Gustavsen authored
Without this patch, positionToRectangle will return a slightly different rectangle than what ends up being drawn. Change-Id: Ib1a3936f0fab393d6016d85d63547ec7f3036b7a Reviewed-by:
Andrew den Exter <andrew.den.exter@qinetic.com.au> Reviewed-by:
Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@digia.com>
-
- 03 Sep, 2014 - 2 commits
-
-
Olivier Goffart authored
Without this, the next click is not received after the windows loses focus while we double clicked but not released the mouse. This may happen if the onDoubleClicked opens a new window Change-Id: I86742de2bb1ea4c9657b9d5e90472d093293177d Reviewed-by:
Alan Alpert <aalpert@blackberry.com>
-
Gunnar Sletta authored
For a testcase with thosands of items, I measured an increase in shutdown time from 800ms to 7500ms, all spent in disconnect(). This is not acceptible, so we're choosing a different approach. If items implement a invalidateSceneGraph slot, this function will be called during shutdown. It should be made a proper virtual in Qt 6. This approach costs very little. Change-Id: I5970143cc0a0744955687e17586f0bb00c9afb26 Reviewed-by:
Lars Knoll <lars.knoll@digia.com>
-