Commit ab940d8f authored by Jesus Fernandez's avatar Jesus Fernandez
Browse files

Resource leak fixed


CameraBinV4LImageProcessing::setParameter was leaking the resource fd
in some cases in the switch using return instead of break.

Change-Id: Ie56eaf4cf1d1b7531094c321f49a818632985628
Reviewed-by: default avatarYoann Lopes <yoann.lopes@qt.io>
Showing with 4 additions and 1 deletion
......@@ -194,8 +194,10 @@ void CameraBinV4LImageProcessing::setParameter(
const QCameraImageProcessing::WhiteBalanceMode m =
value.value<QCameraImageProcessing::WhiteBalanceMode>();
if (m != QCameraImageProcessing::WhiteBalanceAuto
&& m != QCameraImageProcessing::WhiteBalanceManual)
&& m != QCameraImageProcessing::WhiteBalanceManual) {
qt_safe_close(fd);
return;
}
control.value = (m == QCameraImageProcessing::WhiteBalanceAuto) ? true : false;
}
......@@ -214,6 +216,7 @@ void CameraBinV4LImageProcessing::setParameter(
break;
default:
qt_safe_close(fd);
return;
}
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment