the pipe can be read in one swoop.

Change-Id: I72f87996d26663d0203404e77d47e130046845b7
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>

for loops seem to have some really weird scoping rules.

Change-Id: I23d0ee41fb9035545b483c60ad71a9eda50d59b6
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

eat the trailing whitespace, to avoid that the other ws checks trigger
on it again.

Change-Id: Ibaafcf2bf4e0857b61e2f5cd044e4fac84865850
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: I79ded5e4a437e84d444f98e20c70bef023f66398
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>

produces JSON object that is accepted by gerrit >= 2.6.

Started-by: Orgad Shaneh <orgad.shaneh@audiocodes.com>
Change-Id: I7e9bf99d18beadac8a715e10e4f241c953442d16
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: Ia90528e1747c7f9ea46418c7814584cc9220d483
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

instead of dumping everything straight to stdout, buffer it in a hash
first.
there are multiple advantages:
- in some cases, we'd get line-less complaints only after ones with
  lines, which would look funny. the buffering allows us to sort the
  output.
- different output formats will be easier to implement.
- the output code is cleaner, as it can hold the state more locally.

Change-Id: I0b558ecb58cf4d44a7efbd5a13a79349c55283f9
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: I38ecc06bfc8d24f1df89812a8b86bd78970e095b
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: I19567aadfe2e094fb4d25d3302603e96a9b374fa
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

put it in line with how the style checking is reported.

Change-Id: I9a081a3a9f5c1a06aad30e9e487650333bd812c1
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: Ibf68632ea8a8d9216235b64bda1757d110cf24ad
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

there is no real reason to maintain the order of files, so we can just
use the sorted keys of ws_lines.

Change-Id: Id973fcf1fec6995a931dee665303fb58074bc320
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: I999434f1953896d0bd0d2328176df65b05d63855
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

it actually relies on $_ anyway

Change-Id: I17f48f1d50c20936ffd27a06bfb826be7c3bdd7f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

they are generated, and we need to check them in.

Change-Id: Ife8bd4a820c5a29ac9e28ce6af102d30577df4cb
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

xcode always omits it.

Change-Id: I37b1e799d08d595aee4c227f9ed7af3eca69a6b8
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: I6ad9c682697e80e175cb19d67d3167c1756cd311
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>

Submodules that have no changes actually show up with space in front of
the sha-1 which would mess up the logic when splitting by spaces.

Change-Id: I15506c6e3780efb29d885ff456ecfac60526c03d
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>

Change-Id: Ia8fb489715e2ba0f0c29ad76ada20800a1ab5c54
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>

- Added LICENSE.LGPLv21, LICENSE.LGPLv3 & LICENSE.GPLv2

Change-Id: If5b04ddf25095ae1eb59e25361c88e570bb2b4df
Reviewed-by: Antti Kokko <antti.kokko@digia.com>
Reviewed-by: Tony Sarajärvi <tony.sarajarvi@digia.com>

These files are only edited in Xcode in practice, which uses tabs.

Change-Id: Id13d2dc6c40955288041aeaee37282d41e9026f3
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

Change-Id: I3f12d4ce0653b31ca397167a40303b764bdf7472
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>

i considered making --draft the default. however, i didn't like the
change of default behavior.

then it occurred to me that automatically detecting WIP subjects like
the sanity bot does would actually fit our current workflow pretty
neatly.
we are looking only at the last commit, as that's likely to be the one
which is WIP. also, in "unbased" push mode, determining the start of the
range to look at would cause quite some overhead.

Change-Id: I70f6f397693f600b6a5d5791f04d9cae12fa8d02
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>

at the moment the primary effect of this is ensuring early that we are,
in fact, inside a git clone.

Change-Id: I265631a0f4a025b09556ccbb9bfd735973d66d78
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>

Change-Id: Id49de348f8808a9786616e512636c08eb4d6ef6d
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>

properly quote where necessary and space-separate, instead of
comma-separating.

Change-Id: Ibf2e638d92591700c3a26f3402f306f5995552ad
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>

Change-Id: Ia6b72ca42e2493842e228269728be46dd2eaf1df
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>

Change-Id: I4d210bd3c896bb5d1cb13b4d38a08bfb317f4150
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>

object-orientation just adds another layer of obfuscation to perl code,
and really doesn't pay off for such short scripts.

Change-Id: Ibe620839cea9b2cf0b2ff56257e13071535bd3a8
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

Change-Id: I729dc9f37f604d7a7ed97ddb7395080b3afa3b3e
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>

Change-Id: I019707fa3ca050fc9da8fb95b00766f661447223
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: Ia5ca3a45702c52895f084f7f4bbe57ddb673b5ac
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

Change-Id: I67dc5f1a1febeee8465abf34d0cb35bde1a868b9
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

it's supposed to match a literal dot

Change-Id: I4bee3571a4239ec08a14ed18e409f97b4455f928
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>

Change-Id: I2f3feab4a8396d73c8e3313731427061534536a4
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>

people sometimes get creative

Change-Id: Idcb52ca5a4cc0561d80f6b8c74010d701c854dc0
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>

otherwise we complain about the missing newline at the end, which is
pointless (arguably, git is being stupid here in the first place, but
whatever).

Change-Id: I51bc49825c2a74b26691927660a6771a3925af7d
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>

it is expected to be a [ChangeLog] tag, not a ChangeLog footer.

Change-Id: Iaf5bb09976ecfbd4d7cbde9eaf303f682aa14f58
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>

Change-Id: I223eaf32782b2c0d2de3a815e0968706bfff1bdb
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

urls to reviews should be replaced by sha1s of merged commits.
urls to jira tasks should be replaced by task-number footers.

the rationale is keeping the history relocatable, and somewhat
independent from the infrastructure's software.
also, urls are pretty noisy.

Change-Id: I4b2c9ded8cbc02ca96daa4a2ff92c98c0a4b05f9
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>