Commit bd38f7bb authored by Oswald Buddenhagen's avatar Oswald Buddenhagen Committed by Oswald Buddenhagen
Browse files

nuke pointless intermediate


the pipe can be read in one swoop.

Change-Id: I72f87996d26663d0203404e77d47e130046845b7
Reviewed-by: default avatarOswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
parent d2b1eeab
No related merge requests found
Showing with 4 additions and 2 deletions
......@@ -137,13 +137,15 @@ sub process_commit($$$$$)
my $worker = $WORKER;
$worker =~ s/\@SHA1\@/$rev/g;
open VERDICT, $worker." 2>&1 |" or die "cannot run worker: ".$!;
my @verdict = <VERDICT>;
{
local $/;
$verdict = <VERDICT>;
}
close VERDICT;
die "Worker for commit ".$ref." in ".$project." crashed with signal ".$?.".\n" if ($? & 127);
$score = $? >> 8;
die "Worker returned invalid score ".$score." for commit ".$ref." in ".$project.".\n" if ($score > 20);
$score -= 10;
$verdict = "@verdict";
if (length($verdict) > 20000) {
$verdict = substr($verdict, 0, 20000)."\n\n**** Output truncated. Fix the problems above to get more output.\n";
}
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment