Change-Id: I3d34f98c0f6b8abb6fcfb6846edab4c3dd9a4b45
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

Change-Id: Icc4dfd681017ff07ab34444004d0259579fe9949
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

messages like "Adding big file (49KiB > 50kB)" are a tad confusing.

Task-number: QTQAINFRA-485
Change-Id: If3ce78b47be8ba2e64075553abab7236044fb57a
Reviewed-by: Sergio Ahumada <sergio.ahumada@digia.com>

Change-Id: Ic15a8917b8b09d45f608123eab83b08079b837d6
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

It's more or less pointless to complain about these.

Change-Id: I85099cc3a267ab41915552a73c6b6c8c7fcb9ae8
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

the priority argument is not the gerrit score, not even inverted ...

Change-Id: Iec9081449bc9113715b68d2f7268939f6b568fef
Reviewed-by: Sergio Ahumada <sergio.ahumada@digia.com>

Detect and complain about various English spelling errors/typos.
The spelling error dataset comes from the Lingua::EN::CommonMistakes
CPAN module; the feature is silently disabled if that module is not
installed.

Change-Id: Ie67984e43803683477549926cb39c61b96549966
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

Change-Id: I670423c6001e2a504df8be80b42ee88566ad3baa
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

Use a single variable for the current line number of the commit message
and of the current file, in preparation for new checks which use this information.

Note that $lineno always counts from 1. Previously, $ln counted from 0 while
$lineno counted from 1.

Change-Id: I3a87d29df1378e304a27a7672630f0319dc863a2
Reviewed-by: Sergio Ahumada <sergio.ahumada@digia.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

Change-Id: I1cec04e8763c6102b485638058df37d9093ed859
Reviewed-by: Lars Knoll <lars.knoll@digia.com>

options are stored in as git options in the group sanity.<dirname>, with
<dirname> being the basename of the repository.
it is recommended that these keys are added to the global git config,
outside the clones of the inspected repos.

the only currently recognized option is "flags", which corresponds to
the GIT_PUSH environment variable.

Change-Id: I011d4f335ca94b5aa08fc9bcb6283e6c2f7b3b79
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>

Change-Id: I586495e5b9d2561be6c8c16e6824a21af674f044
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>

Change-Id: I000026d8b78deef11245cdc939d9c06eebe676c0
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>

these files are really Makefiles, so complaining about tabs in them is
counterproductive.
the regexp will catch debian.rules as well, which is the convention
found in obs.

Change-Id: I4487a964468f2d3fbf3cad9c91be06ebfdcfaefb
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>

Change-Id: I69bf891d90a5f1bffea2aee16c46e651207405e3
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>

Don't check for tabs in these files.

Change-Id: Ide8101aade4114074293b71c6a397a25b9d2b660
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>

Change-Id: I8d2cc9e590c54109fc86093274995f9e9508a768
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>

it's pretty pointless to do so.
we keep the exclusion of VS projects and creator (and VS) user files,
though, as they clearly don't belong into a repo, and the "generated
file" checker wouldn't catch them.

Task-number: QTQAINFRA-425
Change-Id: I82a082923d51375270fb7ae436d94bfeb2148a9d
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>

to keep the noise down a bit

(cherry picked from commit b46872c68681ebe4528edafc8e8df912d0d112fa)

(cherry picked from commit d7b51b5dcb5cb253c0fa53723dafc72a633fc09b)

ELF exes typically have no extension, so they have no filename check.

(cherry picked from commit 1ca6a72aaa2b1f12ef5ec4b46a3976fffdd866c9)

there is no reason to suppress the "2nd line not empty" message just
because the summary was too long.

(cherry picked from commit cf1f2aca6bee87dd979ee0da72ee1c357dc95af5)

it may in fact make sense to disable most checks for reverts. but then,
there is no reason why the restored code should be just as bad as the
original one, so leave them in.

(cherry picked from commit 54ee24f2109e0b2b4a3ff2eee34c35b4c5663164)

(cherry picked from commit 346c1887237ce9e44543e5bcb0b3a958b809ad81)

branch names can contain "wip", which triggers false positives.
let's assume that nobody will actually keep around wip merges, so just
disable the check for merges completely.

(cherry picked from commit a7f118d1b92d4aa26a8e3fbe978ba75c4075835e)

(cherry picked from commit d326a1cc11c5c3bed3733db85a1f52b20fee093e)

people are confused if it says "wip"

(cherry picked from commit 1eba816a7ba2dd1acf4dcdba722fbdfa21ee97a5)

so it's only comments ... so what?

we got them for squish now

this requires that diffs are created with "infinite" context, otherwise
we don't see the start of the file unless it changes. also, the regexp
needs to run over all lines, not just the added ones.

- three instead of two possible exit values (ok, complain, block)
- no commit header (that's implicit from the context)
- no line prefixes (html frames it well enough)