Sanity-bot regards *.pl as C-like code; unlike the other kinds of file
it regards as C-like, perl scripts are sensible things to make
executable.  So make an exception for them.

Change-Id: Ibbfea2149a3b735baac4424af51b55bcb5bca090
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>

Only shows author date instead of commit date for changes. And
better to make sure rerere.enabled is disabled when analyzing
the conflicts.

Change-Id: I4268b55efb39cc94572117e46686cd5eaa6233c6
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>

Create a WIP change when conflicts arise.

Change-Id: Ifd9f4c78df3491642241754b256ac623399158cf
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>

Change-Id: Ied3d6b8ce07473611515b99d68b19fdf8fe6f283
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>

Change-Id: Ib57adfb3082e6937a3e4983e93629a299b0b6fe8
Reviewed-by: Jake Petroules <jake.petroules@qt.io>

Change-Id: I3a38d2dedc96bbe4aa814ceb008f1b08982fe586
Reviewed-by: Jake Petroules <jake.petroules@qt.io>

Alongside misguided execute permissions, check for set*id permissions;
git won't propagate them, but there's no way they're a good sign.

Change-Id: Ie3499ec79fd275d6f9cd0cb331c9cf2165ba7949
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>

Even scripts normally shouldn't be executable unless they start with a
suitable #! line (although sometimes they'll be run explicitly via
their interpreter).

Change-Id: I8d3371199d6f51e79f1d9ab051086448ee9c2b95
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>

Sporadically someone commits a source file, image or similar with
execute permission.  Let's catch that when it happens; I'm
getting bored of fixing it after the fact.

Change-Id: Ifb8be33f3d0be48466d5613efac09ed6a42fc3e5
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>

The base directory for making the symlink target absolute is of course
the dirname of the original file, not the target itself.

Change-Id: Ide12b77a724aa9f1fcb2512cbd0ada2a98f44303
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>

They were declared alongside some globals used across a broad span of
the file; but were only used locally to the parsing of the commit
message.

Change-Id: I9ad563dbdfba6451d934b153f0b5d8cd833c7da8
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>

Added by the new configuration machinery.

Change-Id: Idf652e104dd6973fd60b099fd622d471a9dc89dc
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>

Markdown uses two trailing spaces for non-paragraph line breaks.

Change-Id: Ib5330fbd9cd4718a45afa62966be46c55a9db338
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>

Previously, the tool would not create the tracking branch of qt5.git.

Change-Id: I13b29852d71e3f56a0a3735c0141bb1366ebf1ec
Reviewed-by: Jan Arve Sæther <jan-arve.saether@theqtcompany.com>

The default config from webkit is
  ForEachMacros:   [ foreach, Q_FOREACH, BOOST_FOREACH ]

This commit adds few other Qt macros used in Qt for which the opening brace
needs to stay on the same line.

Change-Id: I0707879ee6abf1c150b2acc8c88315f3cca0d348
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>

It can be copied or linked to ~/.clang-format or
path/to/qt5/.clang-format

It is based on the WebKit style which is the closest builtin style to Qt.
Then it was adjusted to fit better to the existing Qt style.

The name starts with a '_' instead of with an '.' because I don't want
the file to be hidden in this repository. And clang-format both look for file
named '.clang-format' or '_clang-format'

Change-Id: I0dd561fa9b554331ceaf3a39ea7e3a78649e75c4
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>

Change-Id: Iaa8a4ff67e532b65d27c239f5623a00e4151a7cb
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>

Stray semicolon at end of line, testing len rather than the thing
itself.  Use elif rather than if nested within else; append to
existing lists rather than creating new ones by doing arithmetic.
Prefer .startswith() over comparing [0]; it can take a tuple of
candidates.

Change-Id: I8272e21cb237fe376d6ec097c6ae322adae00c65
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>

Swap the two branches of an if/else clause so that we can test a
positive condition that's simpler and easier to read than its negation.

Change-Id: I72aa0b6ba7eabfee4d9cb62cc9ff3daa4acafb76
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>

This makes it easier to document that you need one of them !
That wasn't obvious before ...

Change-Id: Id35ed832721781d26d02fd642162f9ec78821f8c
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>

It just duplicates the argparse.Namespace class that's used for the
default return from parse_args() anyway.

Change-Id: Id306acd5e0367105c9fdabd3806567158b06852f
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>

Change-Id: Ib237cd0dea97d6a750e490bf257de9f056533299
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>

The call to get_submodules() produced output distracting to those
needing help; move it later and simply set args.modules if unset,
instead of supplying the list as default to the parser.

Moved banner line after arg-parse, too, as it duplicates the help
message's description.  Added an epilog to the help message saying how
to invoke this script.

Change-Id: Ib970f7a9ffa235c9523256d4ccfee448afd37ab2
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>

it's kinda stupid to complain about something the commit template leads
one to do.

the wisdom of the template is debatable. github in particular will make
an ellipsis after column 69. and the official recommendation is 50.

Change-Id: I7a4aed1867f4f9ab15fe513b92b80c0eed37dd07
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

Trailing punctuation is unnecessary in subject lines. It's a title,
and titles do not end with periods. Also, it leaves one more char
to use for subject content without breaking line length.

http://chris.beams.io/posts/git-commit/



Change-Id: I63199b25373ae428e6417ab7d5e90470ce3dd42b
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>

Change-Id: I0d558fa1d81a265bceff0828fbeb5910693ee894
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>

Darwin for desktops is now called macOS.

Change-Id: I7dcfc37a14563398fede004951deec5c53cbd7b2
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>

See http://comments.gmane.org/gmane.comp.lib.qt.devel/25771



Change-Id: I2f9a90c76935c8ff1c1db094f6aa756a5ba92cbb
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
Reviewed-by: Sze Howe Koh <szehowe.koh@gmail.com>

Without supermodule integration, the changes are potentially harmful
for dependent modules.

Change-Id: Ie092275822fe3bf0e060c31bcfb7d520ac568b2a
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@theqtcompany.com>

it's too new for the perl version on the bot.

Change-Id: I18b92b5d2c802966e7ada59d80fd08b7bbcc3853
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Edward Welbourne <edward.welbourne@theqtcompany.com>

Some tools warn about them and they are (usually) superfluous.
Only tests if you have the ImageMagic package's identify command.
Ossi assures me this is adequately widely installed for Gerrit.

Change-Id: Icd6f47fb0695e287f7de9d45b3521c82cc85cecd
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>

most of the files in this list can plausibly appear as input for
QMAKE_SUBSTITUTES (or a similar mechanism).

Change-Id: Iae54b2e1a9f958e83ef9979818125ccaa7f511bb
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

the main change is that the worker code was rewritten in awk instead of
perl.

Change-Id: I57b8c887eec00c4baf92f96d366a5e91efb07dee
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

This makes the growing skip-list manageable again.

Change-Id: If418ed7d22411fda50a9e2ef8446954434524a2e
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@theqtcompany.com>

Update old header.LGPL3 to header.LGPL

Change-Id: Ic9b7de3ff8ad0e6f1c8477ced3d07f7e90f3dae9
Reviewed-by: Lars Knoll <lars.knoll@theqtcompany.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>

Change-Id: I2717a81cd4a1f3d2ca54e642cf65c334392bf72f
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>

the linefeed has already been chomp()ed at this point.

Change-Id: Id8060166a791a61b5c5edc051590924c313477b8
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

only this way we can ensure that we get it really verbatim.

Change-Id: I0d11a1b87fcacf7cc3b9473b05562f5af2b677d2
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: Ibe229236bc56e9b32dfd8c8f508bc8b7b0b4736a
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

this avoids that die if the worker emits any warnings or errors before
the verdict.

Change-Id: I7e5e6ec71983eb2352bf83e4a300c3a6e0a090c2
Reviewed-by: Orgad Shaneh <orgads@gmail.com>