- Oct 09, 2014
-
-
Jarred Nicholls authored
In order to support Fragment (#) based routing and history navigation together, canGoBack/canGoForward properties should be notified when the url is changed instead of when the page is loading. Task-number: QTBUG-41849 Change-Id: Ic995fffa5c683dade88fbd98ffea90527a77261b Reviewed-by:
Michael Bruning <michael.bruning@digia.com> Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com> Reviewed-by:
Jarred Nicholls <jarred.nicholls@gmail.com>
-
- Aug 21, 2014
-
-
Zeno Albisser authored
Change-Id: Idbe0eafb51d77cc00e3a93179b81770724d5bfaa Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com> Reviewed-by:
Tuukka Turunen <tuukka.turunen@digia.com> Reviewed-by:
Pierre Rossi <pierre.rossi@gmail.com>
-
- Aug 06, 2014
-
-
Andras Becsi authored
This is essential API that should be public. Change-Id: Ifbd86171933936112e2495ebed074faa2e52464d Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
Andras Becsi authored
Add missing navigationRequested API to be able to intercept navigation requests. This is useful for ignoring requests for example in kiosk-like applications that want to restrinct navigation to a specific url or domain, or want to disable specific types of navigation requests (e.g. reloading, clicking links, form submissions). Change-Id: Ie375e635a3c3566527972d05f5d99b39489c5ca8 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- Aug 04, 2014
-
-
Jocelyn Turcotte authored
Do the d_ptr magic ourselves to avoid having to include private headers from qtcore, qtgui and qtdeclarative. It is hackish to hide QObject's d_ptr member to have the macros working in a public class, but if anything goes wrong we just need to replace the private macro convenience while maintaining the binary compatibility of the stored extra opaque pointer. Change-Id: Idb92f4f902826bef9068a5c2ef6ea31fc3fa15b2 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- Aug 01, 2014
-
-
Jocelyn Turcotte authored
Fixes: - Make sure that we call SetInitialFocus when giving focus through Tab This does the same as would WebContents::FocusThroughTabTraversal - Implement QWebEnginePagePrivate::passOnFocus - Set each new RWHVQtDelegate as the focus proxy of the QWebEngineView - Make sure that the widgets delegate accepts the tab focus policy Cleaups: - RenderWidgetHostViewQtDelegateQuick doesn't need to be a focus scope, it doesn't have any children - We don't need to reimplement QQuickWebEngineView::forceActiveFocus since the view is now a focus scope - Do not explicitly setFocus(true) on the QQuickWebEngineView, the application should decide this through the API Change-Id: I817dc2c895d4fff4aa3536c71ecc5d306bb3bee0 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
Szabolcs David authored
This fixes the flaky QQuickWebEngineViewGraphics test and extends it with a new test case. Change-Id: I2d8a0762716cb9232fdea6473760e67ac2e7146d Reviewed-by:
Andras Becsi <andras.becsi@digia.com> Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- Jul 26, 2014
-
-
Frederik Gladhorn authored
With this patch the accessibility hierarchy inside webengine becomes accessible when navigating from Qt Quick based web views. Change-Id: Ic1c8caaa908bd32e4175ee9dcdb7a6bef89818b6 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- May 12, 2014
-
-
Michael Brüning authored
This keeps consistency with the other enum names. Change-Id: Idaedb8566fd770b05effeeba377b09a84bf0af12 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- May 09, 2014
-
-
Jocelyn Turcotte authored
The property is still not properly implemented and we'll make it first go through the experimental tryout like other APIs we add. Change-Id: I6eb99fcebb7ca1fc33338d786585cfe7fbc0afd4 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- May 08, 2014
-
-
Szabolcs David authored
Remove unreachableUrl support from WebContentsAdapter::setContent, because this argument behaves exactly the same as baseUrl. Change-Id: I36f92b99b7045c6d3b831481bb04d51a0e05772f Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- May 05, 2014
-
-
Szabolcs David authored
I dropped hovered title support from the QtWebKit API, it seems we don't need that logic. Change-Id: I5617c295344512a35aa526a6f1307f0b21f866d6 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- Apr 15, 2014
-
-
Jocelyn Turcotte authored
I initially misintepreted the meaning of the enum, assuming that it meant that the window should possibly be blocked. The user_gesture parameter in WebContentsDelegate::AddNewContents is actually doing this, while the popup disposition means that JavaScript requested the window to be opened without one of the standard decoration (i.e. status bar, menu bar, tool bar, etc.). Update the QtQuick API to reflect this, renaming the "isPopup" parameter to a more familiar "isUserInitiated". The popup disposition is named "dialog" to match the previous QWebPage::WebModalDialog enum. Change-Id: Ib0c4bc53671fcf0dd9499aa1be2bbc8c494ba49e Reviewed-by:
Michael Bruning <michael.bruning@digia.com>
-
- Apr 14, 2014
-
-
Michael Brüning authored
Translates the internally used LogSeverity values to enums defined by the QtWebEngine integration layer. Change-Id: I7da0983d4fb5c199e1a2436b5899a43cf6698784 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- Mar 13, 2014
-
-
Szabolcs David authored
The forceActiveFocus() doesn't work in the QML tests. We need to call forceActiveFocus() in RenderWidgetHostViewQtDelegateQuick instead of the one in WebEngineView. To make this work, I replaced RWHV with QQuickWebEngineView in the focus chain. This is necessary in order to extend tst_loadUrl QML test with urlProperty test case. Change-Id: Ifba0c824a7ce9f00d328110233402d3563f967aa Reviewed-by:
Zeno Albisser <zeno.albisser@digia.com> Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- Feb 25, 2014
-
-
Adam Kallai authored
Rename QQuickWebEngineView.loadingStateChanged signal name to QQuickWebEngineView.loadingChanged. Change-Id: I0e01034f7b2eea57f5211ff0d8258d9f27d278f0 Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- Feb 18, 2014
-
-
Szabolcs David authored
Patch by Jocelyn Turcotte This fixes the inclusion of private headers. Change-Id: I490336ac30571bf292d88e2747102c75027b8dc6 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- Feb 13, 2014
-
-
Jocelyn Turcotte authored
Improve the code and API in a few ways: - Expose a more discoverable "request" argument in the signal. - Use the request as the carrier of the backend WebContentsAdapter and get rid of our handle. - Put the adoption method (renamed to openIn) on the request object and keep the view API clean of a context-specific adoptHandle method. - Use an enum instead of strings for the new view destination. - Do not let JavaScript own the request object since it won't be necessary until we want to support asynchronous view attachment. We can create the request object on the heap and let the JavaScript engine own the object once we want to support it. - Move the request class to its own header. - Replace tabs.currentView by currentWebView in the quicknanobrowser qml code since we now need this property on the root object anyway. Change-Id: I40d7d15255f516ead9f3e414dd587bf345e6ca4b Reviewed-by:
Simon Hausmann <simon.hausmann@digia.com>
-
- Feb 11, 2014
-
-
Szabolcs David authored
Implement unreachableUrl support for WebContentsAdapter::setContent and add loadProgressAfterLoadHtml QML test case. Change-Id: I2d0d7834cbbf8f508de4fa9cb72240f2ac6ebf83 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- Jan 31, 2014
-
-
Arvid Nilsson authored
To support reparenting, we make the compositing surface independent of the window by using gfx::TEXTURE_TRANSPORT. We also need to be able to keep frame data across window changes so we can reconstruct the QSGNode tree in a new context, so extract that data into DelegatedFrameNodeData class. Any context-specific data is still stored in DelegatedFrameNode. Also hook up window changes to WebContents::WasShown/Hidden for Quick. Remove checking of Qt isVisible state, this mechanism is used to sync Chromium with Qt, not the other way around. WasShown/Hidden is orthogonal to Show/Hide, and can use different triggers. However for Widgets it probably makes sense to hook both up to widget visibility. Change-Id: I1ef4b50cd61b8e54b791e03f0b41929c42fec8bf Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- Jan 30, 2014
-
-
Pierre Rossi authored
And unskip the corresponding autotest. Change-Id: Ida2dcee38b261b2ba4ad0c5c016f5510ed1590a4 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- Jan 15, 2014
-
-
Adam Kallai authored
It contains information about a requested load of a web page. Change-Id: Ie45706adb51ee5bce98e7af01252d9a8389db57d Reviewed-by:
Pierre Rossi <pierre.rossi@gmail.com> Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- Nov 28, 2013
-
-
Jocelyn Turcotte authored
This only move files without adjusting any paths. This moves: - lib/quick -> src/webengine/api (API files) lib/quick -> src/webengine (other files) This contains the main QtWebEngine module library since <ec7b2ee7 >. - lib/widgets -> src/webenginewidgets Also rename this directory to match its module name and rename Api to api. - lib -> src/core - process -> src/process - resources -> src/core/resources - tools/* -> tools/scripts/ The build directory is spread as follow: - build/build.pro -> src/core/gyp_run.pro - build/qmake_extras/* -> src/core/ (for the host and target .pro files) - build/qmake -> tools/qmake - Build related scripts -> tools/buildscripts Change-Id: I0cded1de772c99c0c1da6536c9afea353236b4a1 Reviewed-by:
Zeno Albisser <zeno.albisser@digia.com> Reviewed-by:
Pierre Rossi <pierre.rossi@gmail.com> Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- Nov 18, 2013
-
-
Jocelyn Turcotte authored
Bring this QtWebKit concept to our API as well to contain APIs that we aren't comfortable adding to the supported-forever group yet and allow trying them out unofficially for an undetermined number of releases first. Change-Id: I52c8655dfd2996ea461ac6c00de975002827a4c3 Reviewed-by:
Andras Becsi <andras.becsi@digia.com> Reviewed-by:
Arvid Nilsson <anilsson@blackberry.com> Reviewed-by:
Zeno Albisser <zeno.albisser@digia.com>
-
Jocelyn Turcotte authored
Make the WebEngine QtQuick plubin library a library only that fetches the API privatly from the official module. This will allow an experimental plugin library to also have access to the API classes, which it currently can't since the plugins aren't deployed the same way as module to <prefix>/lib. The module currently only export classes privately but the plan is to make this library the official linking point of entry for applications along with the Qt5WebEngineWidgets module. The WebEngineCore library could eventyally be merged into this module library if we can get gyp to play well with qmake. Change-Id: I5edb60b412e213b59f791a7b8df9f28c295502de Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- Oct 29, 2013
-
-
Chris Hutten-Czapski authored
To implement the Web Inspector we need a delegate to handle the http server and devtools connections, a landing page, a ContentClient to tell the devtools server where to find its frontend resources, those frontend resources, and an API for embedders to turn on inspectability in WebEngineViews. The frontend resources are build by the chromium build and are copied over as part of lib's build. The landing page was taken directly from content_shell. This should be replaced by either a new one for all QtWebEngine embedders or by a mechanism for embedders to supply their own (or both). Change-Id: Id4076d5ede34a91abf8dba443aed4dca4be1b3e5 Reviewed-by:
Pierre Rossi <pierre.rossi@gmail.com>
-
- Oct 04, 2013
-
-
Arvid Nilsson authored
This exposes loadProgress in both widget and quick webengineviews. However, the progress will not change until we get an upstream change in Chromium where the content LoadProgressChanged API is exposed to all ports, not just Android. The upstream change is https://src.chromium.org/viewvc/chrome?revision=221010&view=revision Once we get that change, you'll see the widget example browser start to paint a blue progress rectangle in the background of the URL bar. Also, a progress bar was added to the quicknanobrowser, but it will be stuck at 0 for now. Change-Id: Icbaa01b86c013e0052b3abb7672c38e57128f44a Reviewed-by:
Zeno Albisser <zeno.albisser@digia.com>
-
- Oct 03, 2013
-
-
Arvid Nilsson authored
Adds a favicon API modelled after the WebKit2 QQuickWebView API, but using an http(s) URL instead of a custom protocol, because there's no icondatabase yet. The icon URL lingers even when a new load is committed, until the load finishes. It might be more prudent to clear the icon when committing a new load, but I opted to let the app take care of that detail if desired. Many browsers show a spinner instead of the favicon while loading, for example. There's no widget API implementation for favicons yet, because that API only makes sense if we have a full-fledged icon database (case in point: QWebEngineSettings::iconForUrl()). Change-Id: I1e7b85104c80de2ae46a5fe9a273104d43a5c71f Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- Sep 17, 2013
-
-
Michael Brüning authored
This should enable namespaced builds of Qt and QtWebEngine. Change-Id: I4c9d506d864b42a346026b980dcf3777b9680957 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- Aug 20, 2013
-
-
Jocelyn Turcotte authored
This follows the model used by the rest of Qt, potentially avoiding binary compatibility issues. The compromise is that we now depend on core-private, thus forcing us to follow Qt's release cycle. Change-Id: Ib2df51071fc35935ac99edf7b9c5562949cb43e2 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- Aug 19, 2013
-
-
Jocelyn Turcotte authored
Change-Id: I58d83f4f33728f92e4bf13b6be30b15528fdd033 Reviewed-by:
Zeno Albisser <zeno.albisser@digia.com>
-
- Jul 31, 2013
-
-
Pierre Rossi authored
This is the first step to making proper Qt Modules out of QtWebEngine. The Widgets integration becomes a proper C++ Qt Module while we make the QtQuick side a QML plugin for now (could probably be promoted if the need arises). Code-wise, this means the introduction of a WebContentsAdapterClient interface that is subclassed by the private implementation of our API classes for delegation of things that are UI specific. Functionality from WebContents and the like is exposed via the WebContentsAdapter. Change-Id: I4ca3395b9fe8502a24e36002cfd5af44067bb6e8 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- Jun 19, 2013
-
-
Jocelyn Turcotte authored
- Rename NativeViewQt to RenderWidgetHostViewQtDelegate to keep the context obvious. - Use an interface to handle the parenting instead of the NativeViewContainerQt mechanism that was needed with the Shell.
-
Jocelyn Turcotte authored
-
- Jun 18, 2013
-
-
Zeno Albisser authored
-
- Jun 11, 2013
-
-
Jocelyn Turcotte authored
Rename the class to WebEngineContext and keep it as a ref-counted member of pages instead. Also: - Change the user-agent product to QtWebEngine - Don't pass actual command line arguments to Chromium anymore - Allow attaching to the event loop through Before/AfterRun instead of blocking
-
- Jun 10, 2013
-
-
Jocelyn Turcotte authored
-
- Jun 06, 2013
-
-
Jocelyn Turcotte authored
This layers things properly to be able to implement the UI in the example application instead of directly in shell_qt.cpp. This is still using global variables to allow the Shell platform code to do callbacks to the API classes. This should go away once we properly implemented a WebContentsDelegate.
-
- Jun 05, 2013
-
-
Zeno Albisser authored
The current preliminary implementation uses the QQuickPaintedItem. The RasterWindow is being replaced by an abstract NativeViewQt class, which can be instantiated as QWidgetNativeView or QQuickNativeView. The NativeViewContainerQt builds a wrapper around an instance of these classes and serves as a common api towards chromium. Due to the current design where the view is being created by the shell, we introduce a browser_window.qml which provides a very basic browser UI. The content is then being injected into an item within that browser window. Just executing the example the "regular" way will launch the Widgets example. To launch the QtQuick2 example, the environment variable QQUICKWEBENGINE must be defined.
-
- May 31, 2013
-
-
Simon Hausmann authored
-