1. 07 Nov, 2014 - 1 commit
  2. 18 Sep, 2014 - 1 commit
  3. 29 Aug, 2014 - 1 commit
  4. 21 Aug, 2014 - 1 commit
  5. 12 Aug, 2014 - 1 commit
  6. 04 Aug, 2014 - 1 commit
    • Jocelyn Turcotte's avatar
      Don't inherit from Qt private types · 1c2a4da1
      Jocelyn Turcotte authored
      
      Do the d_ptr magic ourselves to avoid having to include private
      headers from qtcore, qtgui and qtdeclarative.
      
      It is hackish to hide QObject's d_ptr member to have the macros
      working in a public class, but if anything goes wrong we just
      need to replace the private macro convenience while maintaining
      the binary compatibility of the stored extra opaque pointer.
      
      Change-Id: Idb92f4f902826bef9068a5c2ef6ea31fc3fa15b2
      Reviewed-by: default avatarAndras Becsi <andras.becsi@digia.com>
      1c2a4da1
  7. 30 Jul, 2014 - 1 commit
    • Allan Sandfeld Jensen's avatar
      Add api to get the favicon URL · a99922af
      Allan Sandfeld Jensen authored
      
      Adds one of the missing pieces of the QWebFrame and QWebView APIs.
      Unlike the QtWebKit version this only fetches the favicon URL, and not
      the icon. This is because we do not want to implement an icon database,
      and that the icon would be loaded asynchronous anyway, bringing no
      guarantee to be a valid icon/image yet.
      
      Change-Id: I227311ae3676044da850e687b82bee752b5079c8
      Reviewed-by: default avatarJocelyn Turcotte <jocelyn.turcotte@digia.com>
      a99922af
  8. 10 Jul, 2014 - 1 commit
  9. 15 May, 2014 - 1 commit
  10. 12 May, 2014 - 2 commits
  11. 29 Apr, 2014 - 1 commit
  12. 15 Apr, 2014 - 3 commits
  13. 14 Apr, 2014 - 1 commit
  14. 28 Feb, 2014 - 1 commit
    • Jocelyn Turcotte's avatar
      Add HTTP and proxy authentication signals directly to QWebEnginePage · 970ccc7f
      Jocelyn Turcotte authored
      
      This allows handling calls that would be signaled by QNetworkAccessManager
      in QtWebKit.
      This pulls QtNetwork as a dependency of the QtWebEngineWidgets module
      to be able to use QAuthenticator, but isn't required otherwise.
      
      Only the request URL is available in the case of HTTP authentication
      (no access to HTTP request headers that the QNetworkReply would allow)
      and only the proxy host name in the case case of proxy authentication.
      
      This keeps the API synchronous the same way, as QtWebKit did, in
      favor of source compatibility at the cost of requiring a modal
      dialog, even though the implementation doesn't require it.
      
      Change-Id: I9e021def38e6107c9e66d2de8f86bd0328d543df
      Reviewed-by: default avatarMichael Bruning <michael.bruning@digia.com>
      970ccc7f
  15. 21 Feb, 2014 - 1 commit
  16. 13 Feb, 2014 - 2 commits
    • Jocelyn Turcotte's avatar
      Implement QWebEnginePage::findText · 324706a5
      Jocelyn Turcotte authored
      
      A few changes to the API:
      - Return the success result asynchronously.
      - FindWrapsAroundDocument and HighlightAllOccurrences are enabled by
        defaults and cannot be disabled.
      - Found text isn't updating the selection on the page like QtWebKit
        did, but triggers a separate state not available. A find count and
        current index could be exposed, but isn't in this case to keep the
        API delta lower.
      
      This also adds the possibility to pass bool results through the
      CallbackDirectory and add a new tst_QWebEnginePage::findTextResult
      test since the old test relied on the selection to be updated when
      the searched text is found.
      
      Change-Id: I8189b5aea8d832df183c6c1ae03e3f08198a9c45
      Reviewed-by: default avatarSimon Hausmann <simon.hausmann@digia.com>
      324706a5
    • Zoltan Arvai's avatar
      Fix QNetworkRequest usage in WebEngineWidgets on Windows · bbe7b24c
      Zoltan Arvai authored
      
      Changing unused variable suppression in acceptNavigationRequest
      is required for MSVC otherwise it fail with undefined type error.
      Also adding more suppression for unused wariable warning.
      
      Change-Id: Ic449973bc8166f18655e40bf57041b8f02869266
      Reviewed-by: default avatarJocelyn Turcotte <jocelyn.turcotte@digia.com>
      bbe7b24c
  17. 12 Feb, 2014 - 2 commits
    • Jocelyn Turcotte's avatar
      Fix tst_QWebEngineFrame::baseUrl · bf65a7dc
      Jocelyn Turcotte authored
      
      Update tests to check that we can keep the same functionality by
      querying document.baseURI through runJavaScript instead of implementing
      QWebEnginePage::baseUrl.
      
      This also removes QWebEnginePage::baseUrl from the header.
      
      Change-Id: I549e57d3986e22986438f8a23e469bbd220633b7
      Reviewed-by: default avatarPierre Rossi <pierre.rossi@gmail.com>
      bf65a7dc
    • Pierre Rossi's avatar
      [Widgets] RenderWidgetHostViewQtDelegate refactoring · 9c198939
      Pierre Rossi authored
      
      Break up the delegate implementation into two distinct subclasses.
      The first one offers a way for the WebPage to tap into the
      RenderWidgetHostView directly, while a different implementation
      that is backed by a top-level widget can be used to show WebUI
      popups on screen.
      
      This has the benefit of not having a child widget in the webview
      among other things. It also fixes our popups and allows them to fall
      outside the window frame.
      
      Change-Id: I80dc1e4f21bb91ff47c75a626d330f88eacce8c6
      Reviewed-by: default avatarJocelyn Turcotte <jocelyn.turcotte@digia.com>
      9c198939
  18. 30 Jan, 2014 - 1 commit
  19. 22 Jan, 2014 - 2 commits
    • Jocelyn Turcotte's avatar
      Implement QWebEnginePage::toHtml and toPlainText · 1fcd7970
      Jocelyn Turcotte authored
      
      Those methods are now made asynchronous and need to be given a
      callback to handle the result.
      
      Update the code in the browser and fancybrowser examples using
      std::bind when using C++11 or tr1::bind with C++03 (which should be
      available with compilers on platforms that we support).
      
      Add a (currently failing) earlyToHtml test to make sure that an empty
      page doesn't crash because of a possibly incomplete attachment of
      the QtRenderViewObserver.
      
      Change-Id: I3ab7cb6f25b91b584dd80df5e4e9ad1e3214348e
      Reviewed-by: default avatarPierre Rossi <pierre.rossi@gmail.com>
      1fcd7970
    • Jocelyn Turcotte's avatar
      Refactor the callback mechanism used by runJavaScript · 6d760436
      Jocelyn Turcotte authored
      
      This prepares the way for other API made async like toHtml and
      toPlainText.
      
      Use a callback class with an implicit templated constructor to carry
      the functor across the API boundary and avoid the intermediate helper
      method as the ABI that we have to maintain.
      
      Also pass the callback result through WebContentsAdapterClient using
      a bookkeeping ID instead of transferring the callback to
      WebContentsAdapter. This will allow other calls, which might not
      already allow passing a callback functor, to use a consisten way
      of carrying back the result to the top API layer.
      
      Change-Id: Ia923767b9c1021a108c26da17d4c41878ef7cb95
      Reviewed-by: default avatarPierre Rossi <pierre.rossi@gmail.com>
      6d760436
  20. 15 Jan, 2014 - 1 commit
    • Pierre Rossi's avatar
      [Widgets] wire the file pickers · c34b7218
      Pierre Rossi authored
      
      Introduce a new version of chooseFiles in QWebEnginePage.
      The existing API in WebKit1 seemed a bit dusty in any case (multiple
      only supported via extensions).
      
      Changes are:
        * oldFile becomes oldFiles, so that we could at a later stage expose
          the already selected files in the "multiple" case.
        * a type is introduced, for now limited to multiple selection, but
          over time, we might consider additions such as directory upload.
      
      Change-Id: I14cfea64ce95e892a0a1877c8cb914c5a421409f
      Reviewed-by: default avatarJocelyn Turcotte <jocelyn.turcotte@digia.com>
      c34b7218
  21. 28 Nov, 2013 - 1 commit
    • Jocelyn Turcotte's avatar
      Moving sources to src part 1: Move files. · fd61d752
      Jocelyn Turcotte authored
      This only move files without adjusting any paths.
      
      This moves:
      - lib/quick -> src/webengine/api (API files)
        lib/quick -> src/webengine (other files)
        This contains the main QtWebEngine module library since
        <ec7b2ee7
      
      >.
      - lib/widgets -> src/webenginewidgets
        Also rename this directory to match its module name and rename Api to api.
      - lib -> src/core
      - process -> src/process
      - resources -> src/core/resources
      - tools/* -> tools/scripts/
      
      The build directory is spread as follow:
      - build/build.pro -> src/core/gyp_run.pro
      - build/qmake_extras/* -> src/core/ (for the host and target .pro files)
      - build/qmake -> tools/qmake
      - Build related scripts -> tools/buildscripts
      
      Change-Id: I0cded1de772c99c0c1da6536c9afea353236b4a1
      Reviewed-by: default avatarZeno Albisser <zeno.albisser@digia.com>
      Reviewed-by: default avatarPierre Rossi <pierre.rossi@gmail.com>
      Reviewed-by: default avatarAndras Becsi <andras.becsi@digia.com>
      fd61d752
  22. 14 Nov, 2013 - 1 commit
  23. 13 Nov, 2013 - 1 commit
  24. 04 Nov, 2013 - 1 commit
    • Pierre Rossi's avatar
      Implement QWebEnginePage::runJavaScript · a99fdc02
      Pierre Rossi authored
      
      We can't have QWebFrame::evaluateJavascript in its old form for
      several reasons, the first of which being that we don't have a
      QWebEngineFrame class anymore. This is worked around by adding
      an optional QString parameter with the frame's XPath.
      
      Another issue is that the WebKit1 API was synchronous, and this would
      not play nicely with the very asynchronous nature of chromium we're
      now sitting on top of. In order to make this obvious when porting, we
      rename it to runJavaScript which doesn't return any result.
      
      This also introduces a template member function overload that will
      accept function pointers, functors and lambdas,much like Qt5's new
      signal/slot syntax, in order to get the result of the javascript
      evaluation back.
      
      Change-Id: I64e15a6f5a168936c52a4da2cef6285dfd16e0d5
      Reviewed-by: default avatarZeno Albisser <zeno.albisser@digia.com>
      Reviewed-by: default avatarAndras Becsi <andras.becsi@digia.com>
      a99fdc02
  25. 17 Oct, 2013 - 1 commit
  26. 17 Sep, 2013 - 1 commit
  27. 02 Sep, 2013 - 1 commit
    • Jocelyn Turcotte's avatar
      Implement window creation through QWebEnginePage::createWindow. · 7146fcc1
      Jocelyn Turcotte authored
      This makes the necessary changes to handle
      WebContentsDelegateQt::AddNewContents and funnel the callback
      through createWindow in QWebEnginePage and QWebEngineView.
      
      - Expose the AddNewContents callback through WebContentsAdapterClient
      - Allow creating a WebContentsAdapter attached only on the Chromium side,
        leaving the choice to QWebEnginePage to either adopt it and call
        WebContentsAdapter::initialize to attach itself as the client, or
        destroy it if the application isn't handling the call.
      - Delay the InitAsChild handling in RenderWidgetHostViewQt when
        it is called before an adapter client has been attached.
      - Since WebContentsAdapterClient::CreateRenderWidgetHostViewQtDelegate
        is only a factory method, not creating any link with the callee client,
        allow using the creating window's adapter client to create the RWHVQtDelegate.
        This allows an unparented delegate to be created instead of needing to
        add numerous null-checks in RWH...
      7146fcc1
  28. 20 Aug, 2013 - 4 commits