- 07 Nov, 2014 - 1 commit
-
-
Allan Sandfeld Jensen authored
The feature enum names and documentation gave the impression it could control audio and video output, while they only control input. Also removed documentation of non connected feature permissions for Notifications and GeoLocation. Change-Id: Ia35142ca691ebd6059b7472e9803fda8cbd84813 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com> Reviewed-by:
Pierre Rossi <pierre.rossi@gmail.com>
-
- 18 Sep, 2014 - 1 commit
-
-
Pierre Rossi authored
In the same fashion as what is done in QObject::connect's documentation, we can keep it simple here and simply document what is expected. Change-Id: I98a09280870cf0aab935fd0cb69401bb98134145 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- 29 Aug, 2014 - 1 commit
-
-
Allan Sandfeld Jensen authored
This adds API for overriding some certificate errors. Once overridden any identical error for the same hostname and certificate will use the same override. Similar API for QtWebEngine QML should be added in a later patch. Change-Id: I144147b86d9b592e3f87346a1e48890acee0c670 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- 21 Aug, 2014 - 1 commit
-
-
Zeno Albisser authored
Change-Id: Idbe0eafb51d77cc00e3a93179b81770724d5bfaa Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com> Reviewed-by:
Tuukka Turunen <tuukka.turunen@digia.com> Reviewed-by:
Pierre Rossi <pierre.rossi@gmail.com>
-
- 12 Aug, 2014 - 1 commit
-
-
Pierre Rossi authored
Implementing what is already available, namely the WebAttributes, font preferences and default text encoding, as well as a slightly different take on privateBrowsing. Change-Id: I128f060a4661d19aa1c9c4d6daae1f80fb33204b Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@digia.com>
-
- 04 Aug, 2014 - 1 commit
-
-
Jocelyn Turcotte authored
Do the d_ptr magic ourselves to avoid having to include private headers from qtcore, qtgui and qtdeclarative. It is hackish to hide QObject's d_ptr member to have the macros working in a public class, but if anything goes wrong we just need to replace the private macro convenience while maintaining the binary compatibility of the stored extra opaque pointer. Change-Id: Idb92f4f902826bef9068a5c2ef6ea31fc3fa15b2 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- 30 Jul, 2014 - 1 commit
-
-
Allan Sandfeld Jensen authored
Adds one of the missing pieces of the QWebFrame and QWebView APIs. Unlike the QtWebKit version this only fetches the favicon URL, and not the icon. This is because we do not want to implement an icon database, and that the icon would be loaded asynchronous anyway, bringing no guarantee to be a valid icon/image yet. Change-Id: I227311ae3676044da850e687b82bee752b5079c8 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- 10 Jul, 2014 - 1 commit
-
-
Frederik Gladhorn authored
With this patch the accessibility hierarchy inside webengine becomes available when navigating from QWidget based web views. Change-Id: Ib3625a6ec93b4d3f298fb845ab85209b348349ba Reviewed-by:
Zeno Albisser <zeno.albisser@digia.com> Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- 15 May, 2014 - 1 commit
-
-
Szabolcs David authored
Drop hovered title and link text parameters, as we did in the Quick API. Change-Id: Ia1a38e0d728afbcbb6858a890486772da74aa813 Reviewed-by:
Pierre Rossi <pierre.rossi@gmail.com>
-
- 12 May, 2014 - 2 commits
-
-
Jocelyn Turcotte authored
This value is only used internally by Chromium and risks being removed at anytime, for which we would then have to maintain a downstream implementation. Chromium also only supports frame values, while a complete support of the interface would require also supporting this xPath to point to individual document element by affecting the value of "this", the same way that QWebElement::evaluateJavaScript allowed in QtWebKit. Change-Id: Id0cb1b8e3bdf9a6db0ca786fb5eb46ffd726d165 Reviewed-by:
Michael Bruning <michael.bruning@digia.com>
-
Michael Brüning authored
This keeps consistency with the other enum names. Change-Id: Idaedb8566fd770b05effeeba377b09a84bf0af12 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- 29 Apr, 2014 - 1 commit
-
-
Pierre Rossi authored
Simply reuse the existing feature request approach that was used for geolocation and notifications in QtWebKit. Change-Id: I8fec4f4e9e81b491163912fadb4ce17d343864dd Reviewed-by:
Zeno Albisser <zeno.albisser@digia.com>
-
- 15 Apr, 2014 - 3 commits
-
-
Jocelyn Turcotte authored
Headers were left intact to leave a trace of the evolution compared to the QtWebKit API and to make it easier to work until we had a basic subset of the API implemented. With the upcoming release, this patch removes this convenience in the aim of starting polishing the headers and the documentation for the upcoming release. Change-Id: Iae436b4ec041d771a7002575e122835802bc9f3e Reviewed-by:
Michael Bruning <michael.bruning@digia.com>
-
Jocelyn Turcotte authored
This changes implemented methods. The rest of the references will go away with the public headers cleanup. Change-Id: I82340cd7a4488c4b463489ae98cd9c16de4e7487 Reviewed-by:
Michael Bruning <michael.bruning@digia.com>
-
Jocelyn Turcotte authored
Expose the same values as currently available in QQuickWebEngineView::NewViewDestination. Rename the WebModalDialog to WebDialog, which actually replaces the tool/status/menuBarVisibilityChangeRequested signals. Change-Id: Icc103f434fb3eca49f1a53e476e101c3d6fffd36 Reviewed-by:
Pierre Rossi <pierre.rossi@gmail.com>
-
- 14 Apr, 2014 - 1 commit
-
-
Michael Brüning authored
Translates the internally used LogSeverity values to enums defined by the QtWebEngine integration layer. Change-Id: I7da0983d4fb5c199e1a2436b5899a43cf6698784 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- 28 Feb, 2014 - 1 commit
-
-
Jocelyn Turcotte authored
This allows handling calls that would be signaled by QNetworkAccessManager in QtWebKit. This pulls QtNetwork as a dependency of the QtWebEngineWidgets module to be able to use QAuthenticator, but isn't required otherwise. Only the request URL is available in the case of HTTP authentication (no access to HTTP request headers that the QNetworkReply would allow) and only the proxy host name in the case case of proxy authentication. This keeps the API synchronous the same way, as QtWebKit did, in favor of source compatibility at the cost of requiring a modal dialog, even though the implementation doesn't require it. Change-Id: I9e021def38e6107c9e66d2de8f86bd0328d543df Reviewed-by:
Michael Bruning <michael.bruning@digia.com>
-
- 21 Feb, 2014 - 1 commit
-
-
Jocelyn Turcotte authored
Keep the size in the page itself, and ask the optionally attached QWebEngineView only for the rect position. When the view size change, call setViewportSize on the page like QtWebKit does. Change-Id: I735f1509cab9ef9b5d32bf31249a59c919939804 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- 13 Feb, 2014 - 2 commits
-
-
Jocelyn Turcotte authored
A few changes to the API: - Return the success result asynchronously. - FindWrapsAroundDocument and HighlightAllOccurrences are enabled by defaults and cannot be disabled. - Found text isn't updating the selection on the page like QtWebKit did, but triggers a separate state not available. A find count and current index could be exposed, but isn't in this case to keep the API delta lower. This also adds the possibility to pass bool results through the CallbackDirectory and add a new tst_QWebEnginePage::findTextResult test since the old test relied on the selection to be updated when the searched text is found. Change-Id: I8189b5aea8d832df183c6c1ae03e3f08198a9c45 Reviewed-by:
Simon Hausmann <simon.hausmann@digia.com>
-
Zoltan Arvai authored
Changing unused variable suppression in acceptNavigationRequest is required for MSVC otherwise it fail with undefined type error. Also adding more suppression for unused wariable warning. Change-Id: Ic449973bc8166f18655e40bf57041b8f02869266 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- 12 Feb, 2014 - 2 commits
-
-
Jocelyn Turcotte authored
Update tests to check that we can keep the same functionality by querying document.baseURI through runJavaScript instead of implementing QWebEnginePage::baseUrl. This also removes QWebEnginePage::baseUrl from the header. Change-Id: I549e57d3986e22986438f8a23e469bbd220633b7 Reviewed-by:
Pierre Rossi <pierre.rossi@gmail.com>
-
Pierre Rossi authored
Break up the delegate implementation into two distinct subclasses. The first one offers a way for the WebPage to tap into the RenderWidgetHostView directly, while a different implementation that is backed by a top-level widget can be used to show WebUI popups on screen. This has the benefit of not having a child widget in the webview among other things. It also fixes our popups and allows them to fall outside the window frame. Change-Id: I80dc1e4f21bb91ff47c75a626d330f88eacce8c6 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- 30 Jan, 2014 - 1 commit
-
-
Pierre Rossi authored
And unskip the corresponding autotest. Change-Id: Ida2dcee38b261b2ba4ad0c5c016f5510ed1590a4 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- 22 Jan, 2014 - 2 commits
-
-
Jocelyn Turcotte authored
Those methods are now made asynchronous and need to be given a callback to handle the result. Update the code in the browser and fancybrowser examples using std::bind when using C++11 or tr1::bind with C++03 (which should be available with compilers on platforms that we support). Add a (currently failing) earlyToHtml test to make sure that an empty page doesn't crash because of a possibly incomplete attachment of the QtRenderViewObserver. Change-Id: I3ab7cb6f25b91b584dd80df5e4e9ad1e3214348e Reviewed-by:
Pierre Rossi <pierre.rossi@gmail.com>
-
Jocelyn Turcotte authored
This prepares the way for other API made async like toHtml and toPlainText. Use a callback class with an implicit templated constructor to carry the functor across the API boundary and avoid the intermediate helper method as the ABI that we have to maintain. Also pass the callback result through WebContentsAdapterClient using a bookkeeping ID instead of transferring the callback to WebContentsAdapter. This will allow other calls, which might not already allow passing a callback functor, to use a consisten way of carrying back the result to the top API layer. Change-Id: Ia923767b9c1021a108c26da17d4c41878ef7cb95 Reviewed-by:
Pierre Rossi <pierre.rossi@gmail.com>
-
- 15 Jan, 2014 - 1 commit
-
-
Pierre Rossi authored
Introduce a new version of chooseFiles in QWebEnginePage. The existing API in WebKit1 seemed a bit dusty in any case (multiple only supported via extensions). Changes are: * oldFile becomes oldFiles, so that we could at a later stage expose the already selected files in the "multiple" case. * a type is introduced, for now limited to multiple selection, but over time, we might consider additions such as directory upload. Change-Id: I14cfea64ce95e892a0a1877c8cb914c5a421409f Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- 28 Nov, 2013 - 1 commit
-
-
Jocelyn Turcotte authored
This only move files without adjusting any paths. This moves: - lib/quick -> src/webengine/api (API files) lib/quick -> src/webengine (other files) This contains the main QtWebEngine module library since <ec7b2ee7 >. - lib/widgets -> src/webenginewidgets Also rename this directory to match its module name and rename Api to api. - lib -> src/core - process -> src/process - resources -> src/core/resources - tools/* -> tools/scripts/ The build directory is spread as follow: - build/build.pro -> src/core/gyp_run.pro - build/qmake_extras/* -> src/core/ (for the host and target .pro files) - build/qmake -> tools/qmake - Build related scripts -> tools/buildscripts Change-Id: I0cded1de772c99c0c1da6536c9afea353236b4a1 Reviewed-by:
Zeno Albisser <zeno.albisser@digia.com> Reviewed-by:
Pierre Rossi <pierre.rossi@gmail.com> Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- 14 Nov, 2013 - 1 commit
-
-
Zeno Albisser authored
Change-Id: I15261c3737a3284b99308453132f09ee7889c444 Reviewed-by:
Pierre Rossi <pierre.rossi@gmail.com>
-
- 13 Nov, 2013 - 1 commit
-
-
Pierre Rossi authored
Out of the #ifndef Q_MOC_RUN block, so we can keep track of what's missing there. Change-Id: I53ef60b1a70b5495603d44fb23491c144891eb92 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- 04 Nov, 2013 - 1 commit
-
-
Pierre Rossi authored
We can't have QWebFrame::evaluateJavascript in its old form for several reasons, the first of which being that we don't have a QWebEngineFrame class anymore. This is worked around by adding an optional QString parameter with the frame's XPath. Another issue is that the WebKit1 API was synchronous, and this would not play nicely with the very asynchronous nature of chromium we're now sitting on top of. In order to make this obvious when porting, we rename it to runJavaScript which doesn't return any result. This also introduces a template member function overload that will accept function pointers, functors and lambdas,much like Qt5's new signal/slot syntax, in order to get the result of the javascript evaluation back. Change-Id: I64e15a6f5a168936c52a4da2cef6285dfd16e0d5 Reviewed-by:
Zeno Albisser <zeno.albisser@digia.com> Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
- 17 Oct, 2013 - 1 commit
-
-
Pierre Rossi authored
This is just the basic core part and widgets plumbing and default implementations of the virtual functions in QWebEnginePage. QtQuick implementation is still yet to be done Change-Id: I7cf8d6e5ec0bf747d45e9914db57bd0e4ef95b7f Reviewed-by:
Zeno Albisser <zeno.albisser@digia.com>
-
- 17 Sep, 2013 - 1 commit
-
-
Michael Brüning authored
This should enable namespaced builds of Qt and QtWebEngine. Change-Id: I4c9d506d864b42a346026b980dcf3777b9680957 Reviewed-by:
Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-
- 02 Sep, 2013 - 1 commit
-
-
Jocelyn Turcotte authored
This makes the necessary changes to handle WebContentsDelegateQt::AddNewContents and funnel the callback through createWindow in QWebEnginePage and QWebEngineView. - Expose the AddNewContents callback through WebContentsAdapterClient - Allow creating a WebContentsAdapter attached only on the Chromium side, leaving the choice to QWebEnginePage to either adopt it and call WebContentsAdapter::initialize to attach itself as the client, or destroy it if the application isn't handling the call. - Delay the InitAsChild handling in RenderWidgetHostViewQt when it is called before an adapter client has been attached. - Since WebContentsAdapterClient::CreateRenderWidgetHostViewQtDelegate is only a factory method, not creating any link with the callee client, allow using the creating window's adapter client to create the RWHVQtDelegate. This allows an unparented delegate to be created instead of needing to add numerous null-checks in RWH...
-
- 20 Aug, 2013 - 4 commits
-
-
Jocelyn Turcotte authored
This imports code from qwebpage.cpp and QWebPageAdapter.cpp of WebKit into qwebenginepage.cpp and thus also restrict the license accordingly. Change-Id: Ic5da8f2b469109cb10132cbe6585f2d941b14403 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
Jocelyn Turcotte authored
To allow QWebEnginePage to act on its own, let it own the WebContentsAdapter and let the view delegate its calls through the page. Change-Id: I851c753d068992e387edab0e1ea8018732af1fd7 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
Jocelyn Turcotte authored
Chromium doesn't allow managing sub-frames from the contents API. To support operations that were made on the main frame, merge the frame API into the page. Methods should be later either be removed or implemented one by one. Change-Id: I52de89a48c00efb9dd0cf0a2c1fdf09d735d2381 Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-
Jocelyn Turcotte authored
This is the first step toward re-implementing part of the QWebView API on top of QtWebEngine. The plan is to import the complete headers to facilitate diffs and progress tracking. Changes squashed in this commit: - Use the QWebEngine prefix for class names - Strip out non-public members and directives - Allow building using those headers by disabling the Q_PROPERTY macros and by adding a dummy implementation for virtual methods directly in the header - Update the widgetsnanobrowser example to comply with the slight changes from the previous API Change-Id: Ia7efa5430f775d09b493544430a04856cc7928f6 Reviewed-by:
Pierre Rossi <pierre.rossi@gmail.com> Reviewed-by:
Andras Becsi <andras.becsi@digia.com>
-