- 07 Apr, 2018 - 1 commit
-
-
Allan Sandfeld Jensen authored
Avoid hitting undefined reference to 'bool TestNamespace::QTest::qCompare<unsigned long, unsigned int>...' Change-Id: I91588869708899e1055619ca9ba46d2061869417 Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-
- 03 Apr, 2018 - 1 commit
-
-
Jüri Valdmann authored
Replace injectionPoint test with a timeout-less version that uses - both a single-frame and a multi-frame page - both main and isolated worlds - cross-process navigation - window.open - profile-wide scripts Task-number: QTBUG-66338 Change-Id: Ica4acb8ada4acc38aa5e1ca00e7512a2e69b785f Reviewed-by:
Michael Brüning <michael.bruning@qt.io>
-
- 22 Mar, 2018 - 1 commit
-
-
Jüri Valdmann authored
As of version 63, Chromium creates proxy frames also for the main frame in the frame tree during cross-process navigations. This leads to a segmentation fault in WebChannelIPCTransport because we assume that all main frames are local. See https://crrev.com/27caae83cb530daaf49f9a38793e427cdf493a65 for details. This patch refactors the renderer-side WebChannelIPCTransport from a RenderViewObserver into a RenderFrameObserver, which prevents the segmentation fault since the RenderFrameObserver is not created for proxy frames. Most likely this would have to be done eventually anyway since the RenderView and RenderViewObserver classes are deprecated and will likely be removed as part of the Site Isolation project. Installation is changed to follow Chromium's RenderFrameImpl in the sense of performing the installation from RenderFrameObserver::DidClearWindowObject instead of ContentRendererClient::RunScriptsAtDocumentStart. This has the benefit of avoiding the ScriptForbiddenScope DCHECK. Additionally there are the following minor changes: - The deprecated parameterless version of v8::Value::ToObject() method is replaced with v8::Value::IsObject() check and v8::Local::Cast. - The deprecated v8::Handle typedef is replaced with v8::Local. - The deprecated single-parameter WebContentsObserver::OnMessageReceived is replaced with the new two-parameter version. - blink::MainThreadIsolate() is used instead of v8::Isolate::GetCurrent() for Install/Uninstall since we know we are executing on the main thread. - WebChannelIPCTransportHost is changed to ignore messages from unexpected renderers in case something goes wrong with the renderers. - Logging is added to WebChannelIPCTransportHost for debugging purposes. Some new unit tests are added, all of which fail with the old version. Task-number: QTBUG-66333 Change-Id: I936d142fb042d9f936a3f9d08d4328ecba595f1f Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-
- 30 Dec, 2017 - 1 commit
-
-
Allan Sandfeld Jensen authored
The code was not correctly giving a function as argument to the addEventHandler, and the whole logic was more complicated than it needed to be. Change-Id: I21e4e6bb6adf1071ae7eb2798d129224af8ef0fb Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu>
-
- 18 Oct, 2017 - 1 commit
-
-
Peter Varga authored
Change-Id: I8e75d21853ac8f7681b20101e40597154bcaca2d Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- 11 Sep, 2017 - 1 commit
-
-
Alexandru Croitor authored
Change-Id: I536258e22c2ec143f2fd3f1cbda229e0611b6af4 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by:
Qt CI Bot <qt_ci_bot@qt-project.org>
-
- 29 Nov, 2016 - 1 commit
-
-
David Faure authored
I added QSignalSpy::wait() in Qt 5.0 exactly for this purpose. Change-Id: I895a92f5f7e4e8554e00f6668e6973cc2c903adf Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- 13 Jun, 2016 - 1 commit
-
-
Jocelyn Turcotte authored
The gin JavaScript binging gets destroyed on page reload after all references to it disappear from the previous document. Do like other gin wrapper and reinstall the transport binding on DidCreateDocumentElement, following how it's done by the MojoBindingsController. Task-number: QTBUG-53411 Change-Id: Ibcd9ef9dbedc5762d4f2210fd81f68e5b9127680 Reviewed-by:
Michael Brüning <michael.bruning@qt.io>
-
- 15 Jan, 2016 - 1 commit
-
-
Allan Sandfeld Jensen authored
Make it possible to set a web-channel so that it can only be accessed by private scripts. Pulls in needed API extension in 3rdparty. Task-number: QTBUG-50318 Change-Id: I61bcce5c318dffe0a406ee8cddf31f58a021c22c Reviewed-by:
Joerg Bornemann <joerg.bornemann@theqtcompany.com>
-
- 08 Jan, 2016 - 1 commit
-
-
Allan Sandfeld Jensen authored
We exposed javascript worlds for user-scripts, this adds variants of runJavaScript that can access those worlds. Change-Id: I5a0b40b863b543cd364c902d0a84ae2c35e2a0b8 Reviewed-by:
Joerg Bornemann <joerg.bornemann@theqtcompany.com>
-
- 12 Nov, 2015 - 1 commit
-
-
Joerg Bornemann authored
Use QTRY_COMPARE instead of a hard-coded timeout. Fix usage of setTimeout in DOMContentLoaded event listener. Change-Id: I915ea0d2c54cf45be42803963d03b19c15135fd4 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
-
- 06 Nov, 2015 - 1 commit
-
-
Kai Koehne authored
Change the behavior of QWebEnginePage/WebEngineView to print JavaScript console.warn and console.error messages by default in a 'js' logging category. This matches also the behavior for QtQml, where console messages end up in a 'qml' logging category by default. So far access to the JavaScript console required either use of the remote debugging functionality, subclassing of QWebEnginePage, or implementing a custom handler. Anyhow, even then writing a seamless forwarding of the data and metadata to the Qt message handler is difficult. This patches implements this forwarding by default. The behavior can be changed by either setting up rules for the 'js' category, e.g. setFilterRules("js.*=false"); or by implementing onJavaScriptConsoleMessage(), or overriding QWebEnginePage::javaScriptConsoleMessage. [ChangeLog] Unhandled JS console messages are now forwarded to to the Qt message handler inside a 'js' category. Change-Id: I5480383a80dcf7a122496f9b7915264ef9036db3 Reviewed-by:
Joerg Bornemann <joerg.bornemann@theqtcompany.com>
-
- 07 Apr, 2015 - 1 commit
-
-
Szabolcs David authored
The MSVC doesn't support this type of string literal concatenation. Change-Id: I051593a34c801df6c5264370ad751c45bbb41b5a Reviewed-by:
Pierre Rossi <pierre.rossi@theqtcompany.com>
-
- 18 Mar, 2015 - 1 commit
-
-
Pierre Rossi authored
Change-Id: Id29c1ed0b29114f426c35a45192a723d305c5b29 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
-