1. Feb 21, 2018
  2. Feb 13, 2018
    • Jüri Valdmann's avatar
      Add support for registerProtocolHandler · 2a4a5b2e
      Jüri Valdmann authored
      
      Extend initialization of URLRequestContextGetterQt to create a
      content::ProtocolHandlerRegistry for each content::BrowserContext and add the
      registry's URL request interceptor to the front of the interceptor chain.
      
      Implement methods in WebContentsDelegateQt to add/remove protocol handlers
      to/from the ProtocolHandlerRegistry.
      
      Add permission request signal and classes for core, quick and widgets.
      
      Add widgets autotest.
      
      Add signal handlers to quicknanobrowser and simplebrowser.
      
      Task-number: QTBUG-62783
      Change-Id: I808e7eb9a1cb4d7216686deed4895de14fe46310
      Reviewed-by: default avatarAllan Sandfeld Jensen <allan.jensen@qt.io>
      2a4a5b2e
  3. Jan 25, 2018
  4. Jan 24, 2018
  5. Jan 23, 2018
  6. Jan 22, 2018
  7. Jan 15, 2018
  8. Nov 14, 2017
    • Jüri Valdmann's avatar
      Stop preserving aborted navigation entries · cf6768d8
      Jüri Valdmann authored
      Consider the scenario
      
        1. user enters url "http://localhost:8000/"
      
           A new navigation entry is created and committed in the
           NavigationController.
      
        2. user enters url "http://localhost:8000/download.bin"
      
           A new navigation entry is created and a download is triggered, but the
           pending navigation entry in the NavigationController is neither committed
           nor discarded (since our WebContentsDelegate's ShouldPreserveAbortedURLs()
           returns true).
      
        3. user enters url "http://localhost:8000/download.bin"
      
           At this point the NavigationController will have "http://localhost:8000/"
           as the committed navigation entry and "http://localhost:8000/download.bin"
           as the pending entry. NavigateToPendingEntry will see that the user is
           trying to navigate again to the same URL as the last pending entry and will
           therefore identify this new navigation as a reload.
      
           However Blink interprets 'reload' to mean reloading the last committed
           entry, i.e. "http://localhost:8000/", and so we end up trying to download
           "http://localhost:8000/" instead of "http://localhost:8000/download.bin
      
      " as
           the user might have expected.
      
      The patch removes the ShouldPreserveAbortedURLs override and relies on the
      default implementation which always returns false. As a result the pending
      navigation entry in step 2 above is discarded once the download has been
      triggered and the unexpected behavior in step 3 is no longer triggered.
      
      Removing the override resurrects QTBUG-48995 where, for example, calling
      QWebEnginePage::setUrl triggers first a urlChanged signal for the *old* URL. The
      patch adds url and title properties to WebContentsDelegateQt so that property
      change signals are triggered only if the properties have actually changed. A
      consequence of this fix is that the first urlChanged signal is delivered
      directly from the setUrl/load method and not asynchronously once the loading
      starts (this is also how Chrome's URL bar is updated).
      
      Task-number: QTBUG-63388
      Change-Id: Icfa300b165e5e56f1fbc8978a00a237c263df183
      Reviewed-by: default avatarPeter Varga <pvarga@inf.u-szeged.hu>
      cf6768d8
    • Jüri Valdmann's avatar
      Add tests setUrlToBadDomain and setUrlToBadPort · a1a2bd2d
      Jüri Valdmann authored
      
      Document the somewhat strange behavior of the signals
      
        QWebEnginePage::urlChanged,
        QWebEnginePage::titleChanged, and
        QWebEnginePage::loadFinished
      
      when trying to load invalid URLs via QWebEnginePage::setUrl.
      
      Change-Id: I5218a49105ad6187f87e7091589b5175f4349593
      Reviewed-by: default avatarPeter Varga <pvarga@inf.u-szeged.hu>
      Reviewed-by: default avatarAllan Sandfeld Jensen <allan.jensen@qt.io>
      a1a2bd2d
  9. Nov 10, 2017
  10. Nov 08, 2017
    • Viktor Engelmann's avatar
      Make GetUserMediaTestPage more robust · 86207b16
      Viktor Engelmann authored
      
      A 5 second timeout might not be enough for our underpowered CI VMs.
      Also, if the page isn't loaded (to slow or for other reasons), we
      must abort, to prevent the JavaScripts from being run on different
      pages (first scripts to the old page, then to the new page if it
      eventually finishes loading).
      The first JavaScript in particular is rejected on the old page,
      because "about:blank" doesn't have a secure origin. This could
      even make the test accept wrongfully if all scripts are run on the
      old page, because the request (which is supposed to be rejected)
      can be rejected for being run on the wrong page, instead of for
      requesting forbidden permissions.
      
      Task-number: QTBUG-63347
      Change-Id: Ib63d55477d35001b174900b73dc3dd23d33c7263
      Reviewed-by: default avatarJüri Valdmann <juri.valdmann@qt.io>
      Reviewed-by: default avatarAllan Sandfeld Jensen <allan.jensen@qt.io>
      86207b16
  11. Oct 25, 2017
  12. Oct 18, 2017
  13. Sep 22, 2017
    • Alexandru Croitor's avatar
      Fix selectedText() to return the value of what findText("") finds · 9d962bc9
      Alexandru Croitor authored
      
      Previously when a find operation was finished by calling findText(""),
      the selection buffer was cleared and calling selectedText() would
      return an empty string, even though on the UI side a blue rectangle
      selection was still visible.
      
      This was due to an incorrect Unselect() call in
      WebContentsAdapter::stopFinding().
      
      With the new selection change support in the parent patch, and with the
      removed Unselect() call, selectedText() now properly returns the value
      of the highlighted blue selection after searching is finished.
      
      Task-number: QTBUG-60673
      Task-number: QTBUG-54071
      Task-number: QTBUG-53134
      Change-Id: I89e0eddb0c14af6d6c06ee878e706be65d3b0831
      Reviewed-by: default avatarViktor Engelmann <viktor.engelmann@qt.io>
      Reviewed-by: default avatarPeter Varga <pvarga@inf.u-szeged.hu>
      9d962bc9
  14. Sep 20, 2017
  15. Sep 13, 2017
  16. Sep 11, 2017
  17. Sep 08, 2017
    • Oleg Yadrov's avatar
      Make FocusOnNavigationEnabled setting disabled by default · f32b3514
      Oleg Yadrov authored
      
      Before this setting was added in Qt 5.8, the behavior was that
      QWebEngineView/WebEngineView got the focus automatically. With the new
      setting added it is configurable, but it was left enabled for
      compatibility reasons. It would had to be changed at some point anyway:
      none of other QML items or widgets grab the focus after creation, so why
      would QWebEngineView/WebEngineView do?
      This patch also fixes a bug with the text cursor in WebView (the cursor
      was blinking as if WebView had the focus when it did not).
      
      [ChangeLog][Important Changes][QtWebEngine][General]
      focusOnNavigationEnabled setting which allows controlling whether
      a web view will receive focus on a navigation request is now disabled
      by default.
      
      Task-number: QTBUG-60152
      Task-number: QTBUG-60149
      Change-Id: I78dc9bb9ffc70bf06217952acd456b97651c5185
      Reviewed-by: default avatarQt CI Bot <qt_ci_bot@qt-project.org>
      Reviewed-by: default avatarMichal Klocek <michal.klocek@qt.io>
      v5.10.0-alpha1
      f32b3514
  18. Aug 28, 2017
  19. Aug 02, 2017
  20. Jul 19, 2017
  21. Jul 17, 2017
  22. Jun 14, 2017
  23. May 23, 2017
  24. Apr 12, 2017
    • Peter Varga's avatar
      Fix text selection and input method query · 78417958
      Peter Varga authored
      
      Instruct the render process to change the text selection if it was
      requested via an input method event. Raise the selectionChanged() signal
      when all the corresponding input method properties are set.
      
      Moreover, add back the remaining input method widget auto tests. The
      updated tests are moved to the QWebEngineView tests since the
      corresponding APIs (inputMethodQuery() and input event handling) are now
      available via the QWebEngineView's focus proxy (aka RWHV).
      
      Task-number: QTBUG-55766
      Change-Id: Ia0022d5f38b31dd59b084ff42e4abc2780ae90ec
      Reviewed-by: default avatarAllan Sandfeld Jensen <allan.jensen@qt.io>
      78417958
  25. Mar 24, 2017
  26. Mar 07, 2017
  27. Mar 01, 2017
  28. Jan 25, 2017
  29. Jan 22, 2017
  30. Jan 20, 2017
  31. Jan 18, 2017
  32. Jan 15, 2017
  33. Jan 10, 2017
  34. Dec 06, 2016
  35. Nov 29, 2016
  36. Nov 25, 2016