- Feb 21, 2018
-
-
Peter Varga authored
Chromium considers the actual URL as "scary" therefore prefers to pass a simpler URL via the WebContents::GetVisibleURL() content API function. For data URLs, use the actual URL instead to keep their anchor information. Task-number: QTBUG-64972 Change-Id: I74db3e5dd22a728656a58e50a4e3fba93b82dae2 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Feb 13, 2018
-
-
Jüri Valdmann authored
Extend initialization of URLRequestContextGetterQt to create a content::ProtocolHandlerRegistry for each content::BrowserContext and add the registry's URL request interceptor to the front of the interceptor chain. Implement methods in WebContentsDelegateQt to add/remove protocol handlers to/from the ProtocolHandlerRegistry. Add permission request signal and classes for core, quick and widgets. Add widgets autotest. Add signal handlers to quicknanobrowser and simplebrowser. Task-number: QTBUG-62783 Change-Id: I808e7eb9a1cb4d7216686deed4895de14fe46310 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Jan 25, 2018
-
-
Allan Sandfeld Jensen authored
Convert it to QtWebEngine. Change-Id: I7a453cd7544a20a9c461c3bb29b3a2fb78016d44 Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io>
-
Allan Sandfeld Jensen authored
Change-Id: I19bf693fb3916a78f4a199e6e095ca58b8fdfa27 Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu>
-
Allan Sandfeld Jensen authored
Change-Id: I49cd3c419d4dd1180144c3c07bdd9a628ab73caa Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu>
-
- Jan 24, 2018
-
-
Allan Sandfeld Jensen authored
This test makes little sense for QtWebEngine Change-Id: I0177fb59ea23383a3c8135853f7e62b26ce5708a Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu>
-
Allan Sandfeld Jensen authored
We have no plans of implement QtWebKit still plugins. Change-Id: I9f7bb94cc240e2f0eda8c85c03fa5860435d52a3 Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu>
-
- Jan 23, 2018
-
-
Allan Sandfeld Jensen authored
Have been skipped for years but appears to work. Change-Id: I461459b64fe3731b2fb50a3cc9c9d4ab75b135d4 Reviewed-by:
Alexandru Croitor <alexandru.croitor@qt.io>
-
- Jan 22, 2018
-
-
Allan Sandfeld Jensen authored
Change-Id: I54e7633fdfd1f3a4574373e0469c3df733dd32a4 Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io>
-
- Jan 15, 2018
-
-
Jüri Valdmann authored
Unlike QNetworkProxy, Chromium's net::ProxyServer expects the hostname and port to be at default values for special schemes (DIRECT and INVALID). Otherwise, a DCHECK is triggered at proxy_server.cc:73. Change-Id: I1ac6c425ea03fcbfe084d25c2fd05bf174c753d6 Reviewed-by:
Viktor Engelmann <viktor.engelmann@qt.io>
-
- Nov 14, 2017
-
-
Jüri Valdmann authored
Consider the scenario 1. user enters url "http://localhost:8000/" A new navigation entry is created and committed in the NavigationController. 2. user enters url "http://localhost:8000/download.bin" A new navigation entry is created and a download is triggered, but the pending navigation entry in the NavigationController is neither committed nor discarded (since our WebContentsDelegate's ShouldPreserveAbortedURLs() returns true). 3. user enters url "http://localhost:8000/download.bin" At this point the NavigationController will have "http://localhost:8000/" as the committed navigation entry and "http://localhost:8000/download.bin" as the pending entry. NavigateToPendingEntry will see that the user is trying to navigate again to the same URL as the last pending entry and will therefore identify this new navigation as a reload. However Blink interprets 'reload' to mean reloading the last committed entry, i.e. "http://localhost:8000/", and so we end up trying to download "http://localhost:8000/" instead of "http://localhost:8000/download.bin " as the user might have expected. The patch removes the ShouldPreserveAbortedURLs override and relies on the default implementation which always returns false. As a result the pending navigation entry in step 2 above is discarded once the download has been triggered and the unexpected behavior in step 3 is no longer triggered. Removing the override resurrects QTBUG-48995 where, for example, calling QWebEnginePage::setUrl triggers first a urlChanged signal for the *old* URL. The patch adds url and title properties to WebContentsDelegateQt so that property change signals are triggered only if the properties have actually changed. A consequence of this fix is that the first urlChanged signal is delivered directly from the setUrl/load method and not asynchronously once the loading starts (this is also how Chrome's URL bar is updated). Task-number: QTBUG-63388 Change-Id: Icfa300b165e5e56f1fbc8978a00a237c263df183 Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu>
-
Jüri Valdmann authored
Document the somewhat strange behavior of the signals QWebEnginePage::urlChanged, QWebEnginePage::titleChanged, and QWebEnginePage::loadFinished when trying to load invalid URLs via QWebEnginePage::setUrl. Change-Id: I5218a49105ad6187f87e7091589b5175f4349593 Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Nov 10, 2017
-
-
Jüri Valdmann authored
Remove strange options for call to QUrl::path and add test for "qrc" protocol. Change-Id: I6528d858b7661832852c333a7f932d4714f953f2 Reviewed-by:
Alexandru Croitor <alexandru.croitor@qt.io>
-
- Nov 08, 2017
-
-
Viktor Engelmann authored
A 5 second timeout might not be enough for our underpowered CI VMs. Also, if the page isn't loaded (to slow or for other reasons), we must abort, to prevent the JavaScripts from being run on different pages (first scripts to the old page, then to the new page if it eventually finishes loading). The first JavaScript in particular is rejected on the old page, because "about:blank" doesn't have a secure origin. This could even make the test accept wrongfully if all scripts are run on the old page, because the request (which is supposed to be rejected) can be rejected for being run on the wrong page, instead of for requesting forbidden permissions. Task-number: QTBUG-63347 Change-Id: Ib63d55477d35001b174900b73dc3dd23d33c7263 Reviewed-by:
Jüri Valdmann <juri.valdmann@qt.io> Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Oct 25, 2017
-
-
Allan Sandfeld Jensen authored
Change-Id: I5cb198445f283c6cea8187a1a2883896df0ee918 Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-
- Oct 18, 2017
-
-
Peter Varga authored
Change-Id: I8e75d21853ac8f7681b20101e40597154bcaca2d Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Sep 22, 2017
-
-
Alexandru Croitor authored
Previously when a find operation was finished by calling findText(""), the selection buffer was cleared and calling selectedText() would return an empty string, even though on the UI side a blue rectangle selection was still visible. This was due to an incorrect Unselect() call in WebContentsAdapter::stopFinding(). With the new selection change support in the parent patch, and with the removed Unselect() call, selectedText() now properly returns the value of the highlighted blue selection after searching is finished. Task-number: QTBUG-60673 Task-number: QTBUG-54071 Task-number: QTBUG-53134 Change-Id: I89e0eddb0c14af6d6c06ee878e706be65d3b0831 Reviewed-by:
Viktor Engelmann <viktor.engelmann@qt.io> Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu>
-
- Sep 20, 2017
-
-
Viktor Engelmann authored
Positive options are more intuitive and make for a better API. Task-number: QTBUG-63179 Change-Id: I632ee768dba52554e7d37d9da84661a1d01f1f37 Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io> Reviewed-by:
Leena Miettinen <riitta-leena.miettinen@qt.io>
-
- Sep 13, 2017
-
-
Szabolcs David authored
Expose navigator.webkitPersistentStorage.requestQuota() calls to the API layer as a permission API. It allows the users to accept these requests and specify a quota for persistent storage. https://developer.chrome.com/apps/offline_storage#managing_quota [ChangeLog] navigator.webkitPersistentStorage.requestQuota() calls were rejected by default and now they will emit signal quotaPermissionRequested in both WebEngineView and QWebEnginePage. Task-number: QTBUG-56354 Change-Id: Id192577ffb403694d3051414744ded89bbfd2aa8 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Sep 11, 2017
-
-
Alexandru Croitor authored
Change-Id: I536258e22c2ec143f2fd3f1cbda229e0611b6af4 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by:
Qt CI Bot <qt_ci_bot@qt-project.org>
-
- Sep 08, 2017
-
-
Oleg Yadrov authored
Before this setting was added in Qt 5.8, the behavior was that QWebEngineView/WebEngineView got the focus automatically. With the new setting added it is configurable, but it was left enabled for compatibility reasons. It would had to be changed at some point anyway: none of other QML items or widgets grab the focus after creation, so why would QWebEngineView/WebEngineView do? This patch also fixes a bug with the text cursor in WebView (the cursor was blinking as if WebView had the focus when it did not). [ChangeLog][Important Changes][QtWebEngine][General] focusOnNavigationEnabled setting which allows controlling whether a web view will receive focus on a navigation request is now disabled by default. Task-number: QTBUG-60152 Task-number: QTBUG-60149 Change-Id: I78dc9bb9ffc70bf06217952acd456b97651c5185 Reviewed-by:
Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-
- Aug 28, 2017
-
-
Michal Klocek authored
The deletion of CallBackSpy before web engine page destruction could end up in segmentation fault. Make CallbackSpy safe to be deleted before web engine page. Change-Id: I71a184091c0251c61e3383010e3badfef5cb6124 Reviewed-by:
Viktor Engelmann <viktor.engelmann@qt.io>
-
- Aug 02, 2017
-
-
Peter Varga authored
[ChangeLog][Settings] Added setting to hide scrollbars. Change-Id: I17695bb54a460621358345d303302b93eb342696 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Jul 19, 2017
-
-
Peter Varga authored
The tested QWebEnginePage::scrollToAnchor API can't be added to QtWebEngine for now. Currently, Chromium Content API doesn't support to control page scroll. The corresponding feature can be used by URL fragment identifier (#anchor) or JavaScript API (location.href). Change-Id: Ie9c87758d458858ba677d309a548cdced525557b Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Jul 17, 2017
-
-
Jüri Valdmann authored
- Use feature permissions system instead of hard-coded dialog. - Add QML test for getUserMedia() and extend existing widgets test. Task-number: QTBUG-60832 Change-Id: I533bed5021b3b0ee199b8abc6ddbd516cbd14ff6 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Jun 14, 2017
-
-
Allan Sandfeld Jensen authored
Adjustments to auto tests to pass with Chromium 58 Change-Id: I7f6905e5344c528c608734bc660cbf43c89d4a63 Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by:
Qt CI Bot <qt_ci_bot@qt-project.org>
-
- May 23, 2017
-
-
Viktor Engelmann authored
If the Q_VERIFY(current >= previousValue) fails, the output was not verbose enough. The additional outputs will tell us more about what caused the test to fail. Task-number: QTBUG-57839 Change-Id: Ieeefe68ede111be7dba5eda9f2a770e975efc0ee Reviewed-by:
Kai Koehne <kai.koehne@qt.io>
-
- Apr 12, 2017
-
-
Peter Varga authored
Instruct the render process to change the text selection if it was requested via an input method event. Raise the selectionChanged() signal when all the corresponding input method properties are set. Moreover, add back the remaining input method widget auto tests. The updated tests are moved to the QWebEngineView tests since the corresponding APIs (inputMethodQuery() and input event handling) are now available via the QWebEngineView's focus proxy (aka RWHV). Task-number: QTBUG-55766 Change-Id: Ia0022d5f38b31dd59b084ff42e4abc2780ae90ec Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Mar 24, 2017
-
-
Szabolcs David authored
Calculate movementX/movementY at every turn, not only when the mouse is in locked state. Task-number: QTBUG-59127 Change-Id: I362e055e6b5d6f831671604a093434373cedf19a Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Mar 07, 2017
-
-
Samuel Gaist authored
This patch adds the missing QRegExp includes in prevision of the qtbase include cleanup. Change-Id: Ic2cfddcd30207944c573096990032f7f7616a2b1 Reviewed-by:
André Hartmann <aha_1980@gmx.de>
-
- Mar 01, 2017
-
-
Allan Sandfeld Jensen authored
Load failures now have a Chromium side timeout of 10s so we need to wait longer than that. Additionally error-pages no longer have descriptive titles, so we can not rely on that in our tests any longer. Change-Id: I33ac8b9f1247403eb214f7260267edb887fe10d0 Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-
- Jan 25, 2017
-
-
Peter Varga authored
Task-number: QTBUG-55766 Change-Id: I3be3b224dfef9ecc1ce39f4f20ec5c1d13c0fa69 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Jan 22, 2017
-
-
Peter Varga authored
Task-number: QTBUG-55766 Change-Id: I4e6ade8f000f66ff1bb28f3b856ae140834292f1 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Jan 20, 2017
-
-
Peter Varga authored
Moreover, set ImHiddenText hint for password fields and add back the corresponding widget auto test. Task-number: QTBUG-55766 Change-Id: I3f76e19c8c33e11f3d9f515b6dc7d6e998c3c9a4 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Jan 18, 2017
-
-
Peter Varga authored
Moreover, update the Chromium SHA1 for enabling virtual keyboard support for macOS. Task-number: QTBUG-55766 Change-Id: Ic50ae79ab13a62a4b9289afedce2d6647e266f86 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Jan 15, 2017
-
-
Szabolcs David authored
Task-number: QTBUG-51572 Change-Id: Ie8e7e5ef38f88ae91d892b703cd9702b2637daa2 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Jan 10, 2017
-
-
Michael Brüning authored
[ChangeLog][Important Changes] Printing to a PDF file will now emit signal the signal pdfPrintingFinished in both QQuickWebEngineView and QWebEnginePage. The boolean passed with the signal to indicate if the printing and saving of the PDF was successful. The path of the created file is also passed to enable the user to map the signal to a print request. Task-number: QTBUG-56677 Change-Id: Ifab5a20b048f33a8cd872165bd4d453b01708037 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by:
Leena Miettinen <riitta-leena.miettinen@qt.io>
-
- Dec 06, 2016
-
-
Szabolcs David authored
If a test fails it may trigger an assert in debug mode because the delete wasn't performed. Move QWebEngine* objects to the stack or use QScopedPointers to avoid these assertion fails. Change-Id: Ic44c3fddc7cd9cf57a0e2d1c57e0a6fd99033e02 Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu>
-
- Nov 29, 2016
-
-
David Faure authored
I added QSignalSpy::wait() in Qt 5.0 exactly for this purpose. Change-Id: I895a92f5f7e4e8554e00f6668e6973cc2c903adf Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Nov 25, 2016
-
-
Michael Brüning authored
This moves the actual printing using QPrinter to the WebEngineWidgets part of the API. The printsupport module depends on the widgets module and therefore QtWebEngineCore also had a dependency to widgets. This is removed by this change. Change-Id: If6e5745709a59de18f2123b930cbe6e64390c867 Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-