1. 30 Jul, 2014 - 1 commit
    • Allan Sandfeld Jensen's avatar
      Add api to get the favicon URL · a99922af
      Allan Sandfeld Jensen authored
      
      Adds one of the missing pieces of the QWebFrame and QWebView APIs.
      Unlike the QtWebKit version this only fetches the favicon URL, and not
      the icon. This is because we do not want to implement an icon database,
      and that the icon would be loaded asynchronous anyway, bringing no
      guarantee to be a valid icon/image yet.
      
      Change-Id: I227311ae3676044da850e687b82bee752b5079c8
      Reviewed-by: default avatarJocelyn Turcotte <jocelyn.turcotte@digia.com>
      a99922af
  2. 09 Jul, 2014 - 1 commit
    • Frederik Gladhorn's avatar
      Add core accessibility · a9853701
      Frederik Gladhorn authored
      
      This commit adds the basics to bridge the blink
      accessibility classes to QAccessibleInterfaces.
      
      Note that it needs two follow up commits to implement the bridging from
      the QWidget/Qt Quick worlds.
      
      [ChangeLog][Accessibility] QtWebEngine now has accessibility
      support, enabling assistive technology such as screen readers to work
      with it.
      
      Change-Id: Ied1d97e61a024115ac7a9245331211f6d9fac1b4
      Reviewed-by: default avatarZeno Albisser <zeno.albisser@digia.com>
      Reviewed-by: default avatarAndras Becsi <andras.becsi@digia.com>
      a9853701
  3. 15 May, 2014 - 1 commit
  4. 12 May, 2014 - 1 commit
    • Jocelyn Turcotte's avatar
      Remove the xPath argument from runJavaScript · 55f1130b
      Jocelyn Turcotte authored
      
      This value is only used internally by Chromium and risks being removed
      at anytime, for which we would then have to maintain a downstream
      implementation.
      
      Chromium also only supports frame values, while a complete support of
      the interface would require also supporting this xPath to point to
      individual document element by affecting the value of "this", the same
      way that QWebElement::evaluateJavaScript allowed in QtWebKit.
      
      Change-Id: Id0cb1b8e3bdf9a6db0ca786fb5eb46ffd726d165
      Reviewed-by: default avatarMichael Bruning <michael.bruning@digia.com>
      55f1130b
  5. 08 May, 2014 - 1 commit
  6. 29 Apr, 2014 - 2 commits
  7. 15 Apr, 2014 - 3 commits
  8. 14 Apr, 2014 - 1 commit
  9. 08 Apr, 2014 - 3 commits
  10. 31 Mar, 2014 - 3 commits
  11. 21 Mar, 2014 - 1 commit
    • Jocelyn Turcotte's avatar
      Base load signals on Blink loader events · f06cb10c
      Jocelyn Turcotte authored
      
      This mainly remove the use of the LoadingStateChanged callback, which
      is tied to DidStartLoading and DidStopLoading.
      Those signals are handled from the browser process side, also wrapping
      the time where the render process is initialized. We can't rely on
      those signals for loadStarted, but afterward rely on the Blink loader
      for loadFinished. We must use the same source for both.
      
      Instead only rely on Blink callbacks ultimately related to network
      events. This gives us a behavior closer to QtWebKit.
      
      The major compromise that this forces us to to accept is that
      loadStarted is now triggered asynchronously. This will basically break
      anything expecting loadStarted to be emitted synchronously from the
      load method.
      
      This also adjust autotests to get a few more passing.
      
      Initial-patch-by: default avatarPierre Rossi <pierre.rossi@digia.com>
      Change-Id: Ib6c0170df891d1b7f8ed4dc1d483985523e267dc
      Reviewed-by: default avatarPierre Rossi <pierre.rossi@gmail.com>
      Reviewed-by: default avatarSimon Hausmann <simon.hausmann@digia.com>
      f06cb10c
  12. 28 Feb, 2014 - 1 commit
    • Jocelyn Turcotte's avatar
      Add HTTP and proxy authentication signals directly to QWebEnginePage · 970ccc7f
      Jocelyn Turcotte authored
      
      This allows handling calls that would be signaled by QNetworkAccessManager
      in QtWebKit.
      This pulls QtNetwork as a dependency of the QtWebEngineWidgets module
      to be able to use QAuthenticator, but isn't required otherwise.
      
      Only the request URL is available in the case of HTTP authentication
      (no access to HTTP request headers that the QNetworkReply would allow)
      and only the proxy host name in the case case of proxy authentication.
      
      This keeps the API synchronous the same way, as QtWebKit did, in
      favor of source compatibility at the cost of requiring a modal
      dialog, even though the implementation doesn't require it.
      
      Change-Id: I9e021def38e6107c9e66d2de8f86bd0328d543df
      Reviewed-by: default avatarMichael Bruning <michael.bruning@digia.com>
      970ccc7f
  13. 21 Feb, 2014 - 1 commit
  14. 20 Feb, 2014 - 2 commits
  15. 13 Feb, 2014 - 5 commits
    • Jocelyn Turcotte's avatar
      Implement QWebEnginePage::findText · 324706a5
      Jocelyn Turcotte authored
      
      A few changes to the API:
      - Return the success result asynchronously.
      - FindWrapsAroundDocument and HighlightAllOccurrences are enabled by
        defaults and cannot be disabled.
      - Found text isn't updating the selection on the page like QtWebKit
        did, but triggers a separate state not available. A find count and
        current index could be exposed, but isn't in this case to keep the
        API delta lower.
      
      This also adds the possibility to pass bool results through the
      CallbackDirectory and add a new tst_QWebEnginePage::findTextResult
      test since the old test relied on the selection to be updated when
      the searched text is found.
      
      Change-Id: I8189b5aea8d832df183c6c1ae03e3f08198a9c45
      Reviewed-by: default avatarSimon Hausmann <simon.hausmann@digia.com>
      324706a5
    • Jocelyn Turcotte's avatar
      Implement QWebEnginePage::selectedText · 9cf0007b
      Jocelyn Turcotte authored
      
      Change-Id: Idebde8da0befbea7ccc5942de1e09fcc61ce16d4
      Reviewed-by: default avatarSimon Hausmann <simon.hausmann@digia.com>
      9cf0007b
    • Jocelyn Turcotte's avatar
      Refactor the way callbacks are stored · 1f17c9b3
      Jocelyn Turcotte authored
      
      With the upcoming addition of a new type of callback result, this
      patch allows storing multiple callback types in the same QHash instead
      or requiring a different hash table just to please the type system.
      
      This does so by managing the ref-counted callback pointers directly
      instead of relying on a templated QExplicitlySharedDataPointer that
      requires a different type for each different callback pointer type.
      
      The ref-counting, construction and destruction is managed through
      a run-time type enum.
      
      Change-Id: I90ab2e1efc0c9703fc5b6ef57b38204ac8eea828
      Reviewed-by: default avatarSimon Hausmann <simon.hausmann@digia.com>
      1f17c9b3
    • Jocelyn Turcotte's avatar
      Move the requestID argument before the result · 71edccab
      Jocelyn Turcotte authored
      
      This tries to get the order of declaration to be consistent.
      It also follows the order used by Chromium in some places
      where the routing_id usually comes first, then the request_id
      and then the result of the asynchronous request.
      
      Change-Id: I88e164dee67e1631161a222f7dd7a4679c3d3acd
      Reviewed-by: default avatarSimon Hausmann <simon.hausmann@digia.com>
      71edccab
    • Jocelyn Turcotte's avatar
      Fix a warning in QWebEnginePage::setHtml · 0bb596fb
      Jocelyn Turcotte authored
      
      Change-Id: I87c18edb89658433d6dc3487ab92d2ff7bd6c986
      Reviewed-by: default avatarSimon Hausmann <simon.hausmann@digia.com>
      0bb596fb
  16. 12 Feb, 2014 - 4 commits
  17. 30 Jan, 2014 - 1 commit
  18. 22 Jan, 2014 - 4 commits
    • Jocelyn Turcotte's avatar
      Clear callbacks with an empty value on page destruction · 6fb392ee
      Jocelyn Turcotte authored
      
      The current implementation offers no way to cancel async requests.
      This means that normal applications could easily allow callbacks
      to dereference a destroyed object unless they use a smart pointer
      within the callback function object.
      
      This patch will empty the pending callback list by calling each of
      them with an empty value. This will at least allow applications to
      cover the cases where the page is expected to have a shorter or equal
      lifetime than objects referenced in the callback.
      
      Change-Id: Ia9fc556b03f5d83f904a0ff4b05dc9e440ea488c
      Reviewed-by: default avatarPierre Rossi <pierre.rossi@gmail.com>
      6fb392ee
    • Jocelyn Turcotte's avatar
      Implement QWebEnginePage::toHtml and toPlainText · 1fcd7970
      Jocelyn Turcotte authored
      
      Those methods are now made asynchronous and need to be given a
      callback to handle the result.
      
      Update the code in the browser and fancybrowser examples using
      std::bind when using C++11 or tr1::bind with C++03 (which should be
      available with compilers on platforms that we support).
      
      Add a (currently failing) earlyToHtml test to make sure that an empty
      page doesn't crash because of a possibly incomplete attachment of
      the QtRenderViewObserver.
      
      Change-Id: I3ab7cb6f25b91b584dd80df5e4e9ad1e3214348e
      Reviewed-by: default avatarPierre Rossi <pierre.rossi@gmail.com>
      1fcd7970
    • Jocelyn Turcotte's avatar
      Refactor the callback mechanism used by runJavaScript · 6d760436
      Jocelyn Turcotte authored
      
      This prepares the way for other API made async like toHtml and
      toPlainText.
      
      Use a callback class with an implicit templated constructor to carry
      the functor across the API boundary and avoid the intermediate helper
      method as the ABI that we have to maintain.
      
      Also pass the callback result through WebContentsAdapterClient using
      a bookkeeping ID instead of transferring the callback to
      WebContentsAdapter. This will allow other calls, which might not
      already allow passing a callback functor, to use a consisten way
      of carrying back the result to the top API layer.
      
      Change-Id: Ia923767b9c1021a108c26da17d4c41878ef7cb95
      Reviewed-by: default avatarPierre Rossi <pierre.rossi@gmail.com>
      6d760436
    • Jocelyn Turcotte's avatar
      Implement QWebEnginePage::setHtml and setContent · e6b846f3
      Jocelyn Turcotte authored
      
      Load a generated data: URL to carry the data.
      
      This is not as efficient as it could be but the behavior matches and
      this should be fine for now.
      
      Change-Id: I26ad2e5976025a3044fb03f066074ce6dd34e575
      Reviewed-by: default avatarPierre Rossi <pierre.rossi@gmail.com>
      e6b846f3
  19. 17 Jan, 2014 - 1 commit
  20. 15 Jan, 2014 - 3 commits