- Sep 19, 2017
-
-
Michal Klocek authored
Change-Id: I123ce22ea3a3d8b7b80c67fa322cb817d924f2e0 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Michal Klocek authored
Change-Id: Ib9d6c8842609c4c410ca65a35fefeab481f71cb2 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Michal Klocek authored
Move all skipBuild related checks to runConfigure() in configure.prf. Remove some unused functions. Move platform checks to separate prf file. Change-Id: Ia45c837c91c341ed1fbc2e32fc098329da989920 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Sep 18, 2017
-
-
Kai Koehne authored
Task-number: QTBUG-63098 Change-Id: Id5fd1f940c928fd74bdc3c202f3e8b18a086c2d0 Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu>
-
- Sep 17, 2017
-
-
Alexandru Croitor authored
Due to a current issue described in QTBUG-63180, requesting a 3.2 Core context on macOS will advertise that a 4.1 context was created, even though that is not the case. Because RenderWidgetHostViewQtDelegateWidget will read the OpenGL major version from the global shared context and then apply that to its own context, this will cause a failure to create a shared context (one is 3.2, and the other is 4.1). The current workaround is to create the context with the default format version, instead of the global shared one. This way all the requested versions will be consitent. Task-number: QTBUG-60605 Change-Id: I470c43ca9d15cb3887a0ed968b57c62518a33a72 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Sep 16, 2017
-
-
Alexandru Croitor authored
This should improve the CPU usage a bit, due to using software rasterization in Chromium, rather than relying on the mesa implementation in opengl32sw.dll. Change-Id: Ib165aacc6a9d02dd30a6397e48af5616e00eb574 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Allan Sandfeld Jensen authored
Use weak pointers to make sure pending calls don't can run after it has been deleted. Change-Id: I6e808794e1d977dd9e236cf4a3a9ab4213ed7efd Reviewed-by:
Alexandru Croitor <alexandru.croitor@qt.io>
-
Allan Sandfeld Jensen authored
Expose any custom data in the pickled form Chrome uses. Task-number: QTBUG-61503 Change-Id: Ie89bd04f35b1dba94b91e87960cde66238d738df Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io>
-
- Sep 15, 2017
-
-
Alexandru Croitor authored
The in process GPU thread still starts even if kDisableGPU is passed because kInProcessGPU check has a higher priority in GpuDataManagerImplPrivate::GpuAccessAllowed(). This caused a crash when running on Windows with ANGLE. Make sure not to pass kInProcessGPU if we will disable the GPU. Task-number: QTBUG-63221 Change-Id: I8f9d154951e9143c7b5049eb641bfad2448b855b Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Sep 13, 2017
-
-
Alexandru Croitor authored
A user can explicitly request software OpenGL rendering via opengl32sw.dll instead of Skia rendering, by passing the --enable-webgl-software-rendering command line argument. This will make sure not to disable GPU processing if and only if software OpenGL rendering is used on Windows (via QT_OPENGL=software environment variable, or the Qt::AA_UseSoftwareOpenGL attribute), so that WebGL is not disabled. Software OpenGL rendering will still use Skia on platforms other than Windows. Change-Id: I8b3601b144e09e3a732abfb74dbbf6f924889b5a Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Sep 12, 2017
-
-
Allan Sandfeld Jensen authored
Updates Chromium to 60.0.3112.116 and Ninja to 1.8.2 Change-Id: I46f6fe4083f338890ad85437404a442aa7eeba81 Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-
Michal Klocek authored
In case of passing pkg_config also set host_pkg_config otherwise pkg-config for sysroot will inject sysroot root libdir linker flag during host build which leads to weird errors. Change-Id: I57f277e500ba175687f65b9947b9f9c8edd969fc Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io> Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Michal Klocek authored
Use new configure system for all package detection. Move config test execution to new configure system. However, keep old configure.prf for error hanlding. Split configuration summary into: * optional system libraries used * required system libraries * required system libraries for qpa-xcb (on linux) Change-Id: I5108456caa024a1ada9bb54750693064a2d36f78 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Allan Sandfeld Jensen authored
This ensures the scripts and webchannel are added before RunScriptsAtDocumentStart is called. It also means we shouldn't add them later from the changed signal. Task-number: QTBUG-62898 Change-Id: Ib4cd3a69134d0eafc7f2ac4b7927a1c79b63bfa6 Reviewed-by:
Viktor Engelmann <viktor.engelmann@qt.io>
-
Jüri Valdmann authored
Note that the Referer header still won't be sent if the download is triggered via an anchor element with the 'download' attribute: crbug.com/455987 . Task-number: QTBUG-61354 Change-Id: I5af971af916b2190756e3e58f19736072a213922 Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-
- Sep 11, 2017
-
-
Alexandru Croitor authored
Change-Id: I536258e22c2ec143f2fd3f1cbda229e0611b6af4 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by:
Qt CI Bot <qt_ci_bot@qt-project.org>
-
Allan Sandfeld Jensen authored
Change-Id: I472053e316bfa782d0a6fb8903f4901be12247ae Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Michal Klocek authored
Improve implementation of URLRequestCustomJob: * remove qmutex, pass values using PostTask * do not use base::WeakPtr which is not thread safe and must always be dereferenced on the same thread * add proxy object to handle interactions between threads * do not use QPointer to track IODevice since it does not solve anything for us * QIODevice in reply method is used only by IO thread * do not make shared object to commit suicide, instead use refcounted object * improve documentation about thread safety issue of QIODevice object in reply method Change-Id: Ic29bf262de8082dfd46cb9217a68f3c982d16b9e Reviewed-by:
Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Michal Klocek authored
Move URLRequestCustomJobShared to separate file and rename class to URLRequestCustomJobProxy. This commit is a groundwork for following one. Change-Id: I122b2101789e91186a3bffa9a07eed43b7340418 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Joerg Bornemann authored
This flag was set in QWebEngineView::contextMenuEvent and checked in QWebEnginePage::contextMenuRequested. The latter would bail out if the flag was not set. When the user pressed Shift-F10, the key event was received by RenderWidgetHostViewQtDelegateWidget::event and forwarded to Chromium. Blink's default event handler invoked the context menu, and our callback QWebEnginePage::contextMenuRequested was called. But nothing happened, because m_pendingContextMenuEvent has never been set. There is no reason to have this flag. React on every context menu request just like in the QtQuick implementation. Now pressing Shift-F10 invokes the context menu on web pages. Task-number: QTBUG-58306 Change-Id: I2db1b17604e5521e44613297120a964cc4e4d544 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Sep 08, 2017
-
-
Oleg Yadrov authored
Before this setting was added in Qt 5.8, the behavior was that QWebEngineView/WebEngineView got the focus automatically. With the new setting added it is configurable, but it was left enabled for compatibility reasons. It would had to be changed at some point anyway: none of other QML items or widgets grab the focus after creation, so why would QWebEngineView/WebEngineView do? This patch also fixes a bug with the text cursor in WebView (the cursor was blinking as if WebView had the focus when it did not). [ChangeLog][Important Changes][QtWebEngine][General] focusOnNavigationEnabled setting which allows controlling whether a web view will receive focus on a navigation request is now disabled by default. Task-number: QTBUG-60152 Task-number: QTBUG-60149 Change-Id: I78dc9bb9ffc70bf06217952acd456b97651c5185 Reviewed-by:
Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-
Joerg Bornemann authored
VK_MENU is the virtual key code for the Alt key, but Qt::Key_Menu is the context menu key which maps to VK_APPS. Now the menu key can be used to invoke the context menu on web pages. Task-number: QTBUG-58306 Change-Id: I8674ab84848b5c8732e4d0cf189909191b85d562 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Allan Sandfeld Jensen authored
Pulls in relevant security fixes upto Chome 61.0.3163.79 Changes: 609295469702 FIXUP: Support GN on MIPS64 hosts 0c3fee8fd9ae FIXUP: Optionally unbundle re2 10d8b35c35d1 [Backport] Fix for CVE-2017-5112 838d4d79ff42 [Backport] Fix for CVE-2017-5114 72c99b3ca20a [Backport] Fix for CVE-2017-5117 5d375e38c58d [Backport] Fix for CVE-2017-5118 bc703b5d9f97 [Backport] avformat/oggparsecelt: Do not re-allocate os->private 89de564d176a [Backport] FrameHostMsg_OpenURL_Params.resource_request_body needs to be validated. 5ebd47322d60 [Backport] Remove insecure code paths in portable NTLM. Change-Id: I8d8c93aab7f41a485c95878ce7aecb5997bbeb1c Reviewed-by:
Alexandru Croitor <alexandru.croitor@qt.io>
-
Allan Sandfeld Jensen authored
QT_ARCH is the current architecture, and if the host is Arm or MIPS, we also need the flags there. Task-number: QTBUG-61846 Change-Id: I38f826e061eff900f6e27f4de0fc913323cf5e3e Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io>
-
- Sep 06, 2017
-
-
Kai Koehne authored
This is shown in the file properties and in crash dialogs. Task-number: QTBUG-61970 Change-Id: I9e5398cbaff1eda4908fbe0fc89c481d65808771 Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io>
-
- Sep 05, 2017
-
-
Alan Alpert authored
Change-Id: Ibad2b8ebb90e79ff8337d994b2234eed5e230daa Reviewed-by:
Romain Pokrzywka <romain.pokrzywka@gmail.com> Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Sep 03, 2017
-
-
Allan Sandfeld Jensen authored
Change-Id: Ifa305045f3594f06b0ee106cd43f9d35853f8958 Reviewed-by:
Alexandru Croitor <alexandru.croitor@qt.io> Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-
- Aug 31, 2017
-
-
Peter Varga authored
Qt WebEngine implements a custom handler for multiple mouse clicks. These tests are intended to test whether the mouse click events are properly forwarded to the Chromium's RenderWidgetHost. Custom mouse click test functions have been also added for the custom mouse click handler. Change-Id: Ifdc7d09f5e0f0f76c37e137e5743482bf3fb8abb Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Aug 30, 2017
-
-
Viktor Engelmann authored
Since https is an internal scheme, it should be in this list of internal schems. This also prevents custom custom QWebEngineUrlSchemeHandlers to register "https". Although it is debatable whether this is necessary, https should be held to at least the same security standards as http, which is also in that list. Task-number: QTBUG-56894 Change-Id: I83d0130541fe3b5831bf29d429bad89a8fc5408c Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Aug 29, 2017
-
-
Allan Sandfeld Jensen authored
Set host_cpu to ensure GN gets on the right path matching the host of the toolchain we give it in host_toolchain. Task-number: QTBUG-62673 Change-Id: I99d6dfdbe4cee30bc240049b656d1ec73becce8a Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io>
-
Alexandru Croitor authored
Chromium itself does not really support processing touch events on macOS, but rather uses native gestures sent by the OS. Warn the user in case they send simulated QTouchEvents. Task-number: QTBUG-62130 Change-Id: If47f25bc06f3d6f99ba70164a585182354ed9b5a Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Alexandru Croitor authored
Previously when a popup window was shown, and the user issued a command to close the only active main window (via a shortcut for example) with a subsequent call to deleteLater(), the main window would be closed and deleted but the popup would only be hidden, which led to the application loop to still be running and not quitting, even though there would be no visible window left. The closing of a popup is usually done in the QWidget destructor when the popup is still visible, but because we unset the parent right before the parent is destroyed (which sets visibility to false), the popup would not be closed, but only hidden. Thus this change makes sure to explicitly close the popup when its parent is destroyed. Task-number: QTBUG-62311 Change-Id: Ia0bbf327929af55aac19767971ab0acde5715e21 Reviewed-by:
Viktor Engelmann <viktor.engelmann@qt.io>
-
Allan Sandfeld Jensen authored
Changes: dd11b14b60 Optionally unbundle re2 5caa35af6b Support GN on MIPS64 hosts Change-Id: I745f399477b182fa2216b879cac3d356ba0e69fd Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io>
-
- Aug 28, 2017
-
-
Allan Sandfeld Jensen authored
The software backend version of QSGLayer defaults to not mirroring vertically, where the OpenGL does, and we rely on that. Task-number: QTBUG-62112 Change-Id: Id5368728fd7046d2e4dc35bd4b2b61f2db35dac6 Reviewed-by:
Alexandru Croitor <alexandru.croitor@qt.io>
-
Allan Sandfeld Jensen authored
Chromium handles the flag for the render process, but with multi-process we need to enable it for the browser process as well. Task-number: QTBUG-62808 Change-Id: I1111dd7a2fd58876978ec5299bfb7abea8cb8487 Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-
- Aug 23, 2017
-
-
Szabolcs David authored
It was registered as FullScreenRequest in plugin.cpp, not WebEngineFullScreenRequest. Change-Id: Ib9eec950a0f54aad2dbc31e54d6d5c6a6838ac65 Reviewed-by:
Leena Miettinen <riitta-leena.miettinen@qt.io>
-
- Aug 22, 2017
-
-
Viktor Engelmann authored
We now track the values we send to the loadProgress signal. We store the last value in a new int WebContentsDelegateQt::m_lastLoadProgress and only send values that are >= m_lastLoadProgress to ensure monotonicity. A value < 0 indicates that no loading is going on. Only on loadStarted it is set to 0 (and a loadProgress is emitted with progress 0) and on loadFinished, it is set to -1 (and a loadProgress is emitted with progress 100). This way, we ensure that you first get a loadStarted signal, at least two loadProgress signals (0 and 100) and a loadFinished signal AND all loadProgress signals come in a monotonous order. Task-number: QTBUG-57839 Task-number: QTBUG-61815 Change-Id: I219d3bffbd5691adb892a11b79647ba9e1ed248e Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-
- Aug 18, 2017
-
-
Joerg Bornemann authored
DropData::file_contents and DropData::file_description_filename are filled by Chromium if the user drags an image from a web page. Write the file's content into a file with the suggested file name in a temporary directory, and set the drop action to "move". This enables users to drag images from the browser to the desktop or a file browser. The file is moved by the client to the target location. The temporary directory is removed when the page is closed. Note that Chrome doesn't use this temporary directory trick, but employs techniques like XDS [1] on Linux to transfer the data via the native clipboard/DnD MIME object. Unfortunately QDrag doesn't support this. Support could be added, but I consider this solution as good enough. [1] https://www.freedesktop.org/wiki/Specifications/XDS/ Task-number: QTBUG-60790 Change-Id: I44f2b3170a124e861ed4131c421903d895b70715 Reviewed-by:
Alexandru Croitor <alexandru.croitor@qt.io>
-
Andy Shaw authored
Change-Id: I8f8f1baff3824cb07057375a72b5ae6f0e09b5a7 Reviewed-by:
Florian Bruhin <qt-project.org@the-compiler.org> Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by:
Leena Miettinen <riitta-leena.miettinen@qt.io>
-
- Aug 14, 2017
-
-
Viktor Engelmann authored
Instead of explicitly loading libraries from hard-coded locations, we now just call dlopen(NULL, RTLD_LAZY). This returns a handle to the host process'es context, which already contains the symbols of both these libraries, because we link against them. It was necessary to bypass LoadLibrary, because that expects a non-NULL file path, so we couldn't pass NULL through that interface. Task-number: QTBUG-57761 Change-Id: I29f037dfe542222b5188a33c7727c81a464a87bb Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-