1. Sep 19, 2017
  2. Sep 18, 2017
  3. Sep 17, 2017
    • Alexandru Croitor's avatar
      [macOS] Fix creation of shared OpenGL 3.2 Core contexts · 56474df1
      Alexandru Croitor authored
      
      Due to a current issue described in QTBUG-63180, requesting a 3.2 Core
      context on macOS will advertise that a 4.1 context was created, even
      though that is not the case. Because
      RenderWidgetHostViewQtDelegateWidget will read the OpenGL major version
      from the global shared context and then apply that to its own context,
      this will cause a failure to create a shared context (one is 3.2, and
      the other is 4.1).
      
      The current workaround is to create the context with the default format
      version, instead of the global shared one. This way all the requested
      versions will be consitent.
      
      Task-number: QTBUG-60605
      Change-Id: I470c43ca9d15cb3887a0ed968b57c62518a33a72
      Reviewed-by: default avatarAllan Sandfeld Jensen <allan.jensen@qt.io>
      56474df1
  4. Sep 16, 2017
  5. Sep 15, 2017
    • Alexandru Croitor's avatar
      Don't pass kInProcessGPU if we pass kDisableGPU · 6d6e296e
      Alexandru Croitor authored
      
      The in process GPU thread still starts even if kDisableGPU is passed
      because kInProcessGPU check has a higher priority in
      GpuDataManagerImplPrivate::GpuAccessAllowed(). This caused a crash when
      running on Windows with ANGLE.
      
      Make sure not to pass kInProcessGPU if we will disable the GPU.
      
      Task-number: QTBUG-63221
      Change-Id: I8f9d154951e9143c7b5049eb641bfad2448b855b
      Reviewed-by: default avatarAllan Sandfeld Jensen <allan.jensen@qt.io>
      6d6e296e
  6. Sep 13, 2017
    • Alexandru Croitor's avatar
      Allow WebGL to work with a software OpenGL implementation on Windows · c7d46325
      Alexandru Croitor authored
      
      A user can explicitly request software OpenGL rendering via
      opengl32sw.dll instead of Skia rendering, by passing the
      --enable-webgl-software-rendering command line argument.
      
      This will make sure not to disable GPU processing if and only if
      software OpenGL rendering is used on Windows (via
      QT_OPENGL=software environment variable, or the
      Qt::AA_UseSoftwareOpenGL attribute), so that WebGL is not disabled.
      
      Software OpenGL rendering will still use Skia on platforms other than
      Windows.
      
      Change-Id: I8b3601b144e09e3a732abfb74dbbf6f924889b5a
      Reviewed-by: default avatarAllan Sandfeld Jensen <allan.jensen@qt.io>
      c7d46325
  7. Sep 12, 2017
  8. Sep 11, 2017
  9. Sep 08, 2017
    • Oleg Yadrov's avatar
      Make FocusOnNavigationEnabled setting disabled by default · f32b3514
      Oleg Yadrov authored
      
      Before this setting was added in Qt 5.8, the behavior was that
      QWebEngineView/WebEngineView got the focus automatically. With the new
      setting added it is configurable, but it was left enabled for
      compatibility reasons. It would had to be changed at some point anyway:
      none of other QML items or widgets grab the focus after creation, so why
      would QWebEngineView/WebEngineView do?
      This patch also fixes a bug with the text cursor in WebView (the cursor
      was blinking as if WebView had the focus when it did not).
      
      [ChangeLog][Important Changes][QtWebEngine][General]
      focusOnNavigationEnabled setting which allows controlling whether
      a web view will receive focus on a navigation request is now disabled
      by default.
      
      Task-number: QTBUG-60152
      Task-number: QTBUG-60149
      Change-Id: I78dc9bb9ffc70bf06217952acd456b97651c5185
      Reviewed-by: default avatarQt CI Bot <qt_ci_bot@qt-project.org>
      Reviewed-by: default avatarMichal Klocek <michal.klocek@qt.io>
      v5.10.0-alpha1
      f32b3514
    • Joerg Bornemann's avatar
      Fix translation of Qt::Key_Menu · f6dc11e9
      Joerg Bornemann authored
      
      VK_MENU is the virtual key code for the Alt key, but
      Qt::Key_Menu is the context menu key which maps to VK_APPS.
      
      Now the menu key can be used to invoke the context menu on web pages.
      
      Task-number: QTBUG-58306
      Change-Id: I8674ab84848b5c8732e4d0cf189909191b85d562
      Reviewed-by: default avatarAllan Sandfeld Jensen <allan.jensen@qt.io>
      f6dc11e9
    • Allan Sandfeld Jensen's avatar
      Update Chromium · 8b5f1a82
      Allan Sandfeld Jensen authored
      
      Pulls in relevant security fixes upto Chome 61.0.3163.79
      
      Changes:
      609295469702 FIXUP: Support GN on MIPS64 hosts
      0c3fee8fd9ae FIXUP: Optionally unbundle re2
      10d8b35c35d1 [Backport] Fix for CVE-2017-5112
      838d4d79ff42 [Backport] Fix for CVE-2017-5114
      72c99b3ca20a [Backport] Fix for CVE-2017-5117
      5d375e38c58d [Backport] Fix for CVE-2017-5118
      bc703b5d9f97 [Backport] avformat/oggparsecelt: Do not re-allocate os->private
      89de564d176a [Backport] FrameHostMsg_OpenURL_Params.resource_request_body needs to be validated.
      5ebd47322d60 [Backport] Remove insecure code paths in portable NTLM.
      
      
      Change-Id: I8d8c93aab7f41a485c95878ce7aecb5997bbeb1c
      Reviewed-by: default avatarAlexandru Croitor <alexandru.croitor@qt.io>
      8b5f1a82
    • Allan Sandfeld Jensen's avatar
      Also set MIPS/Arm flags for host-builds · 369c64bc
      Allan Sandfeld Jensen authored
      
      QT_ARCH is the current architecture, and if the host is Arm or MIPS, we
      also need the flags there.
      
      Task-number: QTBUG-61846
      Change-Id: I38f826e061eff900f6e27f4de0fc913323cf5e3e
      Reviewed-by: default avatarJoerg Bornemann <joerg.bornemann@qt.io>
      369c64bc
  10. Sep 06, 2017
  11. Sep 05, 2017
  12. Sep 03, 2017
  13. Aug 31, 2017
    • Peter Varga's avatar
      Add auto tests for MultipleMouseClickHelper · 656b7fdd
      Peter Varga authored
      
      Qt WebEngine implements a custom handler for multiple mouse clicks.
      These tests are intended to test whether the mouse click events are
      properly forwarded to the Chromium's RenderWidgetHost.
      Custom mouse click test functions have been also added for the custom
      mouse click handler.
      
      Change-Id: Ifdc7d09f5e0f0f76c37e137e5743482bf3fb8abb
      Reviewed-by: default avatarAllan Sandfeld Jensen <allan.jensen@qt.io>
      656b7fdd
  14. Aug 30, 2017
    • Viktor Engelmann's avatar
      Add https to list of internal schemes · 2710c66f
      Viktor Engelmann authored
      
      Since https is an internal scheme, it should be in this list of
      internal schems.
      This also prevents custom custom QWebEngineUrlSchemeHandlers to
      register "https". Although it is debatable whether this is necessary,
      https should be held to at least the same security standards as http,
      which is also in that list.
      
      Task-number: QTBUG-56894
      Change-Id: I83d0130541fe3b5831bf29d429bad89a8fc5408c
      Reviewed-by: default avatarAllan Sandfeld Jensen <allan.jensen@qt.io>
      2710c66f
  15. Aug 29, 2017
  16. Aug 28, 2017
  17. Aug 23, 2017
  18. Aug 22, 2017
    • Viktor Engelmann's avatar
      Emit loadProgress only between loadStarted and loadFinished · 25bb229a
      Viktor Engelmann authored
      
      We now track the values we send to the loadProgress signal. We store
      the last value in a new int WebContentsDelegateQt::m_lastLoadProgress
      and only send values that are >= m_lastLoadProgress to ensure
      monotonicity.
      A value < 0 indicates that no loading is going on. Only on loadStarted
      it is set to 0 (and a loadProgress is emitted with progress 0) and
      on loadFinished, it is set to -1 (and a loadProgress is emitted with
      progress 100).
      This way, we ensure that you first get a loadStarted signal, at least
      two loadProgress signals (0 and 100) and a loadFinished signal
      AND all loadProgress signals come in a monotonous order.
      
      Task-number: QTBUG-57839
      Task-number: QTBUG-61815
      Change-Id: I219d3bffbd5691adb892a11b79647ba9e1ed248e
      Reviewed-by: default avatarMichal Klocek <michal.klocek@qt.io>
      25bb229a
  19. Aug 18, 2017
  20. Aug 14, 2017
    • Viktor Engelmann's avatar
      Load libEGL and libGLES2 symbols implicitly · d4c621f6
      Viktor Engelmann authored
      
      Instead of explicitly loading libraries from hard-coded locations,
      we now just call dlopen(NULL, RTLD_LAZY). This returns a handle to
      the host process'es context, which already contains the symbols of
      both these libraries, because we link against them.
      It was necessary to bypass LoadLibrary, because that expects a non-NULL
      file path, so we couldn't pass NULL through that interface.
      
      Task-number: QTBUG-57761
      Change-Id: I29f037dfe542222b5188a33c7727c81a464a87bb
      Reviewed-by: default avatarAllan Sandfeld Jensen <allan.jensen@qt.io>
      Reviewed-by: default avatarMichal Klocek <michal.klocek@qt.io>
      d4c621f6