- 09 Apr, 2019 - 6 commits
-
-
Allan Sandfeld Jensen authored
Clang-cl couldn't find the header given to it by -FI when it isn't in any of the included directories. Additionally clang-cl 8 has a bug with exported templated classes with inline methods that causes it to have missing symbols at link time. We work around this. Fixes: QTBUG-74563 Change-Id: I7becf05fa8edb07bd4cefe12bee3737e5e1dfa14 Reviewed-by:
Yuhang Zhao <2546789017@qq.com> Reviewed-by:
Mårten Nordheim <marten.nordheim@qt.io> Reviewed-by:
Kai Koehne <kai.koehne@qt.io>
-
Allan Sandfeld Jensen authored
Include many headers that are commonly used now, and avoid listing them twice. Change-Id: I679dc24cff2cb3a3c9c18585ec78007ab3550743 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Liang Qi authored
-
Kai Koehne authored
/GM at one point apparently was set by default for debug builds. However, nowaways it's officially deprecated and even generates a warning in Visual Studio 2019; so we don't have to 'unset' it specifically anymore. Change-Id: I5b9b93c058c2ee8a5e025da43251d3859acbe061 Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io>
-
Kai Koehne authored
The comment hints that it's fixing an issue in Visual Studio 2013, which we don't support anymore. In all supported Visual Studio Versions -Gm is actually deprecated anyhow, and not set anymore by default. So I guess it's safe to remove the special handling here. Change-Id: I2e8ff85350ba651d9a763aabba7b6494ba88d82e Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io>
-
Samuel Gaist authored
This patch updates the code from the deprecated QRegExp class to QRegularExpression. Task-number: QTBUG-25485 Change-Id: I946790f50c6b14787bca31771de5e3a0d5fefe4c Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
- 08 Apr, 2019 - 5 commits
-
-
Qt Forward Merge Bot authored
Change-Id: I05d14a40e17554691bad369d0363e88413afd9b3
-
Allan Sandfeld Jensen authored
We were using low precision dx/dy for calculating the starting point which meant we could be off when clipping at high scale factors. Fixes: QTBUG-60782 Change-Id: I883f9aed1346fdffae070b6316ea808b83519701 Reviewed-by:
Eirik Aavitsland <eirik.aavitsland@qt.io>
-
Andre Hartmann authored
Change-Id: Ice210b979a1dd948cd8d95003bd50a4b71d91852 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Andre Hartmann authored
QNetworkDatagram was introduced together with these methods in Qt 5.8 (commit 4da2dda2 ) Change-Id: I454c26ebf6f94988cada8ac9315db1d43a31a595 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Qt Forward Merge Bot authored
Change-Id: Id60d508c0f25fd5e67be07daafd2d4c56ae73934
-
- 06 Apr, 2019 - 2 commits
-
-
Davide Beatrici authored
The current code only tries to load the required functions from LIBRESOLV_SO (if defined) and resolv, but on FreeBSD they are in libc: https://www.freebsd.org/cgi/man.cgi?query=res_query&sektion=3&apropos=0&manpath=freebsd This commit changes the code so that, after failing to load the non-existent libraries, it attempts to load the functions with dlsym() using the special handle RTLD_DEFAULT, which searches for the specified symbol in the loaded libraries. This is a follow-up to 8eeb5150 . Change-Id: I19d90b0ca8703398bf4f5f4edd5ae31e346ef251 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Davide Beatrici authored
The current code only tries to load the required functions from LIBRESOLV_SO (if defined) and resolv, but on FreeBSD they are in libc: https://www.freebsd.org/cgi/man.cgi?query=res_query&sektion=3&apropos=0&manpath=freebsd This commit changes the code so that, after failing to load the non-existent libraries, it attempts to load the functions with dlsym() using the special handle RTLD_DEFAULT, which searches for the specified symbol in the loaded libraries. Task-number: QTBUG-74844 Change-Id: If97aaae233cabbfa01c30d26d9a7fb01ec3ff5c2 Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
- 05 Apr, 2019 - 16 commits
-
-
Qt Forward Merge Bot authored
Change-Id: Iec860bb703f983b7438e67c695b9c454e72b3e0f
-
Edward Welbourne authored
Includes a fixup for 03fadc26 , which removed the check on empty transition list, needed when no data are available. Ensured that such a data-free zone would in fact be noticed as invalid during init(). Fixed handling of times before the epoch (we still want to consult a POSIX rule, if that's all that's available) while ensuring we (as documented) ignore DST for such times. Fixed handling of large times (milliseconds since epoch outside int range) when looking up POSIX rules. Gave QTimeZonePrivate a YearRange enum (to be moved to QTimeZone once this merges up to dev) so as to eliminate a magic number (and avoid adding another). Moved year-munging in POSIX rules after the one early return, which doesn't need the year range. Added test-cases for the distant past/future (just checking UTC's offsets; SLES has a minimal version of the UTC data-file that triggers the bugs fixed here for them). Fixes: QTBUG-74666 Fixes: QTBUG-74550 Change-Id: Ief7b7e55c62cf11064700934f404b2fc283614e1 Reviewed-by:
Tony Sarajärvi <tony.sarajarvi@qt.io> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Milian Wolff authored
This allows tools that look for matching `foo_entry/exit` pairs in the trace data to work properly. An unmatched `_entry` would otherwise confuse them, making them think that the call stack is continuously increasing. Change-Id: Idff7f587ea25c46ec86ad623cc82d503db34a194 Reviewed-by:
Christoph Sterz <christoph.sterz@kdab.com> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Milian Wolff authored
Additionally, we also add a Q_TRACE_EXIT which runs a trace point when the scope is exited, leveraging qScopeGuard behind the scenes. Q_TRACE_SCOPE uses Q_TRACE_EXIT internally - the difference is that the _SCOPE version enforces the naming scheme of _entry / _exit for the tracepoints, whereas Q_TRACE_EXIT can be used generically. Change-Id: I4a2f5ea09f451fcf664d07fd493b679f7527ac06 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Milian Wolff authored
This allows us to deduce a lot about what a Qt application is doing, since the debug output usually contains a lot of information. Change-Id: I28a18afd151a1640a44ba8c7c9cd87d5d66c99b0 Reviewed-by:
Christoph Sterz <christoph.sterz@kdab.com> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Milian Wolff authored
This patch fixes compilation with `-trace lttng` or `-trace etw`. We need to forward declare QEvent, QImageReader etc., otherwise the types will be unknown while compiling the trace points. In order to handle this generically, the tracegen utility is extended to support a 'prefix text' in the `*.tracepoints` input files. Any text within curly braces will be embedded as-is in the generated file. This can then be used to add forward declarations for the types we need, including potential namespaces and such. Change-Id: I5cb16763ce0fcb48ce3ea4577578d468ff3a4f4b Reviewed-by:
Konstantin Tokarev <annulen@yandex.ru>
-
Friedemann Kleint authored
Remove the canCopy() check which is not required and pass up the error message. Remove special characters and use the base name of the display name which can be an URL. Task-number: QTBUG-71785 Change-Id: I22966cb8d1f5bca0bbca71cf3ebe66e4ede1a747 Reviewed-by:
Oliver Wolff <oliver.wolff@qt.io> Reviewed-by:
Andre de la Rocha <andre.rocha@qt.io>
-
Qt Forward Merge Bot authored
Change-Id: I010a6322d12e038fdce247a58dfb05e204c2ff3b
-
Albert Astals Cid authored
oss-fuzz found at least width is sometimes not initialized, and we're initializing almost all of them in most cases so be complete. the oss-fuzz instance was ==1==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x667c43 in operator!= /src/qtbase/src/corelib/tools/qsize.h:173:25 #1 0x667c43 in setup_qt /src/qtbase/src/gui/image/qpnghandler.cpp:403 Change-Id: Idb9aaf5ab85509d9c893beaf8d9118339ba46be7 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Kai Koehne authored
The only use of this method got removed already in commit bebae373 . Change-Id: I9757cbe34710efd9a9d31c74f81e01da40453ff9 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com> Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io>
-
Kai Koehne authored
Silences a clang warning Change-Id: I5ade49326afcce964ffb5c24b5708977950d123e Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io>
-
Eirik Aavitsland authored
This runtime warning was recently introduced in the fix for an assert/crash when creating a brush with an invalid Preset value. However, that overlooked the usage where an unknown value is passed to QGradient constructor, and the code afterwards checks if the result is a NoGradient or not. It turns out that such usage is already established as legitimate, including in the Qt Quick Rectangle code, so this warning would be spit out continuously for perfectly legal qml code. Change-Id: Id60aed0817da0214b6cf17edd245f67e26470413 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Dmitry Shachnev authored
Change-Id: Ia053fbc854a77e333edadb0be6c2e04826b8fbdb Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Friedemann Kleint authored
Change-Id: Icfaedcd68ff387cc888e41ec0b1db1810122b229 Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io>
-
Volker Hilsheimer authored
Hardcoding IP addresses and their respective DNS records is fragile. We care about Qt producing the same result as other DNS querying tools, so testing that instead. Running a python script for this is easiest, and assumed to be quite reliable. In case where python fails/is not present, fall back to nslookup. That tool is available on Linux, macOS, and Windows, although the output it produces varies. This change implements very basic line-parsing that can interpret the various results encountered during testing on those platforms. This also reverts commit bbaceff253fae13d8e56691bc9de7e1981db5118, which blacklisted the tests that failed due to changes in DNS records. Use the opportunity to replace usage of gitorious.org. Change-Id: I967de226bd603c805df7fe3ed4e871d92d2d0750 Reviewed-by:
Timur Pocheptsov <timur.pocheptsov@qt.io>
-
Orgad Shaneh authored
Change-Id: I538ef771dcf6b757025c8d31f13a91222c2ebd3e Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
- 04 Apr, 2019 - 8 commits
-
-
Allan Sandfeld Jensen authored
qatomic.h included qbasicatomic.h which included qatomic.h. Due to a define in qbasicatomic.h, the definitions from QAtomic would change depending on which was included first. Fortunately qbasicatomic does not need qatomic.h so the include can be removed. Change-Id: I086009f2e16a6e20b2b76fc6b3bf66a343414206 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Jani Heikkinen authored
This reverts commit 3cdf4605 . It seems change is causing regression & is reverted now to be able to proceed with releases Task-number: QTBUG-74912 Change-Id: Ib2365b96ee98fbbcc8853cc7f8726c157c1913a7 Reviewed-by:
Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io> Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io>
-
Joerg Bornemann authored
Every module already includes its own config. Change-Id: I1ef630092f61f118d79dc9b39ce38f4bdea14f43 Reviewed-by:
Kai Koehne <kai.koehne@qt.io>
-
Morten Johan Sørvig authored
targetX and targetY are canvas-local coordinates, while Qt generally works with window-local and global coordinates. Add coordinate mapping calls where needed and make sure we pass correct coordinate types to Qt. This starts mattering when we have canvases which are not located at (0, 0). Change-Id: I28563310ca17d0cc5535317cff99fcd82d3723db Reviewed-by:
Lorn Potter <lorn.potter@gmail.com>
-
Morten Johan Sørvig authored
Another side effect of setting contenteditable on the canvas. Seen on Firefox. Change-Id: I789ba4d7e6fbbdbf14b66fe1ae57183ec04e04bb Reviewed-by:
Lorn Potter <lorn.potter@gmail.com>
-
Andy Shaw authored
Change-Id: Icbd4920ed03655cec483a402de9d0ae3378ff3ef Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Allan Sandfeld Jensen authored
Change-Id: I019b102e99f99377b528ad5c8a4ccb2a7929f14f Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Friedemann Kleint authored
Typing in invalid URLs results in empty result lists. Emit rejected() in this case. Task-number: QTBUG-71785 Change-Id: Ia257b85a5c4370227f753752f6a473bbb3a054be Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io>
-
- 03 Apr, 2019 - 3 commits
-
-
Qt Forward Merge Bot authored
Change-Id: Ia7328524f2cd9d5995ac8705f0fe0bf570b2e831
-
Joerg Bornemann authored
...starting with Qt 5.0.0. The text is manually inserted there, because \since does not work within sections. Task-number: QTBUG-74737 Change-Id: I0fe2d0a113d48be0266030c8466b062c6f743aab Reviewed-by:
Robert Szefner <robertsz27@interia.pl> Reviewed-by:
Leena Miettinen <riitta-leena.miettinen@qt.io>
-
Morten Johan Sørvig authored
XDG is not very relevant on the Web platform. Change-Id: Ibd885e28da15114d0601c73e34dec556e65cbe75 Reviewed-by:
David Faure <david.faure@kdab.com>
-