1. 12 Feb, 2020 - 8 commits
  2. 11 Feb, 2020 - 6 commits
  3. 10 Feb, 2020 - 10 commits
  4. 09 Feb, 2020 - 1 commit
    • Lars Knoll's avatar
      Don't rely on iterators being stable while modifying the hash · 7caaf4eb
      Lars Knoll authored
      
      The Mapping struct referred to where it got inserted into the
      source_index mapping table by a const iterator to the table. That
      is rather fragile, as changing the table invalidates the iterator.
      
      It happened to work with QHash in Qt 5, but will break with the new
      implementation in Qt 6.
      
      Instead simply store the key in the Mapping struct so that it can
      be quickly found in the hash.
      
      Also fix one place, where we unconditionally call erase on an iterator
      returned by constFind(). Turns out constFind() did sometimes not find
      the item in question and returns end().
      
      Change-Id: I0420a06d496f640a3150478e8c644d4cc669ceff
      Reviewed-by: default avatarLars Knoll <lars.knoll@qt.io>
      Reviewed-by: default avatarMårten Nordheim <marten.nordheim@qt.io>
      7caaf4eb
  5. 08 Feb, 2020 - 2 commits
  6. 07 Feb, 2020 - 13 commits