Change-Id: Id49de348f8808a9786616e512636c08eb4d6ef6d
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>

properly quote where necessary and space-separate, instead of
comma-separating.

Change-Id: Ibf2e638d92591700c3a26f3402f306f5995552ad
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>

Change-Id: Ia6b72ca42e2493842e228269728be46dd2eaf1df
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>

Change-Id: I4d210bd3c896bb5d1cb13b4d38a08bfb317f4150
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>

object-orientation just adds another layer of obfuscation to perl code,
and really doesn't pay off for such short scripts.

Change-Id: Ibe620839cea9b2cf0b2ff56257e13071535bd3a8
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

Change-Id: I729dc9f37f604d7a7ed97ddb7395080b3afa3b3e
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>

Change-Id: I019707fa3ca050fc9da8fb95b00766f661447223
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: Ia5ca3a45702c52895f084f7f4bbe57ddb673b5ac
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

Change-Id: I67dc5f1a1febeee8465abf34d0cb35bde1a868b9
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

it's supposed to match a literal dot

Change-Id: I4bee3571a4239ec08a14ed18e409f97b4455f928
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>

Change-Id: I2f3feab4a8396d73c8e3313731427061534536a4
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>

people sometimes get creative

Change-Id: Idcb52ca5a4cc0561d80f6b8c74010d701c854dc0
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>

otherwise we complain about the missing newline at the end, which is
pointless (arguably, git is being stupid here in the first place, but
whatever).

Change-Id: I51bc49825c2a74b26691927660a6771a3925af7d
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>

it is expected to be a [ChangeLog] tag, not a ChangeLog footer.

Change-Id: Iaf5bb09976ecfbd4d7cbde9eaf303f682aa14f58
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>

Change-Id: I223eaf32782b2c0d2de3a815e0968706bfff1bdb
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

urls to reviews should be replaced by sha1s of merged commits.
urls to jira tasks should be replaced by task-number footers.

the rationale is keeping the history relocatable, and somewhat
independent from the infrastructure's software.
also, urls are pretty noisy.

Change-Id: I4b2c9ded8cbc02ca96daa4a2ff92c98c0a4b05f9
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>

people use them to refer to related commits. they should use stable
sha1s of merged commits instead.

Change-Id: Ic58aa875aa978dc76948521266741258fd8c94aa
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>

they are completely unnecessary and make things look messy.

the algorithm considers cherry-pick lines as footers, following
convention. it even supports multi-line cherry-picks, such as those i
sometimes assemble when squashing multiple commits.

this change will cause a lot of complaints, because almost everybody
appears to be using a broken commit-msg hook. the one coming from our
gerrit is ok, as is the copy in qtrepotools.

Change-Id: I845ba16a70960beb2ce042b2eaddf22b17edcc25
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>

it would be conceivable to integrate this with the bot driving this
script, so the message would be appended only to the first patchset in a
change, or even only to the first complaint (within a while) for any
particular contributor.

Change-Id: I5a7e3265dea8a3e24649d223fdd6e96c886eebc1
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>

Change-Id: I6aff5775a2a9f9c685ba4121557e4c54a469304b
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>

Change-Id: Ifdeb8782bcc47730514eca1fb2f2a481c78484c7
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>

Change-Id: I83d33248a0f9f17e2d44f841064e5280110c006b
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

this was forgotten. it should be analogous to the rev-by check.

Change-Id: I82f35c13a9e17b03b196533e73aec8f240444265
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>

they are redundant with the canonical Task-number footers and steal
precious space in the summary line.

Change-Id: I339c450d6322a7c403b097d880bff10c8167d973
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>

some people think a summary like "revert commit 124fa614423" is a good
idea. it's not - without researching the history, it is meaningless.

Change-Id: I6de02d911073aa2982ee05a6804db370a05d49e5
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>

we don't need them, as contributors do a pre-emptive sign-off on all their
contributions by agreeing with the CLA.

Change-Id: Ibab565370e00800dde7fddaa10a7aa21c332037f
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>

unlike previously thought, gerrit won't eliminate known bogus footers,
so they would stay behind. consequently, complain about them loudly.

note that the footers are just fine above a "(cherry picked from ...)"
line, as we want to preserve the original approvals.

Change-Id: I7856810adb3e3b3e91e539eb626375dd32648460
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>

When cloning a new repository the directory .git/info does not
always exist. This change ensures this directory is always created
before trying to write to a file in that directory.

Change-Id: I9488caa7c4d0d80588ba880bee3bf9d8c11cca92
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

Change-Id: I118f57de2210bf361ec24d8fb32ca18f753a4c59
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>

The perl version which comes with msysgit is v5.8.8. There, the
script fails with

   Undefined subroutine &Cwd::realpath called at
       qtrepotools/bin/qt5_tool line 600.

In this perl version Cwd's realpath apparently needs to be
explicitly exported.

Change-Id: I467c5879e3b67e14652054fc9df1ce9fd547aa14
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>

Add alias for Allan and update Rohan's account to point to the active one.

Change-Id: I72bb56e304ec0a87ecb050a0255541f7da532a54
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

Change-Id: I7488892dd7016013e0a9fdc6b66bdfecf7b9f1dd
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>

The KDE paste server doesn't accept paste.kde.org any more,
pastebin.kde.org works.

Change-Id: I0f2ddbcc62cca98db463e5630acb1057de3e26ef
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>

Change-Id: I3f765054b9449847f30f96f451769f890a60ccd3
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>

Many C++ source files don't end with a '\n'

Change-Id: I785ee0ac0678f63ae41b2bcaddc77bc4c3e5c16e
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>

app.argc() doesn't exist anymore.

Change-Id: Ia4e871e673f819e85d41d4eabe04987a57313995
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>

Change-Id: Ia531b0d87b5fef7556f21803ec8883c782ea0f18
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>

Change-Id: I3df6caa4903c242981125abb2f5467b4b805dc02
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

The exception handling would actually mean that "cd .." was missed when
an exception occurred (eg no gerrit remote in repo).

Change-Id: I056e103cce6c5714a905c434e8341273d48db591
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

xcode generates them with tabs, so it's a futile fight to clean them up.

Change-Id: I68d0b0106047d6a62bf1ba99c20b2da657be75ea
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@digia.com>