Skip to content
GitLab
Select Git revision
  • 6.2.2
  • 6.2
  • dev default
  • 5.12.12
  • 5.15
  • 5.12
  • 6.2.1
  • 5.15.7
  • 6.2.0
  • 5.15.6
  • 5.15.5
  • 5.15.3
  • 5.12.11
  • 5.15.4
  • 5.15.2
  • 5.12.10
  • 5.15.1
  • 5.12.9
  • 5.15.0
  • wip/qtpdf
  • v5.15.0-alpha1
  • v5.12.7
  • v5.14.1
  • v5.9.9
  • v5.14.0
  • v5.14.0-rc2
  • v5.14.0-rc1
  • v5.12.6
  • v5.14.0-beta3
  • v5.13.2
  • v5.14.0-beta2
  • v5.14.0-beta1
  • v5.14.0-alpha1
  • v5.12.5
  • v5.13.1
  • v5.13.0
  • v5.13.0-rc3
  • v5.12.4
  • v5.13.0-rc2
  • v5.13.0-rc1
  1. 04 Apr, 2017 - 1 commit
  3. 21 Mar, 2017 - 1 commit
  5. 15 Mar, 2017 - 1 commit
    • Michael Brüning's avatar
      Remove stale parent connection when initializing delegate as a child · 8e147ed3
      Michael Brüning authored 
      
When clicking on a blank link target, the constructor of the
RenderWidgetHostViewQtDelegateWidget instance for the newly created
view is called with the originating QWebEngineView as its parent
and will connect its removeParentBeforeParentDelete slot to the
originating view's destroyed signal.

This leads to the situation where the delegate's parent will be set to
null when the originating view is closed, causing the view to display
only an empty widget with the actual web contents remaining live in
the background.

This patch removes the connection to the old view when initializing
the delegate as a child of the QWebEnginePagePrivate instance. The
addition to the layout updates the parent and child relationship
between the view and the delegate internally.

Task-number: QTBUG-58381
Change-Id: I448380478c2bcfcfbddaee8a35caf46010e57972
Reviewed-by: default avatarFlorian Bruhin <qt-project.org@the-compiler.org>
Reviewed-by: default avatarJoerg Bornemann <joerg.bornemann@qt.io>
      8e147ed3
  7. 08 Mar, 2017 - 1 commit
  9. 07 Mar, 2017 - 1 commit
  11. 03 Mar, 2017 - 1 commit
  13. 28 Feb, 2017 - 1 commit
    • Viktor Engelmann's avatar
      Pass <input type="file"> result to correct RenderFrameHost · 3f1805f8
      Viktor Engelmann authored 
      
In WebContentsDelegateQt::RunFileChooser, we get a
content::RenderFrameHost*, to which chromium wants us to pass the
files that were selected. We now store that pointer in the
FilePickerController, so that we can pass the files there in
FilePickerController::filesSelectedInChooser.
The attribute content::WebContents *m_contents is no longer needed
then, because that was only used to obtain the main frame to which
the files were sent (this caused problems when the file input was
inside an iframe - we sent the result to the wrong frame in that
case, so the file input object remained blocked).

Task-number: QTBUG-59168
Change-Id: Ic2fdacb225e5a1a9e46ced6a1e4a9ff428f18a62
Reviewed-by: default avatarMichael Brüning <michael.bruning@qt.io>
Reviewed-by: default avatarAllan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: default avatarMichal Klocek <michal.klocek@qt.io>
      3f1805f8
  15. 27 Feb, 2017 - 1 commit
  17. 23 Feb, 2017 - 1 commit
    • Alexandru Croitor's avatar
      Add support for macOS Airplay to Demobrowser in presence of dual GPUs · 714bddf9
      Alexandru Croitor authored 
      
Previously when Airplay was activated and a new QWebEngineView instance
was created, a black area would be rendered inside the view.
This happened because of incompatible OpenGL contexts. The global Qt
OpenGL context could not share its textures with the newly created
"after-airplay" context, due to the contexts being used by different
GPUs (only possible on a MacBook Pro).

The fix is to add the NSSupportsAutomaticGraphicsSwitching option into
the application plist file, which informs macOS that the application
supports usage of dual GPUs, and thus allows sharing of contexts
across GPUs.

Task-number: QTBUG-54053
Change-Id: Ic37fb75f164922bcca6456054174171fa9ba2bfb
Reviewed-by: default avatarLeena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: default avatarAllan Sandfeld Jensen <allan.jensen@qt.io>
      714bddf9
  19. 22 Feb, 2017 - 5 commits
  21. 21 Feb, 2017 - 3 commits
    • Alexandru Croitor's avatar
      Fix building spellchecker example when Qt is not yet installed · 16d8518e
      Alexandru Croitor authored 
      
During the build of the spellchecker example, the dictionary
conversion tool is executed to convert some dictionaries. The tool
will fail to find the ICU data file because the file is not present
at the Qt install location at examples build time.

The fix is to allow passing the ICU data directory via an environment
variable. Specifically the QtWebEngine build directory which contains
the ICU data file will be passed when the spellchecker example is
built.

Task-number: QTBUG-58451
Change-Id: I6188f0b7aabe8b2e55cd2e0d59553282058c5035
Reviewed-by: default avatarMichal Klocek <michal.klocek@qt.io>
      16d8518e
    • Joerg Bornemann's avatar
      Fix Q_ASSERT when dragging an item over WebEngineView · 37206c2b
      Joerg Bornemann authored 
      
When dragging something over a WebEngineView we're waiting for the
result of the asynchronous DragTargetDragOver using a RunLoop. The
result will be delivered by a call to updateDragAction.

The RunLoop will call MessagePumpForUIQt::Run which spins a QEventLoop.
The QEventLoop will dispatch more posted QDragMoveEvent objects while
we're handling the current QDragMoveEvent. This triggers a recursion
guard's Q_ASSERT when dragging from a QtQuick item onto a WebEngineView.

When waiting for the DragTargetDragOver result we're not interested in
Qt events. Instead of using a RunLoop, implement a poor man's chromium
event loop and actively wait for updateDragAction being called.

In practice, no more than two iterations of the loop are run until
updateDragAction is called. Therefore the extra CPU and sleep times are
negligible.

Task-number: QTBUG-58920
Change-Id: Icfdf9c680c4c9987ac3dbb41fbc3e1403af0fa9f
Reviewed-by: default avatarAllan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: default avatarAlexandru Croitor <alexandru.croitor@qt.io>
      37206c2b
    • Szabolcs David's avatar
      Fix empty dialogs on window.onbeforeunload · 90501711
      Szabolcs David authored 
      
Custom texts are not supported anymore in unload dialogs. Fill them
with a better message.

Task-number: QTBUG-58673
Change-Id: I820155452461db90bf1df2ae8a8ec10ee752aab1
Reviewed-by: default avatarJoerg Bornemann <joerg.bornemann@qt.io>
      90501711
  23. 20 Feb, 2017 - 1 commit
    • Alexandru Croitor's avatar
      Fix QWebEngineView::setFocus to properly set internal QQuickItem focus · a6c6665d
      Alexandru Croitor authored 
      
The widgets object hierarchy related to focus goes like this:
QWebEngineView's focus proxy is ->
RenderWidgetHostViewQtDelegateWidget, which has an internal
QQuickRootItem defined by QQuickWidget, and the child of the item is ->
RenderWidgetHostViewQuickItem.

Previously when QWebEngineView::setFocus was called, the focus was set
on the RenderWidgetHostViewQtDelegateWidget and the QQuickRootItem,
but not on the RenderWidgetHostViewQuickItem. This caused for e.g.
an active HTML text input not receiving focus.

Make sure the RenderWidgetHostViewQuickItem is marked to have focus
within its root item, so that if the root item receives active focus,
so will RenderWidgetHostViewQuickItem receive it.

Task-number: QTBUG-58515
Change-Id: I175610e3dfebc03733aefe26c16f47096df8ff5b
Reviewed-by: default avatarAllan Sandfeld Jensen <allan.jensen@qt.io>
      a6c6665d
  25. 17 Feb, 2017 - 1 commit
  27. 16 Feb, 2017 - 1 commit
  29. 14 Feb, 2017 - 1 commit
  31. 13 Feb, 2017 - 1 commit
  33. 10 Feb, 2017 - 3 commits
  35. 09 Feb, 2017 - 1 commit
  37. 07 Feb, 2017 - 2 commits
  39. 02 Feb, 2017 - 1 commit
    • Viktor Engelmann's avatar
      Provisional Fix for Navigation-Breakage on right-click in Flash applet · 685366c9
      Viktor Engelmann authored 
      
When one right-clicks into a flash applet, chromium believes that a
context menu was open (even though
PepperRendererHostFactoryQt::CreateResourceHost returns NULL, which
only causes an ASSERT on chromiums side).
Because of this, the navigation is disabled, although no context menu
is displayed. This fix just sends a message to chromium, telling it
that "the context menu" is now "closed", which causes another ASSERT,
but re-enables the navigation.

Task-number: QTBUG-57924
Change-Id: Id6d8150a7d4944162bab81362153f8621d35bb4c
Reviewed-by: default avatarAllan Sandfeld Jensen <allan.jensen@qt.io>
      685366c9
  41. 01 Feb, 2017 - 1 commit
  43. 26 Jan, 2017 - 3 commits
  45. 25 Jan, 2017 - 3 commits
  47. 22 Jan, 2017 - 1 commit
  49. 20 Jan, 2017 - 2 commits
  51. 18 Jan, 2017 - 1 commit