- 28 Mar, 2017 - 1 commit
-
-
Florian Bruhin authored
This unfortunately means we lose the ability to customize the title with the default implementation, but it's still better than having a QMessageBox hardcoded without being able to customize this behavior at all. [ChangeLog][Qt WebEngineWidgets][QWebEnginePage] The javaScriptConfirm method is now also called for unload dialogs (onbeforeunload handlers). Task-number: QTBUG-58673 Change-Id: I82393da2593dc84e94d577ff28f5d6d8988df552 Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io>
-
- 22 Feb, 2017 - 2 commits
-
-
Allan Sandfeld Jensen authored
Instead of calling deleteLater, just tell close to delete the menu itself. Task-number: QTBUG-59080 Change-Id: I3eae382781f813ed3c6f27b78088b94ed1c486dd Reviewed-by:
Michal Klocek <michal.klocek@qt.io> Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu>
-
Viktor Engelmann authored
In the destructor of QWebEnginePage and QQuickWebEngineView, we now call adapter->stopFinding() to suppress callbacks that would cause segmentation faults if a findText request is still active at that point. Task-number: QTBUG-58563 Change-Id: I9d5d8407ee6c28cd76bf6ecf0b62808394e151cd Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-
- 21 Feb, 2017 - 1 commit
-
-
Szabolcs David authored
Custom texts are not supported anymore in unload dialogs. Fill them with a better message. Task-number: QTBUG-58673 Change-Id: I820155452461db90bf1df2ae8a8ec10ee752aab1 Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io>
-
- 09 Feb, 2017 - 1 commit
-
-
Leena Miettinen authored
- Leave out the class name for the members of the class - Add brackets in the end of method names Change-Id: I5429be5620c5c192aa872d94ab047eebe39a13da Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- 16 Jan, 2017 - 1 commit
-
-
Michal Klocek authored
Currently printing and pdf are bounded together. Make compilation optional by adding it as a feature. Fix formatting of embedded_linux.pri Task-number: QTBUG-57731 Task-number: QTBUG-58108 Change-Id: I53a2baea656df0a5b6139365ed06385c9ebc5830 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- 11 Jan, 2017 - 1 commit
-
-
Viktor Engelmann authored
Added class QWebEngineHttpRequest, which describes a GET or POST HTTP Request. Also added overloads of method "load" to QWebEngineView, QWebEnginePage and WebContentsAdapter, which issue such a request. These can be used for example to simulate form-submissions. Task-number: QTBUG-53314 Task-number: QTBUG-53372 Change-Id: I85ac8cdd3d1557905b35e3172b922aba356d1c41 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- 10 Jan, 2017 - 1 commit
-
-
Michael Brüning authored
[ChangeLog][Important Changes] Printing to a PDF file will now emit signal the signal pdfPrintingFinished in both QQuickWebEngineView and QWebEnginePage. The boolean passed with the signal to indicate if the printing and saving of the PDF was successful. The path of the created file is also passed to enable the user to map the signal to a print request. Task-number: QTBUG-56677 Change-Id: Ifab5a20b048f33a8cd872165bd4d453b01708037 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by:
Leena Miettinen <riitta-leena.miettinen@qt.io>
-
- 01 Dec, 2016 - 1 commit
-
-
Peter Varga authored
Wrap unused parameters. Change-Id: Iac550783a55b3fc585db6f7b8241aa2ae89fdf2e Reviewed-by:
Michael Brüning <michael.bruning@qt.io> Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- 25 Nov, 2016 - 2 commits
-
-
Michael Brüning authored
Both the printer code and the webengine printing code were producing the number of requested copies. So if n copies were requested, n*n copies of the document were printed. Task-number: QTBUG-56722 Change-Id: I34bce2d61041e1234139139dcd70b7b3d1c7cd7b Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Michael Brüning authored
This moves the actual printing using QPrinter to the WebEngineWidgets part of the API. The printsupport module depends on the widgets module and therefore QtWebEngineCore also had a dependency to widgets. This is removed by this change. Change-Id: If6e5745709a59de18f2123b930cbe6e64390c867 Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-
- 10 Nov, 2016 - 1 commit
-
-
Alexandru Croitor authored
Previously when a QWebEngineView was inside a modal QDialog, trying to click on a select tag option did not properly select the option. It either focused the new option without closing the popup, or didn't focus it at all. Fix consists in making sure the newly created popup QWindow and RenderWidgetHostViewQtDelegateWidget are marked as children of the QWebEngineView, so that they are considered part of the current modal session by the OS, thus allowing user interaction with them. Because the ownership of the delegate widget should still be retained by its respective RenderWidgetHostViewQt instance, the QObject parent of the delegate is unset before the parent is destroyed. Also to make it work on macOS, the window attribute has to be set to Qt::Tool instead of Qt::ToolTip. Change-Id: I56d6f446254a624428a0c661ac3c49eb409c931e Task-number: QTBUG-54836 Reviewed-by:
Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by:
Michael Brüning <michael.bruning@qt.io>
-
- 08 Nov, 2016 - 1 commit
-
-
Michael Brüning authored
It used to be just ignored. Task-number: QTBUG-56643 Change-Id: Ife7ac05fce7e93a6eba1ac6e6db1095574c83e42 Reviewed-by:
Viktor Engelmann <viktor.engelmann@qt.io> Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io>
-
- 26 Oct, 2016 - 1 commit
-
-
Joerg Bornemann authored
Delete the FilePickerControl object after we're done with it, analog to what the QtQuick UIDelegatesManager does. Change-Id: Id5ef6666c8536b9e5c6877cd522b4c20adae37e5 Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-
- 01 Oct, 2016 - 1 commit
-
-
Peter Varga authored
Task-number: QTBUG-56092 Change-Id: I026a0d153269a71e4e44f0fd30ef5ca054edd0e7 Reviewed-by:
Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- 26 Sep, 2016 - 1 commit
-
-
Kai Koehne authored
Change-Id: Id9a050775c5cdf54d207bb063d705237c4900f40 Reviewed-by:
Michael Brüning <michael.bruning@qt.io> Reviewed-by:
Leena Miettinen <riitta-leena.miettinen@qt.io>
-
- 31 Aug, 2016 - 2 commits
-
-
Michal Klocek authored
Introduce qml APIs to support custom context menus. [ChangeLog][QtWebEngine][QML] Added ability to show custom context menu. Task-number: QTBUG-52554 Change-Id: Ief0cbbbf221f4c6849e16bbba7417dccee59ad61 Reviewed-by:
Kai Koehne <kai.koehne@qt.io>
-
Michal Klocek authored
Introduce qml APIs to support custom dialogs: * http and proxy authentication * javascript dialogs * file pickers * color pickers * form validation messages [ChangeLog][QtWebEngine][QML] Added ability to provide custom dialogs for HTTP and proxy authentication, JavaScript alerts, file and color picking, and form validation messages. Task-number: QTBUG-51190 Change-Id: I559ca59264750feb36ba7d3dba0bf0647509306d Reviewed-by:
Kai Koehne <kai.koehne@qt.io>
-
- 24 Aug, 2016 - 1 commit
-
-
Michael Bruning authored
Renders the content to a PDF document and then renders this on a QPrinter-backed QPainter using the PDFium library. PDFium bitmap to QImage conversion based on work by Paulo Pinheiro <paulvap.os@gmail.com>. [ChangeLog][QtWebEngineWidgets][Printing] Enables printing QWebPage content on a QPrinter. Currently does not support previewing the document. Widgets only for the moment. Change-Id: I9a5264433093379aee90f5e4f69bf2aee8814f2b Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- 23 Aug, 2016 - 1 commit
-
-
Allan Sandfeld Jensen authored
Ensure that if QWebEnginePage::createWindow returns 'this' that we fall back to navigating in current tab. Change-Id: Idffe25dcafaaf3c824815b3cf1f0e400eaec2923 Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-
- 02 Aug, 2016 - 1 commit
-
-
Peter Varga authored
[ChangeLog][QtWebEngineQML][QQuickWebEngineView] View Source feature is now supported [ChangeLog][QtWebEngineWidgets][QWebEnginePage] View Source feature is now supported Change-Id: Icc16da71fc6ec95880897fc9744dd8be8c004e00 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- 14 Jul, 2016 - 1 commit
-
-
Adam Kallai authored
This is essential for set tooltip in Qt Quick part because the setToolTip function should not be public. Change-Id: I1ebd0c811504fded8edff1a5a6110ce3512bab4f Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by:
Michael Brüning <michael.bruning@qt.io>
-
- 08 Jul, 2016 - 1 commit
-
-
Joerg Bornemann authored
Consider a QWebEnginePage subclass that does "return this;" in createWindow. Commit 1f07d292 made this a no-op to prevent QtWebEngine from crashing. The reason for the crash was access to deleted memory after destroying the current adapter in adoptNewWindow. Defer the adoption in this case to whenever we hit the event loop again. Change-Id: I9674d80ef8b2f301c1446ff505b2486649451ba6 Task-number: QTBUG-42216 Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-
- 02 Jul, 2016 - 1 commit
-
-
Michal Klocek authored
This reverts commit: * d364c05d * e507f140 Moreover it fixes shut down of keyed services, updates versioning of and fixes spellcheck unit test context menu request, which otherwise fails on windows. Change-Id: I9bfc589544cb969abd6d2d7af69531b4c5c907b7 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- 01 Jul, 2016 - 2 commits
-
-
Allan Sandfeld Jensen authored
QExplicitSharedDataPointer is meant for value objects, not for shared objects. Instead switch to using QSharedPointer. Change-Id: Ib3791bbcfde627a67508f2819e141d8c538a4a50 Reviewed-by:
Michael Brüning <michael.bruning@qt.io> Reviewed-by:
Michal Klocek <michal.klocek@theqtcompany.com>
-
Allan Sandfeld Jensen authored
While the script collection always follows a page, it is safer to have both hold a reference to the web-contents adapter, so it doesn't get deleted while adapters are being changed. Change-Id: I21e268f7228f13702468df61e0032bdf2f99873a Reviewed-by:
Michael Brüning <michael.bruning@qt.io>
-
- 30 Jun, 2016 - 1 commit
-
-
Allan Sandfeld Jensen authored
The script collection has a pointer to webcontents adapter, and when a new adapter is adopted, the pointer in the script collection needs to be updated. Task-number: QTBUG-54419 Change-Id: Ia054e1281ab4db637beab570abda752074dc9280 Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io>
-
- 22 Jun, 2016 - 1 commit
-
-
Allan Sandfeld Jensen authored
To ensure Chromium is given a chance to handle editor commands, we must override these short-cuts. On OS X we must also perform the action afterwards as these are not handled internally by the Blink Editor. The patch solves copy/paste in flash plugins and copy/paste on OS X when no application short-cuts have been defined. The handling of short-cut override events is based on how it was handled in Qt WebKit Task-number: QTBUG-54221 Change-Id: I748671c7bfa5662aae16c6a4b9bbe5e2bce1b907 Reviewed-by:
Alexandru Croitor <alexandru.croitor@theqtcompany.com>
-
- 16 Jun, 2016 - 2 commits
-
-
Joerg Bornemann authored
Add the convenience method QWebEnginePage::save for saving pages without the need to explicitly handle download requests. Task-number: QTBUG-51798 Change-Id: I8910ce8cb7c9370d72f2b209c4d2de07c614f6d6 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Joerg Bornemann authored
Suppose QWebEnginePage is destroyed while there's still a combobox popup open. We would crash with the following stack trace: 1 QtWebEngineCore::RenderWidgetHostViewQt::dpiScale 2 QtWebEngineCore::RenderWidgetHostViewQt::GetViewBounds 3 content::RenderWidgetHostImpl::SendScreenRects 4 content::RenderWidgetHostImpl::OnRenderViewReady ... 16 base::MessageLoop::DoWork 17 WebEngineContext::destroy 18 `anonymous namespace'::destroyContext 19 qt_call_post_routines 20 QApplication::~QApplication RenderWidgetHostViewQt still holds a pointer to WebContentsAdapterClient. To fix this, expose the QObject owning the adapter client, and hide RenderWidgetHostViewQt when it is destroyed so it won't try to render. Change-Id: Ide5543197b35038a3e1c7491ceda3f5ad10f6f07 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- 09 Jun, 2016 - 1 commit
-
-
Michael Bruning authored
It does contain valid data and some users seem to build upon the standard context menu. Also, return early with a nullptr from createStandardContextMenu when the context menu data d ptr is null. Task-number: QTBUG-53952 Change-Id: Ib30e85f10e3ae681527210a9e8554f5a21dba7ae Reviewed-by:
Leena Miettinen <riitta-leena.miettinen@qt.io>
-
- 26 May, 2016 - 1 commit
-
-
Alexandru Croitor authored
Currently if a QWebEngineView or a QQuickWebEngineView is disabled using setEnabled(false), after loading a web page, the views are automatically focused, and a user might see a blinking caret in an html input for example, even though the user can't interact with it. Fix consists in not calling the Focus() method whenever a view is disabled. Change-Id: I1014fb5898a5ddf01a4e9b14c3eaf5d4006e5131 Task-number: QTBUG-53159 Reviewed-by:
Michal Klocek <michal.klocek@theqtcompany.com>
-
- 06 May, 2016 - 1 commit
-
-
Michal Klocek authored
Spellchecking API needs a bit more reviews and love. Current API is not intuitive and partly broken. Change-Id: Ie9cd371f38cca2f6b3f56a8699ad874cd332c318 Reviewed-by:
Michael Brüning <michael.bruning@theqtcompany.com>
-
- 04 May, 2016 - 1 commit
-
-
Peter Varga authored
For the Widget API the QIcon returned by QWebEnginePage::icon() function contains all the candidate icons for the current page. For the Quick API the QQuickWebEngineFaviconProvider provides the best quality icon for the requested size from the candidates. Task-number: QTBUG-51179 Change-Id: I42b8427f957e2f2fc745dd0111bedcc71b577216 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
-
- 28 Apr, 2016 - 1 commit
-
-
Allan Sandfeld Jensen authored
Prefer to list all enums to handling defaults, this makes it easier to catch missing cases in the future. Change-Id: Idae2f445bd907f62202a6b68da0d030e21863afe Reviewed-by:
Alexandru Croitor <alexandru.croitor@theqtcompany.com> Reviewed-by:
Kai Koehne <kai.koehne@qt.io>
-
- 27 Apr, 2016 - 1 commit
-
-
Allan Sandfeld Jensen authored
We were not handling this enum value. Change-Id: Ib44b9e42c8b9589513091d2f47c79623416ec358 Reviewed-by:
Joerg Bornemann <joerg.bornemann@theqtcompany.com>
-
- 19 Apr, 2016 - 1 commit
-
-
Allan Sandfeld Jensen authored
BrowserContextAdapter is not a form of shared data, and using QExplicitSharedDataPointer on it as always been a misuse of the class. Instead we should switch it to QSharedPointer, which also allows us to use QWeakPointer. Change-Id: I8eb489b4a12d3fdddcde55821be294814a156a9d Reviewed-by:
Kai Koehne <kai.koehne@qt.io> Reviewed-by:
Michal Klocek <michal.klocek@theqtcompany.com>
-
- 18 Apr, 2016 - 1 commit
-
-
Michal Klocek authored
* marks new properties in QQuickWebEngineProfile as FINAL * removes QT_NO_SPELLCHECK from API headers * renames spellCheckLanguages() to availableDictionaries() * removes "togle spellcheck" methods and actions * use WEBENGINE_CONFIG instead of CONFIG for disable the feature at compile time: WEBENGINE_CONFIG+=no_spellcheck Done-With: Peter Varga <pvarga@inf.u-szeged.hu> Task-number: QTBUG-52371 Change-Id: I8c8eff497b9e7afe0cec2edc97dec248151487f2 Reviewed-by:
Michael Brüning <michael.bruning@theqtcompany.com>
-
- 13 Apr, 2016 - 2 commits
-
-
Joerg Bornemann authored
The SavePage web action is only useful if the user code reacts on the downloadRequested signal. Also, having SavePage available is not useful for e.g. hybrid applications. Extend the demobrowser example to show how to add the SavePage web action to the context menu. Change-Id: I979bcd9f5a25d2cae07ef819663afde17784440b Task-number: QTBUG-52370 Reviewed-by:
Michael Brüning <michael.bruning@theqtcompany.com> Reviewed-by:
Kai Koehne <kai.koehne@theqtcompany.com>
-
Michael Bruning authored
Adds default QPageLayout values. Change-Id: Ibf2964ecd86350a51d682e385973f830ac4347a7 Reviewed-by:
Joerg Bornemann <joerg.bornemann@theqtcompany.com>
-