Change-Id: Ieef29fa09c8b4733737840ce6260ac6e87e7dca0
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>

Wire unfiltered link URL to the API layer.

[ChangeLog][QtWebEngine] linkUrl member of
QWebEngineContextMenuData and ContextMenuRequest was previously
returning with "about:blank" in case of non-standard URLs.
Now it contains the unvalidated URL and CopyLinkToClipboard action
has been fixed to handle such URLs (like javascript:) correctly.

Task-number: QTBUG-59307
Change-Id: I2e49767e1cc9ec8324d230c1bf346e21d7b8d9bb
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

Calling the method window.focus() in javascript causes chromium to send
a ViewHostMsg_Focus message, which is received by RenderViewHost,
which then calls RenderViewHost::OnFocus.
This calls WebContentsDelegate::ActivateContents, which does
nothing in the default implementation. We now override this method in
WebContentsDelegateQt::ActivateContents and call Focus() on
the WebContents object IF the new WebEngineSettings value
AllowWindowActivationFromJavaScript is true (by default, it is false).
This in turn calls QWebEnginePagePrivate::focusContainer.
The WebEnginePage now calls QWidget::activateWindow() in addition
to QWidget::setFocus, to make sure the window is also activated (which
it might not be, if multiple windows are open).
For the QML side, a new boolean Property
allowWindowActivationFromJavaScript was added.

Task-number: QTBUG-58800
Change-Id: Iabf5d4d15236c77838a3886de81e9dafcaf49f5d
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>

The standard context menu currently doesn't have the "Follow link" item for e.g.
the image links on https://www.qt.io

 .

Change-Id: I5b9d620135c7a8e65bd95a0ab07a76278e56cad0
Reviewed-by: Michal Klocek <michal.klocek@qt.io>

QWebEnginePage::runJavaScript and QQuickWebEngineView::runJavaScript
have QString parameters. Passing raw strings causes them to be passed
to the deprecated QString constructor, which causes warnings in the
compilation.

Change-Id: I072149ca85c94b2b94c7b5d9aa198eddd47460e8
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

Failing to do so would trigger an assert in the PDFium wrapper's
constructor.

Change-Id: Iaa53b1baa54e6483a4e7e9985ad841ac3cfef940
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>

Add WebActions ToggleBold, ToggleItalic, ToggleUnderline,
ToggleStrikethrough, AlignLeft, AlignCenter, AlignRight,
AlignJustified, Indent, Outdent, InsertOrderedList and
InsertUnorderedList.
All use the javascript document.execCommand with
parameters according to
https://developer.mozilla.org/de/docs/Web/API/Document/execCommand



Task-number: QTBUG-59221
Change-Id: Ife18d660fefa2073351c5ad959611ec47b680dc6
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>

This unfortunately means we lose the ability to customize the title with the
default implementation, but it's still better than having a QMessageBox
hardcoded without being able to customize this behavior at all.

[ChangeLog][Qt WebEngineWidgets][QWebEnginePage] The javaScriptConfirm method is
now also called for unload dialogs (onbeforeunload handlers).

Task-number: QTBUG-58673
Change-Id: I82393da2593dc84e94d577ff28f5d6d8988df552
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>

Instead of calling deleteLater, just tell close to delete the menu
itself.

Task-number: QTBUG-59080
Change-Id: I3eae382781f813ed3c6f27b78088b94ed1c486dd
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>

In the destructor of QWebEnginePage and QQuickWebEngineView, we
now call adapter->stopFinding() to suppress callbacks that would
cause segmentation faults if a findText request is still active
at that point.

Task-number: QTBUG-58563
Change-Id: I9d5d8407ee6c28cd76bf6ecf0b62808394e151cd
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>

Custom texts are not supported anymore in unload dialogs. Fill them
with a better message.

Task-number: QTBUG-58673
Change-Id: I820155452461db90bf1df2ae8a8ec10ee752aab1
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>

- Leave out the class name for the members of the class
- Add brackets in the end of method names

Change-Id: I5429be5620c5c192aa872d94ab047eebe39a13da
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

Currently printing and pdf are bounded together. Make compilation
optional by adding it as a feature.

Fix formatting of embedded_linux.pri

Task-number: QTBUG-57731
Task-number: QTBUG-58108
Change-Id: I53a2baea656df0a5b6139365ed06385c9ebc5830
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

Added class QWebEngineHttpRequest, which describes a
GET or POST HTTP Request. Also added overloads of method
"load" to QWebEngineView, QWebEnginePage and WebContentsAdapter,
which issue such a request.
These can be used for example to simulate form-submissions.

Task-number: QTBUG-53314
Task-number: QTBUG-53372
Change-Id: I85ac8cdd3d1557905b35e3172b922aba356d1c41
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

[ChangeLog][Important Changes] Printing to a PDF file will now emit
signal the signal pdfPrintingFinished in both QQuickWebEngineView
and QWebEnginePage.

The boolean passed with the signal to indicate if the printing and
saving of the PDF was successful. The path of the created file is
also passed to enable the user to map the signal to a print request.

Task-number: QTBUG-56677
Change-Id: Ifab5a20b048f33a8cd872165bd4d453b01708037
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>

Wrap unused parameters.

Change-Id: Iac550783a55b3fc585db6f7b8241aa2ae89fdf2e
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

Both the printer code and the webengine printing code were
producing the number of requested copies. So if n copies were
requested, n*n copies of the document were printed.

Task-number: QTBUG-56722
Change-Id: I34bce2d61041e1234139139dcd70b7b3d1c7cd7b
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

This moves the actual printing using QPrinter to the WebEngineWidgets
part of the API.
The printsupport module depends on the widgets module and therefore
QtWebEngineCore also had a dependency to widgets. This is removed by
this change.

Change-Id: If6e5745709a59de18f2123b930cbe6e64390c867
Reviewed-by: Michal Klocek <michal.klocek@qt.io>

Previously when a QWebEngineView was inside a modal QDialog, trying to
click on a select tag option did not properly select the option. It
either focused the new option without closing the popup, or didn't
focus it at all.

Fix consists in making sure the newly created popup QWindow and
RenderWidgetHostViewQtDelegateWidget are marked as children of the
QWebEngineView, so that they are considered part of the current modal
session by the OS, thus allowing user interaction with them.

Because the ownership of the delegate widget should still be retained
by its respective RenderWidgetHostViewQt instance, the QObject parent
of the delegate is unset before the parent is destroyed.

Also to make it work on macOS, the window attribute has to be set
to Qt::Tool instead of Qt::ToolTip.

Change-Id: I56d6f446254a624428a0c661ac3c49eb409c931e
Task-number: QTBUG-54836
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>

It used to be just ignored.

Task-number: QTBUG-56643
Change-Id: Ife7ac05fce7e93a6eba1ac6e6db1095574c83e42
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>

Delete the FilePickerControl object after we're done with it, analog to
what the QtQuick UIDelegatesManager does.

Change-Id: Id5ef6666c8536b9e5c6877cd522b4c20adae37e5
Reviewed-by: Michal Klocek <michal.klocek@qt.io>

Task-number: QTBUG-56092
Change-Id: I026a0d153269a71e4e44f0fd30ef5ca054edd0e7
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

Change-Id: Id9a050775c5cdf54d207bb063d705237c4900f40
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>

Introduce qml APIs to support custom context menus.

[ChangeLog][QtWebEngine][QML] Added ability to show custom
context menu.

Task-number: QTBUG-52554
Change-Id: Ief0cbbbf221f4c6849e16bbba7417dccee59ad61
Reviewed-by: Kai Koehne <kai.koehne@qt.io>

Introduce qml APIs to support custom dialogs:
 * http and proxy authentication
 * javascript dialogs
 * file pickers
 * color pickers
 * form validation messages

[ChangeLog][QtWebEngine][QML] Added ability to provide custom dialogs
for HTTP and proxy authentication, JavaScript alerts, file and color
picking, and form validation messages.

Task-number: QTBUG-51190
Change-Id: I559ca59264750feb36ba7d3dba0bf0647509306d
Reviewed-by: Kai Koehne <kai.koehne@qt.io>

Renders the content to a PDF document and then renders this on a
QPrinter-backed QPainter using the PDFium library.

PDFium bitmap to QImage conversion based on work by Paulo Pinheiro
<paulvap.os@gmail.com>.

[ChangeLog][QtWebEngineWidgets][Printing] Enables printing QWebPage
content on a QPrinter. Currently does not support previewing the
document. Widgets only for the moment.

Change-Id: I9a5264433093379aee90f5e4f69bf2aee8814f2b
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

Ensure that if QWebEnginePage::createWindow returns 'this' that we fall
back to navigating in current tab.

Change-Id: Idffe25dcafaaf3c824815b3cf1f0e400eaec2923
Reviewed-by: Michal Klocek <michal.klocek@qt.io>

[ChangeLog][QtWebEngineQML][QQuickWebEngineView] View Source feature is
now supported
[ChangeLog][QtWebEngineWidgets][QWebEnginePage] View Source feature is
now supported

Change-Id: Icc16da71fc6ec95880897fc9744dd8be8c004e00
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

This is essential for set tooltip in Qt Quick part
because the setToolTip function should not be public.

Change-Id: I1ebd0c811504fded8edff1a5a6110ce3512bab4f
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>

Consider a QWebEnginePage subclass that does "return this;" in
createWindow. Commit 1f07d292

 made this a no-op to prevent QtWebEngine
from crashing. The reason for the crash was access to deleted memory
after destroying the current adapter in adoptNewWindow.
  Defer the adoption in this case to whenever we hit the event loop
again.

Change-Id: I9674d80ef8b2f301c1446ff505b2486649451ba6
Task-number: QTBUG-42216
Reviewed-by: Michal Klocek <michal.klocek@qt.io>

This reverts commit:
 * d364c05d
 * e507f140



Moreover it fixes shut down of keyed services,
updates versioning of and fixes spellcheck unit
test context menu request, which otherwise
fails on windows.

Change-Id: I9bfc589544cb969abd6d2d7af69531b4c5c907b7
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

QExplicitSharedDataPointer is meant for value objects, not for shared
objects. Instead switch to using QSharedPointer.

Change-Id: Ib3791bbcfde627a67508f2819e141d8c538a4a50
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@theqtcompany.com>

While the script collection always follows a page, it is safer to have
both hold a reference to the web-contents adapter, so it doesn't get
deleted while adapters are being changed.

Change-Id: I21e268f7228f13702468df61e0032bdf2f99873a
Reviewed-by: Michael Brüning <michael.bruning@qt.io>

The script collection has a pointer to webcontents adapter, and when a
new adapter is adopted, the pointer in the script collection needs to
be updated.

Task-number: QTBUG-54419
Change-Id: Ia054e1281ab4db637beab570abda752074dc9280
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>

To ensure Chromium is given a chance to handle editor commands,
we must override these short-cuts.

On OS X we must also perform the action afterwards as these are not
handled internally by the Blink Editor.

The patch solves copy/paste in flash plugins and copy/paste on OS X
when no application short-cuts have been defined. The handling of
short-cut override events is based on how it was handled in Qt WebKit

Task-number: QTBUG-54221
Change-Id: I748671c7bfa5662aae16c6a4b9bbe5e2bce1b907
Reviewed-by: Alexandru Croitor <alexandru.croitor@theqtcompany.com>

Add the convenience method QWebEnginePage::save for saving pages without
the need to explicitly handle download requests.

Task-number: QTBUG-51798
Change-Id: I8910ce8cb7c9370d72f2b209c4d2de07c614f6d6
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

Suppose QWebEnginePage is destroyed while there's still a combobox popup
open. We would crash with the following stack trace:

1   QtWebEngineCore::RenderWidgetHostViewQt::dpiScale
2   QtWebEngineCore::RenderWidgetHostViewQt::GetViewBounds
3   content::RenderWidgetHostImpl::SendScreenRects
4   content::RenderWidgetHostImpl::OnRenderViewReady
...
16  base::MessageLoop::DoWork
17  WebEngineContext::destroy
18  `anonymous namespace'::destroyContext
19  qt_call_post_routines
20  QApplication::~QApplication

RenderWidgetHostViewQt still holds a pointer to WebContentsAdapterClient.
To fix this, expose the QObject owning the adapter client, and
hide RenderWidgetHostViewQt when it is destroyed so it won't try to render.

Change-Id: Ide5543197b35038a3e1c7491ceda3f5ad10f6f07
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

It does contain valid data and some users seem to build upon the
standard context menu.

Also, return early with a  nullptr from createStandardContextMenu when
the context menu data d ptr is null.

Task-number: QTBUG-53952
Change-Id: Ib30e85f10e3ae681527210a9e8554f5a21dba7ae
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>

Currently if a QWebEngineView or a QQuickWebEngineView is disabled
using setEnabled(false), after loading a web page, the views are
automatically focused, and a user might see a blinking caret in an html
input for example, even though the user can't interact with it.

Fix consists in not calling the Focus() method whenever a view is
disabled.

Change-Id: I1014fb5898a5ddf01a4e9b14c3eaf5d4006e5131
Task-number: QTBUG-53159
Reviewed-by: Michal Klocek <michal.klocek@theqtcompany.com>

Spellchecking API needs a bit more reviews and love.
Current API is not intuitive and partly broken.

Change-Id: Ie9cd371f38cca2f6b3f56a8699ad874cd332c318
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>