- 15 Apr, 2018 - 1 commit
-
-
Michal Klocek authored
The check g_egl_surfaceless_context_supported can not take place in InitializeExtensionSettingsOneOff since correct surface/less initialization is required for gpu info collection which is initialized with InitializeGLNoExtensionsOneOff. Otherwise egl with pbuffers is only supported, which will fail on wayland. Move the check to InitializeOneOff. Task-number: QTBUG-65682 Change-Id: I0f5107134366f141e1941e824e3238473383962a Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- 13 Apr, 2018 - 6 commits
-
-
Jüri Valdmann authored
Change-Id: I2a5b35810d20dec685e134f6d8fe3383003d33d1 Reviewed-by:
Kai Koehne <kai.koehne@qt.io>
-
Jüri Valdmann authored
Change-Id: I55b033a03ec581841e1cea55c3d707067ee5ef42 Reviewed-by:
Kai Koehne <kai.koehne@qt.io>
-
Jüri Valdmann authored
Stop exporting quota / RegisterProtocolHandler request controller classes, and use the public wrapper classes in WebContentsAdapterClient instead. Change-Id: Iaa380b6ceb4f9464fc05dd012ee5df219f11f189 Reviewed-by:
Kai Koehne <kai.koehne@qt.io>
-
Jüri Valdmann authored
Remove 'permission' from class and signal names, so e.g. QWebEngineQuotaPermissionRequest becomes QWebEngineQuotaRequest and quotaPermissionRequested becomes quotaRequested. Rename the internal controller classes to public name + "Controller". Change-Id: I247714ab0a2880adbf4ed8ee68f1b78838ae7a14 Reviewed-by:
Kai Koehne <kai.koehne@qt.io>
-
Allan Sandfeld Jensen authored
The devtools webcontents-adapter is no longer guaranteed to be initialized at this point, and we can initialize it directly with the right site instance. Task-number: QTBUG-67642 Change-Id: I8abbd4297ae677d3bd8d45f00f7463d60ee2bce5 Reviewed-by:
Jüri Valdmann <juri.valdmann@qt.io> Reviewed-by:
Viktor Engelmann <viktor.engelmann@qt.io>
-
Kai Koehne authored
This allows writing something like FindFlags x = FindBackWard | FindCaseSensitively Change-Id: I88f8465dd64482ad871530fbb6d6351895fe6a3a Reviewed-by:
Jüri Valdmann <juri.valdmann@qt.io> Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- 12 Apr, 2018 - 6 commits
-
-
Michal Klocek authored
Use lazy binding for static bindings initialization, the same way we do in ozone. Task-number: QTBUG-65682 Change-Id: I51ecdfa3b7daca8b1345cf2c0c89a4ac6e25a7c9 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Allan Sandfeld Jensen authored
Task-number: QTBUG-67653 Change-Id: I07c9dca788ee31f691b05f7647ffbf3f9e0b7260 Reviewed-by:
Michal Klocek <michal.klocek@qt.io> Reviewed-by:
Viktor Engelmann <viktor.engelmann@qt.io>
-
Allan Sandfeld Jensen authored
Changes: e173cb17d9 Do not initialize static bindings in x11_initializer 7c379772b2 Disable mask-tiling until we support it Task-number: QTBUG-67585 Change-Id: Ic557125e75fb7bdcdc0cd476d7e9c2a7da5f052a Reviewed-by:
Michael Brüning <michael.bruning@qt.io>
-
Michal Klocek authored
Test for icu also in xml2 compile test. Change-Id: I435f609761cb299f58a9b5f68e31698bb238ab1c Reviewed-by:
Kai Koehne <kai.koehne@qt.io>
-
Michal Klocek authored
Change-Id: If35a8f3a69e21a8fbd203ca84c37efdcac514549 Reviewed-by:
Kai Koehne <kai.koehne@qt.io>
-
Michal Klocek authored
Since https://codereview.chromium.org/2788063002 libxml2 is expected to have disabled catalog support. Prevent crashes of render process and do not link against system libxml2 if it is compiled with catalog support. Task-number: QTBUG-66488 Change-Id: I2d922929878262c555802336841536eba1294db2 Reviewed-by:
Kai Koehne <kai.koehne@qt.io>
-
- 10 Apr, 2018 - 2 commits
-
-
Allan Sandfeld Jensen authored
I don't know when it is used, but we have the support, so lets do it. Change-Id: I1784ae902598c99c73c651b6929256e36610ed6d Reviewed-by:
Viktor Engelmann <viktor.engelmann@qt.io>
-
Allan Sandfeld Jensen authored
Seems making a context menu too early is racy. Change-Id: I9cf268d506e6fcee348102cc3138c475ac94d55c Reviewed-by:
Valentin Fokin <fokinv@inf.u-szeged.hu> Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu>
-
- 09 Apr, 2018 - 2 commits
-
-
Allan Sandfeld Jensen authored
Changes: 312f43a137d4 Fix bypassing of installed CDM component define on macOS f1a3b4eec78e Fix compilation with system ICU 59 aa9e7d726498 Do not export .gitignore and .gitattributes Change-Id: I4a7e95a3f7eddc2f0eaa778478688880452a1620 Reviewed-by:
Michael Brüning <michael.bruning@qt.io>
-
Allan Sandfeld Jensen authored
Even if we don't yet implement handling it, we need to hold it to not assert later on it missing from held resources. Task-number: QTBUG-67414 Change-Id: Ic14efba383ba7f1809238768b386b2254fad7121 Reviewed-by:
Jüri Valdmann <juri.valdmann@qt.io> Reviewed-by:
Viktor Engelmann <viktor.engelmann@qt.io>
-
- 07 Apr, 2018 - 3 commits
-
-
Michal Klocek authored
Change-Id: I0f88772a0e869de3c7bfd065227b6151558c7408 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Allan Sandfeld Jensen authored
Move implementation of DirectCompositionSurfaceWin::IsHDRSupported() so OpenGL definitions doesn't conflict. Change-Id: Ib5d61b647b9a6ca00e8f9dae2dffb8cb72fa09c0 Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-
Allan Sandfeld Jensen authored
Avoid hitting undefined reference to 'bool TestNamespace::QTest::qCompare<unsigned long, unsigned int>...' Change-Id: I91588869708899e1055619ca9ba46d2061869417 Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-
- 06 Apr, 2018 - 1 commit
-
-
Jüri Valdmann authored
- Avoid creating a blank WebContents for new QWebEnginePages only to replace it with a different blank WebContents moments later. This problem is already solved in QQuickWebEngineView by lazy initialization, therefore the patch moves this lazy initialization into WebContentsAdapter itself so that it can be applied to both QQuickWebEngineView and QWebEnginePage. - Try to delay WebContents creation until the first navigation so that we have enough information available to pick the right initial SiteInstance when calling WebContents::Create. This is done by triggering WebContents creation from the first call to a WebContentsAdapter::load* method. - Use the SiteInstance from WebContentsDelegate::OpenURLFromTab. This method gets a SiteInstance pointer which we should give to WebContents::Create. Task-number: QTBUG-65561 Task-number: QTBUG-67163 Change-Id: Id7b351998adefb810cf27c61a1447b61d7f4c606 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- 05 Apr, 2018 - 5 commits
-
-
Szabolcs David authored
QWebEngineView hides its siblings in its parent layout. (See QTBUG-66957) Change it to use QVBoxLayout for now. Change-Id: I4e89d8c06d990633adab1150de1c62552f0033a1 Reviewed-by:
Viktor Engelmann <viktor.engelmann@qt.io> Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Valentin Fokin authored
When right clicking on a simple image there would be a separator on the top of the DefaultContextMenu. This patch fixes it by checking if the context menu has any elements in it before adding a separator. Change-Id: I6bbe91fdac9f49006be8cc73df1d97d34f3c2848 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Kai Koehne authored
Q_FLAGS is deprecated, and is replaced by the more powerful Q_FLAG macro. Anyhow, Q_FLAG and Q_FLAGS only makes sense if used inside a QObject or Q_GADGET. The patch therefore makes QWebEngineContextMenuData a Q_GADGET. Change-Id: Icccb373846a645272a7bf29397b930ae80be9b85 Reviewed-by:
Jüri Valdmann <juri.valdmann@qt.io> Reviewed-by:
Valentin Fokin <fokinv@inf.u-szeged.hu> Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Allan Sandfeld Jensen authored
This ties the indexed-db, DOM storage and filesystem access to cookie rights as they can all do the same cookies. A previous patch did the same for workers, but we were missing this class to complete the logic. Change-Id: I5ea894b6c631bcf25439759174866d260b91b71a Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu>
-
Peter Varga authored
Change-Id: Ibca5362c9d1e388885132259fa95a9f575f45fc8 Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- 04 Apr, 2018 - 3 commits
-
-
Michal Klocek authored
Refactor GLSurfaceWGLQt to speparte file. This class is not used by ozone, however is keept in ozone subdirecotry with other surface classes. Change-Id: I161582546b597912bc4c1c75ebbc0c1763aebed5 Reviewed-by:
Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Michal Klocek authored
Move GLSurfaceGLXQt and GLSurfaceEGLQt to own implementation files,so they can be reused easly by ozone backends. Change-Id: Ie403a941424343e13775866772bed709d7cbff6a Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Allan Sandfeld Jensen authored
This caused an unnecessary dependency on skia Change-Id: Ic3f109f985632c3f3cb4c8681e9a8290f463bb53 Reviewed-by:
Viktor Engelmann <viktor.engelmann@qt.io>
-
- 03 Apr, 2018 - 3 commits
-
-
Allan Sandfeld Jensen authored
Instead of always allowing all workers, disallow when similar cookies would have been disallowed. This is following the same logic as Chromium is using. Change-Id: I6b9d6c63b894287f64171b138fe03ec080af5115 Reviewed-by:
Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu>
-
Jüri Valdmann authored
The waitForRequest/waitForSignal function used by these tests is broken: it assumes that calling QEventLoop::exit() will immediately exit from the event loop. In actuality this is not immediate and the event loop may continue to execute more signals handlers even after exit() has been called. This means that in e.g. waitForRequest the 'result' variable may be assigned to twice. Additionally there is a race condition in downloadTwoLinks, where we sometimes skip the first download. This is not a bug but simply one pending navigation being aborted in favor of another. Changes - Delete waitForRequest. Define one HTTP request handler per test, using state variables to communicate with the main body of the test. Ignore unknown requests (including favicon requests). Same for downloadRequested signals. - Expand downloadTwoLinks and fix expectations. - Add logging to HTTPServer. - Unblacklist. Task-number: QTBUG-66888 Change-Id: I718cac6c4b32a8cc68400fa8ee5b853686c77fcb Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu>
-
Jüri Valdmann authored
Replace injectionPoint test with a timeout-less version that uses - both a single-frame and a multi-frame page - both main and isolated worlds - cross-process navigation - window.open - profile-wide scripts Task-number: QTBUG-66338 Change-Id: Ica4acb8ada4acc38aa5e1ca00e7512a2e69b785f Reviewed-by:
Michael Brüning <michael.bruning@qt.io>
-
- 28 Mar, 2018 - 1 commit
-
-
Andy Shaw authored
Task-number: QTBUG-67279 Change-Id: Iff2466cfe3b8bbdb77066f3318014fcb51e2e402 Reviewed-by:
Michael Brüning <michael.bruning@qt.io>
-
- 27 Mar, 2018 - 1 commit
-
-
Topi Reinio authored
This caused build issues in certain configurations. We don't actually need it, as we can rely on the base Qt include path instead. Also move the custom module header under src/webengine/doc and rename it. Task-number: QTBUG-67342 Change-Id: Id5e809202ddaa285bfcc341a36b0b3d5a7ade436 Reviewed-by:
Simon Hausmann <simon.hausmann@qt.io> Reviewed-by:
Martin Smith <martin.smith@qt.io>
-
- 26 Mar, 2018 - 1 commit
-
-
Peter Varga authored
Moving mouse cursor to (0, 0) by QTest::mouseMove() doesn't seem to work and the cursor doesn't leave the QWebEngineView. Change initial coordinates as a workaround. Change-Id: Iaad895c770a6edc5ed6e375f68b2b56196d84073 Reviewed-by:
Viktor Engelmann <viktor.engelmann@qt.io>
-
- 23 Mar, 2018 - 4 commits
-
-
Kai Koehne authored
qdoc has magic to remove the 'This XXX class' in the class overview, but not type. See e.g. http://doc-snapshots.qt.io/qt5-5.11/qtwebengine-modules.html Change-Id: Idd38a860ae08c7199c322d16c3ccc737972131a0 Reviewed-by:
Viktor Engelmann <viktor.engelmann@qt.io>
-
Kai Koehne authored
Change-Id: I633c616fa5b454ecce97037ed068997c26bd72bf Reviewed-by:
Leena Miettinen <riitta-leena.miettinen@qt.io>
-
Michael Brüning authored
Commit ef1d61a3 introduced a regression where multiple shortcut events where delivered on macOS. Instead of using tryShortcut (which triggers shortcut events) to check if the shortcut needs to be overridden, check if the shortcut map has an entry for the key seqeunce in question. Task-number: QTBUG-66207 Change-Id: I8d277e2ac39de8a1f2d2c43dc8486e042c4ea458 Reviewed-by:
Peter Varga <pvarga@inf.u-szeged.hu>
-
Michal Klocek authored
Move ozone related files to core/ozone. Split classes so they can be reused for new ozone platform backends. Change-Id: I98a2aac6807ef2b3eee92eea9ecfd8fce6dd9d16 Reviewed-by:
Kai Koehne <kai.koehne@qt.io> Reviewed-by:
Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- 22 Mar, 2018 - 1 commit
-
-
Jüri Valdmann authored
As of version 63, Chromium creates proxy frames also for the main frame in the frame tree during cross-process navigations. This leads to a segmentation fault in WebChannelIPCTransport because we assume that all main frames are local. See https://crrev.com/27caae83cb530daaf49f9a38793e427cdf493a65 for details. This patch refactors the renderer-side WebChannelIPCTransport from a RenderViewObserver into a RenderFrameObserver, which prevents the segmentation fault since the RenderFrameObserver is not created for proxy frames. Most likely this would have to be done eventually anyway since the RenderView and RenderViewObserver classes are deprecated and will likely be removed as part of the Site Isolation project. Installation is changed to follow Chromium's RenderFrameImpl in the sense of performing the installation from RenderFrameObserver::DidClearWindowObject instead of ContentRendererClient::RunScriptsAtDocumentStart. This has the benefit of avoiding the ScriptForbiddenScope DCHECK. Additionally there are the following minor changes: - The deprecated parameterless version of v8::Value::ToObject() method is replaced with v8::Value::IsObject() check and v8::Local::Cast. - The deprecated v8::Handle typedef is replaced with v8::Local. - The deprecated single-parameter WebContentsObserver::OnMessageReceived is replaced with the new two-parameter version. - blink::MainThreadIsolate() is used instead of v8::Isolate::GetCurrent() for Install/Uninstall since we know we are executing on the main thread. - WebChannelIPCTransportHost is changed to ignore messages from unexpected renderers in case something goes wrong with the renderers. - Logging is added to WebChannelIPCTransportHost for debugging purposes. Some new unit tests are added, all of which fail with the old version. Task-number: QTBUG-66333 Change-Id: I936d142fb042d9f936a3f9d08d4328ecba595f1f Reviewed-by:
Michal Klocek <michal.klocek@qt.io>
-