1. 26 Oct, 2012 - 2 commits
    • Paul Wilkins's avatar
      Explicit MV reference experiment. · ba30e774
      Paul Wilkins authored
      Coding and costing of mv reference signal.
      
      Issues in updating MV ref with COMPANDED_MVREF_THRESH
      to be resolved. Ideally the MV precision should be defined based
      on absolute MV magnitude not as now the MV ref magnitude.
      
      Update to mv counts moved into bitstream.c because otherwise
      if the motion reference is changed at the last minute the encoder
      and decoder get out of step in terms of the counts used to update
      entropy probs.
      
      Code working on a few test clips but no results yet re benefit vs
      signaling cost and no tuning of red loop to test lower cost alternatives
      based on the available reference values.
      
      Patch 3. Added check to make sure we don't pick a reference
      that would give rise to an uncodeable / out of range residual.
      
      Patch 6-7: Attempt to rebase. OK to submit but best to leave flag off for now.
      
      Patch 9. Remove print no longer needed.
      
      Change-Id: I1938c2ffe41afe6d3cf6ccc0cb2c5d404809a712
      ba30e774
    • Ronald S. Bultje's avatar
      Extend edges correctly during actual frame encoding also. · 6d465faa
      Ronald S. Bultje authored
      Should fix B_PRED-related encoder/decoder mismatches.
      
      Change-Id: I16f808dffd19094e02e8562ba58cc1016155ce93
      6d465faa
  2. 25 Oct, 2012 - 1 commit
  3. 23 Oct, 2012 - 1 commit
    • Deb Mukherjee's avatar
      Merging in the Switchable interp experiment · 53731197
      Deb Mukherjee authored
      There is a macro DEFAULT_INTERP_FILTER defined in encoder/onyx_if.c that
      is set as EIGHTTAP for now - so SWITCHABLE is not really used. Ideally,
      this should be SWITCHABLE but that would make the encoder quite a bit slower.
      We will change the default filter to SWITCHABLE once we find a faster way to
      search for switchable filters.
      
      Change-Id: Iee91832cdc07e6e14108d9b543130fdd12fc9874
      53731197
  4. 22 Oct, 2012 - 5 commits
  5. 21 Oct, 2012 - 1 commit
  6. 19 Oct, 2012 - 1 commit
    • Deb Mukherjee's avatar
      Some cleanups and fixes. · f3208f36
      Deb Mukherjee authored
      Separates the logic on transform type selection previously spread out
      over a number of files into a separate function. Currently the tx_type
      field in b_mode_info is not used, but still left in there to eventually
      use for signaling the transform type in the bitstream.
      
      Also, now for tx_type = DCT_DCT, the regular integer DCT is used, as
      opposed to the floating point DCT used in conjuction with hybrid
      transform.
      
      Results change somewhat due to the transform change, but are within
      reasonable limits. The hd/std-hd sets are slightly up, while derf/yt
      are slightly down.
      
      Change-Id: I5776840c2239ca2da31ca6cfd7fd1148dc5f9e0f
      f3208f36
  7. 18 Oct, 2012 - 1 commit
  8. 17 Oct, 2012 - 2 commits
    • John Koleszar's avatar
      cosmetic: fix '= & ' construct · 3883dab0
      John Koleszar authored
      remove useless space after address-of operator.
      
      Change-Id: I1fb9e82e8d6cf87558fbd454fb5c0f87599ca2ab
      3883dab0
    • John Koleszar's avatar
      Interleave modes/residual per macroblock · 6ef5a005
      John Koleszar authored
      Packs the bitstream with each mb's residual following its mode/mv
      information.
      
      TODO: There are still a few fields that should be packed into partition
      0 but are included in partition 1, due to them being serialized from
      write_kfmodes/pack_inter_mode_mvs, which execute after the first
      partition is finalized. These need to be separated out into a separate
      function, similar to mb_mode_mv_init() in decodemv.c.
      
      Change-Id: I43a46c363601ab36954d07ebe498760e1e2e3af4
      6ef5a005
  9. 16 Oct, 2012 - 1 commit
  10. 15 Oct, 2012 - 2 commits
    • Ronald S. Bultje's avatar
      Add a new token stuffing function vp8_stuff_mb(). · e7881462
      Ronald S. Bultje authored
      This way a caller doesn't need to implement the logic for which (and how
      many) tokens to write out to stuff one macroblock worth of EOBs. Make
      the actual function implementations static, since they are now only used
      in tokenize.c; also do some minor stylistic changes so it follows the
      style guide a little more closely; use PLANE_TYPE where appropriate,
      remove old (stale) frame_type function arguments; hardcode plane type
      where only a single one is possible (2nd order DC or U/V EOB stuffing);
      support stuffing 8x8/4x4 transform EOBs with no 2nd order DC.
      
      Change-Id: Ia448e251d19a4e3182eddeb9edd034bd7dc16fa3
      e7881462
    • Ronald S. Bultje's avatar
      Remove duplicate or unused code in encoder/encodemb.c. · 238ed517
      Ronald S. Bultje authored
      Also make some minor stylistic changes to bring the code closer to
      the style guide. Remove distinction between inter and intra transform
      functions, since both do exactly the same thing except for the check
      against SPLITMV for the second-order transform. Remove some commented
      out debug code. Remove 8x8/16x16 transform code in encode_inter16x16y(),
      since the first-pass only uses 4x4 anyway.
      
      Change-Id: Ife54816ff759825b9141f95dc2ba43c253c14dba
      238ed517
  11. 14 Oct, 2012 - 3 commits
  12. 12 Oct, 2012 - 1 commit
  13. 11 Oct, 2012 - 2 commits
  14. 10 Oct, 2012 - 1 commit
    • Jim Bankoski's avatar
      convert copy16x16 to rtcd · 89f060e8
      Jim Bankoski authored
      Convert copy16x16 from invoke to rtcd.  The first in a long
      string of converts.
      
      Change-Id: I296b0aa32f40e9fb649f7a3cb914a4e5300cad63
      89f060e8
  15. 09 Oct, 2012 - 1 commit
    • Ronald S. Bultje's avatar
      Selectable transform size try 2. · 9ca3c8b2
      Ronald S. Bultje authored
      Results: derf (vanilla or +hybridtx) +0.2% and (+hybrid16x16
      or +tx16x16) +0.7%-0.8%; HD (vanilla or +hybridtx) +0.1-0.2%
      and (+hybrid16x16 or +tx16x16) +1.4%, STD/HD (vanilla or +hybridtx)
      about even, and (+hybrid16x16 or +tx16x16) +0.8-1.0%.
      
      Change-Id: I03899e2f7a64e725a863f32e55366035ba77aa62
      9ca3c8b2
  16. 27 Sep, 2012 - 1 commit
    • Deb Mukherjee's avatar
      Entropy coding for hybrid transform · 3f5d60b3
      Deb Mukherjee authored
      Separates the entropy coding context models for 4x4, 8x8 and 16x16
      ADST variants.
      
      There is a small improvement for HD (hd/std-hd) by about 0.1-0.2%.
      Results on derf/yt are about the same, probably because there is not
      enough statistics.
      
      Results may improve somewhat once the initial probability tables are
      updated for the hybrid transforms which is coming soon.
      
      Change-Id: Ic7c0c62dacc68ef551054fdb575be8b8507d32a8
      3f5d60b3
  17. 21 Sep, 2012 - 1 commit
    • Deb Mukherjee's avatar
      Separating 8x8DCT use from hybridtransform8x8 · 70e21afb
      Deb Mukherjee authored
      With this change, even if hybridtransform8x8 experiment is off,
      8x8 dct is used for the I8x8 mode. However note that the gains
      observed with the hybridtransform8x8 experiment will now be less,
      since part of the gain is now merged in.
      
      Change-Id: I9afb3880906fd0a1368a374041fc08efcf060c54
      70e21afb
  18. 20 Sep, 2012 - 1 commit
  19. 12 Sep, 2012 - 1 commit
  20. 11 Sep, 2012 - 1 commit
  21. 10 Sep, 2012 - 1 commit
    • Deb Mukherjee's avatar
      Hybrid transform cleanups · c5af82b7
      Deb Mukherjee authored
      Some cleanups that will make it easier to maintain the code
      and incorporate upcoming changes on  entropy coding for the
      hybrid transforms.
      
      Change-Id: I44bdba368f7b8bf203161d7a6d3b1fc2c9e21a8f
      c5af82b7
  22. 07 Sep, 2012 - 1 commit
    • Paul Wilkins's avatar
      Partial merge of NEWBESTREFMV and NEW_MVREF. · 778ec421
      Paul Wilkins authored
      This commit merges those parts of the CONFIG_NEW_MVREF
      that specifically relate to choosing a better set of candidate
      MV references into the NEWBESTREFMV experiment.
      
      CONFIG_NEW_MVREF will then be used for changes relating
      to the explicit coding of a cost optimized MV reference in the
      bitstream as part of MV coding.
      
      Change-Id: Ied982c0ad72093eab29e38b8cd74d5c3d7458b10
      778ec421
  23. 06 Sep, 2012 - 1 commit
    • Deb Mukherjee's avatar
      New motion vector entropy coding · 00f9eb65
      Deb Mukherjee authored
      Adds a new experiment with redesigned/refactored motion vector entropy
      coding. The patch also takes a first step towards separating the
      integer and fractional pel components of a MV. However the fractional
      pel encoding still depends on the integer pel part and so they are
      not fully independent. Further experiments are in progress to see
      how much they can be decoupled without affecting performance.
      All components including entropy coding/decoding, costing for MV
      search, forward updates and backward updates to probability tables,
      have been implemented.
      
      Results so far:
      derf: +0.19%
      std-hd: +0.28%
      yt: +0.80%
      hd: +1.15%
      
      Patch: Simplifies the fractional pel models:
      derf: +0.284%
      std-hd: +0.289%
      yt: +0.849%
      hd: +1.254%
      
      Patch: Some changes in the models, rebased.
      derf: +0.330%
      std-hd: +0.306%
      yt: +0.816%
      hd: +1.225%
      
      Change-Id: I646b3c48f3587f4cc909639b78c3798da6402678
      00f9eb65
  24. 30 Aug, 2012 - 1 commit
    • Jingning Han's avatar
      hybrid transform of 16x16 dimension · de6dfa6b
      Jingning Han authored
      Enable ADST/DCT of dimension 16x16 for I16X16 modes. This change provides
      benefits mostly for hd sequences.
      
      Set up the framework for selectable transform dimension.
      
      Also allowing quantization parameter threshold to control the use
      of hybrid transform (This is currently disabled by setting threshold
      always above the quantization parameter. Adaptive thresholding can
      be built upon this, which will further improve the coding performance.)
      
      The coding performance gains (with respect to the codec that has all
      other configuration settings turned on) are
      
      derf:   0.013
      yt:     0.086
      hd:     0.198
      std-hd: 0.501
      
      Change-Id: Ibb4263a61fc74e0b3c345f54d73e8c73552bf926
      de6dfa6b
  25. 24 Aug, 2012 - 1 commit
    • Paul Wilkins's avatar
      New Motion Reference Search · 2d60bee1
      Paul Wilkins authored
      Alternative strategy for finding a list of candidate motion
      vectors to use as reference values in mv coding and as
      nearest and near.
      
      Sort by sad in vp8_find_best_ref_mvs() rather than just
      pick the best. Allow 0,0 as a best ref option but not a
      nearest or near unless there are no alternatives.
      
      Encode/Decode verified on at least some clips.
      
      Some commented out experimental and stats code still in place.
      
      Gain over existing code averages about 1% on derf (alll metrics)
      with improvement on all clips. Other test results pending.
      
      The entropy coding of the mode (nearest/near etc) still
      depends upon and requires the old "findnear" code so
      this needs looking at and may provide room for further gains.
      
      Change-Id: I871d7cba1d1c379c4bad9bcccce1fb19c46b8247
      2d60bee1
  26. 21 Aug, 2012 - 1 commit
  27. 20 Aug, 2012 - 1 commit
    • Ronald S. Bultje's avatar
      Superblock coding. · 5d4cffb3
      Ronald S. Bultje authored
      This commit adds a pick_sb_mode() function which selects the best 32x32
      superblock coding mode. Then it selects the best per-MB modes, compares
      the two and encodes that in the bitstream.
      
      The bitstream coding is rather simplistic right now. At the SB level,
      we code a bit to indicate whether this block uses SB-coding (32x32
      prediction) or MB-coding (anything else), and then we follow with the
      actual modes. This could and should be modified in the future, but is
      omitted from this commit because it will likely involve reorganizing
      much more code rather than just adding SB coding, so it's better to let
      that be judged on its own merits.
      
      Gains on derf: about even, YT/HD: +0.75%, STD/HD: +1.5%.
      
      Change-Id: Iae313a7cbd8f75b3c66d04a68b991cb096eaaba6
      5d4cffb3
  28. 15 Aug, 2012 - 1 commit
    • Paul Wilkins's avatar
      Code clean up. · 77dc5c65
      Paul Wilkins authored
      Further cases of inconsistent naming convention.
      
      Change-Id: Id3411ecec6f01a4c889268a00f0c9fd5a92ea143
      77dc5c65
  29. 14 Aug, 2012 - 2 commits
    • Daniel Kang's avatar
      Shut up warnings added by -Wundef · fd084b24
      Daniel Kang authored
      Change-Id: I9c7ef4a75c37aa0e10df75e165e3066614c955ef
      fd084b24
    • Paul Wilkins's avatar
      Code clean up. · 39892cce
      Paul Wilkins authored
      References to MACROBLOCKD that use "x" changed to "xd"
      to comply with convention elsewhere that x = MACROBLOCK
      and xd = MACROBLOCKD.
      
      Simplify some repeat references using local variables.
      
      Change-Id: I0ba2e79536add08140a6c8b19698fcf5077246bc
      39892cce