- 10 May, 2016 - 5 commits
-
-
Alexander Volkov authored
Create parent nodes with the corresponding paths, not with the absolute path of the child node. Otherwise we will get incorrect QFileInfo at least in the following case: QFileSystemModel model; model.setRootPath("/usr/bin"); QModelIndex idx = model.setRootPath("/usr"); qDebug() << model.fileInfo(idx).absoluteFilePath(); Without the fix it prints "/usr/bin". It's a regression triggered by 61cefb2f (De-inline QFileSystemModel::fileInfo() and implement it efficiently). Change-Id: I3b4e5f5b256711e27ad50824eaa8492dbc096808 Task-number: QTBUG-51586 Reviewed-by:
Lars Knoll <lars.knoll@theqtcompany.com>
-
Oswald Buddenhagen authored
the "generated by qt creator" header is not supposed to be checked in. Change-Id: I7626c0bd16f83d81b3facd216a04e7d505942256 Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io>
-
Morten Johan Sørvig authored
The test passes on OS X now. Task-number: QTBUG-8941 Change-Id: I7b57dc30ede7c1ed0bcb8bacb458ea56f222d987 Reviewed-by:
Timur Pocheptsov <timur.pocheptsov@theqtcompany.com>
-
Morten Johan Sørvig authored
Sheets are no longer transparent on newer OS X versions. Change-Id: Iaaed5aea9c9b130a5d991acd36717b76c3927cfb Reviewed-by:
Timur Pocheptsov <timur.pocheptsov@theqtcompany.com>
-
Morten Johan Sørvig authored
The Qt 5 unified toolbar implementation does not move the toolbar to the “non-client” area. This test is no longer relevant. Change-Id: Ia32de2260f8ef400a0dc5acf3e5e3ff59083657a Reviewed-by:
Timur Pocheptsov <timur.pocheptsov@theqtcompany.com>
-
- 09 May, 2016 - 7 commits
-
-
Thiago Macieira authored
Change-Id: I42e7ef1a481840699a8dffff1409e30f191e822f Reviewed-by:
Frederik Gladhorn <frederik.gladhorn@theqtcompany.com>
-
Friedemann Kleint authored
On some X11 window managers, 2 events are received when hiding/reshowing and activating the window, which became apparent after 91f536dd . Change-Id: I66fdc4f69d87ac898b18d5dfddc957617bb8f916 Reviewed-by:
Simon Hausmann <simon.hausmann@theqtcompany.com>
-
Thiago Macieira authored
Allow tmpfs filesystems to be reported, as they're often usable by the user, mounted in /tmp and in /run (the fs for $XDG_RUNTIME_DIR). But disallow anything whose device is not a pathname. This catches most of everything else that wasn't specifically tested for before, like virtual fuse filesystems, like GVFS. Change-Id: I3e15a26e0e424169ac2bffff1417b7cee0f8ec97 Reviewed-by:
Ivan Komissarov <ABBAPOH@gmail.com> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Thiago Macieira authored
The path "/usrfoo" starts with "/usr", so if you tried to get QStorageInfo("/usrfoo") when "/usr" is a mount point, you'd get the wrong filesystem. [ChangeLog][QtCore][QStorageInfo] Fixed a bug that caused QStorageInfo to report information for the wrong filesystem if there is a mounted filesystem at a path that is a prefix of the requested path (e.g., it would report "/usr" filesystem for "/usrfoo"). Task-number: QTBUG-49498 Change-Id: I3e15a26e0e424169ac2bffff1417b7a27cd0132d Reviewed-by:
Jake Petroules <jake.petroules@qt.io>
-
Thiago Macieira authored
There's exactly one application that needs this functionality (kded/ kiod), but we should test it too. Change-Id: Icaa7fb2a490246bda156ffff143d210c6f5f207f Reviewed-by:
David Faure <david.faure@kdab.com>
-
Thiago Macieira authored
If we're linking to libdbus-1, qdbus_symbols_p.h #includes dbus/dbus.h, which may be old and not #define the Unix FD macros. tst_QDBusMarshall had the definition for one of the macros but not the other, so add the missing second one. Change-Id: Id69569111e7d4e619e22ffff144c35edcd6f348b Reviewed-by:
Frederik Gladhorn <frederik.gladhorn@theqtcompany.com>
-
Vyacheslav Grigoryev authored
The old code sometimes made incorrect selections when rows or columns were hidden or moved. It used logical top left and bottom right indexes to create a selection rectangle. However on moved or hidden cells a wrong rectangle was made. This fix calculates a simple rectangle without hidden cells and makes use of the row/column select functionality provided by the selection model, to make the right selection. [ChangeLog][QtWidgets][QTableView] Fixed a selection bug when rows or columns were hidden (QTBUG-50171) Task-number: QTBUG-50171 Change-Id: Id186012af26da7b2051ff5eb1c13e6b7494cca77 Reviewed-by:
Thorbjørn Lund Martsum <tmartsum@gmail.com>
-
- 08 May, 2016 - 2 commits
-
-
Thiago Macieira authored
QMetaEnum::key(n) returns the n-th key, which is not necessarily the one of value n. For the key of value n, we want QMetaEnum::valueToKey(n). Change-Id: Ic90fe6b1cbe84978a02fffff141bf4a06074917a Reviewed-by:
Olivier Goffart (Woboq GmbH) <ogoffart@woboq.com>
-
Thiago Macieira authored
The C and C++ standards say it's undefined whether the preprocessor supports macros that expand to defined() will operate as an ifdef. Clang 3.9 started complaining about that fact. One solution was to change QT_SUPPORTS to check for zero or one, which means we need to change the #defines QT_NO_xxx to #define QT_NO_xxx 1. The C standard says we don't need to #define to 0, as an unknown token is interpreted as zero. However, that might produce a warning (GCC with -Wundef), so changing the macro this way is not recommended. Instead, we deprecate the macro and replace the uses with #ifdef/ndef. Change-Id: Id75834dab9ed466e94c7ffff1444874d5680b96a Reviewed-by:
Olivier Goffart (Woboq GmbH) <ogoffart@woboq.com> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
- 06 May, 2016 - 2 commits
-
-
Timur Pocheptsov authored
BLACKLIST should make it, recent regression in QUdpSocket went unnoticed (first) because of 'insignificant'. We'd like to avoid such regressions in future (again, using BLACKLIST if needed and fixig the real problem then). NB: BLACKLIST in this patch was extended to deal with previously unnoticed failures on Windows and OS X. 'multicast' and related family of of functions on OS X will probably stay like this (seems to be a Darwin's quirk), datagram size related tests - fixed in dev or 5.7 (change is in nativesocket engine, 'bytesAvailable'). Task-number: QTBUG-52714 Change-Id: I039b05935a02983ce1648de449907dfa765f7db7 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io>
-
Timur Pocheptsov authored
This patch QSKIPs all tests that: - take to much time sitting in some QTRY_VERIFY or similar before failing - result in 'not in fullscreen mode' warning (with PASS) - thus completely flaky. - Where previously determined to not apply to OS X using QT_OS_MAC The intent is to make the test run-time more reasonable, both when running the test locally and on the CI system. Reduce the BLACKLIST - to avoid a 'double elimination' the tests that are skipped now, should not be BLACKLISTed so that we fix them for good. Task-number: QTBUG-52974 Change-Id: I34dc2010d0debc6b5b99f2375a6da902b7a17b29 Reviewed-by:
Morten Johan Sørvig <morten.sorvig@qt.io>
-
- 04 May, 2016 - 5 commits
-
-
Friedemann Kleint authored
The test used to output random character sequences which contained terminal control characters. Change it to output plain ASCII and Unicode syntax for non-ASCII characters. Change-Id: Ifaa72f50242bd27416a8698a1f5152bc8b902898 Reviewed-by:
Jędrzej Nowacki <jedrzej.nowacki@theqtcompany.com>
-
Morten Johan Sørvig authored
Q_OS_DARWIN is the general replacement for Q_OS_MAC, but most/all of the MAC sections in this test are OS X specific. Change-Id: Ic54af9d3dce1e1952a57e15b74acdedf2af60c79 Reviewed-by:
Timur Pocheptsov <timur.pocheptsov@theqtcompany.com>
-
Morten Johan Sørvig authored
Change-Id: I54552d9fdd0bc8871247246aea1da14848c4f7a0 Reviewed-by:
Timur Pocheptsov <timur.pocheptsov@theqtcompany.com>
-
Friedemann Kleint authored
Fix a warning about a missing case statement. Change-Id: Ic89646704d62668cf83c463dbf6e9b549a4b5200 Reviewed-by:
Shawn Rutledge <shawn.rutledge@theqtcompany.com>
-
Jędrzej Nowacki authored
The test should not depend on qWait explicitly Change-Id: I13c01c47c9f7bae8b0c30afa2ac8550dc0fbf028 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io> Reviewed-by:
Jan Arve Sæther <jan-arve.saether@theqtcompany.com>
-
- 02 May, 2016 - 2 commits
-
-
Friedemann Kleint authored
Add more error messages on failures. Task-number: QTBUG-25367 Task-number: QTBUG-25368 Change-Id: I064143a058b7b98d9d5eecab8b5da49f5307e1eb Reviewed-by:
Edward Welbourne <edward.welbourne@theqtcompany.com> Reviewed-by:
Richard J. Moore <rich@kde.org>
-
Oswald Buddenhagen authored
newer versions of qt creator understand QMAKE_EXTRA_COMPILERS and INSTALLS, so there is no need to list the files twice. Change-Id: Iccf3cc3248daf3422b8c366c2eb2d2f46c5f08d1 Reviewed-by:
Joerg Bornemann <joerg.bornemann@theqtcompany.com>
-
- 30 Apr, 2016 - 1 commit
-
-
Alex Trotsenko authored
QWindowsPipeWriter uses asynchronous API to perform writing. Once a cycle has been started, the write buffer must remain valid until the write operation is completed. To avoid data corruption and possibly undefined behavior, this patch makes QWindowsPipeWriter::write() take a QByteArray, which it keeps alive for the duration of the write cycle. Autotest-by: Thomas Hartmann Task-number: QTBUG-52401 Change-Id: Ia35faee735c4e684267daa1f6bd689512b670cd2 Reviewed-by:
Joerg Bornemann <joerg.bornemann@theqtcompany.com>
-
- 29 Apr, 2016 - 3 commits
-
-
Allan Sandfeld Jensen authored
Fix regression in a7b0cb46 which caused it to be hard to start scrolling at the ends of a scroll-view if using fine grained scrolling events. Change-Id: I55f3210150b993281545c3ad5a7356d892fa30b5 Reviewed-by:
Simon Hausmann <simon.hausmann@theqtcompany.com>
-
Friedemann Kleint authored
The widget is hidden, reshown and tested for active window, which is flaky. Add a call to activateWindow() which increases the chances of it becoming the active window should another window appear. Change-Id: Ibbecdbc43e2ac9638aec497c47fffaaffa1855af Reviewed-by:
Simon Hausmann <simon.hausmann@theqtcompany.com>
-
Thiago Macieira authored
On some operating systems, tzdata files carry the Local Mean Time (LMT) for the city in question, which better represents how time was tracked before standard, hourly timezones were introduced in the early 20th century. The test was asking for the data for 1653-02-09 and assumed that it would find the first Central European Time (CET) rule, which Germany didn't start using until 1893-04-01. This fix allows us to remove the blacklist that had been applied to this test without investigation. It wasn't related to OpenSUSE, aside from the fact that OpenSUSE tzdata carries the LMT data. Change-Id: Id5480807d25e49e78b79ffff1449bdaf46901367 Reviewed-by:
Simon Hausmann <simon.hausmann@theqtcompany.com> Reviewed-by:
Tony Sarajärvi <tony.sarajarvi@qt.io>
-
- 28 Apr, 2016 - 3 commits
-
-
Kai Pastor authored
Miter limits below 1.0 are not valid in PDF and trigger an error in the Reader. This change enforces a minimum miter limit of 1.0, and it adds a manual test for producing a PDF file demonstrating this issue. Task-number: QTBUG-52641 Change-Id: I1c78b1c4a44579e95e1cddfb459926d304e60165 Reviewed-by:
Lars Knoll <lars.knoll@theqtcompany.com>
-
Weng Xuetian authored
libdbus will send a local signal if connection gets disconnected. When this happens, end all pending calls with QDBusError::Disconnected. Task-number: QTBUG-51649 Change-Id: I5c7d2a468bb5da746d0c0e53e458c1e376f186a9 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Thiago Macieira authored
This is not exhaustive, but was enough to discover ICEs. Change-Id: Ib60be1d298a66b72e3eb9b75ad538f0bf15b5f62 Reviewed-by:
Maurice Kalinowski <maurice.kalinowski@qt.io> Reviewed-by:
Simo Fält <simo.falt@theqtcompany.com> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
- 26 Apr, 2016 - 2 commits
-
-
Friedemann Kleint authored
Pushing the mouse rapidly to the top left corner causes KDE / KWin to switch to "Present all Windows" (Ctrl+F9) mode, showing all windows. This has been observed to be triggered programmatically by QCursor::setPos(0, 0) if there is no other window beneath and apparently depending on the perceived mouse "speed". Suppress this by using the bottom right corner for XCB. Change-Id: Id18d2f45a095ed4d4f365f010cf45a20b0d9435e Reviewed-by:
Tony Sarajärvi <tony.sarajarvi@qt.io>
-
Shawn Rutledge authored
We have a bug that proximity events are generating them spuriously; this is a way of testing it. Task-number: QTBUG-52921 Change-Id: I490dfcf8d5b325f612b733e29fd49de9418bb19e Reviewed-by:
Morten Johan Sørvig <morten.sorvig@qt.io>
-
- 23 Apr, 2016 - 2 commits
-
-
David Faure authored
The "path" of a mailto URL isn't a file, so we shouldn't try to do glob-based matching. I was getting application/x-ms-dos-executable for a .com domain and application/x-perl for a .pl domain... Change-Id: Ifc346c3bba83ba1a8476db3202492f4c2e4d52bb Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io> Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Friedemann Kleint authored
Suppress message dialog of the test helper as does QTestlib. Task-number: QTBUG-52714 Change-Id: I5efd7d72f77c7689500ecaccf46f1f9dfb312140 Reviewed-by:
Timur Pocheptsov <timur.pocheptsov@theqtcompany.com>
-
- 22 Apr, 2016 - 2 commits
-
-
Alexander Volkov authored
Use the correct parent path for the renamed file when creating QFileInfo. It must be a path to the parent directory, not to the root directory of the model. Modify tst_QFileSystemModel::setData() to test renames in subdirs of the root directory of the model. Change-Id: I69d9e3a937616857a81617791ed118af3f6eea05 Task-number: QTBUG-52561 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io> Reviewed-by:
Lars Knoll <lars.knoll@theqtcompany.com>
-
Friedemann Kleint authored
Return pixmaps with device pixel ratio similar to QScreen::grabWindow(), cf c0963486 . Adapt kernel tests accordingly. Task-number: QTBUG-52137 Change-Id: I9ce276d5e2d87ae0d39c8639267d1ac283fed854 Reviewed-by:
Morten Johan Sørvig <morten.sorvig@qt.io>
-
- 21 Apr, 2016 - 1 commit
-
-
Vyacheslav Grigoryev authored
The old code incorrectly calculated visual region for a selection (specified by QItemSelection object) in case of reordered / swapped rows or columns. It used the leftmost and rightmost (upmost and downmost for vertical mode) logical indexes directly. However some middle logical index (in case of reorder) may be the leftmost or rightmost visual index. In such cases the repainting didn't work properly. This fix first checks whether reordering / swapping is in use. If it isn't (ie visual=logical) we use code similar to the old code. Otherwise the new code scans all selected logical indexes, translates them into visual ones and gets the correct leftmost and rightmost indexes. [ChangeLog][QtWidgets][QHeaderView] Fixed a repainting issue when items had been reordered. Task-number: QTBUG-50171 Change-Id: If6afabebf445cf32a8e0afe262b6ee149e7c4b2b Reviewed-by:
Thorbjørn Lund Martsum <tmartsum@gmail.com>
-
- 20 Apr, 2016 - 1 commit
-
-
Friedemann Kleint authored
Task-number: QTBUG-49374 Task-number: QTBUG-52622 Change-Id: Ic205590725780147aec3abc0f4be2058d001d358 Reviewed-by:
Morten Johan Sørvig <morten.sorvig@theqtcompany.com>
-
- 15 Apr, 2016 - 1 commit
-
-
Friedemann Kleint authored
Add dragging functionality to the labels showing a pixmap cursor, allowing for testing DnD with pixmaps with device pixel ratio. Task-number: QTBUG-46068 Task-number: QTBUG-50938 Change-Id: If6781f380864e614efd4328e8b880b57cd900511 Reviewed-by:
Morten Johan Sørvig <morten.sorvig@theqtcompany.com>
-
- 13 Apr, 2016 - 1 commit
-
-
Thiago Macieira authored
When the formatting parameter wasn't exactly QUrl::EncodeUnicode, it wouldn't encode, despite having to. Change-Id: Id75834dab9ed466e94c7ffff1444bacc08dd109b Reviewed-by:
Frederik Gladhorn <frederik.gladhorn@theqtcompany.com> Reviewed-by:
Edward Welbourne <edward.welbourne@theqtcompany.com>
-