Commit 02cbb1d1 authored by Frederik Gladhorn's avatar Frederik Gladhorn
Browse files

Fix requests for audio and video permissions


Requesting MediaAudioCapture would unconditionally ask for
QQuickWebEngineViewExperimental::MediaAudioVideoDevices instead of
MediaAudioDevices since the if wrongly tested for the same condition
twice.

In addition fix a warning: variable 'feature' is used uninitialized whenever 'if' condition is false

api/qquickwebengineview.cpp:369:13: warning: variable 'feature' is used uninitialized whenever 'if' condition is false
      [-Wsometimes-uninitialized]
   else if (requestFlags.testFlag(WebContentsAdapterClient::MediaVideoCapture))
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
api/qquickwebengineview.cpp:371:57: note: uninitialized use occurs here
   Q_EMIT e->featurePermissionRequested(securityOrigin, feature);
                                                        ^~~~~~~
api/qquickwebengineview.cpp:369:9: note: remove the 'if' if its condition is always true
   else if (requestFlags.testFlag(WebContentsAdapterClient::MediaVideoCapture))
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
api/qquickwebengineview.cpp:364:4: note: variable 'feature' is declared here
   QQuickWebEngineViewExperimental::Feature feature;
   ^

Change-Id: If63fbb5a59a71dede1d1829695f66c22849a4dcd
Reviewed-by: default avatarMichael Bruning <michael.bruning@digia.com>
Showing with 2 additions and 2 deletions
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment