Skip to content
GitLab
Projects
Groups
Topics
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
BC
public
external
Qt
QtWebEngine
Commits
1b065b29
Commit
1b065b29
authored
11 years ago
by
Pierre Rossi
Browse files
Options
Download
Patches
Plain Diff
cleaner content margins for the nested layouts
also remove QQUICKWEBENGINE env var
parent
c6144131
dev
0.9
5.10
5.11
5.12
5.12.1
5.12.10
5.12.11
5.12.12
5.12.2
5.12.3
5.12.4
5.12.5
5.12.6
5.12.7
5.12.8
5.12.9
5.13
5.13.0
5.13.1
5.13.2
5.14
5.14.0
5.14.1
5.14.2
5.15
5.15.0
5.15.1
5.15.2
5.15.3
5.15.4
5.15.5
5.15.6
5.15.7
5.4
5.5
5.6
5.7
5.8
5.9
5.9.8
6.2
6.2.0
6.2.1
6.2.2
wip/47-based
wip/qtpdf
v5.15.0-alpha1
v5.14.1
v5.14.0
v5.14.0-rc2
v5.14.0-rc1
v5.14.0-beta3
v5.14.0-beta2
v5.14.0-beta1
v5.14.0-alpha1
v5.13.2
v5.13.1
v5.13.0
v5.13.0-rc3
v5.13.0-rc2
v5.13.0-rc1
v5.13.0-beta4
v5.13.0-beta3
v5.13.0-beta2
v5.13.0-beta1
v5.13.0-alpha1
v5.12.7
v5.12.6
v5.12.5
v5.12.4
v5.12.3
v5.12.2
v5.12.1
v5.12.0
v5.12.0-rc2
v5.12.0-rc1
v5.12.0-beta4
v5.12.0-beta3
v5.12.0-beta2
v5.12.0-beta1
v5.12.0-alpha1
v5.11.3
v5.11.2
v5.11.1
v5.11.0
v5.11.0-rc2
v5.11.0-rc1
v5.11.0-beta4
v5.11.0-beta3
v5.11.0-beta2
v5.11.0-beta1
v5.11.0-alpha1
v5.10.1
v5.10.0
v5.10.0-rc3
v5.10.0-rc2
v5.10.0-rc1
v5.10.0-beta4
v5.10.0-beta3
v5.10.0-beta2
v5.10.0-beta1
v5.10.0-alpha1
v5.9.9
v5.9.8
v5.9.7
v5.9.6
v5.9.5
v5.9.4
v5.9.3
v5.9.2
v5.9.1
v5.9.0
v5.9.0-rc2
v5.9.0-rc1
v5.9.0-beta4
v5.9.0-beta3
v5.9.0-beta2
v5.9.0-beta1
v5.9.0-alpha1
v5.8.0
v5.8.0-rc1
v5.8.0-beta1
v5.8.0-alpha1
v5.7.1
v5.7.0
v5.7.0-rc1
v5.7.0-beta1
v5.7.0-alpha1
v5.6.3
v5.6.2
v5.6.1
v5.6.1-1
v5.6.0
v5.6.0-rc1
v5.6.0-beta1
v5.6.0-alpha1
v5.5.1
v5.5.0
v5.5.0-rc1
v5.5.0-beta1
v5.5.0-alpha1
v5.4.2
v5.4.1
v5.4.0
v5.4.0-rc1
v5.4.0-beta1
v5.4.0-alpha1
v0.1.0-tp1
No related merge requests found
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
examples/widgets/widgetwindow.cpp
+5
-1
examples/widgets/widgetwindow.cpp
lib/qwebcontentsview.cpp
+1
-0
lib/qwebcontentsview.cpp
shared/native_view_container_qt.h
+7
-3
shared/native_view_container_qt.h
with
13 additions
and
4 deletions
examples/widgets/widgetwindow.cpp
+
5
−
1
View file @
1b065b29
...
@@ -43,6 +43,8 @@
...
@@ -43,6 +43,8 @@
#include
"qwebcontentsview.h"
#include
"qwebcontentsview.h"
static
const
int
margin
=
1
;
WidgetWindow
::
WidgetWindow
()
WidgetWindow
::
WidgetWindow
()
:
m_webView
(
new
QWebContentsView
)
:
m_webView
(
new
QWebContentsView
)
,
addressLineEdit
(
0
)
,
addressLineEdit
(
0
)
...
@@ -51,12 +53,14 @@ WidgetWindow::WidgetWindow()
...
@@ -51,12 +53,14 @@ WidgetWindow::WidgetWindow()
if
(
QIcon
::
themeName
().
isEmpty
())
if
(
QIcon
::
themeName
().
isEmpty
())
QIcon
::
setThemeName
(
"oxygen"
);
QIcon
::
setThemeName
(
"oxygen"
);
setGeometry
(
0
,
0
,
1024
,
768
);
setGeometry
(
0
,
0
,
800
,
600
);
QVBoxLayout
*
layout
=
new
QVBoxLayout
;
QVBoxLayout
*
layout
=
new
QVBoxLayout
;
layout
->
setContentsMargins
(
margin
,
margin
,
margin
,
margin
);
// Create a widget based address bar.
// Create a widget based address bar.
QHBoxLayout
*
addressBar
=
new
QHBoxLayout
;
QHBoxLayout
*
addressBar
=
new
QHBoxLayout
;
addressBar
->
setSpacing
(
margin
);
// Bigger buttons, less space between them
QToolButton
*
backButton
=
new
QToolButton
;
QToolButton
*
backButton
=
new
QToolButton
;
backButton
->
setIcon
(
QIcon
::
fromTheme
(
"go-previous"
));
backButton
->
setIcon
(
QIcon
::
fromTheme
(
"go-previous"
));
...
...
This diff is collapsed.
Click to expand it.
lib/qwebcontentsview.cpp
+
1
−
0
View file @
1b065b29
...
@@ -71,6 +71,7 @@ QWebContentsView::QWebContentsView()
...
@@ -71,6 +71,7 @@ QWebContentsView::QWebContentsView()
content
::
BrowserContext
*
browser_context
=
static_cast
<
ContentBrowserClientQt
*>
(
content
::
GetContentClient
()
->
browser
())
->
browser_context
();
content
::
BrowserContext
*
browser_context
=
static_cast
<
ContentBrowserClientQt
*>
(
content
::
GetContentClient
()
->
browser
())
->
browser_context
();
d
->
webContentsDelegate
.
reset
(
WebContentsDelegateQt
::
CreateNewWindow
(
browser_context
,
NULL
,
MSG_ROUTING_NONE
,
gfx
::
Size
()));
d
->
webContentsDelegate
.
reset
(
WebContentsDelegateQt
::
CreateNewWindow
(
browser_context
,
NULL
,
MSG_ROUTING_NONE
,
gfx
::
Size
()));
QVBoxLayout
*
layout
=
new
QVBoxLayout
;
QVBoxLayout
*
layout
=
new
QVBoxLayout
;
layout
->
setContentsMargins
(
0
,
0
,
0
,
0
);
setLayout
(
layout
);
setLayout
(
layout
);
WebContentsViewQt
*
content_view
=
static_cast
<
WebContentsViewQt
*>
(
d
->
webContentsDelegate
->
web_contents
()
->
GetView
());
WebContentsViewQt
*
content_view
=
static_cast
<
WebContentsViewQt
*>
(
d
->
webContentsDelegate
->
web_contents
()
->
GetView
());
...
...
This diff is collapsed.
Click to expand it.
shared/native_view_container_qt.h
+
7
−
3
View file @
1b065b29
...
@@ -15,7 +15,7 @@ public:
...
@@ -15,7 +15,7 @@ public:
:
m_embeddable
(
0
)
:
m_embeddable
(
0
)
,
m_currentQQuickNativeView
(
0
)
,
m_currentQQuickNativeView
(
0
)
,
m_currentQWidgetNativeView
(
0
)
,
m_currentQWidgetNativeView
(
0
)
,
m_isQQuick
(
!
qgetenv
(
"QQUICKWEBENGINE"
).
isNull
()
)
,
m_isQQuick
(
true
)
{
{
}
}
...
@@ -34,8 +34,12 @@ public:
...
@@ -34,8 +34,12 @@ public:
QVBoxLayout
*
widget
()
QVBoxLayout
*
widget
()
{
{
if
(
!
m_embeddable
)
if
(
!
m_embeddable
)
{
m_embeddable
=
new
QVBoxLayout
;
m_isQQuick
=
false
;
QVBoxLayout
*
l
=
new
QVBoxLayout
;
l
->
setContentsMargins
(
0
,
0
,
0
,
0
);
m_embeddable
=
l
;
}
return
static_cast
<
QVBoxLayout
*>
(
m_embeddable
);
return
static_cast
<
QVBoxLayout
*>
(
m_embeddable
);
}
}
...
...
This diff is collapsed.
Click to expand it.
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment